fix: Add debug logging for noise suppression, fix PP_MIN_NN value

reachy_mini_ha_voice/reachy_controller.py

@@ -769,16 +769,25 @@ class ReachyController:
                 logger.error(f"Error setting AGC max gain: {e}")
 
     def get_noise_suppression(self) -> float:
-        """Get noise suppression level (0-100%)."""
+        """Get noise suppression level (0-100%).
+        
+        PP_MIN_NS represents "minimum signal preservation ratio":
+        - PP_MIN_NS = 0.85 means "keep at least 85% of signal" = 15% suppression
+        - PP_MIN_NS = 0.15 means "keep at least 15% of signal" = 85% suppression
+        
+        We display "noise suppression strength" to user, so:
+        - suppression_percent = (1.0 - PP_MIN_NS) * 100
+        """
         with self._get_respeaker() as respeaker:
             if respeaker is None:
                 return getattr(self, '_noise_suppression', 15.0)
             try:
                 result = respeaker.read("PP_MIN_NS")
                 if result is not None:
-                    # PP_MIN_NS is typically a float value, convert to percentage
-                    # Lower values = more suppression
-                    self._noise_suppression = max(0.0, min(100.0, (1.0 - result[0]) * 100.0))
+                    raw_value = result[0]
+                    # Convert: PP_MIN_NS=0.85 -> 15% suppression, PP_MIN_NS=0.15 -> 85% suppression
+                    self._noise_suppression = max(0.0, min(100.0, (1.0 - raw_value) * 100.0))
+                    logger.debug(f"Noise suppression: PP_MIN_NS={raw_value:.2f} -> {self._noise_suppression:.1f}%")
                     return self._noise_suppression
             except Exception as e:
                 logger.debug(f"Error getting noise suppression: {e}")

reachy_mini_ha_voice/voice_assistant.py

@@ -307,19 +307,20 @@ class VoiceAssistantService:
             # ========== 3. Noise Suppression Settings ==========
             # Reduce noise suppression to preserve quiet speech
             # PP_MIN_NS: minimum noise suppression threshold
-            # Lower values = less aggressive suppression = better voice pickup
-            # UI shows percentage where 15% = PP_MIN_NS of 0.85
+            # Higher values = less aggressive suppression = better voice pickup
+            # PP_MIN_NS = 0.85 means "keep at least 85% of signal" = 15% max suppression
+            # UI shows "noise suppression strength" so 15% = PP_MIN_NS of 0.85
             try:
-                respeaker.write("PP_MIN_NS", [0.85])  # 15% noise suppression
-                _LOGGER.info("Noise suppression set to 15%% (PP_MIN_NS=0.85)")
+                respeaker.write("PP_MIN_NS", [0.85])  # 15% noise suppression strength
+                _LOGGER.info("Noise suppression set to 15%% strength (PP_MIN_NS=0.85)")
             except Exception as e:
                 _LOGGER.debug("Could not set PP_MIN_NS: %s", e)
             
             # PP_MIN_NN: minimum noise floor estimation
-            # Lower values help in quieter environments
+            # Higher values = less aggressive noise floor tracking
             try:
-                respeaker.write("PP_MIN_NN", [0.15])
-                _LOGGER.info("Noise floor threshold reduced (PP_MIN_NN=0.15)")
+                respeaker.write("PP_MIN_NN", [0.85])  # Match PP_MIN_NS
+                _LOGGER.info("Noise floor threshold set (PP_MIN_NN=0.85)")
             except Exception as e:
                 _LOGGER.debug("Could not set PP_MIN_NN: %s", e)