{"action":"opened","number":1,"pull_request":{"state":"open","created_at":"2011-12-05T16:59:28Z","review_comments":0,"updated_at":"2011-12-05T16:59:28Z","_links":{"review_comments":{"href":"https://api.github.com/repos/zephirworks/libvmod-redis/pulls/1/comments"},"comments":{"href":"https://api.github.com/repos/zephirworks/libvmod-redis/issues/1/comments"},"html":{"href":"https://github.com/zephirworks/libvmod-redis/pull/1"},"self":{"href":"https://api.github.com/repos/zephirworks/libvmod-redis/pulls/1"}},"patch_url":"https://github.com/zephirworks/libvmod-redis/pull/1.patch","changed_files":1,"comments":0,"issue_url":"https://github.com/zephirworks/libvmod-redis/issues/1","user":{"gravatar_id":"d667ec157f4a3ba4028c83133cdeb4dc","id":388247,"url":"https://api.github.com/users/LuitvD","login":"LuitvD","avatar_url":"https://secure.gravatar.com/avatar/d667ec157f4a3ba4028c83133cdeb4dc?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"deletions":0,"merged":false,"body":"Fix to make vmod_redis reconnect when redis-server has closed the connection, making hiredis fail with REDIS_ERR_EOF. Connecting is tried once and the current command re-issued once per call of redis_common().\r\n\r\nSimply put: have a period of inactivity, and the part of your VCL using Redis is rendered useless because the Redis server will just disconnect you. This will detect that and try (once) to reconnect whenever this has happened and a new command is issued.\r\n\r\nTo be honest, I can't really believe nobody has done this before. Is this vmod that unpopular?","mergeable":null,"commits":1,"id":559072,"additions":12,"base":{"repo":{"created_at":"2011-05-25T00:06:07Z","pushed_at":"2011-06-06T13:17:14Z","updated_at":"2011-12-05T16:16:10Z","private":false,"clone_url":"https://github.com/zephirworks/libvmod-redis.git","svn_url":"https://svn.github.com/zephirworks/libvmod-redis","name":"libvmod-redis","watchers":21,"master_branch":null,"forks":1,"language":"C","owner":{"gravatar_id":"5cbccb48000649674406a94934afea30","id":366470,"url":"https://api.github.com/users/zephirworks","login":"zephirworks","avatar_url":"https://secure.gravatar.com/avatar/5cbccb48000649674406a94934afea30?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":1796443,"homepage":"http://www.varnish-cache.org/project/modules","git_url":"git://github.com/zephirworks/libvmod-redis.git","description":"An example vmod for Varnish","html_url":"https://github.com/zephirworks/libvmod-redis","open_issues":1,"url":"https://api.github.com/repos/zephirworks/libvmod-redis","size":240,"fork":true,"ssh_url":"git@github.com:zephirworks/libvmod-redis.git"},"user":{"gravatar_id":"5cbccb48000649674406a94934afea30","id":366470,"url":"https://api.github.com/users/zephirworks","login":"zephirworks","avatar_url":"https://secure.gravatar.com/avatar/5cbccb48000649674406a94934afea30?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"sha":"699272caa08321988d06310a283c443083e89048","ref":"master","label":"zephirworks:master"},"number":1,"merged_by":null,"title":"This makes libvmod-redis much more useful","head":{"repo":{"created_at":"2011-12-05T16:16:10Z","pushed_at":"2011-12-05T16:41:22Z","updated_at":"2011-12-05T16:41:23Z","private":false,"clone_url":"https://github.com/Luit-IT/libvmod-redis.git","svn_url":"https://svn.github.com/Luit-IT/libvmod-redis","name":"libvmod-redis","watchers":1,"master_branch":null,"forks":0,"language":"C","owner":{"gravatar_id":"d580f312e84136a521f07aa994d693e0","id":993371,"url":"https://api.github.com/users/Luit-IT","login":"Luit-IT","avatar_url":"https://secure.gravatar.com/avatar/d580f312e84136a521f07aa994d693e0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":2917821,"homepage":"http://www.varnish-cache.org/project/modules","git_url":"git://github.com/Luit-IT/libvmod-redis.git","description":"An example vmod for Varnish","html_url":"https://github.com/Luit-IT/libvmod-redis","open_issues":0,"url":"https://api.github.com/repos/Luit-IT/libvmod-redis","size":112,"fork":true,"ssh_url":"git@github.com:Luit-IT/libvmod-redis.git"},"user":{"gravatar_id":"d580f312e84136a521f07aa994d693e0","id":993371,"url":"https://api.github.com/users/Luit-IT","login":"Luit-IT","avatar_url":"https://secure.gravatar.com/avatar/d580f312e84136a521f07aa994d693e0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"sha":"a610660afebbd7c0fa5e32504fd2b88d8978e887","ref":"master","label":"Luit-IT:master"},"html_url":"https://github.com/zephirworks/libvmod-redis/pull/1","closed_at":null,"url":"https://api.github.com/repos/zephirworks/libvmod-redis/pulls/1","diff_url":"https://github.com/zephirworks/libvmod-redis/pull/1.diff","merged_at":null}}