{"number":28,"pull_request":{"number":28,"issue_url":"https://github.com/mwmitchell/rsolr/issues/28","head":{"repo":{"master_branch":null,"name":"rsolr","created_at":"2011-10-10T18:42:30Z","size":116,"clone_url":"https://github.com/bbcsnippets/rsolr.git","private":false,"updated_at":"2011-10-11T12:59:05Z","watchers":1,"ssh_url":"git@github.com:bbcsnippets/rsolr.git","url":"https://api.github.com/repos/bbcsnippets/rsolr","git_url":"git://github.com/bbcsnippets/rsolr.git","language":"Ruby","fork":true,"svn_url":"https://svn.github.com/bbcsnippets/rsolr","id":2550100,"pushed_at":"2011-10-11T12:59:05Z","open_issues":0,"homepage":"","description":"A Ruby client for Apache Solr","forks":0,"html_url":"https://github.com/bbcsnippets/rsolr","owner":{"avatar_url":"https://secure.gravatar.com/avatar/1f81b4cdb2bdaa11ef41c2b6520a7894?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/bbcsnippets","id":648879,"login":"bbcsnippets"}},"label":"bbcsnippets:5e94fb5ed1b41f376ecc82f0212dc1ca6036795d","sha":"5e94fb5ed1b41f376ecc82f0212dc1ca6036795d","ref":"5e94fb5ed1b41f376ecc82f0212dc1ca6036795d","user":{"avatar_url":"https://secure.gravatar.com/avatar/1f81b4cdb2bdaa11ef41c2b6520a7894?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/bbcsnippets","id":648879,"login":"bbcsnippets"}},"merged_by":null,"created_at":"2011-10-11T13:05:04Z","changed_files":3,"merged":false,"body":"Hello,\r\n\r\nFirst of all, apologies for submitting two different commits in the same pull request. \r\n\r\n1) Removed setting the wt=ruby\r\nI am not entirely sure, why this is being done probably due to lack of my understanding of RSolr but in my opinion, this should come from the user as opposed to set in the code by default. I did not see any specs around it. Please enlighten.\r\n\r\n2) Fixed url path\r\nIn build_request method, the merge was removing the /solr bit from the original supplied url. So, instead of\r\n<pre>\r\nhttp://localhost:9999/solr/select?q=a\r\n</pre>\r\n\r\nit was this:\r\n\r\n<pre>\r\nhttp://localhost:9999/select?q=a\r\n</pre>\r\n\r\nThanks.\r\n","comments":0,"title":"Removed setting the wt=ruby in params and fixed url path in build_request","additions":5,"diff_url":"https://github.com/mwmitchell/rsolr/pull/28.diff","updated_at":"2011-10-11T14:38:41Z","url":"https://api.github.com/repos/mwmitchell/rsolr/pulls/28","id":393169,"patch_url":"https://github.com/mwmitchell/rsolr/pull/28.patch","mergeable":true,"merged_at":null,"commits":1,"closed_at":"2011-10-11T14:38:41Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/7e7bb3bc9e522f86e090f1732adacada?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/andhapp","id":6663,"login":"andhapp"},"deletions":6,"html_url":"https://github.com/mwmitchell/rsolr/pull/28","base":{"repo":{"master_branch":null,"name":"rsolr","created_at":"2008-12-09T20:49:50Z","size":224,"clone_url":"https://github.com/mwmitchell/rsolr.git","private":false,"updated_at":"2011-10-11T13:05:05Z","watchers":166,"ssh_url":"git@github.com:mwmitchell/rsolr.git","url":"https://api.github.com/repos/mwmitchell/rsolr","git_url":"git://github.com/mwmitchell/rsolr.git","language":"Ruby","fork":false,"svn_url":"https://svn.github.com/mwmitchell/rsolr","id":87821,"pushed_at":"2011-10-11T13:05:05Z","open_issues":3,"homepage":"","description":"A Ruby client for Apache Solr","forks":45,"html_url":"https://github.com/mwmitchell/rsolr","owner":{"avatar_url":"https://secure.gravatar.com/avatar/444c7d8579d3389a76c8497f5cb66c13?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/mwmitchell","id":11620,"login":"mwmitchell"}},"label":"mwmitchell:master","sha":"2df8a46ba67e3082e4f5515ec03edafc3c65c5aa","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/444c7d8579d3389a76c8497f5cb66c13?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/mwmitchell","id":11620,"login":"mwmitchell"}},"state":"closed"},"action":"closed"}