{"comment":{"created_at":"2011-10-08T14:33:57Z","body":"Actually, before you start working on a new PR. Could you just describe the deficiency you have encountered, and your proposed solution in more detail (maybe just open an issue)?\r\n\r\nWe already have a lot of performance optimizations in place, and with the current code, it is already not necessary to hydrate objects in order to check ACL permissions. So, my guess is that you simply have not used all the power of the existing code yet.","updated_at":"2011-10-08T14:33:57Z","url":"https://api.github.com/repos/symfony/symfony/issues/comments/2332285","id":2332285,"user":{"avatar_url":"https://secure.gravatar.com/avatar/96a13b96ece78afe3c2dc841edc4a8f5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/schmittjoh","id":197017,"login":"schmittjoh"}},"action":"created","issue":{"number":2056,"created_at":"2011-08-30T09:42:20Z","pull_request":{"diff_url":"https://github.com/symfony/symfony/pull/2056.diff","patch_url":"https://github.com/symfony/symfony/pull/2056.patch","html_url":"https://github.com/symfony/symfony/pull/2056"},"body":"This PR follows #2035 and is a first try for a better implementation for 2.1.\r\n\r\nI opened it to discuss it. I haven't even tested it yet!\r\n\r\nWith this implementation, the example from the [cookbook](http://symfony.com/doc/current/cookbook/security/acl.html#creating-an-acl-and-adding-an-ace) would have to be changed to: https://gist.github.com/1180537\r\nAlso, every bundle similar to the DoctrineBundle (i.e. every Doctrine*****Bundle having proxy objects or lazy-loaded domain objects) would have to create a new service tagged with ``security.identity_resolver`` and implementing interface ``Symfony\\Component\\Security\\Acl\\Model\\DomainObjectIdentityRetrievalStrategyInterface``.\r\n\r\nThe names of interfaces/classes/tag/service id are not really great so don't hesitate to propose better ones.\r\n\r\nThis implementation, although maybe not perfect, seems really cleaner than solution in #2035 (although I don't think this can be merged in 2.0) because we don't have to hard-code anything (like every proxy interfaces in #2035).\r\n\r\n@schmittjoh @fabpot @stof What do you think?","comments":17,"title":"[2.1] [Security] [ACL] New service security.acl.identity_resolver","updated_at":"2011-10-08T14:33:57Z","url":"https://api.github.com/repos/symfony/symfony/issues/2056","id":1517713,"assignee":null,"milestone":{"number":6,"created_at":"2011-05-03T13:52:15Z","due_on":null,"title":"2.1","creator":{"avatar_url":"https://secure.gravatar.com/avatar/f1a2c5905e121d09feba5ad73898ffca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/fabpot","id":47313,"login":"fabpot"},"url":"https://api.github.com/repos/symfony/symfony/milestones/6","open_issues":68,"closed_issues":73,"description":"","state":"open"},"closed_at":"2011-10-08T12:50:06Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/34c17828d5b464aaa1b382b34e9ab1f8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/jalliot","id":387904,"login":"jalliot"},"html_url":"https://github.com/symfony/symfony/issues/2056","labels":[{"name":"Security","url":"https://api.github.com/repos/symfony/symfony/labels/Security","color":"444444"}],"state":"closed"},"legacy":{"issue_id":1517713,"comment_id":2332285}}