{"issue":{"state":"open","created_at":"2011-12-12T22:13:24Z","updated_at":"2011-12-12T23:04:20Z","comments":2,"user":{"gravatar_id":"6685c24275d2bf1d3a9fb2639ce6213c","id":82110,"url":"https://api.github.com/users/kelredd","avatar_url":"https://secure.gravatar.com/avatar/6685c24275d2bf1d3a9fb2639ce6213c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"kelredd"},"body":"* support for builder render approach\r\n* flush method\r\n* flexible template creation\r\n* readme love\r\n\r\n/cc @jcredding","assignee":null,"id":2529381,"pull_request":{"patch_url":"https://github.com/kelredd/undies/pull/3.patch","html_url":"https://github.com/kelredd/undies/pull/3","diff_url":"https://github.com/kelredd/undies/pull/3.diff"},"labels":[],"number":3,"title":"Builder","html_url":"https://github.com/kelredd/undies/issues/3","closed_at":null,"url":"https://api.github.com/repos/kelredd/undies/issues/3","milestone":null},"action":"created","comment":{"created_at":"2011-12-12T23:04:20Z","updated_at":"2011-12-12T23:04:20Z","user":{"gravatar_id":"13cda5326399e76077435acc936c092d","id":85966,"url":"https://api.github.com/users/jcredding","avatar_url":"https://secure.gravatar.com/avatar/13cda5326399e76077435acc936c092d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"jcredding"},"body":"@kelredd - README is solid. I think you cover the usage of the API with your examples well. The rendering section makes sense as well. Only a couple minor things (these are questions that came up while reading):\r\n\r\n* XML Namespaces, do they work? If so an example of one would be cool, if not, possibly an explanation could be nice.\r\n* Is the return value of a block used for content? Most of your examples seem this way, but I don't actually think it works this way. Rails' `content_tag` does so there could be some confusion. An example of multiple sibling nodes would also help to clear this up.\r\n* Special XML/HTML stuff. Do HTML DOCTYPE's work or the first line for xml tags work? Or are you expected to use the `__` helper to achieve this? Ex: `<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">` or `<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>`\r\n* XML/HTML comments. Similar to the last point, do you manually enter them or are they supported? Ex: `<!-- comment -->`\r\n* With your examples, some of them use colons (`:`) before the code, other's don't.\r\n\r\nThe return value is the only one I really think could use some more explanation. The rest are pretty minor (to me) but I could see them as feature requests. That's all I can think of right now, hope it helps.","id":3114676,"url":"https://api.github.com/repos/kelredd/undies/issues/comments/3114676"}}