{"action":"closed","pull_request":{"review_comments":2,"state":"closed","created_at":"2011-08-12T20:05:06Z","patch_url":"https://github.com/plataformatec/devise/pull/1266.patch","updated_at":"2011-12-04T21:19:23Z","changed_files":15,"_links":{"review_comments":{"href":"https://api.github.com/repos/plataformatec/devise/pulls/1266/comments"},"comments":{"href":"https://api.github.com/repos/plataformatec/devise/issues/1266/comments"},"html":{"href":"https://github.com/plataformatec/devise/pull/1266"},"self":{"href":"https://api.github.com/repos/plataformatec/devise/pulls/1266"}},"comments":26,"issue_url":"https://github.com/plataformatec/devise/issues/1266","user":{"gravatar_id":"a0eb1b76472eebedf13bfe4c4d4b9b81","id":1901,"url":"https://api.github.com/users/heimidal","avatar_url":"https://secure.gravatar.com/avatar/a0eb1b76472eebedf13bfe4c4d4b9b81?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"heimidal"},"deletions":17,"merged":true,"body":"This code is largely taken from Mandaryn's implementation from several months ago that was not merged. The discussion around that code is still relevant. It can be found here: https://github.com/plataformatec/devise/pull/1120\r\n\r\nI've modified the code to more thoroughly test backward compatibility with prior installations (for users who are already using confirmable). I've also used #headers_for to send the confirmation email to the appropriate email address depending on if the :reconfirmable setting is in use.\r\n\r\nAny feedback is definitely appreciated. Thanks!","commits":9,"mergeable":null,"id":269283,"additions":344,"base":{"repo":{"created_at":"2009-09-16T12:15:12Z","pushed_at":"2011-12-04T21:19:21Z","updated_at":"2011-12-04T21:19:22Z","private":false,"clone_url":"https://github.com/plataformatec/devise.git","svn_url":"https://svn.github.com/plataformatec/devise","name":"devise","watchers":5354,"master_branch":null,"forks":629,"language":"Ruby","owner":{"gravatar_id":"7c12adb8b5521c060ab4630360a4fa27","id":127679,"url":"https://api.github.com/users/plataformatec","avatar_url":"https://secure.gravatar.com/avatar/7c12adb8b5521c060ab4630360a4fa27?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"plataformatec"},"id":308770,"homepage":"http://blog.plataformatec.com.br/tag/devise/","git_url":"git://github.com/plataformatec/devise.git","description":"Flexible authentication solution for Rails with Warden.","html_url":"https://github.com/plataformatec/devise","url":"https://api.github.com/repos/plataformatec/devise","size":1564,"fork":false,"open_issues":1,"ssh_url":"git@github.com:plataformatec/devise.git"},"user":{"gravatar_id":"7c12adb8b5521c060ab4630360a4fa27","id":127679,"url":"https://api.github.com/users/plataformatec","avatar_url":"https://secure.gravatar.com/avatar/7c12adb8b5521c060ab4630360a4fa27?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"plataformatec"},"sha":"2372823fd8d1de9241b399054175108053e0590a","ref":"master","label":"plataformatec:master"},"merged_by":{"gravatar_id":"e837f6b7fd146ab16ed3d663476c063e","id":9582,"url":"https://api.github.com/users/josevalim","avatar_url":"https://secure.gravatar.com/avatar/e837f6b7fd146ab16ed3d663476c063e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"josevalim"},"number":1266,"title":"Revised email re-confirmation feature","head":{"repo":{"created_at":"2011-08-12T18:29:04Z","pushed_at":"2011-10-12T17:04:26Z","updated_at":"2011-10-12T17:05:07Z","private":false,"clone_url":"https://github.com/heimidal/devise.git","svn_url":"https://svn.github.com/heimidal/devise","name":"devise","watchers":2,"master_branch":null,"forks":0,"language":"Ruby","owner":{"gravatar_id":"a0eb1b76472eebedf13bfe4c4d4b9b81","id":1901,"url":"https://api.github.com/users/heimidal","avatar_url":"https://secure.gravatar.com/avatar/a0eb1b76472eebedf13bfe4c4d4b9b81?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"heimidal"},"id":2198551,"homepage":"http://blog.plataformatec.com.br/tag/devise/","git_url":"git://github.com/heimidal/devise.git","description":"Flexible authentication solution for Rails with Warden.","html_url":"https://github.com/heimidal/devise","url":"https://api.github.com/repos/heimidal/devise","size":140,"fork":true,"open_issues":0,"ssh_url":"git@github.com:heimidal/devise.git"},"user":{"gravatar_id":"a0eb1b76472eebedf13bfe4c4d4b9b81","id":1901,"url":"https://api.github.com/users/heimidal","avatar_url":"https://secure.gravatar.com/avatar/a0eb1b76472eebedf13bfe4c4d4b9b81?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"heimidal"},"sha":"7f754caba3f3f3d3901e8f3771a9c0deb82c6594","ref":"updates","label":"heimidal:updates"},"closed_at":"2011-12-04T21:19:23Z","html_url":"https://github.com/plataformatec/devise/pull/1266","url":"https://api.github.com/repos/plataformatec/devise/pulls/1266","diff_url":"https://github.com/plataformatec/devise/pull/1266.diff","merged_at":"2011-12-04T21:19:23Z"},"number":1266}