{"pull_request":{"state":"closed","deletions":81,"merged_by":{"avatar_url":"https://secure.gravatar.com/avatar/05f9b2938a4b1d9228370f2984fe7b74?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"05f9b2938a4b1d9228370f2984fe7b74","url":"https://api.github.com/users/carballude","login":"carballude","id":993836},"user":{"avatar_url":"https://secure.gravatar.com/avatar/bcc5021e37a37507fd22bbd9fbeab599?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"bcc5021e37a37507fd22bbd9fbeab599","url":"https://api.github.com/users/alexmcchesney","login":"alexmcchesney","id":1170469},"updated_at":"2011-11-15T04:17:32Z","closed_at":"2011-11-15T04:17:32Z","base":{"ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/05f9b2938a4b1d9228370f2984fe7b74?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"05f9b2938a4b1d9228370f2984fe7b74","url":"https://api.github.com/users/carballude","login":"carballude","id":993836},"repo":{"name":"GoogleMusicDownloader","fork":false,"pushed_at":"2011-11-15T04:17:33Z","master_branch":null,"open_issues":0,"updated_at":"2011-11-15T04:17:33Z","clone_url":"https://github.com/carballude/GoogleMusicDownloader.git","homepage":"","language":null,"private":false,"forks":2,"svn_url":"https://svn.github.com/carballude/GoogleMusicDownloader","url":"https://api.github.com/repos/carballude/GoogleMusicDownloader","owner":{"avatar_url":"https://secure.gravatar.com/avatar/05f9b2938a4b1d9228370f2984fe7b74?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"05f9b2938a4b1d9228370f2984fe7b74","url":"https://api.github.com/users/carballude","login":"carballude","id":993836},"html_url":"https://github.com/carballude/GoogleMusicDownloader","description":"Small utility to download songs from Google Music","size":204,"id":2658453,"git_url":"git://github.com/carballude/GoogleMusicDownloader.git","watchers":3,"created_at":"2011-10-27T13:51:34Z","ssh_url":"git@github.com:carballude/GoogleMusicDownloader.git"},"label":"carballude:master","sha":"cb9ece571fce95ab904e18f1d094cc0c5a9dd9e5"},"commits":6,"diff_url":"https://github.com/carballude/GoogleMusicDownloader/pull/1.diff","comments":0,"head":{"ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/bcc5021e37a37507fd22bbd9fbeab599?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"bcc5021e37a37507fd22bbd9fbeab599","url":"https://api.github.com/users/alexmcchesney","login":"alexmcchesney","id":1170469},"repo":{"name":"GoogleMusicDownloader","fork":true,"pushed_at":"2011-11-11T22:15:03Z","master_branch":null,"open_issues":0,"updated_at":"2011-11-11T22:15:04Z","clone_url":"https://github.com/alexmcchesney/GoogleMusicDownloader.git","homepage":"","language":"C#","private":false,"forks":0,"svn_url":"https://svn.github.com/alexmcchesney/GoogleMusicDownloader","url":"https://api.github.com/repos/alexmcchesney/GoogleMusicDownloader","owner":{"avatar_url":"https://secure.gravatar.com/avatar/bcc5021e37a37507fd22bbd9fbeab599?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"bcc5021e37a37507fd22bbd9fbeab599","url":"https://api.github.com/users/alexmcchesney","login":"alexmcchesney","id":1170469},"html_url":"https://github.com/alexmcchesney/GoogleMusicDownloader","description":"Small utility to download songs from Google Music","size":152,"id":2704108,"git_url":"git://github.com/alexmcchesney/GoogleMusicDownloader.git","watchers":1,"created_at":"2011-11-03T18:26:15Z","ssh_url":"git@github.com:alexmcchesney/GoogleMusicDownloader.git"},"label":"alexmcchesney:master","sha":"0e9a4a5be67b638b7c4f4b69818dd589665163fb"},"additions":14452,"url":"https://api.github.com/repos/carballude/GoogleMusicDownloader/pulls/1","merged":true,"body":"Hi Pablo.  I've made few little changes to the GoogleMusicDownloader that you might want to know about.\r\n\r\n1. After closing the download window, the process wasn't ending, and had to be killed from task manager.  This was caused by the hidden browser window staying alive. \r\n\r\n2. Invalid characters are now removed from filenames, and if a file already exists in the download location, the target has (n) appended to it, where n is an integer ensuring uniqueness.  (eg MyBand - My Song (1).mp3)\r\n\r\n3. Downloaded songs now have the ID3 tags for Name, Artist and Album set after download.  This uses [UltraID3Lib] to actually write the tags, and I've added this to the project. \r\n\r\nUltraID3 lib is a closed-source project, though it is free to use providing you credit the author.  I don't know how you feel about this, and if you'd rather the project remained totally open-source, then that's fair enough.  If you do decide to roll it into the main fork, we should probably add a credit as per the license file.\r\n\r\nTo explain why the ID3 tags are so useful to me - I recently lost a large MP3 collection to a hard-drive crash.  Fortunately, most of it was \"backed up\" to Google Music, though I was frustrated to find that they don't currently allow you to re-download stuff you have stored there.  Your downloader tool was proving useful, but I keep my music in iTunes, and without ID3 tags it files everything under \"unknown artist\" and \"unknown album\", with the name of the song lifted directly from the file name.  I was able to use [MusicBrainz Picard] to update ID3 information, which did a reasonably good job under the circumstances, but was still quite error prone, since it had to \"guess\" the album from the filename/length etc.\r\n\r\nHaving ID3 tags in place makes rebuilding my library a lot easier.  Unfortunately, Google Music doesn't display the track number in the playlist view, so I still have to put them through Picard before importing into iTunes, or it'll get the track order wrong.  But Picard makes a much better job of it now that it can read the name of the source album from the tags.\r\n\r\nAnyway, let me know what you think of the changes, and thanks again for developing the tool.  Hope things are going well for you.  I'll be keeping an eye on your blog for more interesting projects.  ;)\r\n\r\nAlex\r\n\r\n\r\n[UltraID3Lib]: http://home.fuse.net/honnert/UltraID3Lib/\r\n[MusicBrainz Picard]: http://musicbrainz.org/doc/MusicBrainz_Picard","merged_at":"2011-11-15T04:17:32Z","_links":{"comments":{"href":"https://api.github.com/repos/carballude/GoogleMusicDownloader/issues/1/comments"},"html":{"href":"https://github.com/carballude/GoogleMusicDownloader/pull/1"},"review_comments":{"href":"https://api.github.com/repos/carballude/GoogleMusicDownloader/pulls/1/comments"},"self":{"href":"https://api.github.com/repos/carballude/GoogleMusicDownloader/pulls/1"}},"html_url":"https://github.com/carballude/GoogleMusicDownloader/pull/1","issue_url":"https://github.com/carballude/GoogleMusicDownloader/issues/1","review_comments":0,"title":"Some GoogleMusicDownloader updates","number":1,"mergeable":null,"id":487203,"patch_url":"https://github.com/carballude/GoogleMusicDownloader/pull/1.patch","changed_files":11,"created_at":"2011-11-11T19:47:19Z"},"action":"closed","number":1}