{"action":"closed","pull_request":{"review_comments":0,"created_at":"2011-11-24T14:01:42Z","state":"closed","updated_at":"2011-12-04T15:45:01Z","_links":{"review_comments":{"href":"https://api.github.com/repos/agiliq/django-production-ready/pulls/5/comments"},"comments":{"href":"https://api.github.com/repos/agiliq/django-production-ready/issues/5/comments"},"html":{"href":"https://github.com/agiliq/django-production-ready/pull/5"},"self":{"href":"https://api.github.com/repos/agiliq/django-production-ready/pulls/5"}},"patch_url":"https://github.com/agiliq/django-production-ready/pull/5.patch","changed_files":1,"comments":0,"issue_url":"https://github.com/agiliq/django-production-ready/issues/5","user":{"gravatar_id":"a9e053803882a4ce800def15b6275319","id":316381,"url":"https://api.github.com/users/kailashnath","login":"kailashnath","avatar_url":"https://secure.gravatar.com/avatar/a9e053803882a4ce800def15b6275319?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"deletions":88,"merged":true,"body":"Had to change the current implementation as it's against clean code design.\r\n\r\n* Previously the code was using the functions documentation as a message to the user.\r\n -> Documentation is supposed to communicate the intent of the code block to the programmer but not as an error message to the user. Never use doc strings for printing out a message to the user\r\n* Filename was Tests, which did not convey what it actually meant. The code block under that class wasn't testing any thing it was returning the values which is against what the class name is\r\n* Template checking mechanism was faulty\r\n -> The code was using get_template which means it searches across all the template locations even django's default templates, hence when searched for 404.html it always returns True as 404.html exists with django, hence had to change the implementation\r\n\r\n* Removed the text under 'handle' function as it isn't the appropriate place for it. It should have been placed in README file\r\n* Modified the help text as previously it was too casual message and wasn't in style form with other manage.py commands help description.\r\n\r\nThe new patch sticks to the zen of clean code ! The code structure is self explanatory and very much testable. The class Validations is side effect free.","mergeable":null,"commits":3,"id":526445,"additions":79,"base":{"repo":{"created_at":"2011-10-11T11:57:32Z","pushed_at":"2011-12-04T15:45:01Z","updated_at":"2011-12-04T15:45:01Z","private":false,"clone_url":"https://github.com/agiliq/django-production-ready.git","name":"django-production-ready","watchers":19,"master_branch":null,"svn_url":"https://svn.github.com/agiliq/django-production-ready","forks":5,"language":"Python","owner":{"gravatar_id":"9577a029048553383d95e4c853a6d016","id":95932,"url":"https://api.github.com/users/agiliq","login":"agiliq","avatar_url":"https://secure.gravatar.com/avatar/9577a029048553383d95e4c853a6d016?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":2554886,"homepage":"","git_url":"git://github.com/agiliq/django-production-ready.git","description":"Is your app production ready?","html_url":"https://github.com/agiliq/django-production-ready","url":"https://api.github.com/repos/agiliq/django-production-ready","size":148,"fork":false,"ssh_url":"git@github.com:agiliq/django-production-ready.git","open_issues":0},"user":{"gravatar_id":"9577a029048553383d95e4c853a6d016","id":95932,"url":"https://api.github.com/users/agiliq","login":"agiliq","avatar_url":"https://secure.gravatar.com/avatar/9577a029048553383d95e4c853a6d016?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"sha":"992093337d74b3358ec01c7a646ac67b1373ad01","ref":"master","label":"agiliq:master"},"merged_by":{"gravatar_id":"c096e738f98e3ec97155cd363c0f1ec9","id":33965,"url":"https://api.github.com/users/theju","login":"theju","avatar_url":"https://secure.gravatar.com/avatar/c096e738f98e3ec97155cd363c0f1ec9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"number":5,"title":"Updated the design and naming conventions","head":{"repo":{"created_at":"2011-11-21T09:29:32Z","pushed_at":"2011-11-26T04:48:24Z","updated_at":"2011-11-26T04:48:24Z","private":false,"clone_url":"https://github.com/kailashnath/django-production-ready.git","name":"django-production-ready","watchers":1,"master_branch":null,"svn_url":"https://svn.github.com/kailashnath/django-production-ready","forks":0,"language":"Python","owner":{"gravatar_id":"a9e053803882a4ce800def15b6275319","id":316381,"url":"https://api.github.com/users/kailashnath","login":"kailashnath","avatar_url":"https://secure.gravatar.com/avatar/a9e053803882a4ce800def15b6275319?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"id":2818769,"homepage":"","git_url":"git://github.com/kailashnath/django-production-ready.git","description":"Is your app production ready?","html_url":"https://github.com/kailashnath/django-production-ready","url":"https://api.github.com/repos/kailashnath/django-production-ready","size":108,"fork":true,"ssh_url":"git@github.com:kailashnath/django-production-ready.git","open_issues":0},"user":{"gravatar_id":"a9e053803882a4ce800def15b6275319","id":316381,"url":"https://api.github.com/users/kailashnath","login":"kailashnath","avatar_url":"https://secure.gravatar.com/avatar/a9e053803882a4ce800def15b6275319?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"sha":"a394db1bbd95333502f6438ddf199a11f8df681a","ref":"master","label":"kailashnath:master"},"closed_at":"2011-12-04T15:45:01Z","html_url":"https://github.com/agiliq/django-production-ready/pull/5","url":"https://api.github.com/repos/agiliq/django-production-ready/pulls/5","diff_url":"https://github.com/agiliq/django-production-ready/pull/5.diff","merged_at":"2011-12-04T15:45:01Z"},"number":5}