{"issue":{"created_at":"2011-11-29T21:47:14Z","state":"closed","updated_at":"2011-11-29T21:47:20Z","comments":5,"user":{"gravatar_id":"1c0dba2e2d4914062d95c1f45099537b","id":357895,"url":"https://api.github.com/users/fbender","avatar_url":"https://secure.gravatar.com/avatar/1c0dba2e2d4914062d95c1f45099537b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"fbender"},"body":"In dc46e7ec794c583c02b01abad4c82b14 (remove unnecessary whitespace) you also removed some semicolons from (mostly) inline JavaScript. It is not required at EOF (as well as in several other places), but you should insert it (as a good practice). It might even have a (really really small) performance impact (as the parser might need to clean up the code first). Additionally, I don't know what impact this change has on dynamically inserted JavaScript (e. g. in onclick attributes). \n\nSee also http://inimino.org/~inimino/blog/javascript_semicolons\n\n--- _Originally created on October 16th, 2011, at 12:57pm (ID 3551)_","assignee":null,"id":2393899,"number":3551,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[{"name":"Feature","color":"4183c4","url":"https://api.github.com/repos/contao/import/labels/Feature"},{"name":"framework","color":"e6e6e6","url":"https://api.github.com/repos/contao/import/labels/framework"}],"title":"Re-insert semicolons at EOF","closed_at":"2011-11-29T21:47:20Z","html_url":"https://github.com/contao/import/issues/3551","url":"https://api.github.com/repos/contao/import/issues/3551","milestone":null},"action":"closed"}