{"ref":"refs/heads/master","push_id":55653597,"commits":[{"sha":"30f2be3b70ac035987ab340dcda7f09295e80fac","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/30f2be3b70ac035987ab340dcda7f09295e80fac","message":"merged branch juliendidier/twig-security-class (PR #2835)\n\nCommits\n-------\n\n60ebaaa [SecurityBundle] fix service class by adding a parameter, on twig extension\n\nDiscussion\n----------\n\n[SecurityBundle] fix service class by adding a parameter, on twig extension\n\nBug fix: no\nFeature addition: no\nBackwards compatibility break: no\nSymfony2 tests pass: yes\nFixes the following tickets: -\nTodo: -\n\nTo override the is_granted twig function, the class of TwigExtension is now set in a parameter.\n\n---------------------------------------------------------------------------\n\nby stof at 2011/12/10 10:38:38 -0800\n\nFirst thing, you could overwrite the extension at the twig level by simply registering another twig extension with the same ``getName`` method.\n\nAnd second point, replacing core Twig functions is probably one of the best way to forbid you to use third party bundles as the change will also impact their code. Do you really need to do it (especially considering that this function simply calls the security context and all the logic is in the context) ?\n\n---------------------------------------------------------------------------\n\nby juliendidier at 2011/12/10 15:43:08 -0800\n\nYes, overriding ```is_granted``` function is probably a bad example. But having it set as parameter allow you to redefine it (if you know what you are doing)."},{"sha":"fd174a228b2964ae6f362d2f2b22ee2e353b5803","author":{"email":"fe14975b02825621d741133a720055170ebcf991@gmail.com","name":"Joseph Bielawski"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/fd174a228b2964ae6f362d2f2b22ee2e353b5803","message":"[Tests] Use proper assertion for counting"},{"sha":"517eebcb317b971785db78a8d086e81acbc4530d","author":{"email":"c7f588235eb4d781000efad2e6ace6c60b7a63ef@beberlei.de","name":"Benjamin Eberlei"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/517eebcb317b971785db78a8d086e81acbc4530d","message":"[DoctrineBridge] Refactor entity choice list to be ORM independant using an EntityLoader interface."},{"sha":"b919d92b523eb5fb35e25f40245d8d00e67627ef","author":{"email":"c7f588235eb4d781000efad2e6ace6c60b7a63ef@beberlei.de","name":"Benjamin Eberlei"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/b919d92b523eb5fb35e25f40245d8d00e67627ef","message":"[DoctrineBridge] Optimize fetching of entities to use WHERE IN and fix other inefficencies."},{"sha":"3b5c617ad01e36f74bd949d55d90326c69acc85e","author":{"email":"c7f588235eb4d781000efad2e6ace6c60b7a63ef@beberlei.de","name":"Benjamin Eberlei"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/3b5c617ad01e36f74bd949d55d90326c69acc85e","message":"[DoctrineBridge] Remove large parts of the EntityChoiceList code that were completly unnecessary (code was unreachable)."},{"sha":"988c2a525e3dc4c7a38489ba99f42ac7e6ac7835","author":{"email":"c7f588235eb4d781000efad2e6ace6c60b7a63ef@beberlei.de","name":"Benjamin Eberlei"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/988c2a525e3dc4c7a38489ba99f42ac7e6ac7835","message":"Adjust check"},{"sha":"7646a5bc6da37d4f0ad455d9e550c7e2f284e5fe","author":{"email":"c7f588235eb4d781000efad2e6ace6c60b7a63ef@beberlei.de","name":"Benjamin Eberlei"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/7646a5bc6da37d4f0ad455d9e550c7e2f284e5fe","message":"[Doctrine] Dont allow null in ORMQueryBuilderLoader"},{"sha":"3c81b6295572fe435e2fbc67846d6029be7e5010","author":{"email":"c7f588235eb4d781000efad2e6ace6c60b7a63ef@beberlei.de","name":"Benjamin Eberlei"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/3c81b6295572fe435e2fbc67846d6029be7e5010","message":"[Doctrine] Cleanup and move loader into its own method"},{"sha":"694c74da30fd697af42c11f2e3bddfc69afdcba0","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/694c74da30fd697af42c11f2e3bddfc69afdcba0","message":"merged branch stloyd/proper_asserts (PR #2916)\n\nCommits\n-------\n\nfd174a2 [Tests] Use proper assertion for counting\n\nDiscussion\n----------\n\n[Tests] Use proper assertion for counting\n\n```\nBug fix: no\nFeature addition: no\nBackwards compatibility break: no\nSymfony2 tests pass: yes\n```\n\nDocs PR: symfony/symfony-docs#924"},{"sha":"200ed5490b3ee33dafc465ea2f7ebc53a2f29fad","author":{"email":"bdfc83b49179f4905b3a5b06f3b74bb5172a9a16@notk.org","name":"Christophe Coevoet"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/200ed5490b3ee33dafc465ea2f7ebc53a2f29fad","message":"[DoctrineBridge] Extracted the common type and made the choice list generic"},{"sha":"f1199c0c684f6e16e2be58b9e87905156edd8dc2","author":{"email":"bdfc83b49179f4905b3a5b06f3b74bb5172a9a16@notk.org","name":"Christophe Coevoet"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/f1199c0c684f6e16e2be58b9e87905156edd8dc2","message":"[DoctrineBridge] Decoupled the EntityUserProvider from the ORM\n\nIt can now be used by any Doctrine project implementing the interfaces\nfrom Doctrine Common 2.2."},{"sha":"29f4111f3e20e6dc123badfb87ea9faa4efa31b7","author":{"email":"bdfc83b49179f4905b3a5b06f3b74bb5172a9a16@notk.org","name":"Christophe Coevoet"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/29f4111f3e20e6dc123badfb87ea9faa4efa31b7","message":"[DoctrineBridge] Added a failing test showing the issue for proxy users"},{"sha":"649fa5219f98cca4d80908fd73560a854f21de4e","author":{"email":"bdfc83b49179f4905b3a5b06f3b74bb5172a9a16@notk.org","name":"Christophe Coevoet"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/649fa5219f98cca4d80908fd73560a854f21de4e","message":"[DoctrineBridge] Fixed the entity provider to support proxies"},{"sha":"84ad40dcc80b9a5cd51e53fc2183f966cadca6fe","author":{"email":"7a83503a0d44a162e91f72df11a584cb7ce300ad@gmail.com","name":"Dustin Dobervich"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/84ad40dcc80b9a5cd51e53fc2183f966cadca6fe","message":"added cache clear hook"},{"sha":"3ae976cd5a3436d67b48599068d58671fc6de27c","author":{"email":"7a83503a0d44a162e91f72df11a584cb7ce300ad@gmail.com","name":"Dustin Dobervich"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/3ae976cd5a3436d67b48599068d58671fc6de27c","message":"fixed CS"},{"sha":"b0987a3c9cffb5976f4540a90880fa71d1f5217c","author":{"email":"6e2196333a34bac97531a453d97d022a997931b2@madalynn.eu","name":"Julien Brochet"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/b0987a3c9cffb5976f4540a90880fa71d1f5217c","message":"[WebProfilerBundle] fixed toolbar height"},{"sha":"ddf6534cc684eb14fa634ff23a0108d3facea3d4","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/ddf6534cc684eb14fa634ff23a0108d3facea3d4","message":"merged branch stof/doctrine_choice_list (PR #2921)\n\nCommits\n-------\n\n200ed54 [DoctrineBridge] Extracted the common type and made the choice list generic\n3c81b62 [Doctrine] Cleanup and move loader into its own method\n7646a5b [Doctrine] Dont allow null in ORMQueryBuilderLoader\n988c2a5 Adjust check\n3b5c617 [DoctrineBridge] Remove large parts of the EntityChoiceList code that were completly unnecessary (code was unreachable).\nb919d92 [DoctrineBridge] Optimize fetching of entities to use WHERE IN and fix other inefficencies.\n517eebc [DoctrineBridge] Refactor entity choice list to be ORM independant using an EntityLoader interface.\n\nDiscussion\n----------\n\n[DoctrineBridge] Refactor EntityChoiceList\n\nBug fix: no\nFeature addition: yes\nBackwards compatibility break: no (99%)\nSymfony2 tests pass: yes\n\nThis decouples the ORM from the EntityChoiceList and makes its much more flexible. Instead of having a \"query_builder\" to do smart or complex queries you can now create \"loader\" instances which can arbitrarily help loading entities.\n\nAdditionally i removed lots of code that was unnecessary and not used by the current code.\n\nThere is a slight BC break in that the EntityChoiceList class is now accepting an EntityLoaderInterface instead of a querybuilder. However that class was nested inside the EntityType and should not be widely used or overwritten.\n\nThe abstract class DoctrineType is meant to be used as base class by other Doctrine project to share the logic by simply using a different type name and a different loader implementation.\n\nThis PR replaces #2728.\n\n---------------------------------------------------------------------------\n\nby beberlei at 2011/12/19 09:20:43 -0800\n\nThanks for doing the last refactorings, this is now fine from my side as well."},{"sha":"ce41b8eafac2a440236da38ce0e0f8b4c4473b78","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/ce41b8eafac2a440236da38ce0e0f8b4c4473b78","message":"merged branch stof/entity_provider (PR #2923)\n\nCommits\n-------\n\nf1199c0 [DoctrineBridge] Decoupled the EntityUserProvider from the ORM\n\nDiscussion\n----------\n\n[DoctrineBridge] Decoupled the EntityUserProvider from the ORM\n\nBug fix: no\nFeature addition: yes\nBackwards compatibility break: yes\nSymfony2 tests pass: yes\n\nThe entity provider can now be used by any Doctrine project implementing the interfaces from Doctrine Common 2.2."},{"sha":"f58cfc0dcb09d03b402d0c21783d5c41a519891e","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/f58cfc0dcb09d03b402d0c21783d5c41a519891e","message":"merged branch stof/entity_provider_proxy (PR #2922)\n\nCommits\n-------\n\n649fa52 [DoctrineBridge] Fixed the entity provider to support proxies\n29f4111 [DoctrineBridge] Added a failing test showing the issue for proxy users\n\nDiscussion\n----------\n\nFixed the entity provider to support proxies\n\nBug fix: yes\nFeature addition: no\nBackwards compatibility break: yes\nSymfony2 tests pass: yes\n\nIf a proxy object was used, the ``supportsClass`` method would fail becasue it does a string comparison for the class name.\n\nThis issue has not been reported by users yet because it is an edge case:\n\n- ``supportsClass`` is used only in the RememberMe system\n- getting a proxy in the entity provider is possible only if a listener running before the firewall loaded an object which has a relation to the user, which is far from being a standard use case.\n\n---------------------------------------------------------------------------\n\nby schmittjoh at 2011/12/19 10:07:46 -0800\n\nHow about using the new proxy tools that Doctrine has?\n\n---------------------------------------------------------------------------\n\nby stof at 2011/12/19 10:20:37 -0800\n\nthe new tool will only be available in 2.2 so only for Symfony 2.1. Once merged into master, we could eventually refactor it in the master branch to use ``Doctrine\\Common\\Util\\ClassUtils``"},{"sha":"05285e429c251aa5ab41929329607ca3b8950036","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"url":"https://api.github.com/repos/sgehrig/symfony/commits/05285e429c251aa5ab41929329607ca3b8950036","message":"merged branch dustin10/cache-clearers (PR #2857)\n\nCommits\n-------\n\n3ae976c fixed CS\n84ad40d added cache clear hook\n\nDiscussion\n----------\n\n[Cache][2.1] Added cache clear hook\n\nAllows bundles to hook into the `cache:clear` command by using the `kernel.cache_clearer` tag instead of using the `event_dispatcher` service.\n\nSee #1884\n\nBug fix: No\nFeature addition: Yes\nBackwards compatibility break: No\nSymfony2 tests pass: Yes\nFixes the following tickets: #1884\nReferences the following tickets: #1884\n\n---------------------------------------------------------------------------\n\nby dustin10 at 2011/12/16 11:03:54 -0800\n\nRebased to squash all commits into one.\n\n---------------------------------------------------------------------------\n\nby lsmith77 at 2011/12/17 05:27:29 -0800\n\n@fabpot: we figured that priorities wouldn't be needed for cleaning .. haven't tested the PR, but conceptually it looks good to me and aside from the priority stuff its modeled after the cache warners.\n\n---------------------------------------------------------------------------\n\nby dustin10 at 2011/12/19 09:46:26 -0800\n\n@fabpot Updated to pass cache dir to `clear` method.\n\n---------------------------------------------------------------------------\n\nby dustin10 at 2011/12/19 10:02:21 -0800\n\n@stof and @fabpot Another thought I just had. Should the `$this->getContainer()->get('cache_clearer')->clear($realCacheDir);` call in the `CacheClearCommand` be done before the warming?\n\n---------------------------------------------------------------------------\n\nby stof at 2011/12/19 10:03:59 -0800\n\nindeed. the clearing should be done before the warming.\n\n---------------------------------------------------------------------------\n\nby dustin10 at 2011/12/19 10:19:28 -0800\n\nSquashed all commits into one. Let me know if there is anything else.\n\n---------------------------------------------------------------------------\n\nby dustin10 at 2011/12/19 10:31:50 -0800\n\nFixed extra lines."}],"head":"23e04e3acb4cb9328a395ddb8b97928dfb1b3627","size":110}