{"issue":{"state":"open","created_at":"2011-11-01T23:06:06Z","updated_at":"2011-12-06T11:34:11Z","user":{"gravatar_id":"2d961080e97ad8be3a0fdcb9a9c5b183","id":1132472,"url":"https://api.github.com/users/jrief","login":"jrief","avatar_url":"https://secure.gravatar.com/avatar/2d961080e97ad8be3a0fdcb9a9c5b183?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":1,"body":"","assignee":null,"id":2116284,"number":113,"labels":[],"pull_request":{"patch_url":"https://github.com/divio/django-shop/pull/113.patch","html_url":"https://github.com/divio/django-shop/pull/113","diff_url":"https://github.com/divio/django-shop/pull/113.diff"},"title":"Fix for issue #112","html_url":"https://github.com/divio/django-shop/issues/113","closed_at":null,"url":"https://api.github.com/repos/divio/django-shop/issues/113","milestone":null},"action":"created","comment":{"created_at":"2011-12-06T11:34:11Z","updated_at":"2011-12-06T11:34:11Z","user":{"gravatar_id":"7d1f1e5f0365595b4b97ca26115bdf02","id":25211,"url":"https://api.github.com/users/chrisglass","login":"chrisglass","avatar_url":"https://secure.gravatar.com/avatar/7d1f1e5f0365595b4b97ca26115bdf02?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"This pull request is polluted with commits that have absolutely nothing to do with issue 112.\r\n\r\nThe instructions on how to send patches are wrong, but apply to the whole of github, and not just to this project:\r\n1. Checkout your fork.\r\n2. ***Create a feature branch***\r\n3. Hack hack hack, test test test, commit commit commit, test again.\r\n4. Push to your fork.\r\n5. Open a pull request ***from that feature branch***.\r\n6. (Merge back that branch into your master if you're so inclined)\r\n\r\nFrom the github documentation: http://help.github.com/send-pull-requests/\r\n\"Pull requests can be sent from any branch or commit but it’s recommended that a topic branch be used so that follow-up commits can be pushed to update the pull request if necessary.\"\r\n\r\nI'll indeed make this clear in the shop's documentation too, however.","id":3031100,"url":"https://api.github.com/repos/divio/django-shop/issues/comments/3031100"}}