{"shas":[["174e87a9b150a06a4ff9d696a6008fc08b05568b","1fa2ef4755a9226cb9a0a4840bd89b158ac71391@puppetlabs.com","(#4258) Fix pkgutil spec test to have the correct provider\n\nThe resource being used for testing didn't explicitly set the provider,\nso it ended up using whatever the default provider was on the system on\nwhich it was run.  This was problematic when running the specs on a Mac\nsince the default provider is pkgdmg and that provider doesn't seem to\nbe upgradeable.  So when you tried:\n\n    @resource[:ensure] = :latest\n\nYou got the error:\n\n    1) Puppet::Type::Package::ProviderPkgutil when installing should use a command without versioned package\n     Failure/Error: @resource[:ensure] = :latest\n     Puppet::Error: Parameter ensure failed: Provider must have features 'upgradeable' to set 'ensure' to 'latest'\n     # ./lib/puppet/parameter.rb:171:in `fail'     # ./lib/puppet/parameter.rb:257:in `validate'\n     # ./lib/puppet/property.rb:300:in `should='     # ./lib/puppet/property.rb:300:in `each'\n     # ./lib/puppet/property.rb:300:in `should='     # ./lib/puppet/property.rb:337:in `value='\n     # ./lib/puppet/type.rb:416:in `[]='     # ./spec/unit/provider/package/pkgutil_spec.rb:35\n\nReviewed-by: Daniel Pittman <daniel@puppetlabs.com>","Matt Robinson"],["d88b3763cea9e116c8abf45ca2aa4ec80fa20349","1fa2ef4755a9226cb9a0a4840bd89b158ac71391@puppetlabs.com","Merge branch 'feature/master/4258-pkgutil' into 2.7.x\n\n* feature/master/4258-pkgutil: (29 commits)\n  (#4258) Fix pkgutil spec test to have the correct provider\n  (#4258) Remove superfluous command check that called pkgutil\n  (#4258) Fix fd leak opening pkgutil config files\n  (#4258) Permit variations of -nv in both pkgutil.conf files\n  (#4258) Stop file and config checks from breaking spec\n  (#4258) Check wgetopts in pkgutil.conf\n  (#4258) Fix hash duplication affecting canonical provider instance\n  (#4258) Use pkgutil -a to reliably determine package common names/aliases\n  (#4258) Update pkgutil spec for recent impl changes\n  (#4258) pkgutil: bug fix: if shortname is not equal to package name\n  (#4258) pkgutil provider: better handling of short package names\n  (#4258) pkgutil provider: misc enhancements\n  Add spec tests for pkgutil package provider\n  * Fix exception on parse failure of pkgutil output * Fix exception when querying latest version for unknown package\n  Fixing indentation\n  Removing blastwave references and unused PAGER\n  Changing indentation to 2-spaces as per 2.6+ style\n  Single package queries made more robust when dealing with pkgutil noise\n  Fixing wget verbose regex\n  These regular expressions will not match anything.  pkgutil doesn't output anything that can be matched.\n  ...","Matt Robinson"]],"repo":"puppetlabs/puppet","actor":"mmrobins","ref":"refs/heads/2.7.x","size":2,"head":"d88b3763cea9e116c8abf45ca2aa4ec80fa20349","actor_gravatar":"ece4667b127c1d3f3ff917c86893433c","push_id":29051459}