{"shas":[["5e47d0452087b89b322295ed95b30d2ae699fd93","1594cc7c4ef8452618155c7c4d62ab14ed606a60@midnightcircus.com","Move the post form from teh handler to the Post class.\nBeware of at least these two issues:\n1. The on_success system in FormUI is altered.  The behavior is not meant to have changed except to allow multiple on_success handlers to be registered to a form.  This is not ideal, since the return result of the on_success handler is what is displayed in the form space after the form is successfully committed (see the wiki).  Something needs to be decided on how to proceed, and it likely will break some compatibility with something.\n2. Displaying a post's form from a page is possible, but the form will not submit.  Why?  Because handler_vars (which contains the incoming criteria from the URL about what to display) merges both $_GET and $_POST into itself.  Since the form POSTs a value for \"id\" of 0 (signifying a new post), and the slug of a page is also submitted, Posts::get() tries to fetch the page using id=0 AND slug=whatever, which obviously fails.  Thus the page that is submitted to isn't found and the form isn't processed successfully.  If $_POST values are removed from the handler_vars (currently done in Controller:173), then the form submits successfully and the new post is created, but because some field values are extracted from handler_vars for the post, the results are still not ideal.  Also, removing $_POST from handler_vars has other side-effects that I've not tested thoroughly, since some parts of Habari expect that $_POST values will be present there.  An unfortunate situation with no easy solution but to tear a bunch of stuff apart.\nI submit this commit in the hope that someone has a good idea to fix it.  If you don't stretch Habari much farther that we have been, everything works fine, but if you try to do some of the very attractive things that this commit was meant to enable (like embed post submission forms in the public site), they fail.  Hopefully a resolution presents itself soon.\nThanks for reading this long commit message.","ringmaster"],["a3f9ff96df6c141048ff15da25f6f79b11749dfb","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Break every theme ever made (except mine) by changing the default for $theme-> calls from echo'ing the output to simply returning it. You can now append _echo to your function name or simply echo the existing call. The _return purpose still exists, but is redundant and should be considered deprecated.","Chris Meller"],["66cfc831ea5ddc7d6bac00a5ab49ffd1904334a0","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Update K2, our default theme, to fix the changes created in commit a3f9ff9.","Chris Meller"],["a271bceee09116dcbb962366c78a0dade868d1d0","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Merge branch 'master' of github.com:habari/system","Chris Meller"],["c31c50742143d51d5accc705a13df78192459c64","ae832fafa8f9598e4326d42533ead9f436a91daa@gmail.com","Only output the error message about blocks not being found if DEBUG is defined.","rick-c"],["64cc6cfe02d20b18c22974a5c1f713f868b25e13","94ec4b54882db3332b14dc568295a6a2eb5a4225@gmail.com","Bring back consistent look for all the ul.tabs","Colin Seymour"],["b56bbef1dc393a0fdb5df9a1f2544bfe5401e5ce","1594cc7c4ef8452618155c7c4d62ab14ed606a60@midnightcircus.com","Test for boolean, not just DEBUG.","ringmaster"],["3cfbaad6cdab5d0e58363caa980b63cb836b5894","1594cc7c4ef8452618155c7c4d62ab14ed606a60@midnightcircus.com","Make Stack pass the test.","ringmaster"],["98f1380645f7d6bfe9da99d6d74788c3b9100a57","1594cc7c4ef8452618155c7c4d62ab14ed606a60@midnightcircus.com","Move the post form from teh handler to the Post class.\nBeware of at least these two issues:\n1. The on_success system in FormUI is altered.  The behavior is not meant to have changed except to allow multiple on_success handlers to be registered to a form.  This is not ideal, since the return result of the on_success handler is what is displayed in the form space after the form is successfully committed (see the wiki).  Something needs to be decided on how to proceed, and it likely will break some compatibility with something.\n2. Displaying a post's form from a page is possible, but the form will not submit.  Why?  Because handler_vars (which contains the incoming criteria from the URL about what to display) merges both $_GET and $_POST into itself.  Since the form POSTs a value for \"id\" of 0 (signifying a new post), and the slug of a page is also submitted, Posts::get() tries to fetch the page using id=0 AND slug=whatever, which obviously fails.  Thus the page that is submitted to isn't found and the form isn't processed successfully.  If $_POST values are removed from the handler_vars (currently done in Controller:173), then the form submits successfully and the new post is created, but because some field values are extracted from handler_vars for the post, the results are still not ideal.  Also, removing $_POST from handler_vars has other side-effects that I've not tested thoroughly, since some parts of Habari expect that $_POST values will be present there.  An unfortunate situation with no easy solution but to tear a bunch of stuff apart.\nI submit this commit in the hope that someone has a good idea to fix it.  If you don't stretch Habari much farther that we have been, everything works fine, but if you try to do some of the very attractive things that this commit was meant to enable (like embed post submission forms in the public site), they fail.  Hopefully a resolution presents itself soon.\nThanks for reading this long commit message.","ringmaster"],["50cff1676ef5f1b27e5b9a0ce97bd3203d5ea333","1fa2ef4755a9226cb9a0a4840bd89b158ac71391@mattread.com","automatic POT template generation","Matt Read"],["55509ae8cb936355f23552688e5fa630f0f80b0f","1fa2ef4755a9226cb9a0a4840bd89b158ac71391@mattread.com","merge from subversion client","Matt Read"],["b2ed4713a8bde81d32e493b47be79704361c2ead","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Un-rubbish a single-line conditional in Charcoal.","Chris Meller"],["645f839eb7a1463ebe40efcca131371071b11282","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Really, who uses sizeof()?","Chris Meller"],["fb71d0f0361f882d5a2746175ba7a135b5cfed41","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Update Charcoal for the theme changes.","Chris Meller"],["7f3f2465bab676b1877cd17a8c2a608b3e550442","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Switch _echo on theme calls to _out to please Mr. @ringmaster's sense of consistency.","Chris Meller"],["b6fa6d012b805e9283461ebee90b3419a13ca2f8","711c73f64afdce07b7e38039a96d2224209e9a6c@doesnthaveone.com","Merge branch 'master' of github.com:habari/system","Chris Meller"],["9819b5043e7bfbbe1f7ea60c58de78521471b0f5","94ec4b54882db3332b14dc568295a6a2eb5a4225@gmail.com","Setting AjaxResponse::out return header to text/plain as it seems to not cause any problems with any browsers.  This fixes habari/habari#204","Colin Seymour"],["9a4a92aa937ab6c91b008aa49f4704780553a19a","94ec4b54882db3332b14dc568295a6a2eb5a4225@gmail.com","Return 404 when someone manually accesses atom content that doesn't exist. Coding standards change too. Fixes habari/habari#201","Colin Seymour"],["d5bd03e086685b4c082a80242fc3890336008429","94ec4b54882db3332b14dc568295a6a2eb5a4225@gmail.com","Merge branch 'master' of github.com:habari/system","Colin Seymour"],["fd921ff6016f42c570993b9182dfcd9b8a558f01","ae832fafa8f9598e4326d42533ead9f436a91daa@gmail.com","Get info to work in the search field on the posts manage page.","rick-c"]],"ref":"refs/heads/master","size":21,"head":"ece783a92435947b20af91a62a34a9324589f6ac","push_id":43621423}