{"comment":{"created_at":"2011-10-17T12:42:29Z","body":"> I think it does make sense to give Sunspot the responsibility for creating the config files, and sunspot_solr the responsibility for running what is there.\r\n\r\nSounds fine to me.\r\n\r\n> I might have driven this in the wrong direction earlier…!\r\n\r\nHappens all the time in software; doesn't bother me :)\r\n\r\nSo as @jmileham says, we are going to require the config files be created locally or `bin/sunspot-solr` will not run, right? That's fine too .. just want to be ultra-clear.","updated_at":"2011-10-17T12:42:29Z","url":"https://api.github.com/repos/sunspot/sunspot/issues/comments/2428260","id":2428260,"user":{"gravatar_id":"3da9aebb918d0d1b12d66fcca93c289d","avatar_url":"https://secure.gravatar.com/avatar/3da9aebb918d0d1b12d66fcca93c289d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/alindeman","id":395621,"login":"alindeman"}},"action":"created","issue":{"number":81,"created_at":"2011-09-09T19:46:06Z","pull_request":{"diff_url":"https://github.com/sunspot/sunspot/pull/81.diff","patch_url":"https://github.com/sunspot/sunspot/pull/81.patch","html_url":"https://github.com/sunspot/sunspot/pull/81"},"body":"@nz Fixes a bug on 1.3rc that prevents automatically generating solr config files due to the extraction of the config directories to the sunspot_solr gem.\r\n\r\nIt achieves this by yanking fresh copies of the config files from sunspot_solr/solr/solr/config into the sunspot gem at build time.  That should keep those files from bitrotting even when the bundled solr is upgraded, while not getting into sketchy territory surrounding symlinks stored in git.\r\n\r\nIt also refactors sunspot-installer to work sensibly with non-vendored solr: you must now provide a directory name rather than defaulting to `pwd`.  This is because it also automatically pulls in any files that you're missing (even if you don't specify -f).  With that behavior, defaulting to `pwd` is too dangerous/magical (if you were in your rails root and you ran `sunspot-installer` without this modification you'd get schema.xml dropped in your rails root).  This way you don't have \"force\" a fresh install (which to me violates POLS).  Considering that this script is totally undocumented (and had the wrong filename for itself in its help text), I figured I could get away with this change in this pull request.\r\n\r\nThe auto-installation of config files when running rake sunspot:solr:(run|start) for the first time from sunspot_rails is preserved.\r\n\r\nAlso if you choose not to install sunspot_solr, you can simply type `sunspot-installer solr` from your app root and get a standard set of config files that you can check into source control.  Useful if, for example, you're using Websolr for both development and production, but need to track schema.xml changes.","comments":13,"title":"Pull default config files out of Sunspot::Solr for packaging.","updated_at":"2011-10-17T12:42:29Z","url":"https://api.github.com/repos/sunspot/sunspot/issues/81","id":1610786,"assignee":null,"milestone":null,"closed_at":null,"user":{"gravatar_id":"079ab1cc5aa71e625bb160e62b09f09c","avatar_url":"https://secure.gravatar.com/avatar/079ab1cc5aa71e625bb160e62b09f09c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/jmileham","id":40619,"login":"jmileham"},"html_url":"https://github.com/sunspot/sunspot/issues/81","labels":[],"state":"open"},"legacy":{"issue_id":1610786,"comment_id":2428260}}