{"issue":{"created_at":"2011-11-11T14:39:37Z","state":"closed","updated_at":"2011-11-25T03:59:25Z","user":{"gravatar_id":"8531b0de83cb35089082f9acd7038b74","id":35949,"url":"https://api.github.com/users/jmreidy","login":"jmreidy","avatar_url":"https://secure.gravatar.com/avatar/8531b0de83cb35089082f9acd7038b74?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":1,"body":"While there still doesn't seem to be a universal convention for using underscores versus dashes in node files, I prefer the underscore notation. Unfortunately, vows only supports test files that end in `-test` or `-spec`. This code adds logic to allow either a dash or underscore.\r\n\r\nAs part of this fix, I noticed that the vows `watch` functionality wasn't working entirely as it should. Investigating it revealed that *all* files in the test directory were being loaded, regardless of whether the file name ended in a dash (or underscore) `test/spec`. Since I needed to fix the watch logic to support underscores anyway, I also added a fix for this issue.\r\n\r\nFinally, the `testInherit` test was not loading the `lib` version of vows, but rather the global system vows, so there's a quick change there.","assignee":null,"number":153,"id":2209874,"labels":[],"pull_request":{"patch_url":"https://github.com/cloudhead/vows/pull/153.patch","html_url":"https://github.com/cloudhead/vows/pull/153","diff_url":"https://github.com/cloudhead/vows/pull/153.diff"},"title":"Add underscore support","closed_at":"2011-11-25T03:59:25Z","html_url":"https://github.com/cloudhead/vows/issues/153","url":"https://api.github.com/repos/cloudhead/vows/issues/153","milestone":null},"action":"created","comment":{"created_at":"2011-11-25T03:59:25Z","updated_at":"2011-11-25T03:59:25Z","user":{"gravatar_id":"d43e8ea63b61e7669ded5b9d3c2e980f","id":4624,"url":"https://api.github.com/users/indexzero","login":"indexzero","avatar_url":"https://secure.gravatar.com/avatar/d43e8ea63b61e7669ded5b9d3c2e980f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"This looks good. Cherry-picked into `master`.","id":2871118,"url":"https://api.github.com/repos/cloudhead/vows/issues/comments/2871118"}}