{"issue":{"title":"Syntax Error in ‘src/torrent/object_raw_bencode.h’","user":{"login":"veryfoolish","id":526645,"url":"https://api.github.com/users/veryfoolish","avatar_url":"https://secure.gravatar.com/avatar/9b3c7141bc664a469b965b3fb0552363?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"9b3c7141bc664a469b965b3fb0552363"},"created_at":"2011-12-24T21:02:26Z","milestone":null,"labels":[],"state":"open","updated_at":"2011-12-25T16:57:54Z","id":2653632,"closed_at":null,"html_url":"https://github.com/rakshasa/libtorrent/issues/8","pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"body":"I really dislike the way you’ve responded to my previous bug reports, but I don’t want your software to be broken so I am going through it to find bugs since you obviously don’t seem to really care about them. Hopefully this will make the Internet just a tiny bit more secure.\r\n\r\nAnyway, in ‘src/torrent/object_raw_bencode.h’ we have the following:\r\n\r\n<code>bool empty() const { return m_size == 0;; }</code>\r\n\r\nWhich should obviously be:\r\n\r\n<code>bool empty() const { return m_size == 0; }</code>\r\n\r\nYou’re welcome!","number":8,"url":"https://api.github.com/repos/rakshasa/libtorrent/issues/8","comments":1,"assignee":null},"comment":{"user":{"login":"veryfoolish","id":526645,"url":"https://api.github.com/users/veryfoolish","avatar_url":"https://secure.gravatar.com/avatar/9b3c7141bc664a469b965b3fb0552363?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"9b3c7141bc664a469b965b3fb0552363"},"created_at":"2011-12-25T16:57:54Z","updated_at":"2011-12-25T16:57:54Z","id":3271150,"body":"Just to note; I am auditing your code in general. What would be the easiest way for me to send you the things I find? There are quite a lot of issues in your code: you use variable-sized buffers all over, esp. in the memory management section... you really should probably use std::vector or perhaps a new type... but what you’re writing is technically incorrect and almost certainly insecure!— You declare enums incorrectly too; as if you were writing C not C++.\r\n\r\nMoreover, the code in general a complete mess. You misspell things all the time (I understand English isn’t your first language) and the documentation is awful.","url":"https://api.github.com/repos/rakshasa/libtorrent/issues/comments/3271150"},"action":"created"}