{"issue":{"state":"open","pull_request":{"diff_url":"https://github.com/mozilla/addon-sdk/pull/258.diff","html_url":"https://github.com/mozilla/addon-sdk/pull/258","patch_url":"https://github.com/mozilla/addon-sdk/pull/258.patch"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/bb55b2a8c34fd29f570ca139f13d46b8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"bb55b2a8c34fd29f570ca139f13d46b8","url":"https://api.github.com/users/KWierso","login":"KWierso","id":172215},"milestone":null,"updated_at":"2011-11-09T22:09:26Z","labels":[],"assignee":null,"comments":2,"closed_at":null,"url":"https://api.github.com/repos/mozilla/addon-sdk/issues/258","body":"This add's asqueella's webserver module to api-utils. I copied over the module, the documentation, and the test.\r\n\r\nI had to change the test a bit to get it to work. The test was failing as it was originally written: \r\nerror: TEST FAILED: test-httpd.testBasicHTTPServer (exception)\r\nerror: An exception occurred.\r\nTraceback (most recent call last):\r\n  File \"resource://83d01d46-ac84-4a54-be64-31f6d6d94b07-at-jetpack-api-utils-tests/test-httpd.js\", line 4, in\r\n    require(\"url\").toFilename(__url__)); // ...this file is in\r\nReferenceError: __url__ is not defined\r\nSo the test now serves up api-util's data/ directory and requests a file located in there.\r\n\r\n(Running the test spews a lot of stuff to the console, including some warnings. I don't know whether that's important or not, or just part of the way httpd.js works normally.)\r\n\r\nWhile changing the test to pull from the data/ directory, cuddlefish.js was complaining about me requiring \"self\", but I noticed a typo in the error message, so I fixed that as well.\r\n\r\n\r\n(I'm not sure why that activate.bat change got into this pull request. I haven't touched that file for weeks, and I just did a fresh merge from github master...)","html_url":"https://github.com/mozilla/addon-sdk/issues/258","title":"Bug 561926 - Import Httpd module from @asqueella","number":258,"id":2190394,"created_at":"2011-11-09T19:50:17Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/bb55b2a8c34fd29f570ca139f13d46b8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"bb55b2a8c34fd29f570ca139f13d46b8","url":"https://api.github.com/users/KWierso","login":"KWierso","id":172215},"updated_at":"2011-11-09T22:09:26Z","url":"https://api.github.com/repos/mozilla/addon-sdk/issues/comments/2688267","body":"My git-fu is weak. Is pushing a commit that undoes what that bad commit included the preferred way to back something out?","id":2688267,"created_at":"2011-11-09T22:09:26Z"}}