{"issue":{"user":{"id":836770,"login":"b333z","url":"https://api.github.com/users/b333z","avatar_url":"https://secure.gravatar.com/avatar/49e8c91520d61d5a9160a5caeb8012fa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"49e8c91520d61d5a9160a5caeb8012fa"},"title":"zfs diff support","milestone":{"title":"0.6.0","created_at":"2011-05-01T20:06:19Z","creator":{"id":148917,"login":"behlendorf","url":"https://api.github.com/users/behlendorf","avatar_url":"https://secure.gravatar.com/avatar/ea1f5fb7eefd51c5d308e2b78dbdf921?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ea1f5fb7eefd51c5d308e2b78dbdf921"},"open_issues":49,"state":"open","due_on":"2011-12-31T08:00:00Z","closed_issues":25,"description":"ZFS on Linux v0.6.0 - Official stable release which includes the ZFS Posix Layer (ZPL)","number":10,"url":"https://api.github.com/repos/zfsonlinux/zfs/milestones/10"},"created_at":"2011-12-05T10:37:12Z","labels":[{"name":"Feature","url":"https://api.github.com/repos/zfsonlinux/zfs/labels/Feature","color":"02d7e1"}],"state":"open","updated_at":"2011-12-16T06:33:55Z","id":2447818,"html_url":"https://github.com/zfsonlinux/zfs/issues/481","closed_at":null,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"body":"To be able to see a diff across snapshots of a massive filesystem in a matter of seconds will be a great thing. \r\n\r\nThanks to all the great work on the snapshot dirs issue #173, once the snapshot code is finalized, as far as I can tell we will be close to getting the zfs diff command operational.\r\n\r\nAfter compiling up rohan-puri's snapshot branch we get:\r\n\r\n    b15 zfs # zfs diff data@snap3 data@snap4\r\n    Cannot stat /data/.zfs/shares/: unable to generate diffs\r\n\r\nBut after removing the code from libzfs_diff.c that checks for the '.zfs/share' directory:\r\n\r\n\t  diff --git a/lib/libzfs/libzfs_diff.c b/lib/libzfs/libzfs_diff.c\r\n\t  index 8140a70..c00ca75 100644\r\n\t  --- a/lib/libzfs/libzfs_diff.c\r\n\t  +++ b/lib/libzfs/libzfs_diff.c\r\n\t  @@ -739,8 +739,8 @@ setup_differ_info(zfs_handle_t *zhp, const char *fromsnap,\r\n\t\t  if (get_mountpoints(di) != 0)\r\n\t\t\t  return (-1);\r\n\t  \r\n\t  -       if (find_shares_object(di) != 0)\r\n\t  -               return (-1);\r\n\t  +       //if (find_shares_object(di) != 0)\r\n\t  +       //      return (-1);\r\n\t  \r\n\t\t  return (0);\r\n\t  }\r\n\r\n\r\n I was able to see a simple diff in operation:\r\n\r\n\tb15 ~ # zfs diff data@snap3 data@snap4\r\n\tM       /data/\r\n\t+       /data/fstab\r\n\tb15 ~ # \r\n\r\n( for comparison )\r\n\r\n    b15 ~ # diff -r /data/.zfs/snapshot/snap3 /data/.zfs/snapshot/snap4 \r\n    \tOnly in /data/.zfs/snapshot/snap4: fstab\r\n\r\nWould be good to investigate the diff command's requirements including the .zfs/share directory, so that once the snapshot code is finalized we can get the diff command working correctly.\r\n\r\nI will spent some time attempting to understand it via the source code, but anyone got and tips/starting points about what the .zfs/share directory is there for other than to adjust smb acl's and why the libzfs_diff.c file wants to look at it?\r\n","number":481,"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/481","comments":8,"assignee":null},"comment":{"user":{"id":836770,"login":"b333z","url":"https://api.github.com/users/b333z","avatar_url":"https://secure.gravatar.com/avatar/49e8c91520d61d5a9160a5caeb8012fa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"49e8c91520d61d5a9160a5caeb8012fa"},"created_at":"2011-12-16T06:33:55Z","updated_at":"2011-12-16T06:33:55Z","id":3173943,"body":"No worries","url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/3173943"},"action":"created"}