{"comment":{"created_at":"2011-12-13T18:29:33Z","commit_id":"930145641418b8b452617a00c09b1ffbddcbe186","position":null,"updated_at":"2011-12-13T18:29:33Z","user":{"gravatar_id":"baf8186ac5f3f367c8a03e57dc9aabef","id":199558,"url":"https://api.github.com/users/cash","avatar_url":"https://secure.gravatar.com/avatar/baf8186ac5f3f367c8a03e57dc9aabef?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"cash"},"body":"Thanks for the pull request!\r\n\r\nThis does the same (untested!):\r\n```\r\nelgg_get_entities(array(\r\n    'type' => 'group',\r\n    'joins' => array(\"JOIN {$db_prefix}groups_entity ge\"),\r\n    'wheres' => array(\"ge.name = '$name'\"),\r\n));\r\n```\r\n\r\nHere are a few questions/comments (everyone is welcome to chime in):\r\n 1. Is this a function we want in core? I know that I have wanted to get groups by name before, but does it cross the line to merit inclusion in core?\r\n 2. Our policy is to not add new functions/classes in minor releases. If we did add this, we do it in 1.9.0.","id":791229,"path":null,"line":null,"html_url":"https://github.com/jdnavarro/Elgg/commit/9301456414#commitcomment-791229","url":"https://api.github.com/repos/jdnavarro/Elgg/comments/791229"}}