{"action":"opened","pull_request":{"state":"open","created_at":"2011-11-23T07:54:51Z","review_comments":0,"_links":{"review_comments":{"href":"https://api.github.com/repos/ashtuchkin/iconv-lite/pulls/1/comments"},"comments":{"href":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/1/comments"},"html":{"href":"https://github.com/ashtuchkin/iconv-lite/pull/1"},"self":{"href":"https://api.github.com/repos/ashtuchkin/iconv-lite/pulls/1"}},"updated_at":"2011-11-23T07:54:51Z","patch_url":"https://github.com/ashtuchkin/iconv-lite/pull/1.patch","changed_files":6,"user":{"gravatar_id":"0e163a687b422735fd8c9d60b2d1f69a","id":738465,"url":"https://api.github.com/users/jenkinv","login":"jenkinv","avatar_url":"https://secure.gravatar.com/avatar/0e163a687b422735fd8c9d60b2d1f69a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":0,"issue_url":"https://github.com/ashtuchkin/iconv-lite/issues/1","deletions":3,"body":"      'iconv-lite' is awesome!\r\n      I met the problem that node.js don't support 'new Buffer(mystring, myencoding) or mybuffer.toString(myencoding)' when i prepared to parse GBK file in my job.Then, i found 'iconv' module which have to depend on iconv command line in linux environment. It works fine ,but i have to run my code in windows 7 where 'iconv' cann't compile . So, i found 'iconv-lite' and got an insight into the problem. \r\n     Now, i finished the just-work version with GBK encoding in my fork from iconv-lite.So i 'Send pull request' to u.\r\n    I add a table method in index.js. It can translate one encoding to any other encoding through table-data in 'encodings/table' directory.table-data is key-value struct,key is the code want to decode, value is matched unicode.table-data now only support ucs2 unicode ,max value is 0xFFFF.the gbk.js in encodings dirctory just mapped GBK/GB2312 encoding with table-data and decode function.\r\n\r\n    And then, i meet a question that encodings's method name 'toEncoding/fromEncoding' lead to \r\na litter  confusion for me. I mean it when i look at the code .I suggest 'encode(str,encoding) / decode(buffer,encoding)' which corespond to ' new Buffer(str, encoding)/ buffer.toString(encoding)'","merged":false,"commits":1,"mergeable":null,"number":1,"id":521841,"additions":119,"base":{"user":{"gravatar_id":"caf4918da10588d23f8aaf7ac656d8c5","id":627997,"url":"https://api.github.com/users/ashtuchkin","login":"ashtuchkin","avatar_url":"https://secure.gravatar.com/avatar/caf4918da10588d23f8aaf7ac656d8c5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"repo":{"pushed_at":"2011-11-09T18:42:30Z","created_at":"2011-11-09T17:41:43Z","updated_at":"2011-11-22T02:51:02Z","private":false,"clone_url":"https://github.com/ashtuchkin/iconv-lite.git","name":"iconv-lite","svn_url":"https://svn.github.com/ashtuchkin/iconv-lite","watchers":2,"master_branch":null,"forks":2,"language":"JavaScript","owner":{"gravatar_id":"caf4918da10588d23f8aaf7ac656d8c5","id":627997,"url":"https://api.github.com/users/ashtuchkin","login":"ashtuchkin","avatar_url":"https://secure.gravatar.com/avatar/caf4918da10588d23f8aaf7ac656d8c5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"homepage":"","id":2743221,"description":"Convert character encodings in pure javascript.","git_url":"git://github.com/ashtuchkin/iconv-lite.git","html_url":"https://github.com/ashtuchkin/iconv-lite","url":"https://api.github.com/repos/ashtuchkin/iconv-lite","size":144,"ssh_url":"git@github.com:ashtuchkin/iconv-lite.git","fork":false,"open_issues":1},"sha":"0a09402d86039fbffcdcaba355423fcd9525523a","ref":"master","label":"ashtuchkin:master"},"merged_by":null,"title":"gbk,gb2312 encoding for Simple Chinese language supported","head":{"user":{"gravatar_id":"0e163a687b422735fd8c9d60b2d1f69a","id":738465,"url":"https://api.github.com/users/jenkinv","login":"jenkinv","avatar_url":"https://secure.gravatar.com/avatar/0e163a687b422735fd8c9d60b2d1f69a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"repo":{"pushed_at":"2011-11-23T07:08:02Z","created_at":"2011-11-21T08:59:42Z","updated_at":"2011-11-23T07:08:03Z","private":false,"clone_url":"https://github.com/jenkinv/iconv-lite.git","name":"iconv-lite","svn_url":"https://svn.github.com/jenkinv/iconv-lite","watchers":1,"master_branch":null,"forks":0,"language":"JavaScript","owner":{"gravatar_id":"0e163a687b422735fd8c9d60b2d1f69a","id":738465,"url":"https://api.github.com/users/jenkinv","login":"jenkinv","avatar_url":"https://secure.gravatar.com/avatar/0e163a687b422735fd8c9d60b2d1f69a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"homepage":"","id":2818637,"description":"Convert character encodings in pure javascript.","git_url":"git://github.com/jenkinv/iconv-lite.git","html_url":"https://github.com/jenkinv/iconv-lite","url":"https://api.github.com/repos/jenkinv/iconv-lite","size":272,"ssh_url":"git@github.com:jenkinv/iconv-lite.git","fork":true,"open_issues":0},"sha":"e559c6b9cbbdf1213ab65d9ed06a7626098d215f","ref":"master","label":"jenkinv:master"},"closed_at":null,"html_url":"https://github.com/ashtuchkin/iconv-lite/pull/1","url":"https://api.github.com/repos/ashtuchkin/iconv-lite/pulls/1","diff_url":"https://github.com/ashtuchkin/iconv-lite/pull/1.diff","merged_at":null},"number":1}