{"issue":{"created_at":"2011-12-06T02:56:24Z","state":"open","updated_at":"2011-12-09T14:48:00Z","comments":3,"user":{"gravatar_id":"d07c1f81d10a1d147d6b5cb80fa1c654","id":42126,"url":"https://api.github.com/users/genehack","avatar_url":"https://secure.gravatar.com/avatar/d07c1f81d10a1d147d6b5cb80fa1c654?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"genehack"},"body":"Hi -- here are a few changes that deal with figuring out the proper include path to pass to '-I' as well as a fix where perlcritic is called on the real (not temp) file, avoiding the warning about package and filename mismatches. ","assignee":null,"id":2458004,"labels":[],"pull_request":{"patch_url":"https://github.com/illusori/emacs-flymake-perlcritic/pull/1.patch","html_url":"https://github.com/illusori/emacs-flymake-perlcritic/pull/1","diff_url":"https://github.com/illusori/emacs-flymake-perlcritic/pull/1.diff"},"number":1,"title":"Fixes for include path and file name mismatch issues","html_url":"https://github.com/illusori/emacs-flymake-perlcritic/issues/1","closed_at":null,"url":"https://api.github.com/repos/illusori/emacs-flymake-perlcritic/issues/1","milestone":null},"action":"created","comment":{"created_at":"2011-12-09T14:48:00Z","updated_at":"2011-12-09T14:48:00Z","user":{"gravatar_id":"6a25f29b456663e04e167d80f24f7ba7","id":360670,"url":"https://api.github.com/users/illusori","avatar_url":"https://secure.gravatar.com/avatar/6a25f29b456663e04e167d80f24f7ba7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"illusori"},"body":"\"but without looking at it too closely, this seems like a problem that the original version would have as well, no?\"\r\n\r\nNo, flymake runs against a temporary copy of the buffer contents rather than the file contents, so the original version doesn't have the same issue.\r\n\r\n\"Also, maybe I don't understand the approach you're thinking about, but it's not just a mismatch on the leaf filename\"\r\n\r\nYou're quite probably right, I haven't looked at just what Perl::Critic is doing in that check, whether it's just checking the leaf filename or looking at the parent directories too. If that is the case then that complicates matters even more.","id":3079949,"url":"https://api.github.com/repos/illusori/emacs-flymake-perlcritic/issues/comments/3079949"}}