{"issue":{"milestone":null,"user":{"id":169061,"login":"sptramer","url":"https://api.github.com/users/sptramer","avatar_url":"https://secure.gravatar.com/avatar/71668abbd82dcf496aec4a44c29ada2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"71668abbd82dcf496aec4a44c29ada2d"},"title":"[TIMOB-6572] Don't inject the alert() function - bind it","created_at":"2011-12-14T01:15:00Z","labels":[],"updated_at":"2011-12-16T19:21:50Z","state":"open","id":2546551,"html_url":"https://github.com/appcelerator/titanium_mobile/issues/973","closed_at":null,"pull_request":{"patch_url":"https://github.com/appcelerator/titanium_mobile/pull/973.patch","html_url":"https://github.com/appcelerator/titanium_mobile/pull/973","diff_url":"https://github.com/appcelerator/titanium_mobile/pull/973.diff"},"body":"Evaluating scripts outside of begin/end eval causes issues with the debugger hooks in certain multicontext situations, and we shouldn't be \"evaluating\" this function anyway; it should be a direct binding into the kroll context.\r\n\r\nThis pull request will need to be tested both against the bug and a basic `alert()` use case. We may also have been allowing users to overload/redefine `alert` in the past (due to the injection); might want to check for this as well and see if we regressed there. But `alert` is technically reserved by ECMA (again, check).","number":973,"url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/973","comments":4,"assignee":null},"comment":{"user":{"id":59506,"login":"BlainHamon","url":"https://api.github.com/users/BlainHamon","avatar_url":"https://secure.gravatar.com/avatar/bb6b8b44cb3508f67f00da79d37157c4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"bb6b8b44cb3508f67f00da79d37157c4"},"created_at":"2011-12-16T19:21:50Z","updated_at":"2011-12-16T19:21:50Z","id":3181456,"body":"Functional testing passed. APPROVED.","url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/comments/3181456"},"action":"created"}