{"issue":{"state":"open","pull_request":{"diff_url":"https://github.com/Paratron/SimpLESS/pull/7.diff","html_url":"https://github.com/Paratron/SimpLESS/pull/7","patch_url":"https://github.com/Paratron/SimpLESS/pull/7.patch"},"milestone":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/730c03c7ecdbd654028b3beb5f592290?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"730c03c7ecdbd654028b3beb5f592290","url":"https://api.github.com/users/mike182uk","login":"mike182uk","id":991592},"updated_at":"2011-10-30T10:45:35Z","labels":[],"assignee":null,"comments":1,"closed_at":null,"url":"https://api.github.com/repos/Paratron/SimpLESS/issues/7","body":"## Features Added\r\n\r\n- **Localization (L10n) Support** - When i first started using this app i noticed the months where in german. Rather than simply replacing them to english equivalents i have added L10n.json which contains localized data depending on the users preference. This could be expanded to include lots of other locales.\r\n- **User Configuration Support** - For the localization support to work correctly the user needs the ability to select there locale. I have created a configuration page the user can go to, to modify the configuration of the app. I have moved the show love message here as-well. I think on the homescreen rather than having the 'show love' icon in the bottom bar, a cog icon (indicates settings) would be more appropriate which would then take you to the conifg page (where you can modify multiple settings for the app). This adds scope to add more configurable options later.\r\n- **CSS Minification Support** - On the configuration page the user can select wether they want the CSS output to be minified or not.\r\n\r\n\r\n## Notes\r\n\r\n**Design**\r\n\r\nUnfortunately im not a designer so im not too good at making things look pretty :( You did an awesome job with the looks of the app so i have left the design of the configure cog, and configuration page up to you.\r\n\r\n**Misc**\r\n\r\nI have used localStorage to save the users configuration data. Im not 100% sure how titanium works with this but when i was testing it seemed to work fine with me (making changes, rebooting app etc.)\r\n\r\nThe users configuration data is saved as a JSON string (stringified). It needs parsing on retrieval.\r\n\r\nThe CSS minification is done by a series of regular expressions. I have tested on a few different less files (with different levels of formattings) and it seems to work fine. Regular expressions could probably do with refactoring a little though.\r\n\r\n","html_url":"https://github.com/Paratron/SimpLESS/issues/7","title":"Added localization, user configuration and CSS minification","number":7,"id":2088962,"created_at":"2011-10-30T00:06:29Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/ce2b8ed18b8fe0a3dbafb09c49af7c64?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ce2b8ed18b8fe0a3dbafb09c49af7c64","url":"https://api.github.com/users/Paratron","login":"Paratron","id":902599},"updated_at":"2011-10-30T10:45:35Z","url":"https://api.github.com/repos/Paratron/SimpLESS/issues/comments/2569052","body":"Wow, thanks for your work :)\r\n\r\nFirst away: the months werent in german - I simply had typos in may and october... wasn't paying attention there :/\r\nBut as mentioned in [issue 5](https://github.com/Paratron/SimpLESS/issues/5) that was a typo and is fixed with version 1.2\r\n\r\nI did some major changes for 1.2 which arent commited jet - so I wait with pulling your changes until after the release of 1.2","id":2569052,"created_at":"2011-10-30T10:45:35Z"}}