{"pull_request":{"state":"closed","deletions":0,"user":{"avatar_url":"https://secure.gravatar.com/avatar/265130ebc94aa038debeeeaa3913d574?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"265130ebc94aa038debeeeaa3913d574","url":"https://api.github.com/users/Boris-de","login":"Boris-de","id":388462},"merged_by":{"avatar_url":"https://secure.gravatar.com/avatar/44369565060ca0609f3f7f9f3b46f4a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"44369565060ca0609f3f7f9f3b46f4a6","url":"https://api.github.com/users/felixb","login":"felixb","id":192135},"updated_at":"2011-11-18T06:23:12Z","commits":1,"comments":0,"base":{"ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/44369565060ca0609f3f7f9f3b46f4a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"44369565060ca0609f3f7f9f3b46f4a6","url":"https://api.github.com/users/felixb","login":"felixb","id":192135},"repo":{"name":"websms-api","master_branch":null,"fork":false,"pushed_at":"2011-11-18T06:23:13Z","updated_at":"2011-11-18T06:23:13Z","clone_url":"https://github.com/felixb/websms-api.git","homepage":"http://code.google.com/p/websmsdroid/","open_issues":0,"svn_url":"https://svn.github.com/felixb/websms-api","language":"Java","private":false,"forks":5,"url":"https://api.github.com/repos/felixb/websms-api","owner":{"avatar_url":"https://secure.gravatar.com/avatar/44369565060ca0609f3f7f9f3b46f4a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"44369565060ca0609f3f7f9f3b46f4a6","url":"https://api.github.com/users/felixb","login":"felixb","id":192135},"html_url":"https://github.com/felixb/websms-api","description":"WebSMS' Connector API","size":196,"id":692497,"watchers":12,"git_url":"git://github.com/felixb/websms-api.git","created_at":"2010-05-29T11:43:25Z","ssh_url":"git@github.com:felixb/websms-api.git"},"label":"felixb:master","sha":"cdd87f071a4ace57b8b035667f97feeb42b1afb6"},"closed_at":"2011-11-18T06:23:12Z","diff_url":"https://github.com/felixb/websms-api/pull/3.diff","head":{"ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/265130ebc94aa038debeeeaa3913d574?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"265130ebc94aa038debeeeaa3913d574","url":"https://api.github.com/users/Boris-de","login":"Boris-de","id":388462},"repo":{"name":"websms-api","master_branch":null,"fork":true,"pushed_at":"2011-11-13T20:39:52Z","updated_at":"2011-11-13T20:39:52Z","clone_url":"https://github.com/Boris-de/websms-api.git","homepage":"http://code.google.com/p/websmsdroid/","open_issues":0,"svn_url":"https://svn.github.com/Boris-de/websms-api","language":"Java","private":false,"forks":0,"url":"https://api.github.com/repos/Boris-de/websms-api","owner":{"avatar_url":"https://secure.gravatar.com/avatar/265130ebc94aa038debeeeaa3913d574?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"265130ebc94aa038debeeeaa3913d574","url":"https://api.github.com/users/Boris-de","login":"Boris-de","id":388462},"html_url":"https://github.com/Boris-de/websms-api","description":"WebSMS' Connector API","size":104,"id":948095,"watchers":1,"git_url":"git://github.com/Boris-de/websms-api.git","created_at":"2010-09-29T10:58:30Z","ssh_url":"git@github.com:Boris-de/websms-api.git"},"label":"Boris-de:master","sha":"0956b059f263f6828b65383af75fc34917768419"},"additions":20,"url":"https://api.github.com/repos/felixb/websms-api/pulls/3","merged":true,"merged_at":"2011-11-18T06:23:12Z","body":"This is more of a workaround for issue [#608](http://code.google.com/p/websmsdroid/issues/detail?id=608) which prevents the trustAll-parameter from getting used in certain situations. The underlying problem is that the httpClient is cached by Utils.getHttpClient after its created for the first time. So as long as websms runs in the background as a cached process, any change of the trustAll-parameter in the settings are ignore because no new httpClient is created after that.\r\n\r\nAs the caching is a good thing and even seems to be used for some cookie-handling, I did not change this behaviour but added a resetHttpClient() which can be called by a connector after a significant settings-change.\r\n\r\nHowever I don't think this is a very nice way of handling with this because the connectors need to be aware of this when using the websms-api...","html_url":"https://github.com/felixb/websms-api/pull/3","_links":{"comments":{"href":"https://api.github.com/repos/felixb/websms-api/issues/3/comments"},"html":{"href":"https://github.com/felixb/websms-api/pull/3"},"review_comments":{"href":"https://api.github.com/repos/felixb/websms-api/pulls/3/comments"},"self":{"href":"https://api.github.com/repos/felixb/websms-api/pulls/3"}},"review_comments":0,"issue_url":"https://github.com/felixb/websms-api/issues/3","title":"offer a workaround for #608 (\"Utils.getHTTPClient ignores trustAll parameter\")","number":3,"mergeable":null,"id":490101,"patch_url":"https://github.com/felixb/websms-api/pull/3.patch","changed_files":1,"created_at":"2011-11-13T20:48:10Z"},"action":"closed","number":3}