{"action":"closed","pull_request":{"created_at":"2011-12-11T22:25:35Z","state":"closed","review_comments":0,"changed_files":4,"updated_at":"2011-12-12T14:04:45Z","_links":{"review_comments":{"href":"https://api.github.com/repos/viljami/ResponsiveSlides.js/pulls/2/comments"},"comments":{"href":"https://api.github.com/repos/viljami/ResponsiveSlides.js/issues/2/comments"},"html":{"href":"https://github.com/viljami/ResponsiveSlides.js/pull/2"},"self":{"href":"https://api.github.com/repos/viljami/ResponsiveSlides.js/pulls/2"}},"patch_url":"https://github.com/viljami/ResponsiveSlides.js/pull/2.patch","comments":4,"issue_url":"https://github.com/viljami/ResponsiveSlides.js/issues/2","user":{"gravatar_id":"7db2313538a841b5c5137c14c705bc07","id":189964,"url":"https://api.github.com/users/naapuri","avatar_url":"https://secure.gravatar.com/avatar/7db2313538a841b5c5137c14c705bc07?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"naapuri"},"merged":false,"body":"Just for fun, I tried to optimize the JS code for minification, mostly by substituting repeated patterns with some new variables and removing some extra stuff. This all is quite untested, so handle with care, if at all.\r\n\r\nThe IE6 code seems a bit odd (is it really needed to call `$this.css('width', '100%')`twice? also, the feature detection `if` seems a bit verbose), so I think there should some more bytes to be saved.\r\n\r\nI also recommend renaming `.pack.js` to `.min.js`, which is AFAIK more often used.\r\n\r\n(I don't know which minification engine you used, but I used Google Closure.)","deletions":39,"mergeable":false,"commits":5,"number":2,"id":581869,"base":{"user":{"gravatar_id":"2be2f2bf86c3f260735515ca4f4e305c","id":671836,"url":"https://api.github.com/users/viljami","avatar_url":"https://secure.gravatar.com/avatar/2be2f2bf86c3f260735515ca4f4e305c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"viljami"},"repo":{"created_at":"2011-12-03T18:52:56Z","pushed_at":"2011-12-12T13:56:46Z","updated_at":"2011-12-12T13:56:46Z","private":false,"clone_url":"https://github.com/viljami/ResponsiveSlides.js.git","name":"ResponsiveSlides.js","svn_url":"https://svn.github.com/viljami/ResponsiveSlides.js","watchers":77,"master_branch":null,"language":"JavaScript","forks":5,"owner":{"gravatar_id":"2be2f2bf86c3f260735515ca4f4e305c","id":671836,"url":"https://api.github.com/users/viljami","avatar_url":"https://secure.gravatar.com/avatar/2be2f2bf86c3f260735515ca4f4e305c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"viljami"},"id":2906456,"homepage":"http://responsive-slides.viljamis.com","git_url":"git://github.com/viljami/ResponsiveSlides.js.git","description":"Responsive slideshow plugin that weights just ~1kb","html_url":"https://github.com/viljami/ResponsiveSlides.js","url":"https://api.github.com/repos/viljami/ResponsiveSlides.js","size":112,"fork":false,"open_issues":1,"ssh_url":"git@github.com:viljami/ResponsiveSlides.js.git"},"sha":"136eac5c2cd7e172b0d26a7a7a1b6aa9cbead4e6","ref":"master","label":"viljami:master"},"additions":48,"merged_by":null,"title":"Some optimizations for minification","head":{"user":{"gravatar_id":"7db2313538a841b5c5137c14c705bc07","id":189964,"url":"https://api.github.com/users/naapuri","avatar_url":"https://secure.gravatar.com/avatar/7db2313538a841b5c5137c14c705bc07?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"naapuri"},"repo":{"created_at":"2011-12-11T19:28:11Z","pushed_at":"2011-12-11T22:17:00Z","updated_at":"2011-12-11T22:17:00Z","private":false,"clone_url":"https://github.com/naapuri/ResponsiveSlides.js.git","name":"ResponsiveSlides.js","svn_url":"https://svn.github.com/naapuri/ResponsiveSlides.js","watchers":1,"master_branch":null,"language":"JavaScript","forks":0,"owner":{"gravatar_id":"7db2313538a841b5c5137c14c705bc07","id":189964,"url":"https://api.github.com/users/naapuri","avatar_url":"https://secure.gravatar.com/avatar/7db2313538a841b5c5137c14c705bc07?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"naapuri"},"id":2959666,"homepage":"http://responsive-slides.viljamis.com","git_url":"git://github.com/naapuri/ResponsiveSlides.js.git","description":"Responsive slideshow plugin that weights just ~1kb","html_url":"https://github.com/naapuri/ResponsiveSlides.js","url":"https://api.github.com/repos/naapuri/ResponsiveSlides.js","size":108,"fork":true,"open_issues":0,"ssh_url":"git@github.com:naapuri/ResponsiveSlides.js.git"},"sha":"52fa34db709300c080ffb69d881ce7f3d2e1d8cb","ref":"master","label":"naapuri:master"},"html_url":"https://github.com/viljami/ResponsiveSlides.js/pull/2","closed_at":"2011-12-12T14:04:45Z","diff_url":"https://github.com/viljami/ResponsiveSlides.js/pull/2.diff","url":"https://api.github.com/repos/viljami/ResponsiveSlides.js/pulls/2","merged_at":null},"number":2}