{"pull_request":{"user":{"id":169061,"login":"sptramer","url":"https://api.github.com/users/sptramer","avatar_url":"https://secure.gravatar.com/avatar/71668abbd82dcf496aec4a44c29ada2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"71668abbd82dcf496aec4a44c29ada2d"},"title":"[TIMOB-6572] Don't inject the alert() function - bind it","created_at":"2011-12-14T01:15:00Z","merged_at":"2011-12-16T23:30:48Z","review_comments":0,"updated_at":"2011-12-16T23:30:48Z","state":"closed","id":591435,"patch_url":"https://github.com/appcelerator/titanium_mobile/pull/973.patch","html_url":"https://github.com/appcelerator/titanium_mobile/pull/973","closed_at":"2011-12-16T23:30:48Z","deletions":13,"mergeable":null,"issue_url":"https://github.com/appcelerator/titanium_mobile/issues/973","base":{"user":{"id":82188,"login":"appcelerator","url":"https://api.github.com/users/appcelerator","avatar_url":"https://secure.gravatar.com/avatar/01d8a2b8546d6479cf4323d72cbed363?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"01d8a2b8546d6479cf4323d72cbed363"},"ref":"master","sha":"eb1cd19282b0f827b0632bd48dce007fa2234240","repo":{"created_at":"2009-06-15T22:54:37Z","watchers":1090,"open_issues":54,"git_url":"git://github.com/appcelerator/titanium_mobile.git","updated_at":"2011-12-16T23:30:47Z","fork":false,"id":228094,"language":"Objective-C","html_url":"https://github.com/appcelerator/titanium_mobile","name":"titanium_mobile","description":"Appcelerator Titanium Mobile","master_branch":null,"forks":339,"url":"https://api.github.com/repos/appcelerator/titanium_mobile","ssh_url":"git@github.com:appcelerator/titanium_mobile.git","clone_url":"https://github.com/appcelerator/titanium_mobile.git","pushed_at":"2011-12-16T23:30:47Z","owner":{"id":82188,"login":"appcelerator","url":"https://api.github.com/users/appcelerator","avatar_url":"https://secure.gravatar.com/avatar/01d8a2b8546d6479cf4323d72cbed363?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"01d8a2b8546d6479cf4323d72cbed363"},"homepage":"http://www.appcelerator.com","svn_url":"https://svn.github.com/appcelerator/titanium_mobile","size":21248,"private":false},"label":"appcelerator:master"},"body":"Evaluating scripts outside of begin/end eval causes issues with the debugger hooks in certain multicontext situations, and we shouldn't be \"evaluating\" this function anyway; it should be a direct binding into the kroll context.\r\n\r\nThis pull request will need to be tested both against the bug and a basic `alert()` use case. We may also have been allowing users to overload/redefine `alert` in the past (due to the injection); might want to check for this as well and see if we regressed there. But `alert` is technically reserved by ECMA (again, check).","commits":1,"additions":27,"number":973,"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/973","diff_url":"https://github.com/appcelerator/titanium_mobile/pull/973.diff","_links":{"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/973/comments"},"html":{"href":"https://github.com/appcelerator/titanium_mobile/pull/973"},"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/973"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/973/comments"}},"merged_by":{"id":59506,"login":"BlainHamon","url":"https://api.github.com/users/BlainHamon","avatar_url":"https://secure.gravatar.com/avatar/bb6b8b44cb3508f67f00da79d37157c4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"bb6b8b44cb3508f67f00da79d37157c4"},"comments":4,"head":{"user":{"id":169061,"login":"sptramer","url":"https://api.github.com/users/sptramer","avatar_url":"https://secure.gravatar.com/avatar/71668abbd82dcf496aec4a44c29ada2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"71668abbd82dcf496aec4a44c29ada2d"},"ref":"timob-6572","sha":"f5c47c6da239e5bc60ab3072a57c228aa53963d2","repo":{"created_at":"2011-05-27T20:34:00Z","watchers":1,"open_issues":0,"git_url":"git://github.com/sptramer/titanium_mobile.git","updated_at":"2011-12-16T23:24:26Z","fork":true,"id":1811752,"language":"Objective-C","html_url":"https://github.com/sptramer/titanium_mobile","name":"titanium_mobile","description":"Appcelerator Titanium Mobile","master_branch":null,"forks":0,"url":"https://api.github.com/repos/sptramer/titanium_mobile","ssh_url":"git@github.com:sptramer/titanium_mobile.git","clone_url":"https://github.com/sptramer/titanium_mobile.git","pushed_at":"2011-12-16T23:24:21Z","owner":{"id":169061,"login":"sptramer","url":"https://api.github.com/users/sptramer","avatar_url":"https://secure.gravatar.com/avatar/71668abbd82dcf496aec4a44c29ada2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"71668abbd82dcf496aec4a44c29ada2d"},"homepage":"http://www.appcelerator.com","svn_url":"https://svn.github.com/sptramer/titanium_mobile","size":428,"private":false},"label":"sptramer:timob-6572"},"changed_files":3,"merged":true},"number":973,"action":"closed"}