{"action":"closed","number":46,"pull_request":{"created_at":"2011-12-07T21:03:50Z","review_comments":0,"state":"closed","updated_at":"2011-12-09T16:54:25Z","changed_files":5,"_links":{"review_comments":{"href":"https://api.github.com/repos/goncalossilva/rails3_acts_as_paranoid/pulls/46/comments"},"comments":{"href":"https://api.github.com/repos/goncalossilva/rails3_acts_as_paranoid/issues/46/comments"},"html":{"href":"https://github.com/goncalossilva/rails3_acts_as_paranoid/pull/46"},"self":{"href":"https://api.github.com/repos/goncalossilva/rails3_acts_as_paranoid/pulls/46"}},"patch_url":"https://github.com/goncalossilva/rails3_acts_as_paranoid/pull/46.patch","issue_url":"https://github.com/goncalossilva/rails3_acts_as_paranoid/issues/46","user":{"gravatar_id":"e3fcd1818a98b0b4cdf3a2fe46a7ba55","id":59473,"url":"https://api.github.com/users/softcraft-development","avatar_url":"https://secure.gravatar.com/avatar/e3fcd1818a98b0b4cdf3a2fe46a7ba55?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"softcraft-development"},"comments":2,"merged":false,"body":"I'm hacking around in rails3_acts_as_paranoid. In the process of making my own changes (which I hope to fill you in on later), I found the errors (mentioned [here](https://github.com/goncalossilva/rails3_acts_as_paranoid/issues/40)) caused by using the Rails 3.1 version of ActiveRecord... and managed to fix them.\r\n\r\nThere's only 3 changes of real importance:\r\n\r\n* Rename the call in uniqueness_without_deleted.rb from mount_sql_and_params to build_relation\r\n* In the same call, pass an Arel::Table instead of a String table name.\r\n* Remove the aliasing of primary_key_name to foreign_key in ActiveRecord::Reflection::AssociationReflection\r\n\r\nFeel free to ignore/revert my changes to the Gemspec; those are mostly for my own internal purpose.\r\n\r\nHope this helps,\r\n\r\nCraig","deletions":32,"commits":6,"mergeable":true,"id":569599,"additions":31,"base":{"repo":{"created_at":"2010-04-18T18:57:49Z","pushed_at":"2011-11-20T18:52:21Z","updated_at":"2011-12-09T07:45:47Z","private":false,"clone_url":"https://github.com/goncalossilva/rails3_acts_as_paranoid.git","name":"rails3_acts_as_paranoid","master_branch":null,"svn_url":"https://svn.github.com/goncalossilva/rails3_acts_as_paranoid","watchers":143,"language":"Ruby","forks":55,"owner":{"gravatar_id":"d3919b52fcacd09dcbf8804da13321c2","id":102931,"url":"https://api.github.com/users/goncalossilva","avatar_url":"https://secure.gravatar.com/avatar/d3919b52fcacd09dcbf8804da13321c2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"goncalossilva"},"id":616646,"homepage":"","description":"ActiveRecord (>=3.0) plugin which allows you to hide and restore records without actually deleting them. IMPORTANT NOTE: I'm currently out of time for fixing and improving this gem since I'm leaving my current company. I'll start working on it again in August.","git_url":"git://github.com/goncalossilva/rails3_acts_as_paranoid.git","html_url":"https://github.com/goncalossilva/rails3_acts_as_paranoid","size":360,"url":"https://api.github.com/repos/goncalossilva/rails3_acts_as_paranoid","open_issues":5,"fork":false,"ssh_url":"git@github.com:goncalossilva/rails3_acts_as_paranoid.git"},"user":{"gravatar_id":"d3919b52fcacd09dcbf8804da13321c2","id":102931,"url":"https://api.github.com/users/goncalossilva","avatar_url":"https://secure.gravatar.com/avatar/d3919b52fcacd09dcbf8804da13321c2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"goncalossilva"},"sha":"84415bb7c162238c1cee24f526f5b6397c30ff2b","ref":"master","label":"goncalossilva:master"},"merged_by":null,"number":46,"head":{"repo":{"created_at":"2011-12-06T17:14:11Z","pushed_at":"2011-12-08T23:03:28Z","updated_at":"2011-12-08T23:03:28Z","private":false,"clone_url":"https://github.com/softcraft-development/rails3_acts_as_paranoid.git","name":"rails3_acts_as_paranoid","master_branch":null,"svn_url":"https://svn.github.com/softcraft-development/rails3_acts_as_paranoid","watchers":1,"language":"Ruby","forks":0,"owner":{"gravatar_id":"e3fcd1818a98b0b4cdf3a2fe46a7ba55","id":59473,"url":"https://api.github.com/users/softcraft-development","avatar_url":"https://secure.gravatar.com/avatar/e3fcd1818a98b0b4cdf3a2fe46a7ba55?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"softcraft-development"},"id":2926367,"homepage":"","description":"ActiveRecord (>=3.0) plugin which allows you to hide and restore records without actually deleting them. IMPORTANT NOTE: I'm currently out of time for fixing and improving this gem since I'm leaving my current company. I'll start working on it again in August.","git_url":"git://github.com/softcraft-development/rails3_acts_as_paranoid.git","html_url":"https://github.com/softcraft-development/rails3_acts_as_paranoid","size":120,"url":"https://api.github.com/repos/softcraft-development/rails3_acts_as_paranoid","open_issues":0,"fork":true,"ssh_url":"git@github.com:softcraft-development/rails3_acts_as_paranoid.git"},"user":{"gravatar_id":"e3fcd1818a98b0b4cdf3a2fe46a7ba55","id":59473,"url":"https://api.github.com/users/softcraft-development","avatar_url":"https://secure.gravatar.com/avatar/e3fcd1818a98b0b4cdf3a2fe46a7ba55?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"softcraft-development"},"sha":"819f99a6e6a904510eb132a40a61be1b076bc02f","ref":"rails-3-1","label":"softcraft-development:rails-3-1"},"title":"Changes to rails3_acts_as_paranoid for Rails 3.1","html_url":"https://github.com/goncalossilva/rails3_acts_as_paranoid/pull/46","closed_at":"2011-12-09T16:54:25Z","url":"https://api.github.com/repos/goncalossilva/rails3_acts_as_paranoid/pulls/46","diff_url":"https://github.com/goncalossilva/rails3_acts_as_paranoid/pull/46.diff","merged_at":null}}