{"issue":{"created_at":"2011-09-02T09:43:26Z","state":"open","updated_at":"2011-12-02T09:39:33Z","comments":17,"user":{"gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","id":439401,"url":"https://api.github.com/users/stof","avatar_url":"https://secure.gravatar.com/avatar/7894bbdf1c05b18a1444ad8c76c9d583?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"stof"},"body":"Currently, the library still uses the behavior coming from KnpMenuBundle:\r\n\r\n- an item can be set explicitly as being (or not being) current.\r\n- if the flag is not set, the uri is checked against the current uri set for the item (and if there is no current uri, it is not a current item)\r\n\r\nThere is some improvements needed here:\r\n- there can be multiple current items in a tree so the ``getCurrentItem`` method is lying by giving only the first found (should it be removed entirely ?)\r\n- this part of the library should be more flexible to support other behaviors (for instance matching several uris on the same item)","assignee":null,"id":1549572,"number":2,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[{"name":"Improvement","color":"02e10c","url":"https://api.github.com/repos/knplabs/KnpMenu/labels/Improvement"}],"title":"Improving the way the current item is determined","closed_at":null,"html_url":"https://github.com/knplabs/KnpMenu/issues/2","url":"https://api.github.com/repos/knplabs/KnpMenu/issues/2","milestone":null},"action":"created","comment":{"created_at":"2011-12-02T09:39:33Z","updated_at":"2011-12-02T09:39:33Z","user":{"gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","id":439401,"url":"https://api.github.com/users/stof","avatar_url":"https://secure.gravatar.com/avatar/7894bbdf1c05b18a1444ad8c76c9d583?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"stof"},"body":"yeah, for ESI request, you probably need to propagate the main attribute through a GET attribute and use it instead.","id":2988121,"url":"https://api.github.com/repos/knplabs/KnpMenu/issues/comments/2988121"}}