{"ref":"refs/heads/master","commits":[{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"2363748ba2c9e8769b03824dae578412a8a7c7f4","message":"merged branch canni/failed_login_event (PR #2678)\n\nCommits\n-------\n\n09562df Update CHANGELOG for 2.1, describe new auth events\ncf09c2d added authentication success/failure events\n\nDiscussion\n----------\n\n[Security] Implementation of a \"failed login\" event, replaces: PR #1307\n\nAs I have to use this feature I have completed its implementation.\n\nBugfix: no\nFeature addition: yes\nSymfopny2 tests pass: yes\nReplaces/closes PR: #1307\n\n---------------------------------------------------------------------------\n\nby schmittjoh at 2011/11/18 23:57:56 -0800\n\nUsually, this event is used for the wrong reasons (to customize what happens on authentication failure). Can you move your implementation to the AuthenticationProviderManager instead?\n\nsee https://github.com/schmittjoh/symfony/blob/master/src/Symfony/Component/Security/Core/Authentication/AuthenticationProviderManager.php#L103\n\n---------------------------------------------------------------------------\n\nby canni at 2011/11/19 06:00:36 -0800\n\nGood point :) I'll not rewrite yours work, I've cherry-picked yours commits. (BTW you added call to `setEventDispatcher` on `security.authentication.manager` to commit related to some different work ;)\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/11/22 00:12:19 -0800\n\nThe new files are missing the LICENSE header. As far as I can see, @schmittjoh fork has a different license from the Symfony one. This needs to be clarified before I can merge this PR.\n\n---------------------------------------------------------------------------\n\nby schmittjoh at 2011/11/22 01:53:09 -0800\n\nNo biggy, MIT is fine here.\n\n---------------------------------------------------------------------------\n\nby canni at 2011/11/22 01:57:51 -0800\n\n@fabpot done\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/11/22 02:22:47 -0800\n\n@canni: Can you update the CHANGELOG file (to reference the changes and the BC breaks -- like the move of KernelEvents for instance).\n\n---------------------------------------------------------------------------\n\nby canni at 2011/11/22 02:40:33 -0800\n\n@fabpot: no problem & done\n\nPS I haven't realized that namespace change of `SecurityEvents` is actually a BC Break, thx for pointing this.\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/11/22 03:06:17 -0800\n\n@canni: What about keeping a `SecurityEvents` class in the `Http` namespace that just extends the new one. That way, we don't break BC.\n\n---------------------------------------------------------------------------\n\nby canni at 2011/11/22 03:53:01 -0800\n\n@fabpot: that will force us to remove `final` keyword form one of classes.\n\nMaybe we can add new, not extending class e.g.: `GeneralSecurityEvents` or `AuthenticationEvents`, that way we dont break BC and dont introduce confusion in naming?\n\n---------------------------------------------------------------------------\n\nby canni at 2011/11/22 05:53:15 -0800\n\n@fabpot: I've removed the BC break, and squashed schmittjoh commits, to keep things nice and clear.","url":"https://api.github.com/repos/symfony/symfony/commits/2363748ba2c9e8769b03824dae578412a8a7c7f4"}],"head":"2363748ba2c9e8769b03824dae578412a8a7c7f4","size":1,"push_id":51258025}