{"issue":{"created_at":"2011-11-28T08:34:25Z","state":"open","updated_at":"2011-11-28T12:07:58Z","user":{"gravatar_id":"983326429ea11fc02e961bc088f66d36","id":16546,"url":"https://api.github.com/users/hellekin","avatar_url":"https://secure.gravatar.com/avatar/983326429ea11fc02e961bc088f66d36?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"hellekin"},"comments":3,"body":"Cheer up,\r\n\r\nI made a lot of cleanup.  There's a patch that I reverted, because it didn't help with Emacs and I suppose Debian is stable with where zsh lives now ;o)\r\n\r\nOtherwise, I went anal on the reporting system, code readability and the safety mechanisms for using shared memory and temporary files/dirs.  I think it will now break on purpose where it used to break because it lacked SHM support.\r\n\r\nNot much novelty there, but as the script becomes larger, I hope you appreciate the folding :)\r\n\r\nNow I can have a look at the actual issues :]\r\n\r\n@8087f172 doesn't actually check that tomb-open is there.  That code could be moved to the TOMBOPENEXEC definition, and a test -x replace it in the check_bin function.\r\n\r\n@e6aacc6d rewriting the reporting functions made obvious that some calls could exit instead of returning.  To be discussed and decided though.\r\n\r\n@abdf7622 here, IMO die should exit 1 by default, and pass 0 in the exceptions where exit without an error is required.  That would be the \"die peacefully\" situations.\r\n\r\n@dc8afe91 and @52b5570e could be merged into one patch. More zsh awesomeness.  Arrays for commands+args make me shiver a bit, and it's not the temperature.\r\n\r\nOops, I forgot to remove DEBUG.","assignee":null,"labels":[],"id":2365027,"pull_request":{"patch_url":"https://github.com/dyne/Tomb/pull/72.patch","html_url":"https://github.com/dyne/Tomb/pull/72","diff_url":"https://github.com/dyne/Tomb/pull/72.diff"},"number":72,"title":"ohlalalala","closed_at":null,"html_url":"https://github.com/dyne/Tomb/issues/72","url":"https://api.github.com/repos/dyne/Tomb/issues/72","milestone":null},"action":"created","comment":{"created_at":"2011-11-28T12:07:57Z","updated_at":"2011-11-28T12:07:57Z","user":{"gravatar_id":"bee0ea62822e83a23a1e5fd61af1f31f","id":148059,"url":"https://api.github.com/users/jaromil","avatar_url":"https://secure.gravatar.com/avatar/bee0ea62822e83a23a1e5fd61af1f31f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"jaromil"},"body":"Thanks Hellekin, I'm going to read through it today.\r\nIt looks immediately good that you broke all modifications in single commits.","id":2896043,"url":"https://api.github.com/repos/dyne/Tomb/issues/comments/2896043"}}