{"ref":"refs/heads/master","push_id":55219460,"commits":[{"sha":"bccba0afb8dc2e96160b75cc318ca5bf5a69d580","author":{"email":"54234b27fef504da340909df6dcfdd8e7524fa74@gnu.org","name":"Miles Bader"},"url":"https://api.github.com/repos/snogglethorpe/snogray/commits/bccba0afb8dc2e96160b75cc318ca5bf5a69d580","message":"Count translucent samples as \"specular\" in path integrator\n\nPreviously they were explicitly treated as non-specular (despite being\nflagged as specular), with the comment:\n\n   We \"don't count\" Bsdf::TRANSLUCENT for this purpose (even\n   though they're nominally \"specular\"), because they actually\n   _are_ accounted for in the direct-lighting term.\n\nHowever, this seems to be simply wrong.  When the path integrator\nsamples direct lighting, it excludes Bsdf::SPECULAR from the sampling\nflags (and the only place Bsdf::TRANSLUCENT is used is in the Stencil\nclass, and Stencil::sample only includes translucent samples if\nBsdf::SPECULAR is present).\n\nMaybe in a previous incarnation of the code, the above comment was\ncorrect, but it doesn't seem to be any longer."}],"head":"bccba0afb8dc2e96160b75cc318ca5bf5a69d580","size":1}