{"issue":{"state":"open","pull_request":{"diff_url":"https://github.com/eventmachine/eventmachine/pull/84.diff","html_url":"https://github.com/eventmachine/eventmachine/pull/84","patch_url":"https://github.com/eventmachine/eventmachine/pull/84.patch"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/000359d385267ab0be8978178e0f7972?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"000359d385267ab0be8978178e0f7972","url":"https://api.github.com/users/miketheiron","login":"miketheiron","id":288743},"milestone":null,"assignee":null,"updated_at":"2011-11-08T16:24:47Z","labels":[{"name":"1.0","color":"0088ff","url":"https://api.github.com/repos/eventmachine/eventmachine/labels/1.0"},{"name":"patch","color":"bcf0f7","url":"https://api.github.com/repos/eventmachine/eventmachine/labels/patch"},{"name":"ssl","color":"f0ba5d","url":"https://api.github.com/repos/eventmachine/eventmachine/labels/ssl"}],"comments":5,"closed_at":null,"url":"https://api.github.com/repos/eventmachine/eventmachine/issues/84","body":"As part of the project I'm working on, I added a couple of extra options to eventmachine evma_set_tls_parms  for dealing with SSL certificate verification, to more easily allow our thin server to act as a client to a remote server over SSL. \r\n\r\nI added an optional private key file password parameter that can be used to unlock a password protected private key file.\r\n\r\nI also added an optional ca certificate file parameter that can be used to register additional CAs with SSL_CTX_load_verify_locations. The remote server we connect to has a certificate issued by our company CA which is not in a standard trust hierarchy, and I thought with such relatively simply verification requirements it would be better to handle this internally within eventmachine, rather than pushing the logic up to ruby's verify_peer every time, just to do the same thing. Ruby's verify_peer method is still called in this case, but our server doesn't do any additional verification.\r\n\r\nIf the implementation of these changes is acceptable, I thought they might make a useful addition.\r\n\r\nThis is the first time I've played around with eventmachine so apologies if this isn't the right approach to solving this problem - any more elegent solutions would be welcome! but I suppose at the very least, this pull request is a good way to articulate what I'm trying to achieve, and find the right solution to it.\r\n\r\nAny feedback/suggestions are greatly appreciated,\r\n\r\nMike","html_url":"https://github.com/eventmachine/eventmachine/issues/84","title":"Additional options for SSL certificate verification","number":84,"id":307502,"created_at":"2010-09-08T11:49:55Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/0f1f17ba297242e9d3c86d4cc0a6ea85?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"0f1f17ba297242e9d3c86d4cc0a6ea85","url":"https://api.github.com/users/ibc","login":"ibc","id":16191},"updated_at":"2011-11-08T16:24:47Z","url":"https://api.github.com/repos/eventmachine/eventmachine/issues/comments/2669671","body":"I will try to update the patch.","id":2669671,"created_at":"2011-11-08T16:24:47Z"}}