{"comment":{"created_at":"2011-10-18T05:56:31Z","body":"Hi @Carreau,\n\nOn Mon, Oct 17, 2011 at 10:39 PM, Bussonnier Matthias\n<reply@reply.github.com>\nwrote:\n> I'ms sure I already add Ctrl+PageUp/Down\n\nYes, indeed the code you point out is already there.  But for some\nreason it doesn't work: hitting those keybindings with multiple tabs\nopen doesn't do anything...\n\n> Warning, everything using magic will throw exception when using --pure.\n> some of %hist handling is still in history_frontend_widget i guess\n\nNo worries, that makes sense as there's no ipython there and magics\nare inherently ipython-specific.\n\nCheers,\nf","updated_at":"2011-10-18T05:56:31Z","url":"https://api.github.com/repos/ipython/ipython/issues/comments/2438307","id":2438307,"user":{"gravatar_id":"95198572b00e5fbcd97fb5315215bf7a","avatar_url":"https://secure.gravatar.com/avatar/95198572b00e5fbcd97fb5315215bf7a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/fperez","id":57394,"login":"fperez"}},"action":"created","issue":{"number":887,"created_at":"2011-10-17T08:56:09Z","pull_request":{"diff_url":"https://github.com/ipython/ipython/pull/887.diff","patch_url":"https://github.com/ipython/ipython/pull/887.patch","html_url":"https://github.com/ipython/ipython/pull/887"},"body":"This PR is meant to continue the work started by @Carreau in #813, which was sadly interrupted by a robbery.  Since we don't know when @Carreau will be able to resume regular work, I've rebased his branch on top of master (at his last commit it had a small conflict), and I'm putting it up here on a common branch that several of us could in principle work on.\r\n\r\nUnfortunately, when this happened the branch was actually in a broken state, because the qtconsole doesn't start, failing with:\r\n\r\n<pre>\r\n/home/fperez/usr/lib/python2.7/site-packages/IPython/frontend/qt/console/qtconsoleapp.py in init_window_shortcut()\r\n   1134                 statusTip=\"Toggle menubar betwin visible and not\",\r\n   1135                 triggered=self.toggle_menu_bar)\r\n-> 1136             self.window_menu.addAction(self.toggle_menu_bar_act)\r\n   1137 \r\n   1138     def toggle_menu_bar(self):\r\nAttributeError: 'IPythonQtConsoleApp' object has no attribute 'window_menu'\r\n</pre>\r\n\r\nI'm not sure what happened, since a few days ago I'd played with the branch and it was broken.  I haven't had a chance to bisect it yet.\r\n\r\nBasically, the point of putting this PR here is to see whether we can find the resources to finish up @Carreau's work to include it in 0.12.  It's a large PR that had very nice functionality, and I would love to have his contribution in 0.12.  But it's a lot of complex code that we can't just dump in there unless we're reasonably confident it's in good shape.\r\n\r\n@epatters had given @Carreau already a ton of feedback, so you're the best positioned to gauge whether it's just missing  a tiny bit of (doable) work or major effort that is not realistic in a short timeframe.  I certainly won't take any action without your input.\r\n\r\nIn summary, before this can be merged, it needs:\r\n\r\n- fixing the current brokenness, since the qt console won't even start.\r\n- finishing up the remaining comments that were in-flight in the discussion for #813.\r\n- any other checks/fixes that @epatters might deem necessary.\r\n\r\nWe'll see if it can be done before 0.12 or not...","comments":9,"title":"Qtconsole menu","updated_at":"2011-10-18T05:56:31Z","url":"https://api.github.com/repos/ipython/ipython/issues/887","id":1926358,"assignee":null,"milestone":null,"closed_at":null,"user":{"gravatar_id":"95198572b00e5fbcd97fb5315215bf7a","avatar_url":"https://secure.gravatar.com/avatar/95198572b00e5fbcd97fb5315215bf7a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/fperez","id":57394,"login":"fperez"},"html_url":"https://github.com/ipython/ipython/issues/887","labels":[],"state":"open"},"legacy":{"issue_id":1926358,"comment_id":2438307}}