{"comment":{"created_at":"2011-10-14T22:53:02Z","body":"Looks much cleaner I reckon.  Your thoughts?\r\n\r\nOnly thing I don't like is the circular dependencies on creation.  It kinda goes from infomanager -> skin -> includes -> create new skin var -> register with infomanager.  All the way returning an integer value that is held by the infomanager.\r\n\r\nNo particular ideas as to how it could be done better though.","updated_at":"2011-10-14T22:53:02Z","url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/2412274","id":2412274,"user":{"avatar_url":"https://secure.gravatar.com/avatar/f2f465d1d46f3f4436a7658f9817fa95?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","id":406571,"login":"jmarshallnz"}},"action":"created","issue":{"number":481,"created_at":"2011-10-10T11:36:00Z","pull_request":{"diff_url":"https://github.com/xbmc/xbmc/pull/481.diff","patch_url":"https://github.com/xbmc/xbmc/pull/481.patch","html_url":"https://github.com/xbmc/xbmc/pull/481"},"body":"Currently skin variables are created without context info. This cause problems if boolean conditions need context info to return proper value (http://forum.xbmc.org/showpost.php?p=905703&postcount=70). This PR fix this issue by adding context information to skin variables.\r\n\r\nSimple logic:\r\n - create skin variable \"definitions\" when parsing includes.xml (no context info)\r\n - create proper skin variables with context info (copy of definition with context aware conditions) when parsing window .xml\r\n\r\nThis is bugfix so I think this (after review) should go in before release.","comments":2,"title":"Store context in skin variables","updated_at":"2011-10-14T22:53:02Z","url":"https://api.github.com/repos/xbmc/xbmc/issues/481","id":1863330,"assignee":null,"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/f3da60dded840e1e82616cd79613ba3d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"f3da60dded840e1e82616cd79613ba3d","url":"https://api.github.com/users/pieh","id":419821,"login":"pieh"},"html_url":"https://github.com/xbmc/xbmc/issues/481","labels":[],"state":"open"},"legacy":{"issue_id":1863330,"comment_id":2412274}}