{"ref":"refs/heads/master","commits":[{"author":{"name":"Gunnar Wrobel","email":"516b9783fca517eecbd1d064da2d165310b19759@rdus.de"},"sha":"4d88ec0f5d9dd342818d18a2f02fdd1fdcbf1051","message":"Add look behind assertion to avoid including question marks in the end-of-url match.\n\nComments concerning the fix:\n\nI admit I do not fully understand the reason why the regex does not\nmatch the long sequence of question marks. The matching works up to\nabout ten question marks and then magically fails. I assume there is\nsome kind of backtracking mechanism that fails once a certain count is\nhit. The middle part of the regex will certainly encompasses the\ncomplete test string at first. When the regex mechanism tries to match\nthe end-of-url part (see \"End with:\" in the regex) it will need to\nbacktrack and reduce the middle match. To me it looks as if this\nbacktracking has limits. Why the look behind assertion cures this is\nalso not 100% clear to me.\n\nSo this is just a suggestion that needs checking and I won't complain\nif it is reverted :)\n\n\nConcerning breaking the build:\n\nI don't see a reason why a test got added with the explicit intention\nof breaking the build. The tested problem does not seem to be any\ncritical issue that would require immediate fixing. Which is also\nsuggested by the amount of time it was left unfixed.\n\nI would suggest to add a test marked as incomplete in such cases. And\nat the same time a corresponding issue should be opened in our bug\ntracker and linked in a comment to the test method.","url":"https://api.github.com/repos/horde/horde/commits/4d88ec0f5d9dd342818d18a2f02fdd1fdcbf1051"}],"head":"4d88ec0f5d9dd342818d18a2f02fdd1fdcbf1051","size":1,"push_id":51795795}