{"issue":{"pull_request":{"diff_url":"https://github.com/sehmaschine/django-filebrowser/pull/46.diff","html_url":"https://github.com/sehmaschine/django-filebrowser/pull/46","patch_url":"https://github.com/sehmaschine/django-filebrowser/pull/46.patch"},"state":"open","user":{"avatar_url":"https://secure.gravatar.com/avatar/667bd007bac994a1441386ac4d2beb2b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"667bd007bac994a1441386ac4d2beb2b","url":"https://api.github.com/users/hcarvalhoalves","login":"hcarvalhoalves","id":161577},"milestone":null,"labels":[],"assignee":null,"updated_at":"2011-11-13T17:18:38Z","comments":10,"closed_at":null,"url":"https://api.github.com/repos/sehmaschine/django-filebrowser/issues/46","body":"* Using the default site from `filebrowser.versions.sites` is equivalent to using the old one\r\n* Using the default site from `filebrowser.sites` is a stripped down version without versions and admin thumbnails\r\n* Both admin interfaces seem fully functional\r\n* `filebrowser.tests` passing\r\n* `filebrowser.versions.tests.sites` are failing, tests URL resolver don't work after moving the site to a different module.\r\n* `FileBrowserField` is now a base class without previews, `VersionFileBrowserField` provided\r\n\r\nI couldn't figure out how the test suite in sites.py actually work. They stopped working after moving the site to a `versions` module, the tests apparently can't resolve the installed site and fail with a `KeyError` on `APP_NAME`. The admin is fully functional though.\r\n\r\nCan you help me making those tests pass? Also, tests for `FileBrowserField` are needed.\r\n\r\nTo install and test this branch:\r\n\r\n* Adding `filebrowser` to `INSTALLED_APPS` and using the old `filebrowser.sites.site` on `urls.py` will provide a stripped down version\r\n* Adding both `filebrowser` and `filebrowser.versions` to `INSTALLED_APPS` and using `filebrowser.versions.sites.site` will provide the equivalent of the current version\r\n* `VersionFileBrowserField` is provided, `FileBrowserField` is now a base class without previewing functionality","html_url":"https://github.com/sehmaschine/django-filebrowser/issues/46","title":"Refactored versions functionality to filebrowser.versions","number":46,"id":2219899,"created_at":"2011-11-13T02:35:03Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/667bd007bac994a1441386ac4d2beb2b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"667bd007bac994a1441386ac4d2beb2b","url":"https://api.github.com/users/hcarvalhoalves","login":"hcarvalhoalves","id":161577},"updated_at":"2011-11-13T17:18:38Z","url":"https://api.github.com/repos/sehmaschine/django-filebrowser/issues/comments/2723268","body":"@vam\r\n\r\nOk, since the tests pass for you but not for me, I think I'll include a test project on the source tree so we both can run the tests with the same settings.","id":2723268,"created_at":"2011-11-13T17:18:38Z"}}