{"shas":[["16aa62db0e315cb273652397c2835b9fdfc265df","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","merged branch lenar/non-blocking-process (PR #1403)\n\nCommits\n-------\n\nbda4129 Make run() fully non-blocking and fix potential other problems\n\nDiscussion\n----------\n\nMake run() fully non-blocking and fix potential other problems\n\nMultiple changes:\n\n1) make writing to process non-blocking too - otherwise there might be increased possibility for buffer deadlock\ngiven big enough input data. Also now it's guaranteed that all stdin data will be written.\n\n2) get rid of fgets() - fgets() isn't really good function to use in case of non-blocking sockets. Data loss possible.","Fabien Potencier"],["da04075c9d62e1d5e10a18b69ef938da0059087a","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","merged branch craue/patch-5 (PR #1384)\n\nCommits\n-------\n\nc17a836 typo\n\nDiscussion\n----------\n\ntypo","Fabien Potencier"],["2d29a82412702faf513710ce45f90346c4f08d27","ff43542b64f5819b84811760cd0ed3895428cddb@city.ee","New test for Process, testing stdout and stderr at different stream sizes","lenar"],["a4451b48cb2ce508b218e10642dc532d3d8e8e5a","6891d4ccc99d611c485bf26d3a4c9ebdbaab0cf6@gmail.com","[DomCrawler] Added tests for links starting with ?foo","Alexander"],["74d539db25ccf300a3372d8340938d91e41b46f6","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","merged branch vicb/form/php-theme (PR #1397)\n\nCommits\n-------\n\n5d46e63 [Form] Add the FormHelper configuration\na43fad4 [Form] Improve unit tests for rendering\n1cb2129 [FrameworkBundle][Form] Adding a cache to FormHelper::lookupTemplate()\nf39ce67 [Form][FrameworkBundle] PHP theming\n\nDiscussion\n----------\n\n[2.1] RFC [Form] Php theming\n\nThis PR implements theming support for the php engine.\n\nIt works similarly as the twig theming with themes being folders and blocks being individual files.\n\nThere are probably a few things to tune before this can get merged:\n\n### Theme naming\n\nThe current format is \"\\<Bundle\\>:\\<Controller\\>\" i.e. \"FrameworkBundle:Form\".\n\nIs this ok or could you imagine something better ?\n\n### Div and Table theme folders\n\nCurrently \"FrameworkBundle\\\\Resources\\\\views\\\\Form\" and \"FrameworkBundle\\\\Resources\\\\views\\\\FormTable\"\n\nIs this ok or anything better ?\n\n### Form helper configuration\n\nI am not sure if the configuration is at the best possible location:\n\n```\nframework:\n    templating:\n        form:\n            resources: [themeA, themeB]\n```\n\nAny better idea ?\n\nThere is a [thread on the ml](http://groups.google.com/group/symfony-devs/browse_thread/thread/9b3f131fe116b511)","Fabien Potencier"],["d49e306b9b4fe0f26db8775fd29da650b89e4f85","6891d4ccc99d611c485bf26d3a4c9ebdbaab0cf6@gmail.com","[DomCrawler] Fixed handling of relative query strings as links","Alexander"],["a39558260529b5361f1aa6e875282b9916850857","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","merged branch stloyd/choicetype (PR #1371)\n\nCommits\n-------\n\n7783a05 Removed unused code from DateType Additional tests for ChoiceType and DateType based code\ncdd39ac Added ability to set \"empty_value\" for `DateTimeType`, `DateType` and `TimeType` Additional tests covering added code\naf4a7d7 More tests and more compatible code, with some suggestions from @helmer\n527b738 Test covered version of fix for issue #1336\n\nDiscussion\n----------\n\n[Form] Added ability to set \"empty_value\" for choice list\n\nHey,\n\nThis PR is similar to #1336, but this one is fully test covered and have few change in behavior:\n\n- if choice field is not set as non-required, `empty_value` is not added automaticly,\n- also `empty_value` is not set if field have option `multiple` or `expanded`,\n- `empty_value` for `DateType` and `TimeType` can be set \"global\" or per field, i.e.:\n\n```\n$builder->add('date', 'choice', array('required' => false, 'empty_value' => array('day' => 'Choose day')));\n```\n\n- `DateType` and `TimeType` code was cleaned a bit,\n- added missing option to set up choice list as required when using PHP templates\n\n---------------------------------------------------------------------------\n\nby stloyd at 2011/06/20 04:55:45 -0700\n\n@fabpot I'm just not sure is that change with removing \"auto-adding\" of `empty_value` is good (probably BC)\n\n---------------------------------------------------------------------------\n\nby lenar at 2011/06/20 05:24:02 -0700\n\nNow this is a really nice way to hijack work done by others. Really encourages newcomers. Gratz!\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/06/20 05:57:40 -0700\n\n@lenar: if the code in this PR is yours (at least partly), I'm not going to merge it. @stloyd, can you clarify this issue with @lenar? Thanks.\n\n---------------------------------------------------------------------------\n\nby lenar at 2011/06/20 06:21:11 -0700\n\nIt's @helmer's mostly, not mine, but the issue stays.\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/06/20 06:26:15 -0700\n\nNo matter who the code belongs to, Git allows us to keep track of all contributors. So, we need to do our best to not loose any code ownership.\n\n---------------------------------------------------------------------------\n\nby helmer at 2011/06/20 06:58:03 -0700\n\nI do not care much for ownership, just that this kind of cooperation (or lack thereof) is kind of exhausting. Closed #1336.\n\n---------------------------------------------------------------------------\n\nby stloyd at 2011/06/20 07:47:53 -0700\n\n@fabpot, @lenar: This PR is inspired by #1336, made by @helmer, but after looking at his code and talking with him, we cant (IMO) get an consensus. So I wrote this PR as an another way to fix issue described in #1336.\n\n__Summary__: I don't think this one is better than fix at #1336, it's more like another approach to fix that issue.\n\n---------------------------------------------------------------------------\n\nby helmer at 2011/06/20 08:15:59 -0700\n\n@stloyd: I actually think your variant is better, so good job there, thanks.\n\nIt just ain't nice to:\n1) Comment on my changes being useless due to lack of tests\n2) Writing brand new testsuite from your perspective that \"proves\" my approach is \"wrong\" (while ignoring my answers, why I did something precisely like I did, which I did in sync with @fabpot comments on his first attempt to improve the issue)\n3) Saying my PR is broken because your new tests against it fail\n4) Changing functionality to \"fix\" something that was not really broken\n\nOther than that, I wanted to contribute a few lines to improve something relatively simple, and it ended up in a huge mess with more lost hours than I planned to spend on it.\n\nOn the bright side, we ended up with something good (:\n\n---------------------------------------------------------------------------\n\nby stloyd at 2011/06/20 08:32:30 -0700\n\n@helmer: 1) & 2) Sorry for that \"bad language\", but you get me wrong a bit. Tests was written for code in master (there was no problem to change them to work with your POV). 3) Same as before, you can adopt tests easily, but never mind. Maybe later we could cooperate better ;-)\nAbout 4) I mentioned it in description of this PR and that was point I was disagreeing with you (also about how \"default\" options are adopted in fields) :-)","Fabien Potencier"],["6de97c56e18f2c53b43b18a12006db7c72aa714c","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","[Form] made required part of the algorithm to determine if an empty value should be added to a choice","Fabien Potencier"],["88c8119152461bba9cf4fbd03bff61c7dbcd28ad","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","merged branch asm89/domcrawler_link (PR #1410)\n\nCommits\n-------\n\nd49e306 [DomCrawler] Fixed handling of relative query strings as links\na4451b4 [DomCrawler] Added tests for links starting with ?foo\n\nDiscussion\n----------\n\n[DomCrawler] Fixed handling of relative query strings as links\n\nThe link object concatenates links containing only a query string to the current URI. This shouldn't happen if the current URI already contains a query string.\n\nThis PR fixes the incorrect behavior (tests included).","Fabien Potencier"],["8ccebc463114a850e08d634098aeaf49ad5c3eee","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","[DomCrawler] fixed Link::getUri() method for anchors","Fabien Potencier"],["482492625dea0752fef82650138dffe237e90966","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","[Validator] restricted the True and False validator accepted values (the notion of True/False in PHP alone is too large)","Fabien Potencier"],["05c990628b4487114fee5f2955ae27193a29de97","0712a68aba493ca0413b8a0d0238658b52132f56@seld.be","[HttpKernel] Suppress response content for 304 responses out of the cache\n\nFixes #1413","Jordi Boggiano"],["0938f7ed54e37b5cce3cc51040683c818758a2f6","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","merged branch lenar/non-blocking-process (PR #1403)\n\nCommits\n-------\n\n2d29a82 New test for Process, testing stdout and stderr at different stream sizes\n\nDiscussion\n----------\n\nMake run() fully non-blocking and fix potential other problems\n\nMultiple changes:\n\n1) make writing to process non-blocking too - otherwise there might be increased possibility for buffer deadlock\ngiven big enough input data. Also now it's guaranteed that all stdin data will be written.\n\n2) get rid of fgets() - fgets() isn't really good function to use in case of non-blocking sockets. Data loss possible.\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/06/22 07:11:55 -0700\n\nDoes it make https://github.com/symfony/symfony/pull/1365 obsolete?\n\n---------------------------------------------------------------------------\n\nby lenar at 2011/06/22 14:08:14 -0700\n\n@fabpot: After reading, I really don't know. Let's hope. But ...\n\nI now improved Process tests a bit to test stdout, stderr with different stream sizes and different\nbehaviours of child processes. Added it to non-blocking-process branch, commit 2d29a82412702faf5137.\nIn my case, nothing fails, but maybe this helps other people. Or Windows people - I myself cannot test on Windows.\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/06/22 22:59:55 -0700\n\nThese tests pass on my Linux box but fail on my Mac.\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/06/22 23:05:14 -0700\n\nActually, on the Mac, the tests behave correctly but the exit code is `-1` instead of `0`.\n\n---------------------------------------------------------------------------\n\nby lenar at 2011/06/23 01:23:51 -0700\n\nCould you check if the $this->status['running'] (after call to proc_get_status()) is true in the case you get -1.\n\nOn my linux I got it -1 couple of times. 99% of time it doesn't happen. I theorized it's because sometimes the child\nprocess isn't finished enough and finally I got confirmation too that in case of -1 the process is still running (stats['running'] === true).\n\nBut it's really almost unreproducible on my Linux. So if you have this value every time it might be easier for you to find solution.\n\nWhat comes into my mind:\n\n1) maybe we should poll, let's say if process is still running we usleep(1000) and the try proc_get_status() again until not running. Maybe up to a 1 sec.\n\n2) maybe, if the process is still running we can trust the return value subsequently given by proc_close()?\n\nOr maybe there's some other problem on Mac.","Fabien Potencier"],["ad5d2c13e11abba361267ed78df7182e5597354a","fe14975b02825621d741133a720055170ebcf991@gmail.com","Added to `TimeType` extension possibility to render form as `single_text` (similar to DateType option) (issue #1205)\nAdjusted `DateTimeType` to allow usage of this new feature","stloyd"],["100a8dc105c89973ce7985881cfb17eb5e924c00","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","[Console] fixed Process exit code\n\nTo get the proper status for the Process, it needs to be terminated.\nSometimes, this is not the case when we call proc_get_status, so this\npatch waits up to 1 sec to get the right information.","Fabien Potencier"],["135064524ae1f4c202a3043cdb4a7ed668f086b7","0712a68aba493ca0413b8a0d0238658b52132f56@seld.be","[HttpKernel] Uppercased a few http methods","Jordi Boggiano"],["0891c578b213e4270ab5e3e87e12d181ebe63156","0712a68aba493ca0413b8a0d0238658b52132f56@seld.be","[HttpKernel] Added test","Jordi Boggiano"],["7db0b952b6a25df2315f61faed4e57870a01ecb6","0712a68aba493ca0413b8a0d0238658b52132f56@seld.be","[HttpKernel] Removed unnecessary strtoupper","Jordi Boggiano"],["f406e3d6a37ae8961cd5ab546f51ccdea800760d","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","merged branch Seldaek/http (PR #1414)\n\nCommits\n-------\n\n7db0b95 [HttpKernel] Removed unnecessary strtoupper\n0891c57 [HttpKernel] Added test\n1350645 [HttpKernel] Uppercased a few http methods\n05c9906 [HttpKernel] Suppress response content for 304 responses out of the cache\n\nDiscussion\n----------\n\nHttpCache changes for 304 responses\n\nFixes #1413","Fabien Potencier"],["f322a4a99d973a434dc79acc8446231f6c6b33d2","d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","fixed CS","Fabien Potencier"]],"ref":"refs/heads/master","size":617,"head":"baba3f387c55dbc93af8d11b8ccc902ff986c570","push_id":37894324}