{"action":"closed","pull_request":{"created_at":"2011-11-18T19:51:42Z","review_comments":0,"state":"closed","patch_url":"https://github.com/mongoid/mongoid/pull/1439.patch","changed_files":1,"updated_at":"2011-11-26T13:18:30Z","_links":{"review_comments":{"href":"https://api.github.com/repos/mongoid/mongoid/pulls/1439/comments"},"comments":{"href":"https://api.github.com/repos/mongoid/mongoid/issues/1439/comments"},"html":{"href":"https://github.com/mongoid/mongoid/pull/1439"},"self":{"href":"https://api.github.com/repos/mongoid/mongoid/pulls/1439"}},"comments":0,"user":{"gravatar_id":"232201372f022447559c323ec162d58f","id":69175,"url":"https://api.github.com/users/jdmorani","login":"jdmorani","avatar_url":"https://secure.gravatar.com/avatar/232201372f022447559c323ec162d58f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"issue_url":"https://github.com/mongoid/mongoid/issues/1439","body":"Even though my relation were set to :cyclic => true, the embedded? method was still returning false, until I figured cyclic was nil because it should have been metadata.cyclic.","deletions":1,"merged":false,"mergeable":true,"commits":1,"number":1439,"id":509739,"merged_by":null,"base":{"user":{"gravatar_id":"816cd66ab2b1552a1bc99ff774cecf27","id":262752,"url":"https://api.github.com/users/mongoid","login":"mongoid","avatar_url":"https://secure.gravatar.com/avatar/816cd66ab2b1552a1bc99ff774cecf27?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"repo":{"created_at":"2009-09-16T16:24:56Z","pushed_at":"2011-11-26T13:18:28Z","clone_url":"https://github.com/mongoid/mongoid.git","private":false,"updated_at":"2011-11-26T13:18:28Z","name":"mongoid","master_branch":null,"watchers":1834,"svn_url":"https://svn.github.com/mongoid/mongoid","forks":527,"language":"Ruby","owner":{"gravatar_id":"816cd66ab2b1552a1bc99ff774cecf27","id":262752,"url":"https://api.github.com/users/mongoid","login":"mongoid","avatar_url":"https://secure.gravatar.com/avatar/816cd66ab2b1552a1bc99ff774cecf27?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":309009,"homepage":"http://mongoid.org","description":"Ruby ODM framework for MongoDB","git_url":"git://github.com/mongoid/mongoid.git","html_url":"https://github.com/mongoid/mongoid","ssh_url":"git@github.com:mongoid/mongoid.git","size":2136,"fork":false,"url":"https://api.github.com/repos/mongoid/mongoid","open_issues":69},"sha":"cd8d350a52d7704218025e88cde8d2dedb37fee5","ref":"master","label":"mongoid:master"},"additions":1,"head":{"user":{"gravatar_id":"232201372f022447559c323ec162d58f","id":69175,"url":"https://api.github.com/users/jdmorani","login":"jdmorani","avatar_url":"https://secure.gravatar.com/avatar/232201372f022447559c323ec162d58f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"repo":{"created_at":"2011-11-18T19:44:15Z","pushed_at":"2011-11-18T19:48:33Z","clone_url":"https://github.com/jdmorani/mongoid.git","private":false,"updated_at":"2011-11-18T19:48:34Z","name":"mongoid","master_branch":null,"watchers":1,"svn_url":"https://svn.github.com/jdmorani/mongoid","forks":0,"language":"Ruby","owner":{"gravatar_id":"232201372f022447559c323ec162d58f","id":69175,"url":"https://api.github.com/users/jdmorani","login":"jdmorani","avatar_url":"https://secure.gravatar.com/avatar/232201372f022447559c323ec162d58f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"id":2805044,"homepage":"http://mongoid.org","description":"Ruby ODM framework for MongoDB","git_url":"git://github.com/jdmorani/mongoid.git","html_url":"https://github.com/jdmorani/mongoid","ssh_url":"git@github.com:jdmorani/mongoid.git","size":212,"fork":true,"url":"https://api.github.com/repos/jdmorani/mongoid","open_issues":0},"sha":"acde658c48ad67cf2d17151bc7d5091aaa9158da","ref":"master","label":"jdmorani:master"},"title":"the embedded? method does not seem to check properly if the relation is cyclic or not","closed_at":"2011-11-26T13:18:30Z","html_url":"https://github.com/mongoid/mongoid/pull/1439","diff_url":"https://github.com/mongoid/mongoid/pull/1439.diff","url":"https://api.github.com/repos/mongoid/mongoid/pulls/1439","merged_at":null},"number":1439}