{"pull_request":{"state":"closed","user":{"avatar_url":"https://secure.gravatar.com/avatar/49eeb455c3be9d8aa9c4959b9cf55636?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"49eeb455c3be9d8aa9c4959b9cf55636","url":"https://api.github.com/users/dhoerl","login":"dhoerl","id":812695},"deletions":3,"merged_by":{"avatar_url":"https://secure.gravatar.com/avatar/ac48abfd9468edd1d29f1c97c981e5f5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ac48abfd9468edd1d29f1c97c981e5f5","url":"https://api.github.com/users/Cocoanetics","login":"Cocoanetics","id":333270},"updated_at":"2011-10-28T11:26:36Z","commits":9,"comments":19,"diff_url":"https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML/pull/71.diff","base":{"ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/ac48abfd9468edd1d29f1c97c981e5f5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ac48abfd9468edd1d29f1c97c981e5f5","url":"https://api.github.com/users/Cocoanetics","login":"Cocoanetics","id":333270},"repo":{"name":"NSAttributedString-Additions-for-HTML","master_branch":null,"fork":false,"pushed_at":"2011-10-28T11:26:37Z","open_issues":6,"homepage":"","clone_url":"https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML.git","updated_at":"2011-10-28T11:26:37Z","language":"Objective-C","private":false,"forks":73,"svn_url":"https://svn.github.com/Cocoanetics/NSAttributedString-Additions-for-HTML","url":"https://api.github.com/repos/Cocoanetics/NSAttributedString-Additions-for-HTML","owner":{"avatar_url":"https://secure.gravatar.com/avatar/ac48abfd9468edd1d29f1c97c981e5f5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ac48abfd9468edd1d29f1c97c981e5f5","url":"https://api.github.com/users/Cocoanetics","login":"Cocoanetics","id":333270},"html_url":"https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML","description":"Methods to allow using HTML code with CoreText","size":464,"id":1238201,"watchers":697,"git_url":"git://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML.git","created_at":"2011-01-10T15:02:13Z","ssh_url":"git@github.com:Cocoanetics/NSAttributedString-Additions-for-HTML.git"},"label":"Cocoanetics:master","sha":"7f42dff24d308b6b33e1dd79fe943b9f0396f30c"},"closed_at":"2011-10-28T11:26:36Z","head":{"ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/49eeb455c3be9d8aa9c4959b9cf55636?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"49eeb455c3be9d8aa9c4959b9cf55636","url":"https://api.github.com/users/dhoerl","login":"dhoerl","id":812695},"repo":{"name":"NSAttributedString-Additions-for-HTML","master_branch":null,"fork":true,"pushed_at":"2011-09-27T14:18:26Z","open_issues":0,"homepage":"","clone_url":"https://github.com/dhoerl/NSAttributedString-Additions-for-HTML.git","updated_at":"2011-10-04T17:51:15Z","language":"Objective-C","private":false,"forks":0,"svn_url":"https://svn.github.com/dhoerl/NSAttributedString-Additions-for-HTML","url":"https://api.github.com/repos/dhoerl/NSAttributedString-Additions-for-HTML","owner":{"avatar_url":"https://secure.gravatar.com/avatar/49eeb455c3be9d8aa9c4959b9cf55636?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"49eeb455c3be9d8aa9c4959b9cf55636","url":"https://api.github.com/users/dhoerl","login":"dhoerl","id":812695},"html_url":"https://github.com/dhoerl/NSAttributedString-Additions-for-HTML","description":"Methods to allow using HTML code with CoreText","size":124,"id":2184955,"watchers":2,"git_url":"git://github.com/dhoerl/NSAttributedString-Additions-for-HTML.git","created_at":"2011-08-10T12:17:54Z","ssh_url":"git@github.com:dhoerl/NSAttributedString-Additions-for-HTML.git"},"label":"dhoerl:master","sha":"18796ed0c2b3967dbd0f42f5d4815d76afea3641"},"url":"https://api.github.com/repos/Cocoanetics/NSAttributedString-Additions-for-HTML/pulls/71","additions":15,"merged":true,"body":"1) a internal routine was commented out saying it didn't work right when version older than 4.2. So I added and ifdef test and enabled it for 4.2 and newer. Note that the routine used for older versions is worthless if you are trying to get the size of the text by directly calling the function (the newer one does work).\r\n\r\n2) the width on the newer routine was reduced by the inset, but the inset was already accounted for. I removed those reductions, and now it works properly with no inset and with insets.\r\n\r\nThe three commits are to the same file same method - was iterating to get it correct.","merged_at":"2011-10-28T11:26:36Z","issue_url":"https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML/issues/71","review_comments":0,"_links":{"comments":{"_href":"https://api.github.com/repos/Cocoanetics/NSAttributedString-Additions-for-HTML/issues/71/comments"},"html":{"_href":"https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML/pull/71"},"review_comments":{"_href":"https://api.github.com/repos/Cocoanetics/NSAttributedString-Additions-for-HTML/pulls/71/comments"},"self":{"_href":"https://api.github.com/repos/Cocoanetics/NSAttributedString-Additions-for-HTML/pulls/71"}},"html_url":"https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML/pull/71","number":71,"title":"-sizeThatFits had two problems now fixed","mergeable":null,"id":327270,"patch_url":"https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML/pull/71.patch","changed_files":2,"created_at":"2011-09-13T18:02:28Z"},"action":"closed","number":71}