{"comment":{"created_at":"2011-10-25T00:53:34Z","body":"OK, we talked about this one.  We want to do this, but it needs a couple of changes to make it work with migrated data.\r\n\r\nWe already have a new helper method, FabrikHelperHTML::image(), which takes an image filepath (which might be just the filename, or a filename with a relative path prepended), and attempts to find it in a variety of locations.\r\n\r\nWhat we need to do is extract the path testing from within the image() helper, and turn that into another getImagePath() method.\r\n\r\nThen, anywhere in the code where we need an actual full file path (rather than an img tag or src path), we can call the new getImagePath() method.  For instance, in the change you made to the googlemap.php ...\r\n\r\n        list($width, $height) = $this->markerSize(JPATH_SITE.DS.'images'.DS.'stories'.DS.$iconImg);\r\n\r\n... it would become ...\r\n\r\n        list($width, $height) = $this->markerSize(FabrikHelperHTML::getImagePath($iconImg));\r\n\r\nThen the getImagePath() can handle looking for it with ./images and ./images/stories as alternate root paths, making differences between f2 migrated data and new f3 data transparent.\r\n\r\nWe'd like to get this done ASAP, as it's something that does need fixing, and needs fixing before we release the first Beta.  Which we were kind of hoping to do early this week.\r\n\r\nSo ... I'll build the new method, then follow up here with some usage examples.  Then if you can go through the code again and fix everything up to either use the image() or getImagePath() methods, that'd be awesome.\r\n\r\nMeanwhile, I'll have to close this pull request, and you'll need to submit a new request with the updated code.\r\n\r\n   -- hugh\r\n","updated_at":"2011-10-25T00:53:34Z","url":"https://api.github.com/repos/Fabrik/fabrik/issues/comments/2511633","id":2511633,"user":{"avatar_url":"https://secure.gravatar.com/avatar/da3a2e95142e7a5534851b983197b6ec?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"da3a2e95142e7a5534851b983197b6ec","url":"https://api.github.com/users/cheesegrits","id":934456,"login":"cheesegrits"}},"action":"created","issue":{"number":59,"created_at":"2011-10-20T13:34:10Z","pull_request":{"diff_url":"https://github.com/Fabrik/fabrik/pull/59.diff","patch_url":"https://github.com/Fabrik/fabrik/pull/59.patch","html_url":"https://github.com/Fabrik/fabrik/pull/59"},"body":"Joomla 1.6 / 1.7 doesn't use /images/stories anymore so code and tooltip references carried over from Fab 2.x are no longer relevant.\r\n\r\nini files, code comments and actual code has been changed.\r\n\r\nIn all cases it has been changed like for like.  So /images/stories/  becomes /images/  and /images/stories becomes /images.\r\n\r\n","comments":4,"title":"Removed all references to /images/stories","updated_at":"2011-10-25T00:53:34Z","url":"https://api.github.com/repos/Fabrik/fabrik/issues/59","id":2004711,"assignee":null,"milestone":null,"closed_at":"2011-10-25T00:53:34Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/e2892a1dbe352fdbae9e1a80020eeac7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e2892a1dbe352fdbae9e1a80020eeac7","url":"https://api.github.com/users/felixkat","id":1116451,"login":"felixkat"},"html_url":"https://github.com/Fabrik/fabrik/issues/59","labels":[],"state":"closed"},"legacy":{"issue_id":2004711,"comment_id":2511633}}