{"issue":{"state":"closed","created_at":"2011-11-29T18:44:03Z","updated_at":"2011-11-29T18:44:07Z","user":{"gravatar_id":"256406243346b9253f8610fb1d1e05f6","id":1215373,"url":"https://api.github.com/users/importer","login":"importer","avatar_url":"https://secure.gravatar.com/avatar/256406243346b9253f8610fb1d1e05f6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":2,"body":"I noticed a bug with the SMHExtended module/implementation in core which might be related to a previously discovered safemodehack bug.\nSince the previous SMH bug I discovered (#1016) also looked like a wrong configuration/usage issue on first sight, this one is maybe also worth a second look :-)\n\nI added my initial problem description in #1235 as a comment, but I guess that nobody will read the comment if this already closed ticket.\nSince I am unable to reopen the ticket, I am adding my comment from ticket #1235 again in here:\n\nWe are currently working on the relaunch of the website of a institute at a german university.\nDue to the restrictions imposed by the university datacenter (no soap, allow_url_fopen = off and just S-FTP=ssh file transfer, not FTP-S=FTP-over-SSL) we are very interested in this hook and the SMHEXTENDED module (which should be included by default, once stable - SFTP gets more and more popular).\n\nOnce enabled the module works - kind of -. It's at least possible to modify the localconfig via the typolight admin interface, it's possible to create directories and upload files, but unfortunately typolight is obviously still unable to create the \"cachefiles\" in system/html/ and system/tmp/\nEventually you forgot to call the SMHExtended hook there?\n\nAlso we noticed, that SMHEXTENDED throws a ton of \"DEPRECATED\" errors, if \"Display Errors\" is enabled in typolight (log file is attached).\neven if these errors are suppressed, they are still displayed in the install tool, so probably either the SMHE hook or the \"display errors\" setting isn't respected there.\n\nSumming it up, I'd propose the following fixes/changes for the hook/the SMHExtended module:\n1) make sure that the hook is correctly called in all situations (/system/html, /system/tmp/, installtool, typolight log files)\n2) implement the SMHEXTENDED module in a more \"general\" way. maybe change the default SMH setting useFTP -> useSMH, with another setting smhPROTOCOL=ftp / sftp)\n3) check/fix the underlying phpseclib in order to fix the deprecation issues\n4) make sure that SMHEXTENDED works correctly without calling the Extension Manager (unfortunately we have no SOAP support on the server and probably due to the allow_url_fopen = off restrictions the nusoap/tensiderepository extension also don't works -> timeout), so if there is work to be done by the installer (beyond simply copying SMHEXTENDED to the server and setting it up manually in localconf, it wont work in situation where the extension manager is also not working because of soap/fopen restrictions\n\nThere might be a relation to the ticket #1016 - maybe the image handling functions don't correctly respect/use the SMHExtended hook\nAlso it would be great if the safe mode hack testing tool mentioned in ticket #1016 would also support the SMHExtended hook.\n\n[Download the attachments](http://www.contao.org/tl_files/tickets/1919.zip \"Download the attachments of this ticket\")\nRelated issues: #1016, #1235\n\n--- _Originally created by enemours on May 4th, 2010, at 12:08am (ID 1919)_","assignee":null,"id":2389928,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[{"name":"backend","color":"e6e6e6","url":"https://api.github.com/repos/contao/import/labels/backend"},{"name":"Defect","color":"bd2c00","url":"https://api.github.com/repos/contao/import/labels/Defect"},{"name":"Invalid","color":"ffdd00","url":"https://api.github.com/repos/contao/import/labels/Invalid"}],"number":1919,"title":"SMHExtended / SMH Bug","closed_at":"2011-11-29T18:44:07Z","html_url":"https://github.com/contao/import/issues/1919","url":"https://api.github.com/repos/contao/import/issues/1919","milestone":null},"action":"opened"}