{"number":164,"pull_request":{"number":164,"issue_url":"https://github.com/l3pp4rd/DoctrineExtensions/issues/164","head":{"repo":{"master_branch":"master","name":"DoctrineExtensions","created_at":"2011-07-07T10:40:21Z","size":156,"clone_url":"https://github.com/ulabox/DoctrineExtensions.git","private":false,"updated_at":"2011-10-07T08:44:14Z","watchers":1,"ssh_url":"git@github.com:ulabox/DoctrineExtensions.git","url":"https://api.github.com/repos/ulabox/DoctrineExtensions","git_url":"git://github.com/ulabox/DoctrineExtensions.git","language":"PHP","fork":true,"svn_url":"https://svn.github.com/ulabox/DoctrineExtensions","id":2011683,"pushed_at":"2011-10-07T08:44:14Z","open_issues":0,"homepage":"http://www.gediminasm.org","description":"Extensions and diferent behaviors for Doctrine 2, Translatable, Sluggable, Tree - NestedSet, Timestampable, Loggable","forks":0,"html_url":"https://github.com/ulabox/DoctrineExtensions","owner":{"avatar_url":"https://secure.gravatar.com/avatar/39da1cc8fb1e4e250dc54b68b9dc07a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/ulabox","id":694956,"login":"ulabox"}},"label":"ulabox:remove_default_locale","sha":"62b6940c8f6bd2159f362057a69bc313f56367f7","ref":"remove_default_locale","user":{"avatar_url":"https://secure.gravatar.com/avatar/39da1cc8fb1e4e250dc54b68b9dc07a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/ulabox","id":694956,"login":"ulabox"}},"merged_by":{"avatar_url":"https://secure.gravatar.com/avatar/213cb2e855af1cbbee74fdc7e9c6d92d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/l3pp4rd","id":132389,"login":"l3pp4rd"},"created_at":"2011-10-06T17:19:17Z","changed_files":23,"merged":true,"body":"Hi l3ppard, \r\n\r\nHere is the first preview of all the changes. Things now are like i told on issue #161 where the default translation is stored on the original record and all the other translations in the translations table. Hence, the default_locale is now a mandatory param set by default to 'en_us', same as the translation locale.\r\n\r\nI corrected the majority of the tests accordingly but there is one with the WITH statement in the Query Walker that still doesn't work (i see a TODO there) and a strange failure in the testSelectWithTranslationFallbackOnArrayHydration that states\r\n\r\n```\r\nExpectation failed for method name is equal to <string:getCustomHydrationMode> when invoked zero or more times.\r\nMocked method does not exist.\r\n```\r\n\r\nFeel free to comment!!!","comments":10,"title":"Improved the default locale management","additions":338,"diff_url":"https://github.com/l3pp4rd/DoctrineExtensions/pull/164.diff","updated_at":"2011-10-08T17:59:12Z","url":"https://api.github.com/repos/l3pp4rd/DoctrineExtensions/pulls/164","id":382884,"patch_url":"https://github.com/l3pp4rd/DoctrineExtensions/pull/164.patch","mergeable":null,"merged_at":"2011-10-08T17:59:12Z","commits":2,"closed_at":"2011-10-08T17:59:12Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/8f2089782f2711659072020ad7227aff?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/acasademont","id":825021,"login":"acasademont"},"deletions":374,"html_url":"https://github.com/l3pp4rd/DoctrineExtensions/pull/164","base":{"repo":{"master_branch":"master","name":"DoctrineExtensions","created_at":"2010-09-03T12:08:12Z","size":596,"clone_url":"https://github.com/l3pp4rd/DoctrineExtensions.git","private":false,"updated_at":"2011-10-08T17:59:11Z","watchers":284,"ssh_url":"git@github.com:l3pp4rd/DoctrineExtensions.git","url":"https://api.github.com/repos/l3pp4rd/DoctrineExtensions","git_url":"git://github.com/l3pp4rd/DoctrineExtensions.git","language":"PHP","fork":false,"svn_url":"https://svn.github.com/l3pp4rd/DoctrineExtensions","id":885517,"pushed_at":"2011-10-08T17:59:11Z","open_issues":15,"homepage":"http://www.gediminasm.org","description":"Extensions and diferent behaviors for Doctrine 2, Translatable, Sluggable, Tree - NestedSet, Timestampable, Loggable","forks":68,"html_url":"https://github.com/l3pp4rd/DoctrineExtensions","owner":{"avatar_url":"https://secure.gravatar.com/avatar/213cb2e855af1cbbee74fdc7e9c6d92d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/l3pp4rd","id":132389,"login":"l3pp4rd"}},"label":"l3pp4rd:master","sha":"a4e25dcf884b1e8a7d92d4e6bddfc8aadf362f7f","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/213cb2e855af1cbbee74fdc7e9c6d92d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/l3pp4rd","id":132389,"login":"l3pp4rd"}},"state":"closed"},"action":"closed"}