{"issue":{"created_at":"2011-11-23T17:35:01Z","state":"open","updated_at":"2011-11-24T09:51:05Z","user":{"gravatar_id":"cd7f456b9fb41dc2acc016675728c895","id":973909,"url":"https://api.github.com/users/barclayadam","login":"barclayadam","avatar_url":"https://secure.gravatar.com/avatar/cd7f456b9fb41dc2acc016675728c895?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":3,"body":"Andrew,\r\n\r\nAnother breaking change when upgrading to 0.9.2, this time regarding the PlaceholderReplacingResponseFilter.\r\n\r\nWe load templates via AJAX which do not contain the HTML tag (e.g. just a portion of the application). This causes the above mentioned filter to throw an exception at src/Cassette.Web/PlaceholderReplacingResponseFilter.cs (ln 82). \r\n\r\nNot sure exactly what the reasoning is but the problem is the check on line 66 (if (!html.Contains(\"</html>\")) return;) which then does not set the hasWrittenToOutputStream variable to true.\r\n\r\nThanks,\r\nAdam","assignee":null,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"id":2332377,"labels":[],"number":103,"title":"PlaceholderReplacingResponseFilter - Output is missing the \"</html>\" tag","closed_at":null,"html_url":"https://github.com/andrewdavey/cassette/issues/103","milestone":null,"url":"https://api.github.com/repos/andrewdavey/cassette/issues/103"},"action":"created","comment":{"created_at":"2011-11-24T09:51:05Z","updated_at":"2011-11-24T09:51:05Z","user":{"gravatar_id":"e774874a8acc65cc0f0bb1e77b4def5b","id":292014,"url":"https://api.github.com/users/andrewdavey","login":"andrewdavey","avatar_url":"https://secure.gravatar.com/avatar/e774874a8acc65cc0f0bb1e77b4def5b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"v0.9.3 is in nuget. It now outputs the buffered, rewritten HTML in the filter's Close method, instead of looking for `</html>`.\r\n\r\n@bloodsplatter I'm not sure why disabling rewriting is giving you an empty page! Please create another issue with the details.\r\n","id":2860725,"url":"https://api.github.com/repos/andrewdavey/cassette/issues/comments/2860725"}}