{"issue":{"state":"open","created_at":"2011-11-28T15:50:41Z","updated_at":"2011-11-29T20:08:32Z","user":{"gravatar_id":"ab3bd127ce5e35766919bbf19efb4d67","id":60786,"url":"https://api.github.com/users/neilmiddleton","avatar_url":"https://secure.gravatar.com/avatar/ab3bd127ce5e35766919bbf19efb4d67?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"neilmiddleton"},"comments":3,"body":"This commit, via the 'is_heroku' config flag allows a heroku pre-compile to fail quietly in pre-compilation.\r\n\r\nThis should only be used when you're manually running 'rake assets:precompile'","assignee":null,"number":29,"id":2368659,"labels":[],"pull_request":{"patch_url":"https://github.com/rumblelabs/asset_sync/pull/29.patch","html_url":"https://github.com/rumblelabs/asset_sync/pull/29","diff_url":"https://github.com/rumblelabs/asset_sync/pull/29.diff"},"title":"Allow precompile to fail quietly on heroku","closed_at":null,"html_url":"https://github.com/rumblelabs/asset_sync/issues/29","url":"https://api.github.com/repos/rumblelabs/asset_sync/issues/29","milestone":null},"action":"created","comment":{"created_at":"2011-11-29T20:08:32Z","updated_at":"2011-11-29T20:08:32Z","user":{"gravatar_id":"ab3bd127ce5e35766919bbf19efb4d67","id":60786,"url":"https://api.github.com/users/neilmiddleton","avatar_url":"https://secure.gravatar.com/avatar/ab3bd127ce5e35766919bbf19efb4d67?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"neilmiddleton"},"body":"I've been working with Heroku pretty closely myself (I work for a Heroku partner) about the deployment process. \r\n\r\nIt may be possible to detect if you're on Heroku when compiling the slug, but I doubt this could be done in a way that is not sensitive to whatever compilation mechanism Heroku has in place at that time.  I would not be happy with the gem having this sort of dependency on the Heroku stack.\r\n\r\nAs for `config.fail_silently` I agree, it's less Heroku focused.  As for what it does, that's different.\r\n\r\nIn the Heroku deploy process, it automatically tries to run assets:precompile.  If that fails, it then injects a plugin `rails31_enable_runtime_asset_compilation` that means your app will publish assets at runtime.  However, if you're using this gem then you don't want this.  You're clearly manually compiling and syncing.\r\n\r\nThus, the raise needs to be removed for Heroku.  This PR still outputs the error to stdout so the deployed should still be as aware as they are now (both just get output to stdout in a deploy), but won't fail the task, leaving your app setup as it should be.\r\n\r\nI'll tweak the `unless` to an `if`, change the name of the var, update the README and do a new pull request.","id":2945455,"url":"https://api.github.com/repos/rumblelabs/asset_sync/issues/comments/2945455"}}