{"number":18,"pull_request":{"number":18,"issue_url":"https://github.com/chriso/klein.php/issues/18","head":{"repo":{"master_branch":null,"name":"klein.php","created_at":"2011-10-11T12:28:30Z","size":116,"clone_url":"https://github.com/berklee/klein.php.git","private":false,"updated_at":"2011-10-11T12:30:58Z","watchers":1,"ssh_url":"git@github.com:berklee/klein.php.git","url":"https://api.github.com/repos/berklee/klein.php","git_url":"git://github.com/berklee/klein.php.git","language":"PHP","fork":true,"svn_url":"https://svn.github.com/berklee/klein.php","id":2555046,"pushed_at":"2011-10-11T12:30:58Z","open_issues":0,"homepage":"","description":"A lightning fast router for PHP","forks":0,"html_url":"https://github.com/berklee/klein.php","owner":{"avatar_url":"https://secure.gravatar.com/avatar/75b09e832adef1e518765148e3819613?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/berklee","id":123516,"login":"berklee"}},"label":"berklee:master","sha":"1b346e1bcf64cdb1f5f7956aaf8f7c5ad0c8b910","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/75b09e832adef1e518765148e3819613?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/berklee","id":123516,"login":"berklee"}},"merged_by":{"avatar_url":"https://secure.gravatar.com/avatar/a22a8707c85dff1f5499eaa4fc90c6a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/chriso","id":364903,"login":"chriso"},"created_at":"2011-10-11T12:36:18Z","changed_files":1,"merged":true,"body":"Changed fpassthru($path) to readfile($path) on line 412 in $response->file() because fpassthru() expects a file handle instead of a string. Readfile() handles a string correctly.\r\n\r\n===========\r\n\r\nHello Chris,\r\n\r\nI've been using klein.php for a day or two, and I wanted to use the file sending functionality. But I couldn't get it to work because fpassthru() expects a file handle instead of a string. So I changed it to use readfile() instead.\r\n\r\nIf you want, I can also add some code to override the MIME type, because that would be handy as well. Let me know if you'd appreciate that and I'll send you a new pull request with that functionality.\r\n\r\nAnyway, thanks for the great library!\r\n\r\nRegards,\r\nBerklee","comments":1,"title":"Changed fpassthru() to readfile() in $response->file() on line 412.","additions":1,"diff_url":"https://github.com/chriso/klein.php/pull/18.diff","updated_at":"2011-10-11T21:01:34Z","url":"https://api.github.com/repos/chriso/klein.php/pulls/18","id":393103,"patch_url":"https://github.com/chriso/klein.php/pull/18.patch","mergeable":null,"merged_at":"2011-10-11T21:01:34Z","commits":1,"closed_at":"2011-10-11T21:01:34Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/75b09e832adef1e518765148e3819613?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/berklee","id":123516,"login":"berklee"},"deletions":1,"html_url":"https://github.com/chriso/klein.php/pull/18","base":{"repo":{"master_branch":null,"name":"klein.php","created_at":"2011-04-04T10:47:14Z","size":188,"clone_url":"https://github.com/chriso/klein.php.git","private":false,"updated_at":"2011-10-11T21:01:35Z","watchers":260,"ssh_url":"git@github.com:chriso/klein.php.git","url":"https://api.github.com/repos/chriso/klein.php","git_url":"git://github.com/chriso/klein.php.git","language":"PHP","fork":false,"svn_url":"https://svn.github.com/chriso/klein.php","id":1566536,"pushed_at":"2011-10-11T21:01:35Z","open_issues":1,"homepage":"","description":"A lightning fast router for PHP","forks":15,"html_url":"https://github.com/chriso/klein.php","owner":{"avatar_url":"https://secure.gravatar.com/avatar/a22a8707c85dff1f5499eaa4fc90c6a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/chriso","id":364903,"login":"chriso"}},"label":"chriso:master","sha":"9c14c5a1a859dcd01f940909d4c401a951e11f59","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/a22a8707c85dff1f5499eaa4fc90c6a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/chriso","id":364903,"login":"chriso"}},"state":"closed"},"action":"closed"}