{"ref":"refs/heads/master","commits":[{"author":{"email":"c7f588235eb4d781000efad2e6ace6c60b7a63ef@beberlei.de","name":"Benjamin Eberlei"},"sha":"59397cf42b76fede63879fc39f5a045f0ffd25d1","message":"[DoctrineBridge] Generalize EntityValidator to work with any validation service and against any Common ClassMetadata provider","url":"https://api.github.com/repos/drak/symfony/commits/59397cf42b76fede63879fc39f5a045f0ffd25d1"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"7c1cbb9f374e597af6d990f94de5457e13eb942a","message":"[Config] Use LoaderResolverInterface for type-hinting","url":"https://api.github.com/repos/drak/symfony/commits/7c1cbb9f374e597af6d990f94de5457e13eb942a"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"ba8322e106bcf3b04f804a4d1b5113af6e1cb52c","message":"[DependencyInjection] Format base exception classes consistently","url":"https://api.github.com/repos/drak/symfony/commits/ba8322e106bcf3b04f804a4d1b5113af6e1cb52c"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"cf2ca9b1966cdbcef3e90f373e52d080c1523e22","message":"[DependencyInjection] Create additional SPL exceptions","url":"https://api.github.com/repos/drak/symfony/commits/cf2ca9b1966cdbcef3e90f373e52d080c1523e22"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"123f514e06e706683fdc2cafbf50d35d3251138c","message":"[DependencyInjection] Use component-specific SPL exceptions\n\nThis replaces existing use of core SPL exceptions with the equivalent classes defined within the component. Although method documentation has been changed, this change should be BC since the component-specific SPL exceptions extend their core counterpart.\n\nThis commit purposely omits any changes to the PhpDumper, which throws several core SPL exceptions.","url":"https://api.github.com/repos/drak/symfony/commits/123f514e06e706683fdc2cafbf50d35d3251138c"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"b7300d2e07f0bd7b7a710af107acd537b381ea47","message":"[DependencyInjection] Fix up @throws documentation","url":"https://api.github.com/repos/drak/symfony/commits/b7300d2e07f0bd7b7a710af107acd537b381ea47"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"47256ea76fcc20a1028c6c5ad5cf68e26ef7376f","message":"[DependencyInjection] Make exceptions consistent when ContainerBuilder is frozen\n\nSome methods previously threw LogicExceptions when the ContainerBuilder was frozen. Using BadMethodCallException (a descendant of LogicException) in all cases improves consistency and preserves BC.","url":"https://api.github.com/repos/drak/symfony/commits/47256ea76fcc20a1028c6c5ad5cf68e26ef7376f"},{"author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"sha":"30262878f00a8d434b255bfcedbee0ec23b7e97b","message":"merged branch jmikola/2.0-LoaderResolverInterface (PR #2785)\n\nCommits\n-------\n\n7c1cbb9 [Config] Use LoaderResolverInterface for type-hinting\n48b084e fixed typo\n8ad94fb merged branch hhamon/doctrine_bridge_cs (PR #2775)\n240796e [Bridge] [Doctrine] fixed coding conventions.\n7cfc392 check for session before trying to authentication details\n648fae7 merged branch proofek/domcrawlerform-radiodisabled (PR #2768)\n3976b7a [DoctrineBridge] fixed CS\n9a04783 merged branch beberlei/SecurityEntityRepositoryIdentifierFix (PR #2765)\n3c83b89 [DoctrineBridge] Catch user-error when the identifier is not serialized with the User entity.\n36c7d03 Fixed GH-2720 - Fix disabled atrribute handling for radio form elements\n\nDiscussion\n----------\n\n[Config] Use LoaderResolverInterface for type-hinting\n\n```\nBug fix: no\nFeature addition: no\nBackwards compatibility break: yes\nSymfony2 tests pass: yes\nFixes the following tickets: -\n```\n\nI've listed this as a BC break because we're changing the argument type-hint, but I think it's unlikely to affect anyone.","url":"https://api.github.com/repos/drak/symfony/commits/30262878f00a8d434b255bfcedbee0ec23b7e97b"},{"author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"sha":"839dd2aaa4b6209e3916935481c6df5c873bb3b6","message":"merged branch drak/patch-1 (PR #2784)\n\nCommits\n-------\n\n541888d [EventDispatcher] Added missing object destruction in test tearDown() and removed duplicated tests.\n\nDiscussion\n----------\n\n[EventDispatcher] Merge two test cases into one.\n\nBug fix: no\nFeature addition: no\nBackwards compatibility break: no\nSymfony2 tests pass: yes\nFixes the following tickets: -\nTodo: -\n\nRef https://github.com/symfony/symfony/commit/667c24d73da03b6076609c8d616e982ecf493cdd#commitcomment-766966\n\n---------------------------------------------------------------------------\n\nby stof at 2011/12/04 19:43:32 -0800\n\n``testGetName`` could also be removed as it is already tested by ``getSetName``, and same for the event dispatcher.\n\nBasically, you cannot test the setter without testing the associated getter so no need for 2 tests for them as it is forced to be duplicate for part of them (and no need to use so long names IMO)\n\n---------------------------------------------------------------------------\n\nby drak at 2011/12/05 00:49:22 -0800\n\nI've refactored the test to remove duplication, I pushed as a rebase so the new commit is 541888d referencing the same discussion.","url":"https://api.github.com/repos/drak/symfony/commits/839dd2aaa4b6209e3916935481c6df5c873bb3b6"},{"author":{"email":"12e9293ec6b30c7fa8a0926af42807e929c1684f@dubture.com","name":"Robert Gruendler"},"sha":"9fcea7fcfe7a32e1eca70950e3f8760610d01736","message":"[DoctrineBundle] added EntityManager to use statements in registry (IDE support)","url":"https://api.github.com/repos/drak/symfony/commits/9fcea7fcfe7a32e1eca70950e3f8760610d01736"},{"author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"sha":"e316a2f784d107d1b6f493feebad1bc5fa9b4e3a","message":"merged branch pulse00/master (PR #2787)\n\nCommits\n-------\n\n9fcea7f [DoctrineBundle] added EntityManager to use statements in registry (IDE support)\n\nDiscussion\n----------\n\n[DoctrineBundle] added Doctrine\\ORM\\EntityManager to use statements in Registry\n\nAdds type inference support for return types in IDEs.","url":"https://api.github.com/repos/drak/symfony/commits/e316a2f784d107d1b6f493feebad1bc5fa9b4e3a"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"3c02ea220c39f207bbe0ed237773cf40d4f2bdd6","message":"[DependencyInjection] Use exception class for API doc generation\n\nThe API doc generator needs a use statement to properly reference the component's own InvalidArgumentException class.","url":"https://api.github.com/repos/drak/symfony/commits/3c02ea220c39f207bbe0ed237773cf40d4f2bdd6"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"2334596d2bf745e1a5af69fcae4e03f6debddef8","message":"[DependencyInjection] Use component's SPL classes in dumped service container","url":"https://api.github.com/repos/drak/symfony/commits/2334596d2bf745e1a5af69fcae4e03f6debddef8"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"9a090bc37d0fd19aea15fb1dc4e24ffbc47f6eb8","message":"[DependencyInjection] Fix class check and failure message in PhpDumper test","url":"https://api.github.com/repos/drak/symfony/commits/9a090bc37d0fd19aea15fb1dc4e24ffbc47f6eb8"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"da0773ceb1f3601b3409b6ae6c32a38374631681","message":"Note DependencyInjection exception changes in the 2.1 changelog","url":"https://api.github.com/repos/drak/symfony/commits/da0773ceb1f3601b3409b6ae6c32a38374631681"},{"author":{"email":"474c6c8bb2713ab736e19baa8f3357c45a8f0a26@gmail.com","name":"Kris Wallsmith"},"sha":"70e93329bfc8837280b698720940d96382bb8ad5","message":"added check for invalid user providers","url":"https://api.github.com/repos/drak/symfony/commits/70e93329bfc8837280b698720940d96382bb8ad5"},{"author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"sha":"7e2ca4ad93b9a0608ab5ba1e0ae1c5ee88ba15ac","message":"merged branch jmikola/master-DependencyInjectionExceptions (PR #2786)\n\nCommits\n-------\n\nda0773c Note DependencyInjection exception changes in the 2.1 changelog\n9a090bc [DependencyInjection] Fix class check and failure message in PhpDumper test\n2334596 [DependencyInjection] Use component's SPL classes in dumped service container\n3c02ea2 [DependencyInjection] Use exception class for API doc generation\n47256ea [DependencyInjection] Make exceptions consistent when ContainerBuilder is frozen\nb7300d2 [DependencyInjection] Fix up @throws documentation\n123f514 [DependencyInjection] Use component-specific SPL exceptions\ncf2ca9b [DependencyInjection] Create additional SPL exceptions\nba8322e [DependencyInjection] Format base exception classes consistently\n\nDiscussion\n----------\n\n[DependencyInjection] Refactor usage of SPL exceptions\n\n```\nBug fix: no\nFeature addition: no\nBackwards compatibility break: yes\nSymfony2 tests pass: yes\nFixes the following tickets: -\n```\n\nThis was something discussed on the mailing list recently and a topic at the last IRC meeting. The DependencyInjection component was what I had in mind while discussing this with @lsmith a few weeks ago, as I found that it already had some local SPL exceptions, which weren't being used directly (only as base classes for the compiler exceptions). This PR replaces uses of core SPL exceptions with the component's equivalents. I've listed it as BC-breaking to be safe, but I don't think it should cause any trouble, since the new exceptions are sub-classes of those originally used.\n\nI purposely avoided changing the exceptions in the dumped PHP container. If we agree that's worth doing, it would be a trivial addition to the PR.\n\n---------------------------------------------------------------------------\n\nby jmikola at 2011/12/04 22:38:47 -0800\n\nOne question I came across while implementing this PR: the doc blocks in ContainerInterface reference InvalidArgumentException (actually the component's local SPL equivalent), but there is no practical need for that class to be used in the file. How will the API doc generator handle this? Do we need to change the doc block reference to the full class path?\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/12/05 01:20:31 -0800\n\nWhy have you not replaced the exception in the dumped container code? I don't see any drawback.\n\n---------------------------------------------------------------------------\n\nby stof at 2011/12/05 03:39:25 -0800\n\nit would even be better to be consistent in the generated code\n\n---------------------------------------------------------------------------\n\nby jmikola at 2011/12/05 09:48:05 -0800\n\nI'll update the exceptions in the dumped container code as well. Thanks for the feedback.\n\n---------------------------------------------------------------------------\n\nby jmikola at 2011/12/05 10:41:21 -0800\n\nOk, this should be ready to review and merge. Tests needed some updating, but they still pass.","url":"https://api.github.com/repos/drak/symfony/commits/7e2ca4ad93b9a0608ab5ba1e0ae1c5ee88ba15ac"},{"author":{"email":"0d4690f8004600a4fd3fcc816275bfa3cf59f7be@gmail.com","name":"Jeremy Mikola"},"sha":"ea2b0e5454055797ff881d5c88305a79087a04ac","message":"Note LoaderResolverInterface type hinting in the 2.1 changelog","url":"https://api.github.com/repos/drak/symfony/commits/ea2b0e5454055797ff881d5c88305a79087a04ac"},{"author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"sha":"faa7e53a8671b53d5e42303385ad55d711312d58","message":"merged branch jmikola/patch-1 (PR #2793)\n\nCommits\n-------\n\nea2b0e5 Note LoaderResolverInterface type hinting in the 2.1 changelog\n\nDiscussion\n----------\n\nNote LoaderResolverInterface type hinting in the 2.1 changelog\n\nAlthough #2785 was originally opened against 2.0, its merge to master seems to be intentional. This documents the BC break that some experienced (see: FriendsOfSymfony/FOSRestBundle#155).","url":"https://api.github.com/repos/drak/symfony/commits/faa7e53a8671b53d5e42303385ad55d711312d58"},{"author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"sha":"492812b2712ac768a612ac27a23e90ea3652617c","message":"merged branch kriswallsmith/security/invalid-user-provider (PR #2789)\n\nCommits\n-------\n\n70e9332 added check for invalid user providers\n\nDiscussion\n----------\n\n[security] added check for invalid user providers\n\nI've added an exception if an invalid user provider is passed into a context listener.\n\nThe FOSFacebookBundle configuration has been documented wrong for a long time. This exception prevent users from configuring the security layer incorrectly.\n\n```\nBug fix: no\nFeature addition: no\nBackwards compatibility break: yes\nSymfony2 tests pass: yes\nFixes the following tickets: ~\nTodo: ~\n```\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/12/06 00:40:08 -0800\n\nWhat about doing that in the 2.0 branch?\n\n---------------------------------------------------------------------------\n\nby kriswallsmith at 2011/12/06 03:23:59 -0800\n\nIt is possible it will break some applications -- a non-user provider that is not first in the array may never be called.","url":"https://api.github.com/repos/drak/symfony/commits/492812b2712ac768a612ac27a23e90ea3652617c"}],"head":"460b33cf7eaf9cd5e043578f2a681d5199feab93","push_id":53109014,"size":26}