{"comment":{"created_at":"2011-10-11T16:38:47Z","body":"[springmeyer] re-opening. after r3279, seeing linking problem in rundemo.cpp (I think a few more template functions need exposed in image_util.hpp:\r\n\r\n{{{\r\nUndefined symbols for architecture i386:\r\n  \"void mapnik::save_to_file<mapnik::image_32>(mapnik::image_32 const&, std::string const&, std::string const&)\", referenced from:\r\n      _main in rundemo.o\r\nld: symbol(s) not found for architecture i386\r\nclang: error: linker command failed with exit code 1 (use -v to see invocation)\r\nscons: *** [demo/c++/rundemo] Error 1\r\n}}\r\n\r\n\r\nAlso, seeing inf loop in palette::valid(): \r\n\r\n\r\n{{{Index: include/mapnik/image_util.hpp\r\n===================================================================\r\n--- include/mapnik/image_util.hpp\t(revision 3280)\r\n+++ include/mapnik/image_util.hpp\t(working copy)\r\n@@ -216,8 +216,16 @@\r\n template <typename Image>\r\n void scale_image_bilinear8 (Image& target,const Image& source, double x_off_f=0, double y_off_f=0);\r\n \r\n+\r\n inline MAPNIK_DECL void save_to_file (image_32 const& image,\r\n                                       std::string const& file,\r\n+                                      std::string const& type)\r\n+{\r\n+    save_to_file<image_data_32>(image.data(), file, type);\r\n+}\r\n+\r\n+inline MAPNIK_DECL void save_to_file (image_32 const& image,\r\n+                                      std::string const& file,\r\n                                       std::string const& type,\r\n                                       rgba_palette const& palette)\r\n {\r\n@@ -247,7 +255,10 @@\r\n #ifdef _MSC_VER\r\n template MAPNIK_DECL void save_to_file<image_data_32>(image_data_32 const&,\r\n                                                       std::string const&,\r\n+                                                      std::string const&);\r\n+template MAPNIK_DECL void save_to_file<image_data_32>(image_data_32 const&,\r\n                                                       std::string const&,\r\n+                                                      std::string const&,\r\n                                                       rgba_palette const&);\r\n template MAPNIK_DECL void save_to_file<image_data_32>(image_data_32 const&,\r\n                                                       std::string const&,\r\n}}}","updated_at":"2011-10-11T16:38:47Z","url":"https://api.github.com/repos/artemp/mapnik/issues/comments/2367843","id":2367843,"user":{"avatar_url":"https://secure.gravatar.com/avatar/941f68386168a8a6b60f2529a7830af7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/artemp","id":59056,"login":"artemp"}},"action":"created","issue":{"number":843,"created_at":"2011-10-11T16:38:43Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"The hextree/octree dynamic color reduction algorithms are quite fast and robust. But a possible optimization might be to pre-compute a fixed palette to reduce to.","comments":7,"title":"png8 based on fixed palette","updated_at":"2011-10-11T16:38:47Z","url":"https://api.github.com/repos/artemp/mapnik/issues/843","id":1878276,"assignee":null,"milestone":{"number":18,"created_at":"2011-10-11T15:50:51Z","due_on":"1970-01-01T09:21:56Z","title":"Performance Optimizations","creator":{"avatar_url":"https://secure.gravatar.com/avatar/941f68386168a8a6b60f2529a7830af7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/artemp","id":59056,"login":"artemp"},"url":"https://api.github.com/repos/artemp/mapnik/milestones/18","open_issues":5,"closed_issues":2,"description":"Various ideas for a faster mapnik.\r\n\r\nInspired by the FOSS4G 2011 benchmarking competition: http://wiki.osgeo.org/wiki/Benchmarking_2011","state":"open"},"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/941f68386168a8a6b60f2529a7830af7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/artemp","id":59056,"login":"artemp"},"html_url":"https://github.com/artemp/mapnik/issues/843","labels":[{"name":"Core_Library","url":"https://api.github.com/repos/artemp/mapnik/labels/Core_Library","color":"FFFFFF"}],"state":"open"},"legacy":{"issue_id":1878276,"comment_id":2367843}}