{"issue":{"user":{"id":80595,"login":"kbarber","url":"https://api.github.com/users/kbarber","gravatar_id":"9accebe46504a4777d7b3c9707549dc6","avatar_url":"https://secure.gravatar.com/avatar/9accebe46504a4777d7b3c9707549dc6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"milestone":null,"created_at":"2011-12-14T23:58:06Z","title":"Ticket/10309 spec fixtures","state":"open","updated_at":"2011-12-20T19:20:13Z","labels":[],"id":2561320,"html_url":"https://github.com/puppetlabs/facter/issues/117","closed_at":null,"pull_request":{"patch_url":"https://github.com/puppetlabs/facter/pull/117.patch","html_url":"https://github.com/puppetlabs/facter/pull/117","diff_url":"https://github.com/puppetlabs/facter/pull/117.diff"},"body":"","number":117,"url":"https://api.github.com/repos/puppetlabs/facter/issues/117","comments":9,"assignee":null},"comment":{"user":{"id":306753,"login":"daniel-pittman","url":"https://api.github.com/users/daniel-pittman","gravatar_id":"611a7f168a2de85fdbc1a2ab3aa502ba","avatar_url":"https://secure.gravatar.com/avatar/611a7f168a2de85fdbc1a2ab3aa502ba?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"created_at":"2011-12-20T19:20:13Z","updated_at":"2011-12-20T19:20:13Z","id":3223727,"body":">> So can you discuss this with Daniel Pittman? He had other opinions about a separate library which is why I went down this road. The idea is to make a subtree for maintenance. I'm okay with some other methodology - but I'm getting mixed messages and you guys should discuss.\r\n>\r\n> OK... @daniel-pittman what do you think? I'm taking the stance that this change set should only include changes applicable to Facter. Functionality for other code bases should be made to those code bases and functionality truly re-usable by Facter and other code bases should be in a library.\r\n\r\nWe already tried that; the `reductive-build` package turned out to be a big overhead for everyone to get working, when it ultimately supplied nothing but some common behaviour around supporting specs.\r\n\r\nInstead of trying that again, having the master copy of the spec support stuff in a separate repository, then adding it as a submodule (high overhead) or just by copying it into place in each repo that consumes it (aka the `git-subtree` model), seems like a good trade-off.\r\n","url":"https://api.github.com/repos/puppetlabs/facter/issues/comments/3223727"},"action":"created"}