{"action":"opened","number":137,"pull_request":{"review_comments":0,"created_at":"2011-12-08T20:51:29Z","state":"open","updated_at":"2011-12-08T20:51:29Z","changed_files":2,"_links":{"review_comments":{"href":"https://api.github.com/repos/sonatype/nexus/pulls/137/comments"},"comments":{"href":"https://api.github.com/repos/sonatype/nexus/issues/137/comments"},"html":{"href":"https://github.com/sonatype/nexus/pull/137"},"self":{"href":"https://api.github.com/repos/sonatype/nexus/pulls/137"}},"patch_url":"https://github.com/sonatype/nexus/pull/137.patch","issue_url":"https://github.com/sonatype/nexus/issues/137","comments":0,"user":{"gravatar_id":"ab61e2cd52a9c09a0bc778df8da477c6","id":136590,"url":"https://api.github.com/users/velo","avatar_url":"https://secure.gravatar.com/avatar/ab61e2cd52a9c09a0bc778df8da477c6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"velo"},"merged":false,"body":"I added some extra checks on ProgressListener and got more accurate logs\r\nhttps://builds.sonatype.org/view/nexus/job/nexus-oss-its-feature/jdk=java-6x,label=linux/107/consoleFull\r\n{code}\r\nCaused by: java.lang.NullPointerException\r\n\tat com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187)\r\n\tat org.sonatype.nexus.integrationtests.report.ProgressListener.showResult(ProgressListener.java:80)\r\n\tat org.sonatype.nexus.integrationtests.report.ProgressListener.onTestFailure(ProgressListener.java:57)\r\n\tat org.testng.internal.Invoker.runTestListeners(Invoker.java:1823)\r\n{code}\r\n\r\nProgressListener.java:80 : https://github.com/sonatype/nexus/commit/3036e7d47ecd67c27c396b0f106a23fe60b6eb2c#L0R80\r\nThat mean System.out == null\r\n\r\nI can change ProgressListener to ignore that, but why did it got null in the first place?\r\n\r\nTestNG nature will skip @Test if any exception happens on @Before* and that happen on NEXUS383.  Once that happen, testNG start skipping, but it doesn't skip Nexus4520PlexusPrefixedVariablesArePickedUpIT.restoreOut()\r\n\r\nI will change it to not set out if null, but this can happen again if any future test sets System.out to null.  At least now it is easier to track.","deletions":4,"commits":2,"mergeable":null,"id":574262,"number":137,"additions":14,"base":{"repo":{"created_at":"2011-04-14T15:03:51Z","pushed_at":"2011-12-08T20:49:44Z","updated_at":"2011-12-08T20:49:44Z","private":false,"clone_url":"https://github.com/sonatype/nexus.git","name":"nexus","watchers":27,"svn_url":"https://svn.github.com/sonatype/nexus","master_branch":null,"language":"Java","forks":15,"owner":{"gravatar_id":"cb46e422424d56564bbe32db56d00de6","id":44938,"url":"https://api.github.com/users/sonatype","avatar_url":"https://secure.gravatar.com/avatar/cb46e422424d56564bbe32db56d00de6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"sonatype"},"id":1614615,"homepage":"http://nexus.sonatype.org/","description":"Nexus OSS","git_url":"git://github.com/sonatype/nexus.git","html_url":"https://github.com/sonatype/nexus","size":2644,"url":"https://api.github.com/repos/sonatype/nexus","fork":false,"open_issues":5,"ssh_url":"git@github.com:sonatype/nexus.git"},"user":{"gravatar_id":"cb46e422424d56564bbe32db56d00de6","id":44938,"url":"https://api.github.com/users/sonatype","avatar_url":"https://secure.gravatar.com/avatar/cb46e422424d56564bbe32db56d00de6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"sonatype"},"sha":"1ebc8f6c54f2a6961f021fee448c674268f9f5d1","ref":"master","label":"sonatype:master"},"merged_by":null,"head":{"repo":{"created_at":"2011-04-14T15:03:51Z","pushed_at":"2011-12-08T20:49:44Z","updated_at":"2011-12-08T20:49:44Z","private":false,"clone_url":"https://github.com/sonatype/nexus.git","name":"nexus","watchers":27,"svn_url":"https://svn.github.com/sonatype/nexus","master_branch":null,"language":"Java","forks":15,"owner":{"gravatar_id":"cb46e422424d56564bbe32db56d00de6","id":44938,"url":"https://api.github.com/users/sonatype","avatar_url":"https://secure.gravatar.com/avatar/cb46e422424d56564bbe32db56d00de6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"sonatype"},"id":1614615,"homepage":"http://nexus.sonatype.org/","description":"Nexus OSS","git_url":"git://github.com/sonatype/nexus.git","html_url":"https://github.com/sonatype/nexus","size":2644,"url":"https://api.github.com/repos/sonatype/nexus","fork":false,"open_issues":5,"ssh_url":"git@github.com:sonatype/nexus.git"},"user":{"gravatar_id":"cb46e422424d56564bbe32db56d00de6","id":44938,"url":"https://api.github.com/users/sonatype","avatar_url":"https://secure.gravatar.com/avatar/cb46e422424d56564bbe32db56d00de6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"sonatype"},"sha":"c552d1e1d49f2c77be3920f4511363118252205a","ref":"NEXUS-4691-ProgressListener-NPE","label":"sonatype:NEXUS-4691-ProgressListener-NPE"},"title":"Nexus 4691 progress listener npe","closed_at":null,"html_url":"https://github.com/sonatype/nexus/pull/137","diff_url":"https://github.com/sonatype/nexus/pull/137.diff","url":"https://api.github.com/repos/sonatype/nexus/pulls/137","merged_at":null}}