{"shas":[["6660beef367a888ac633cc03d1d7157737e6b2cb","5c2dd944dde9e08881bef0894fe7b22a5c9c4b06@jonathanleighton.com","An attempt to make CollectionAssociation#merge_target_lists make more sense.","Jon Leighton"],["60b23ea1da1c119eaab6d07e5a03cf3b5d5577d4","5c2dd944dde9e08881bef0894fe7b22a5c9c4b06@jonathanleighton.com","CollectionAssociation#merge_target_lists should write to the underlying attributes when copying, rather than using the assignment method","Jon Leighton"],["7e6145b4a2108a4ad94af02c3070789c03ccbd00","5c2dd944dde9e08881bef0894fe7b22a5c9c4b06@jonathanleighton.com","These extra array operations appear to be unnecessary. Reasoning:\n\n * It is not necessary to subtract 'id' from the list of copied attributes because record and mem_record are equal, so therefore their id attributes are also equal (so there is no harm in copying it, and this reduces the complexity of the code)\n * It is not necessary to intersect the attribute names, since record and mem_record are equal, so they have the same id and class, so they have the same columns in the database. If record has non-column attributes then it seems reasonable to also copy them onto mem_record (though I am not sure what situation this would ever happen in)","Jon Leighton"],["6871cda693a9a3e5d26ab0884f19132064acbf0a","999e8c50cd8b45fcffd2276fb62f876489a73119@gmail.com","Cleanup instantiate builder method definition","Carlos Antonio da Silva"],["4b10585128fcaf3270ece6829c3511fbbba529ac","d0eeec95a7aec5655966ec2ebd2cba997d670861@gmail.com","Clean up redundant backslashes","Pirogov Evgenij"],["f0479cbbd52961c75906022003d4f03aa39556e0","999e8c50cd8b45fcffd2276fb62f876489a73119@gmail.com","Refactor fields_for to make the api more clear, and fix usage with non nested attributes and without object","Carlos Antonio da Silva"],["82f33dce9c6229bee35af35a9aa3bc9c144737f3","999e8c50cd8b45fcffd2276fb62f876489a73119@gmail.com","Use record_name to make fields for methods more consistent","Carlos Antonio da Silva"],["3bed43c6a539638d2d4b3bc3ee7ffe5cca41a320","a0f1490a20d0211c997b44bc357e1972deab8ae3@sikachu.com","Do not try to call `column_names` on the abstract class.\n\nNormally the table for abstract class won't be existed, so we should not trying to call `#column_names` on it.","Prem Sichanugrist"],["5d24c3c8c58ffa3c617972b17fdfca53ee34e44d","7bbcc45b0f8f88a262415b9271579a59b891be2e@gmail.com","Merge pull request #564 from sikachu/fix_wrapper\n\nDo not try to call `column_names` on the abstract class.","Aaron Patterson"],["6a408f3e90a3c6b07072fd6f83f8ccb1c4896fcd","5282eb8a112e0c62fe591e7e5c0a8d029936dc09@gmail.com","Fixing Changelog link","Guillermo Iguaran"],["6bd99ecb629807fe940e9f8a2e67d1fb51c800ea","d0eeec95a7aec5655966ec2ebd2cba997d670861@gmail.com","Use more English language","Pirogov Evgenij"],["34482882285070391bca6083279702280572ee44","be11b38ca2a8492ea688531e4730d7fc0f6b7beb@hashref.com","reviewed the first ~70 lines of the configuration guide","Xavier Noria"],["dde82a44d702f8416905476bbea5842157d6a508","be11b38ca2a8492ea688531e4730d7fc0f6b7beb@hashref.com","Merge branch 'master' of git://github.com/lifo/docrails","Xavier Noria"],["6e581cce1c1116d71484a5a4a5f92f0ea6fd29e4","0c2436ea76ed86e37cc05f66dea18d48ef390882@gmail.com","Merge pull request #568 from carlosantoniodasilva/fields_for_fixes\n\nFields for fixes for non nested attributes and without object","José Valim"],["5ca67eca21d2adfb418f96b63e7d3de237737a1e","a0f1490a20d0211c997b44bc357e1972deab8ae3@sikachu.com","Add ActiveRecord::attribute_names to retrieve a list of attribute names. This method will also return an empty array on an abstract class or a model that the table doesn't exists.","Prem Sichanugrist"],["d77b306b63e20aabec5daf7159d31c8ee31492c9","a0f1490a20d0211c997b44bc357e1972deab8ae3@sikachu.com","Make ParamsWrapper calling newly introduced `Model.attribute_names` instead of `.column_names`","Prem Sichanugrist"],["d043d6539682f804a696d301b580accfc68f6cce","0c2436ea76ed86e37cc05f66dea18d48ef390882@gmail.com","Merge pull request #570 from sikachu/decouple_actionpack\n\nMake ParamsWrapper use a well-defined API and not rely on AR methods","José Valim"]],"repo":"castlerock/rails","actor":"arunagw","ref":"refs/heads/master","size":17,"head":"d043d6539682f804a696d301b580accfc68f6cce","actor_gravatar":"ce65c96086ebf17e2b1b363e553a8c79","push_id":31421584}