{"issue":{"state":"open","created_at":"2011-12-09T00:25:17Z","updated_at":"2011-12-09T00:55:43Z","comments":3,"user":{"gravatar_id":"429517c0e93a51d739cc17f2371a3d71","id":139824,"url":"https://api.github.com/users/glarizza","avatar_url":"https://secure.gravatar.com/avatar/429517c0e93a51d739cc17f2371a3d71?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"glarizza"},"body":"Previously, `git describe` was being used to get the puppet version,\r\nhowever this breaks the Jenkins builds. Puppet::PUPPETVERSION is\r\nthe better choice here (though we lose the 'rc' tags at the end).","assignee":null,"id":2496819,"number":263,"pull_request":{"patch_url":"https://github.com/puppetlabs/puppet/pull/263.patch","html_url":"https://github.com/puppetlabs/puppet/pull/263","diff_url":"https://github.com/puppetlabs/puppet/pull/263.diff"},"labels":[],"title":"Use Puppet::PUPPETVERSION to get version string","closed_at":null,"html_url":"https://github.com/puppetlabs/puppet/issues/263","url":"https://api.github.com/repos/puppetlabs/puppet/issues/263","milestone":null},"action":"created","comment":{"created_at":"2011-12-09T00:55:42Z","updated_at":"2011-12-09T00:55:42Z","user":{"gravatar_id":"fa147ffde386565a674bc13453dc6f8d","id":6961,"url":"https://api.github.com/users/stahnma","avatar_url":"https://secure.gravatar.com/avatar/fa147ffde386565a674bc13453dc6f8d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"stahnma"},"body":"Please don't merge this until I can review\r\n\r\nOn Dec 8, 2011, at 19:25, Gary Larizza<reply@reply.github.com> wrote:\r\n\r\n> Previously, `git describe` was being used to get the puppet version,\r\n> however this breaks the Jenkins builds. Puppet::PUPPETVERSION is\r\n> the better choice here (though we lose the 'rc' tags at the end).\r\n> \r\n> You can merge this Pull Request by running:\r\n> \r\n>  git pull https://github.com/glarizza/puppet-1 feature/2.7.x/Rakefile_DMG\r\n> \r\n> Or you can view, comment on it, or merge it online at:\r\n> \r\n>  https://github.com/puppetlabs/puppet/pull/263\r\n> \r\n> -- Commit Summary --\r\n> \r\n> * Build a Rake task for building Apple Packages\r\n> \r\n> -- File Changes --\r\n> \r\n> M tasks/rake/apple.rake (4)\r\n> \r\n> -- Patch Links --\r\n> \r\n>  https://github.com/puppetlabs/puppet/pull/263.patch\r\n>  https://github.com/puppetlabs/puppet/pull/263.diff\r\n> \r\n> --- \r\n> Reply to this email directly or view it on GitHub:\r\n> https://github.com/puppetlabs/puppet/pull/263","id":3073715,"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/3073715"}}