{"issue":{"created_at":"2011-11-29T16:58:59Z","state":"open","updated_at":"2011-11-29T17:45:53Z","comments":5,"user":{"gravatar_id":"9730e28f36f98687f5b3c727f29af8d5","id":87115,"url":"https://api.github.com/users/eMxyzptlk","avatar_url":"https://secure.gravatar.com/avatar/9730e28f36f98687f5b3c727f29af8d5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"eMxyzptlk"},"body":"Hey guys,\r\n\r\nGreat work on the proxy, really useful, but I noticed the code is untested, is anyone currently working on tests? I was thinking of writing specs but I do not want to re-invent the wheel if someone is already working on that\r\n\r\nWael","assignee":null,"id":2387651,"number":85,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[],"title":"Is someone working on tests?","closed_at":null,"html_url":"https://github.com/plamoni/SiriProxy/issues/85","url":"https://api.github.com/repos/plamoni/SiriProxy/issues/85","milestone":null},"action":"created","comment":{"created_at":"2011-11-29T17:45:53Z","updated_at":"2011-11-29T17:45:53Z","user":{"gravatar_id":"19cfa7175a8db4cf43790731882fdda2","id":130735,"url":"https://api.github.com/users/netpro2k","avatar_url":"https://secure.gravatar.com/avatar/19cfa7175a8db4cf43790731882fdda2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"netpro2k"},"body":"Great. If you have time please drop by irc channel (#siriproxy on freenode)  later and we can discuss further. \n\n\nOn Tuesday, November 29, 2011 at 12:38 PM, Wael M. Nasreddine wrote:\n\n> Yes that will do fine\n> \n> -- \n> Wael Nasreddine\n> Sent from my iPhone\n> \n> On Nov 29, 2011, at 18:34, Dominick D'Aniello\n> <reply@reply.github.com (mailto:reply@reply.github.com)>\n> wrote:\n> \n> > Unfortunately part of the binary data includes the unique identifier for the phone in question, so it is to sensitive to share/store in repo. I think best would be to have fixtures at the decoded object level (or perhaps the gziped decoded object level) as this would avoid the sensitive information, ssl handshake, etc. Its not quite a full integration test, but covers the main aspects of the code that will actually be frequently modified.\n> > \n> > ---\n> > Reply to this email directly or view it on GitHub:\n> > https://github.com/plamoni/SiriProxy/issues/85#issuecomment-2937437\n> > \n> \n> \n> --- \n> Reply to this email directly or view it on GitHub:\n> https://github.com/plamoni/SiriProxy/issues/85#issuecomment-2937688\n> \n>","id":2938020,"url":"https://api.github.com/repos/plamoni/SiriProxy/issues/comments/2938020"}}