{"issue":{"state":"open","pull_request":{"diff_url":null,"html_url":null,"patch_url":null},"milestone":{"state":"open","open_issues":9,"url":"https://api.github.com/repos/shakty/Patterns/milestones/1","due_on":"2011-10-03T07:00:00Z","title":"All patterns + simple test done","description":"Everybody has to implement all the simple tests marked in the issues","creator":{"avatar_url":"https://secure.gravatar.com/avatar/e1034afdc997133cdc5a7cac7a7caba7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e1034afdc997133cdc5a7cac7a7caba7","url":"https://api.github.com/users/shakty","login":"shakty","id":956020},"number":1,"closed_issues":1,"created_at":"2011-09-22T13:18:35Z"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/e1034afdc997133cdc5a7cac7a7caba7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e1034afdc997133cdc5a7cac7a7caba7","url":"https://api.github.com/users/shakty","login":"shakty","id":956020},"labels":[],"assignee":{"avatar_url":"https://secure.gravatar.com/avatar/c273e7c0a671536c4d122bc39d67c3d2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"c273e7c0a671536c4d122bc39d67c3d2","url":"https://api.github.com/users/xrfind","login":"xrfind","id":683144},"updated_at":"2011-11-16T15:07:12Z","comments":9,"closed_at":null,"url":"https://api.github.com/repos/shakty/Patterns/issues/19","body":"","html_url":"https://github.com/shakty/Patterns/issues/19","title":"Toolbar Pattern + Test","number":19,"id":1713883,"created_at":"2011-09-22T13:23:27Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/e1034afdc997133cdc5a7cac7a7caba7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e1034afdc997133cdc5a7cac7a7caba7","url":"https://api.github.com/users/shakty","login":"shakty","id":956020},"updated_at":"2011-11-16T15:07:12Z","url":"https://api.github.com/repos/shakty/Patterns/issues/comments/2760603","body":"thanks for the job! Some remarks: \r\n\r\n1- I don't find the test. That should be under the patterns/tests/ directory.\r\n2- Please adjust the names you use on the yaml to something shorter, and easier to understand (for western people :))\r\n2.b - Please make them consistent: e.g. the same shorcut_set_name should be used across different patterns (so that I don't have to change it manually to run the pattern)\r\n3- I seems not to be running correctly. If run add new shortcut set (create) and then add a link to a shortcut set (create), it says that the pattern run correctly, but in fact nothing happens. \r\n4- You are still using custom functions to set the roles which can see the toolbar. I don't know if can do this through a form, that would be better, but maybe the pattern component for that is not ready (@csko should say something).\r\n\r\nThanks a lot, I see you did a lot of work!","id":2760603,"created_at":"2011-11-16T15:07:12Z"}}