{"issue":{"state":"closed","pull_request":{"diff_url":"https://github.com/mrdoob/three.js/pull/707.diff","html_url":"https://github.com/mrdoob/three.js/pull/707","patch_url":"https://github.com/mrdoob/three.js/pull/707.patch"},"milestone":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/ced7f76fd1b5573ce3bdce2f3392df04?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ced7f76fd1b5573ce3bdce2f3392df04","url":"https://api.github.com/users/huttarl","login":"huttarl","id":651356},"assignee":null,"updated_at":"2011-10-31T20:01:59Z","labels":[],"closed_at":"2011-10-31T15:02:15Z","comments":3,"url":"https://api.github.com/repos/mrdoob/three.js/issues/707","body":"OK, I think I got the git workflow working! mostly.\r\n\r\nI don't know why it's putting 4 commits into this pull request... only the last one matters (https://github.com/huttarl/three.js/commit/8f3f5bbe1f114c7d717a1decc31d420afa0d7c78)\r\n\r\nHere's the blurb from my patch submittal:\r\n\r\nTrackballCamera has a noZoom param/property, and also noPan. It would be useful to have a corresponding noRotate property, so that we could temporarily disable the rotation of the trackball. (In my case, I need to do this when the user is clicking the mouse for some other purpose, e.g. to select an object.) So I've implemented it, and tested it. When the user doesn't access the noRotate property (existing code), behavior is unaffected.\r\n","html_url":"https://github.com/mrdoob/three.js/issues/707","title":"added noRotate parameter to TrackballCamera","number":707,"id":2091080,"created_at":"2011-10-30T16:11:16Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/a00211a1e1aa4fe920302e7b76da0d91?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"a00211a1e1aa4fe920302e7b76da0d91","url":"https://api.github.com/users/mrdoob","login":"mrdoob","id":97088},"updated_at":"2011-10-31T20:01:59Z","url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/2582403","body":"So on your git client you should be able to see 2 branches, `master` and `dev`. Instead of branching `master` you should branch `dev` and apply your fixes there and commit. Then on github you have the \"pull request\" button on the top right. Once there you should change the \"master\" to \"dev\" on the target field.","id":2582403,"created_at":"2011-10-31T20:01:59Z"}}