{"issue":{"title":"new persistent collection class for reference many properties","user":{"login":"starkj","id":655445,"url":"https://api.github.com/users/starkj","avatar_url":"https://secure.gravatar.com/avatar/2b6c08d6ffdba1f0e9c796808907ba4e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"2b6c08d6ffdba1f0e9c796808907ba4e"},"created_at":"2011-12-29T13:20:49Z","milestone":null,"labels":[],"state":"open","updated_at":"2011-12-29T17:09:57Z","id":2679359,"pull_request":{"patch_url":"https://github.com/doctrine/phpcr-odm/pull/87.patch","html_url":"https://github.com/doctrine/phpcr-odm/pull/87","diff_url":"https://github.com/doctrine/phpcr-odm/pull/87.diff"},"closed_at":null,"html_url":"https://github.com/doctrine/phpcr-odm/issues/87","body":"this brings a new persistent collection to store all documents or their proxies referenced by a reference-many-property\r\n\r\nwhile doing this the following came up to my mind:\r\nwouldn't it be better to handle reference-many-properties like other multivalued properties and make use of the MultivaluePropertyCollection, too?\r\n\r\nOr are references “special enough” to get a separate treatment?","number":87,"url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/87","comments":1,"assignee":null},"comment":{"user":{"login":"lsmith77","id":300279,"url":"https://api.github.com/users/lsmith77","avatar_url":"https://secure.gravatar.com/avatar/54787afbd0e7c30936101c2fa84bd89b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"54787afbd0e7c30936101c2fa84bd89b"},"created_at":"2011-12-29T17:09:57Z","updated_at":"2011-12-29T17:09:57Z","id":3302653,"body":"uhm so you dont see benefit in the special treatment? in that case i guess it can/should be removed to consolidate the code. \r\n\r\nLukas\r\n\r\nOn 29.12.2011, at 14:20, Johannes Stark <reply@reply.github.com> wrote:\r\n\r\n> this brings a new persistent collection to store all documents or their proxies referenced by a reference-many-property\r\n> \r\n> while doing this the following came up to my mind:\r\n> wouldn't it be better to handle reference-many-properties like other multivalued properties and make use of the MultivaluePropertyCollection, too?\r\n> \r\n> Or are references “special enough” to get a separate treatment?\r\n> \r\n> You can merge this Pull Request by running:\r\n> \r\n>  git pull https://github.com/starkj/phpcr-odm reference_many_collection\r\n> \r\n> Or you can view, comment on it, or merge it online at:\r\n> \r\n>  https://github.com/doctrine/phpcr-odm/pull/87\r\n> \r\n> -- Commit Summary --\r\n> \r\n> * new persistent collection class for reference many properties\r\n> \r\n> -- File Changes --\r\n> \r\n> A lib/Doctrine/ODM/PHPCR/ReferenceManyCollection.php (29)\r\n> M lib/Doctrine/ODM/PHPCR/UnitOfWork.php (23)\r\n> M tests/Doctrine/Tests/ODM/PHPCR/Functional/ReferenceTest.php (4)\r\n> \r\n> -- Patch Links --\r\n> \r\n>  https://github.com/doctrine/phpcr-odm/pull/87.patch\r\n>  https://github.com/doctrine/phpcr-odm/pull/87.diff\r\n> \r\n> --- \r\n> Reply to this email directly or view it on GitHub:\r\n> https://github.com/doctrine/phpcr-odm/pull/87","url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/comments/3302653"},"action":"created"}