{"comment":{"created_at":"2011-10-09T04:01:12Z","body":"Ok, so I actually stopped being lazy and looked up what emit does, and how it's used in QSanguosha. I tried adding a bool argument (in addition to the general_str one being emitted), but this turned out really messy; I had to declare new callback types for instance. This is even messier, and looking at how the invokes are being used elsewhere, I think the best approach would be to just keep using the same general_str, but instead of having a \"noRole\" \"general\", it could be its own token.\r\n\r\nSomething like \"guojia+guanyu+gaoshun:showRole\".","updated_at":"2011-10-09T04:01:12Z","url":"https://api.github.com/repos/Moligaloo/QSanguosha/issues/comments/2335142","id":2335142,"user":{"avatar_url":"https://secure.gravatar.com/avatar/52f0d4ecc61410889a84cb361b22d2d3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/cxong","id":1083215,"login":"cxong"}},"action":"created","issue":{"number":63,"created_at":"2011-09-27T10:07:51Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"The role prompt (Your role is ...) is very small, which is not helpful for new players. The role prompt is very important, so it's best to have it as prominent as possible.\r\n\r\nMy idea is to display a role card to the left of the list of generals: mockup here\r\nhttp://imageshack.us/photo/my-images/42/choosegeneraldialogmock.jpg/\r\nThere may be limited horizontal space; alternately the general cards can be displayed at a smaller size (compare with the \"ChooseGeneralDialog\" in Sanguosha Online). Any suggestions are very welcome.\r\n\r\nIf you agree that this is worth doing, I can try and make a patch myself.","comments":22,"title":"Bigger role prompt in ChooseGeneralDialog","updated_at":"2011-10-09T04:01:12Z","url":"https://api.github.com/repos/Moligaloo/QSanguosha/issues/63","id":1750717,"assignee":null,"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/52f0d4ecc61410889a84cb361b22d2d3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/cxong","id":1083215,"login":"cxong"},"html_url":"https://github.com/Moligaloo/QSanguosha/issues/63","labels":[],"state":"open"},"legacy":{"issue_id":1750717,"comment_id":2335142}}