{"action":"closed","pull_request":{"created_at":"2011-11-28T03:44:06Z","state":"closed","review_comments":0,"patch_url":"https://github.com/jaliss/securesocial/pull/7.patch","changed_files":1,"updated_at":"2011-11-28T11:07:24Z","_links":{"review_comments":{"href":"https://api.github.com/repos/jaliss/securesocial/pulls/7/comments"},"comments":{"href":"https://api.github.com/repos/jaliss/securesocial/issues/7/comments"},"html":{"href":"https://github.com/jaliss/securesocial/pull/7"},"self":{"href":"https://api.github.com/repos/jaliss/securesocial/pulls/7"}},"user":{"gravatar_id":"9f6121c293ae7b22a80a3d23324fc57b","id":1223422,"url":"https://api.github.com/users/erosas","avatar_url":"https://secure.gravatar.com/avatar/9f6121c293ae7b22a80a3d23324fc57b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"erosas"},"issue_url":"https://github.com/jaliss/securesocial/issues/7","comments":1,"body":"Old activations are now properly cleaned up. Notice that in the controller the user is being saved so at the point of sending the activation email, the user exists on both maps. This is fine because it makes searching for taken usernames easier since only the \"users\" map needs to be scanned but in case that the account is not activated this needs to be cleaned up. This will cause many inactive accounts to exist that will waste usernames. (Either this implementation changes, or the controller logic changes)\r\n\r\nAlso, it may be a good idea to add delete to the Service interface.","merged":false,"deletions":2,"commits":1,"mergeable":true,"id":532249,"number":7,"base":{"user":{"gravatar_id":"c5a40f5a1031b3cfa4796ec0f7c9aff8","id":997114,"url":"https://api.github.com/users/jaliss","avatar_url":"https://secure.gravatar.com/avatar/c5a40f5a1031b3cfa4796ec0f7c9aff8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"jaliss"},"repo":{"pushed_at":"2011-11-27T19:08:29Z","created_at":"2011-11-10T17:32:54Z","updated_at":"2011-11-27T19:08:30Z","private":false,"clone_url":"https://github.com/jaliss/securesocial.git","watchers":38,"name":"securesocial","master_branch":null,"svn_url":"https://svn.github.com/jaliss/securesocial","forks":7,"language":"Java","owner":{"gravatar_id":"c5a40f5a1031b3cfa4796ec0f7c9aff8","id":997114,"url":"https://api.github.com/users/jaliss","avatar_url":"https://secure.gravatar.com/avatar/c5a40f5a1031b3cfa4796ec0f7c9aff8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"jaliss"},"id":2750249,"homepage":"","git_url":"git://github.com/jaliss/securesocial.git","description":"A module that provides OAuth, OAuth2 and OpenID authentication for Play Framework applications","html_url":"https://github.com/jaliss/securesocial","size":184,"fork":false,"url":"https://api.github.com/repos/jaliss/securesocial","open_issues":4,"ssh_url":"git@github.com:jaliss/securesocial.git"},"sha":"4023b8c45fb90614dace3076ab07f7b63d3b186c","ref":"master","label":"jaliss:master"},"additions":38,"merged_by":null,"head":{"user":{"gravatar_id":"9f6121c293ae7b22a80a3d23324fc57b","id":1223422,"url":"https://api.github.com/users/erosas","avatar_url":"https://secure.gravatar.com/avatar/9f6121c293ae7b22a80a3d23324fc57b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"erosas"},"repo":{"pushed_at":"2011-11-28T03:38:30Z","created_at":"2011-11-27T15:54:10Z","updated_at":"2011-11-28T03:38:30Z","private":false,"clone_url":"https://github.com/erosas/securesocial.git","watchers":1,"name":"securesocial","master_branch":null,"svn_url":"https://svn.github.com/erosas/securesocial","forks":0,"language":"Java","owner":{"gravatar_id":"9f6121c293ae7b22a80a3d23324fc57b","id":1223422,"url":"https://api.github.com/users/erosas","avatar_url":"https://secure.gravatar.com/avatar/9f6121c293ae7b22a80a3d23324fc57b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"erosas"},"id":2861514,"homepage":"","git_url":"git://github.com/erosas/securesocial.git","description":"A module that provides OAuth, OAuth2 and OpenID authentication for Play Framework applications","html_url":"https://github.com/erosas/securesocial","size":116,"fork":true,"url":"https://api.github.com/repos/erosas/securesocial","open_issues":0,"ssh_url":"git@github.com:erosas/securesocial.git"},"sha":"12f749a4ad89e3594a65ccf00cb25703b6d935d2","ref":"master","label":"erosas:master"},"title":"Proper clean up in the DefaultUserService for non-activated accounts","closed_at":"2011-11-28T11:07:23Z","html_url":"https://github.com/jaliss/securesocial/pull/7","url":"https://api.github.com/repos/jaliss/securesocial/pulls/7","diff_url":"https://github.com/jaliss/securesocial/pull/7.diff","merged_at":null},"number":7}