{"comment":{"created_at":"2011-10-19T23:13:15Z","body":"@jdalton I'm not talking about the implementation details of various libraries, but the reason for using a library in the first place. And, I'd say that direct comparisons to the Prototype or jQuery ways are less relevant to Underscore, as we should favor more semantically cogent API decisions.\r\n\r\n@keithamus, I think you might have reversed your answer? Since both `Infinity` and `NaN` fits something \"of or relating to a number\" I'd expect them to pass a `isNumeric` check, but not a `isNumber` check. \r\n\r\nThe big issue for me is the contradiction that `_.isNumber(NaN)` returning `true` presents. This reads like `_.isTrue(kNotTrue)` to me. I'm *less interested in the specs and numeracy of NaN as implemented,* and more interested in ensuring that the API is semantically clear. If being purely on-spec was our goal, then `isEqual` should really munge types, right? After all, the function name isn't `_.isStrictlyEqual`.","updated_at":"2011-10-19T23:13:15Z","url":"https://api.github.com/repos/documentcloud/underscore/issues/comments/2462660","id":2462660,"user":{"avatar_url":"https://secure.gravatar.com/avatar/6a811536d2b8fba3a92ef054db9ba377?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"6a811536d2b8fba3a92ef054db9ba377","url":"https://api.github.com/users/arbales","id":21961,"login":"arbales"}},"action":"created","issue":{"number":321,"created_at":"2011-10-05T03:04:18Z","pull_request":{"diff_url":"https://github.com/documentcloud/underscore/pull/321.diff","patch_url":"https://github.com/documentcloud/underscore/pull/321.patch","html_url":"https://github.com/documentcloud/underscore/pull/321"},"body":"The current tests allow for too many false positives for my liking. This also changes `_.isNumber(NaN)` from `false` to `true`. It really should have been `true` in the first place.","comments":39,"title":"better isXXX checks","updated_at":"2011-10-19T23:13:15Z","url":"https://api.github.com/repos/documentcloud/underscore/issues/321","id":1820179,"assignee":null,"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/24fb0088507077f7852adaec4f6b679f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"24fb0088507077f7852adaec4f6b679f","url":"https://api.github.com/users/michaelficarra","id":218840,"login":"michaelficarra"},"html_url":"https://github.com/documentcloud/underscore/issues/321","labels":[{"name":"change","url":"https://api.github.com/repos/documentcloud/underscore/labels/change","color":"22694d"}],"state":"open"},"legacy":{"issue_id":1820179,"comment_id":2462660}}