{"issue":{"pull_request":{"diff_url":"https://github.com/laumann/jekyll/pull/1.diff","html_url":"https://github.com/laumann/jekyll/pull/1","patch_url":"https://github.com/laumann/jekyll/pull/1.patch"},"state":"open","user":{"avatar_url":"https://secure.gravatar.com/avatar/039a383a7ed35c227fd8f2bf24fafe0a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"039a383a7ed35c227fd8f2bf24fafe0a","url":"https://api.github.com/users/cgroner","login":"cgroner","id":946024},"milestone":null,"assignee":null,"labels":[],"updated_at":"2011-11-04T16:23:56Z","comments":2,"closed_at":null,"url":"https://api.github.com/repos/laumann/jekyll/issues/1","body":"I added some test cases for default values. That is, for cases when no explicit `redcloth` or `hard_breaks` values exist in the config. \r\n\r\n","html_url":"https://github.com/laumann/jekyll/issues/1","title":"Missing test cases for defaults.","number":1,"id":2136195,"created_at":"2011-11-03T18:59:48Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/b10c21316dfdcb8a5dee987ad92c8202?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"b10c21316dfdcb8a5dee987ad92c8202","url":"https://api.github.com/users/laumann","login":"laumann","id":390428},"updated_at":"2011-11-04T16:23:56Z","url":"https://api.github.com/repos/laumann/jekyll/issues/comments/2632954","body":"I'll pull this, because I think you are right about the test cases - but I'm thinking we might as well expand it to pick up anything in the redcloth section of the `_config.yml` - that way we don't have to rely on things being set in the `DEFAULTS` section.\r\n\r\nSo, instead of asking directly for hard_breaks, I want to iterate all the members set in the redcloth section, and build an array of symbols to pass to RedCloth's constructor. This has the added benefit that even if nothing is set the empty array just indicates the default values. But to do this we have to employ a little defensive programming - some malicious user (who?) might decide to delete the redcloth section from the config altogether (as is rightly pointed out by your code)!\r\n\r\nThanks for the inspiration :-)","id":2632954,"created_at":"2011-11-04T16:23:56Z"}}