{"shas":[["89ca3994480c74b23f05c4deac0eee24dee0d9b0","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Avoid double-destroying the file-changed info_bar on \"Reload\"\n\nThis was caused by an addition I made in the earlier patch to destroy\nthe info_bar when the user manually reverts or loads a new file).\n\nThe callback on revert button was trying to delete it (again) after\nthe revert _action_ we call triggered a destroy of the widget. Avoid\nthis by destroying the info_bar before we call the revert action.","Peter Clifton"],["b372ca668852701f5e19b878ee3aa97361e377c8","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use gtk_cell_renderer_get_{align,pad} accessors\n\nIn GTK3.0, direct access to these fields will be impossible.","Peter Clifton"],["cbd2f49e3b4f48c45e70b76ce207e9e76a81dcb8","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Clean and make gport_set_cursor_type() more GTK3.0 compatible\n\nAlso removes the DEFAULT_CURSOR return value (for the case of no window\nbeing setup) to GDK_X_CURSOR (the 0 enum value), as the code path which\nreturned DEFAULT_CURSOR would never have been hit.","Peter Clifton"],["a369bf7cf2cfffbf9c44fc5ef3be8b0f9beabc0e","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Avoid warning caused by early drawing before gport->pixmap is set\n\nAvoids a command line warning:\n\n(pcb:28876): Gdk-CRITICAL **: IA__gdk_draw_drawable: assertion `GDK_IS_DRAWABLE (src)' failed\n\nWith the GDK renderer in use.\n\nThis trigger appears to be some state changes triggered as the new layer\nselector widget initialises.","Peter Clifton"],["0809a6ec7d32e4acec5a6fcaca8a9fd8ab63e51a","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use gtk_widget_get_allocation() not gdk_window_get_geometry()\n\nThis avoids an unnecessary round-trip the the X server on X11 platforms.","Peter Clifton"],["ce34fefde11f0b617e1291b27a65aeebe6d3bf6d","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use gtk_widget_get_allocation() accessor\n\nIn GTK3.0, direct access to widget->allocation will be impossible.","Peter Clifton"],["718b9c34a4c2e4070436cf8abf756f22c5c74cec","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use gtk_widget_get_window() accessor\n\nIn GTK3.0, direct access to widget->window will be impossible.","Peter Clifton"],["9b803f2740021a18ae37f89b341efb87fad39786","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use gtk_widget_get_style() accessor, rather than direct access\n\nIn GTK3.0, direct access to widget->style will be impossible.\n\nSwap out the GTK_WIDGET_STATE() macro for gtk_widget_get_state(), which\ndoes not directly access the GSeal'd member widget->state.","Peter Clifton"],["29c9c84b025f13687f99974b255ef3c365a129ef","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Remove unused function ghid_button_active()","Peter Clifton"],["3073ecedc2ea25b2f1f65b54032d2ae3b444671c","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Remove unused function ghid_button_set_text()","Peter Clifton"],["d96be87abe6b84c40814c71d719c136a79533a58","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Don't test for NOOP before calling gtk_widget_set_sensitive()\n\nWe were using a deprecated test macro anyway, GTK already does a NOOP\ntest inside gtk_widget_set_sensitive().","Peter Clifton"],["cddceda9372314d504f3eb65668ae831b0a23d27","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Don't use GTK_WIDGET_SET_FLAGS()\n\nCall the appropriate setter function instead. (For GTK3.0 compatibility).","Peter Clifton"],["03eb7fd68481ec1f471ce08d7def9774c10d58af","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use accessor functions for handling GtkAdjustments\n\nIn GTK3.0, direct access to these member variables will be impossible.","Peter Clifton"],["8cc3e88ce5df28718eac576bc1d1f28616658a9e","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use accessors to get the vbox from GtkDialog\n\nIn GTK3.0, direct access to dialog->vbox will be impossible.","Peter Clifton"],["e04f041cfd56000414c2b167e03bcc2ed0e1a1d1","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Free list returned from gtk_container_get_children()\n\nWe can (and should) g_list_free() the list of children returned when\nwe are finished with it.\n\nWhilst we are at it, convert the while loop to a for loop and use a\ntighter condition on the loop termination test. The existing test worked,\nbut would leave a negative number in the object counter we test against.\nThis would not work if the object counters were ever unsigned integers\n(as they might plausibly be).","Peter Clifton"],["3584101f67f6ca2f0a252c312cb0c6c9c4fa016f","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Don't access a GtkMenuShell's children directly\n\nIn GTK3.0, direct access to shell->children will be impossible.","Peter Clifton"],["09d3ccc2c43c2e1bbb8f625d39e6f587403af858","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use gtk_notebook_get_n_pages() rather than diving in and counting\n\nIn GTK3.0, direct access to notebook->children will be impossible.","Peter Clifton"],["d9f4e9d25110f47b750df6b4259b9c4e02e7b94f","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Use gtk_bin_get_child() accessor\n\nIn GTK3.0, direct access to bin->child will be impossible.","Peter Clifton"],["3f09eea65bc65eeb69bf36443ce33d14b14fb4dc","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Replace GTK_WIDGET_REALIZED() test with a check for window != NULL\n\nThis avoids the use of the deprecated GTK_WIDGET_REALIZED macro, without\nneeding to use the GTK2.20 function gtk_widget_get_realized(). The check\nfor a NULL window should be sufficient here I hope.","Peter Clifton"],["c9b505b52f912541674fdd1aabda43e7c0702f10","1131b31988b060307ac241782243ebf25e705312@cam.ac.uk","hid/gtk: Fix not accessing GtkMenuShell's children harder\n\nI missed a critical part of the fix from\ncommit 3584101f67f6ca2f0a252c312cb0c6c9c4fa016f","Peter Clifton"]],"ref":"refs/heads/master","size":20,"head":"c9b505b52f912541674fdd1aabda43e7c0702f10","push_id":41706401}