{"head":"ed865a98bf168d35456d38dfdd3dea5240e1b400","size":5,"push_id":46070869,"ref":"refs/heads/xpc_reformat","commits":[{"sha":"01d0c8f5db81e7604a95203627b1229d33836a6e","author":{"name":"Bobby Holley","email":"fed27ab4bbe1a911524b30ef25d6483205c1ac13@gmail.com"},"url":"https://api.github.com/repos/bholley/mozilla-central/commits/01d0c8f5db81e7604a95203627b1229d33836a6e","message":"Bug 688012 - Remove trailing whitespace within XPConnect. v1\n\nxpcfix -w `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\ngit diff -w verifies that this patch contains no non-whitespace changes."},{"sha":"d762e250273228ef03665e0e35e493ab55d1ef2d","author":{"name":"Bobby Holley","email":"fed27ab4bbe1a911524b30ef25d6483205c1ac13@gmail.com"},"url":"https://api.github.com/repos/bholley/mozilla-central/commits/d762e250273228ef03665e0e35e493ab55d1ef2d","message":"Bug 688012 - Move all multi-line continuation backslashes to column 79 (where possible). v1\n\nxpcfix -c `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\nThis isn't a huge deal, but it's necessary for the other style changes we want to make. Specifically, when adding and removing things from lines within macros, xpcfix corrects continuation backslashes by putting them at column 79. If we make sure that this is also the default everywhere, then everything will match up.\n\ngit diff -w shows no changes here as well."},{"sha":"cbba1668ccc9a46992ca6191e26d535cc344ab17","author":{"name":"Bobby Holley","email":"fed27ab4bbe1a911524b30ef25d6483205c1ac13@gmail.com"},"url":"https://api.github.com/repos/bholley/mozilla-central/commits/cbba1668ccc9a46992ca6191e26d535cc344ab17","message":"Bug 688012 - Fix alignment of arguments and tests relative to parens. v1\n\nxpcfix -puc `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\nSome of these changes aren't quite ideal, but it's the best my tooling can do and I think it's very much a step in the right direction. This is necessary to do first, because doing if(foo) -> if (foo) changes the location of parentheses, which affects how other things should be aligned. So this has to be built into the tooling, and we might as well take care of the pre-existing issues first."},{"sha":"d51553cbd6a06e5028e88438082d34d61ca9903c","author":{"name":"Bobby Holley","email":"fed27ab4bbe1a911524b30ef25d6483205c1ac13@gmail.com"},"url":"https://api.github.com/repos/bholley/mozilla-central/commits/d51553cbd6a06e5028e88438082d34d61ca9903c","message":"Bug 688012 - Add space between keyword and paren for: if, for, while, and switch. v1\n\nxpcfix -spuc `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\ngit diff -w is empty here as well."},{"sha":"ed865a98bf168d35456d38dfdd3dea5240e1b400","author":{"name":"Bobby Holley","email":"fed27ab4bbe1a911524b30ef25d6483205c1ac13@gmail.com"},"url":"https://api.github.com/repos/bholley/mozilla-central/commits/ed865a98bf168d35456d38dfdd3dea5240e1b400","message":"Bug 688012 - Move the open-brace for if, else, for, while, and switch to the same line as the keyword or condition. v1\n\nxpcfix -bpc `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\nThis is a huge, repetitive patch, and I confess having only skimmed a lot of it. I'm reasonably confident in the tool here though."}],"legacy":{"head":"ed865a98bf168d35456d38dfdd3dea5240e1b400","size":5,"push_id":46070869,"shas":[["01d0c8f5db81e7604a95203627b1229d33836a6e","bobbyholley@gmail.com","Bug 688012 - Remove trailing whitespace within XPConnect. v1\n\nxpcfix -w `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\ngit diff -w verifies that this patch contains no non-whitespace changes.","Bobby Holley"],["d762e250273228ef03665e0e35e493ab55d1ef2d","bobbyholley@gmail.com","Bug 688012 - Move all multi-line continuation backslashes to column 79 (where possible). v1\n\nxpcfix -c `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\nThis isn't a huge deal, but it's necessary for the other style changes we want to make. Specifically, when adding and removing things from lines within macros, xpcfix corrects continuation backslashes by putting them at column 79. If we make sure that this is also the default everywhere, then everything will match up.\n\ngit diff -w shows no changes here as well.","Bobby Holley"],["cbba1668ccc9a46992ca6191e26d535cc344ab17","bobbyholley@gmail.com","Bug 688012 - Fix alignment of arguments and tests relative to parens. v1\n\nxpcfix -puc `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\nSome of these changes aren't quite ideal, but it's the best my tooling can do and I think it's very much a step in the right direction. This is necessary to do first, because doing if(foo) -> if (foo) changes the location of parentheses, which affects how other things should be aligned. So this has to be built into the tooling, and we might as well take care of the pre-existing issues first.","Bobby Holley"],["d51553cbd6a06e5028e88438082d34d61ca9903c","bobbyholley@gmail.com","Bug 688012 - Add space between keyword and paren for: if, for, while, and switch. v1\n\nxpcfix -spuc `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\ngit diff -w is empty here as well.","Bobby Holley"],["ed865a98bf168d35456d38dfdd3dea5240e1b400","bobbyholley@gmail.com","Bug 688012 - Move the open-brace for if, else, for, while, and switch to the same line as the keyword or condition. v1\n\nxpcfix -bpc `find | grep -P \"cpp$|h$\" | perl -pe 's/\\n/ /'`\n\nThis is a huge, repetitive patch, and I confess having only skimmed a lot of it. I'm reasonably confident in the tool here though.","Bobby Holley"]],"ref":"refs/heads/xpc_reformat"}}