{"ref":"refs/heads/master","push_id":54987118,"commits":[{"sha":"231e79ce0fa4bab295d8d347205fda0b6b468323","author":{"email":"2ece23298f06d9fb45772fdb1d38086918c80f44@burgov.nl","name":"Bart van den Burg"},"url":"https://api.github.com/repos/homer6/symfony/commits/231e79ce0fa4bab295d8d347205fda0b6b468323","message":"fixed entity choice list BC break"},{"sha":"c60f0363de56919763b5e1ee728dcdd1ec88b9e5","author":{"email":"2ece23298f06d9fb45772fdb1d38086918c80f44@burgov.nl","name":"Bart van den Burg"},"url":"https://api.github.com/repos/homer6/symfony/commits/c60f0363de56919763b5e1ee728dcdd1ec88b9e5","message":"fixed typo"},{"sha":"10c60ab5d5cfedc572b72205dae6906ad3e33cb7","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"url":"https://api.github.com/repos/homer6/symfony/commits/10c60ab5d5cfedc572b72205dae6906ad3e33cb7","message":"merged branch Burgov/fix_entity_choice_list (PR #2942)\n\nCommits\n-------\n\nc60f036 fixed typo\n231e79c fixed entity choice list BC break\n\nDiscussion\n----------\n\nfixed EntityChoiceList BC break\n\nBug fix: yes\nFeature addition: no\nBackwards compatibility break: fixes a BC break\nSymfony2 tests pass: yes\n\nThis PR resolves a serious BC break introduced in commit b919d92b523eb5fb35e25f40245d8d00e67627ef\nPrior to this commit, it was possible to use the entity shorthand notation in the EntityChoiceList constructor, but it broke because the EntityChoiceList now expects the second argument to be the actual class name\n\nThere is another issue at hand here, but I'm not sure how to fix it:\n\nThe EntityChoiceManager expects an Doctrine\\Common\\Persistence\\ObjectManager instance, then the ClassMetadata is fetched from it and the method getIdentifierFieldNames is called on it. Yet, according to the docblock, getClassMetadata of the ObjectManager returns an instance of Doctrine\\Common\\Persistence\\Mapping\\ClassMetadata, which doesn't have a getIdentifierFieldNames() method.\n\nSo either the EntityChoiceList should expect an instance of EntityManager, or it should be rewritten to not use getIdentifierFieldNames() anymore.\n\nAny ideas?\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/12/22 03:48:49 -0800\n\nping @beberlei\n\n---------------------------------------------------------------------------\n\nby beberlei at 2011/12/22 04:02:30 -0800\n\nThe fix is valid\n\n---------------------------------------------------------------------------\n\nby stof at 2011/12/22 04:54:53 -0800\n\n@beberlei getIdentifierFieldNames should probably be added in the interface too. Currently, we only have isIdentifier in it.\n\nThis methods needs to be implemented in the MongoDB ODM though (simply returning ``array($this->getIdentifier())``"}],"head":"10c60ab5d5cfedc572b72205dae6906ad3e33cb7","size":3}