{"issue":{"title":"Fix the TODO in BuildLog class.","user":{"login":"tfarina","id":970071,"url":"https://api.github.com/users/tfarina","avatar_url":"https://secure.gravatar.com/avatar/ed0bb664e7512196906107cd27f42211?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ed0bb664e7512196906107cd27f42211"},"created_at":"2011-12-24T01:50:16Z","milestone":null,"labels":[],"state":"open","updated_at":"2011-12-27T20:13:03Z","id":2651355,"closed_at":null,"html_url":"https://github.com/martine/ninja/issues/165","pull_request":{"patch_url":"https://github.com/martine/ninja/pull/165.patch","html_url":"https://github.com/martine/ninja/pull/165","diff_url":"https://github.com/martine/ninja/pull/165.diff"},"body":"This is was pretty trivial, since no one was calling |log_|.\r\n\r\nSigned-off-by: Thiago Farina <tfarina@chromium.org>","number":165,"url":"https://api.github.com/repos/martine/ninja/issues/165","comments":4,"assignee":null},"comment":{"user":{"login":"martine","id":3847,"url":"https://api.github.com/users/martine","avatar_url":"https://secure.gravatar.com/avatar/1d125552c92c317d4b00435a75848404?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"1d125552c92c317d4b00435a75848404"},"created_at":"2011-12-27T20:13:03Z","updated_at":"2011-12-27T20:13:03Z","id":3284777,"body":"I tried pulling this, and ninja_test didn't build:\r\n\r\nFAILED: g++ -MMD -MF build/build_log_test.o.d -g -Wall -Wextra -Wno-deprecated -Wno-unused-parameter -fno-exceptions -fvisibility=hidden -pipe -c src/build_log_test.cc -o build/build_log_test.o\r\nsrc/build_log.h: In member function ‘virtual void BuildLogTest_WriteRead_Test::TestBody()’:\r\nsrc/build_log.h:75: error: ‘__gnu_cxx::hash_map<const char*, BuildLog::LogEntry*, ExternalStringHash, ExternalStringEq, std::allocator<BuildLog::LogEntry*> > BuildLog::log_’ is private\r\nsrc/build_log_test.cc:57: error: within this context\r\nsrc/build_log.h:75: error: ‘__gnu_cxx::hash_map<const char*, BuildLog::LogEntry*, ExternalStringHash, ExternalStringEq, std::allocator<BuildLog::LogEntry*> > BuildLog::log_’ is private\r\nsrc/build_log_test.cc:58: error: within this context\r\nninja: build stopped: subcommand failed.\r\n","url":"https://api.github.com/repos/martine/ninja/issues/comments/3284777"},"action":"created"}