{"issue":{"pull_request":{"diff_url":"https://github.com/camptocamp/puppet-java/pull/5.diff","html_url":"https://github.com/camptocamp/puppet-java/pull/5","patch_url":"https://github.com/camptocamp/puppet-java/pull/5.patch"},"state":"open","user":{"avatar_url":"https://secure.gravatar.com/avatar/4847c025f562b462f400129b06eeff07?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"4847c025f562b462f400129b06eeff07","url":"https://api.github.com/users/cjeanneret","login":"cjeanneret","id":82490},"milestone":null,"labels":[],"assignee":null,"updated_at":"2011-11-04T11:07:52Z","comments":2,"closed_at":null,"url":"https://api.github.com/repos/camptocamp/puppet-java/issues/5","body":"","html_url":"https://github.com/camptocamp/puppet-java/issues/5","number":5,"title":"Manage keystore","id":2130762,"created_at":"2011-11-03T09:59:10Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/2d2f7a7f27009d80cb876111b3ddbbb6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"2d2f7a7f27009d80cb876111b3ddbbb6","url":"https://api.github.com/users/mfournier","login":"mfournier","id":37533},"updated_at":"2011-11-04T11:07:52Z","url":"https://api.github.com/repos/camptocamp/puppet-java/issues/comments/2629342","body":"Considering readability of puppet manifest:\r\n\r\n  java::key { xyz: ... } # What are we talking about ???\r\n\r\n  java::keystore::keypair { xyz: ...  } # Ah, this I know what it is without having to read the source code of the definition :-)\r\n\r\nSo I would suggest renaming the definitions as follow:\r\njava::key -> java::keystore::keypair \r\njava::duplicate::keystore -> java::keystore::duplicate\r\njava::import::keystore -> java::keystore::import\r\njava::import::cert ->  java::keystore::cert::import\r\n\r\nBonus: this matches the \"right\" way to organise the module namespace and will ease the transition to 100% autoloading of our modules.","id":2629342,"created_at":"2011-11-04T11:07:52Z"}}