{"issue":{"created_at":"2011-11-21T13:23:23Z","state":"open","updated_at":"2011-11-29T18:37:30Z","user":{"gravatar_id":"c0efe8e5c15bd268224fbc40a574329d","id":94636,"url":"https://api.github.com/users/jpic","avatar_url":"https://secure.gravatar.com/avatar/c0efe8e5c15bd268224fbc40a574329d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"jpic"},"comments":1,"body":"Hi, first i want to say that I use django-ajax-selects for a long time and it's really great!\r\n\r\nI hacked a LookupChannel that returns non-existing items in get_query, items would be created by get_objects. That didn't work with M2M so after some debugging i figured that AutoCompleteSelectMultipleField.clean did not call get_objects like AutoCompleteSelectField.clean.\r\n\r\nThis patch addresses this issue, making the clean() behaviour consistent between AutoCompleteSelectMultipleField and AutoCompleteSelectField.\r\n\r\nLooking forward to read you","assignee":null,"labels":[],"id":2304504,"pull_request":{"patch_url":"https://github.com/crucialfelix/django-ajax-selects/pull/1.patch","html_url":"https://github.com/crucialfelix/django-ajax-selects/pull/1","diff_url":"https://github.com/crucialfelix/django-ajax-selects/pull/1.diff"},"number":1,"title":"Patch fixing an inconsistency","closed_at":null,"html_url":"https://github.com/crucialfelix/django-ajax-selects/issues/1","url":"https://api.github.com/repos/crucialfelix/django-ajax-selects/issues/1","milestone":null},"action":"created","comment":{"created_at":"2011-11-29T18:37:30Z","updated_at":"2011-11-29T18:37:30Z","user":{"gravatar_id":"a27a73bf3b4c35a576f9baa74021458a","id":218738,"url":"https://api.github.com/users/crucialfelix","avatar_url":"https://secure.gravatar.com/avatar/a27a73bf3b4c35a576f9baa74021458a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"crucialfelix"},"body":"Thanks so much for the pull request !  Very much appreciated to get changes sent in this way.  and sorry for the delay in responding\r\n\r\nJust thinking it through:  It would result in a database fetch that is only used to check for the fairly rare situation where the objects have been deleted.  So most of the time it is a wasted fetch and in fact I think the objects would be fetched again after that in order to save them (django will do this to save a m2m).  \r\n\r\nOf course if we don't check then it will save and this will throw a database IntegrityError.  I suppose that is messier / worse.\r\n\r\nAnd it would be consistant with ForeignKey\r\n\r\nDid you actually have a situation where some objects were deleted while somebody was editing a form ?\r\n","id":2940660,"url":"https://api.github.com/repos/crucialfelix/django-ajax-selects/issues/comments/2940660"}}