{"comment":{"created_at":"2011-10-21T16:49:57Z","body":"I had a look at the implementation earlier :)\r\n\r\n@dj2 at some stage it makes sense to convert the headers to downcase, but probably I would have done it lower down if I had been thinking about using the Handlers directly.\r\n\r\nOne thing I thought was that the Exception handler on line 66 should just catch HandshakeError. I'm thinking of adding a http_code to this error since some of the new drafts now specify which http code should be returned - for example the origin check in http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17#section-4.2.2 (which em-websocket doesn't currently support). The general case though, when no http code is specified, is that the connection should simply be closed (not 500 returned - see http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17#section-7.1.1).","updated_at":"2011-10-21T16:49:57Z","url":"https://api.github.com/repos/igrigorik/em-websocket/issues/comments/2483522","id":2483522,"user":{"gravatar_id":"620734cfa78f4d78e4837cb0e56ccd32","avatar_url":"https://secure.gravatar.com/avatar/620734cfa78f4d78e4837cb0e56ccd32?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/mloughran","id":214,"login":"mloughran"}},"action":"created","issue":{"number":64,"created_at":"2011-10-21T04:52:58Z","pull_request":{"diff_url":"https://github.com/igrigorik/em-websocket/pull/64.diff","patch_url":"https://github.com/igrigorik/em-websocket/pull/64.patch","html_url":"https://github.com/igrigorik/em-websocket/pull/64"},"body":"fixed the multicast smaple so it uses SSL to fetch the twitter stream (now required)","comments":8,"title":"simple example fix due to twitter API change","updated_at":"2011-10-21T16:49:57Z","url":"https://api.github.com/repos/igrigorik/em-websocket/issues/64","id":2012322,"assignee":null,"milestone":null,"closed_at":"2011-10-21T05:09:33Z","user":{"gravatar_id":"c69521d6e22fc0bbd69337ec8b1698df","avatar_url":"https://secure.gravatar.com/avatar/c69521d6e22fc0bbd69337ec8b1698df?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/mattetti","id":113,"login":"mattetti"},"html_url":"https://github.com/igrigorik/em-websocket/issues/64","labels":[],"state":"closed"},"legacy":{"issue_id":2012322,"comment_id":2483522}}