{"shas":[["9438163b4d43e4e0000d6073c62ba9870a3b9daa","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Fix the review request ID on the review request page when there's a draft.\n\nWhen there's a draft of a review request, the review request ID shown was\nthat of the draft and not the review request. Now we pull from the right\nobject.","Christian Hammond"],["658e76d60ece44d3018ff09aeb9a3a0e0f5f9454","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Fix linking for localsite URLs and make the usage more seamless.\n\nThis implements some tricks to get seamless, easy linking of localsite URLs\nwhen inside a localsite.\n\nFirst, the URLs have been registered by creating a new urlpatterns entry\nthat we both add to the main URLs list and add with a s/(name)/ prefix (using\nan include). Django, it turns out, allows multiple URLs with the same name,\nand it will try each URL with the regular expression and parameters given.\nGoing this route, we don't trip up the URL parsers by encasing the \"s/\" in the\noptional regex.\n\nThat's the first half of the equation. The second is URL resolving.\n\nURL resolving for templates is now very easy and transparent to work with.\nWe replace/wrap Django's own {% url %} tag. We do this by adding the\nlocalsite app's templatetags as a built-in set of tags, which will actually\noverride any of Django's own built-in tags.\n\nThe new tag wraps Django's tag and attempts to resolve two versions of the\nURL: one with the local site name and one without. We get the local_site_name\nfrom the context, which in most cases (when using RequestContext) is provided\nby the new localsite context processor, which gets it from the new\nLocalSiteMiddleware. LocalSiteMiddleware processes every view and stores\nthe local_site_name in the request for the context processor to access,\nif it's provided in the URL.\n\nThis is still missing a couple components. First, reverse() still hasn't\nbeen replaced. The plan there is to provide a new wrapper version that works\nlike the new {% url %} tag, and then use that everywhere else. Second,\nthe datagrid code doesn't provide context when linking to an object from a\ncell, so that needs to be added to Djblets. These will be done in a\nsubsequent change.\n\nReviewed at http://reviews.reviewboard.org/r/2007/","Christian Hammond"],["caea00b04ab23c55389d011fe6f76a0c95a82e3e","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Add support for URL reversing for local sites.\n\nThis adds a new local_site_reverse function in reviewboard.site.urlresolvers\nthat can, given a local_site_name or request, attempt to reverse the URL\nwith that site name. This makes it easy to write a function that points\nto the correct URL depending on whether or not the user is accessing a local\nsite.\n\nCall sites have been updated to use the new function. The review request\nmodels have also been updated to use this in the get_absolute_url functions.\nThere shouldn't be any manual URL generation left at this point.\n\nReviewed at http://reviews.reviewboard.org/r/2008/","Christian Hammond"],["3ee17820ef3dfcb3fca08ad79df3b4e2cb83e059","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Delete the custom iphone interface.\n\nThe old iphone interface was never polished up, and isn't really that useful,\nespecially now that the web UI works on touchscreen interfaces a bit better.\nIt's now being removed from 1.6.","Christian Hammond"],["e4fc2941aa2eb0c1ccf10b8d049263a4739ca43c","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Require tonight's build of Djblets.\n\nReview Board requires some new fixes and changes in Djblets for linking and\nthe API, so require the latest Djblets build.","Christian Hammond"],["3804af230d4ac0aef1ca31a71cc11161c2891e2f","a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","Fix a build breakage.\n\nI failed to resolve a merge correctly and ended up with a typo, which broke\nthe nightly build. Fixed.","Christian Hammond"]],"repo":"davidt/reviewboard","actor":"davidt","ref":"refs/heads/master","size":6,"head":"3804af230d4ac0aef1ca31a71cc11161c2891e2f","push_id":21977132}