{"comment":{"user":{"id":75864,"login":"Montellese","url":"https://api.github.com/users/Montellese","avatar_url":"https://secure.gravatar.com/avatar/4d6e5dc659667cacb0405ee88515e687?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"4d6e5dc659667cacb0405ee88515e687"},"created_at":"2011-12-21T23:35:29Z","path":null,"updated_at":"2011-12-21T23:35:29Z","id":814319,"position":null,"html_url":"https://github.com/xbmc/xbmc/commit/227d928d93#commitcomment-814319","body":"I have to say I don't like this for three reasons:\r\n\r\n1. CAnnouncementManager is meant for providing 3rd party clients with event information and not for communicating stuff in core (but you didn't introduce that)\r\n2. The way it is done now, the OnUpdate announcement doesn't provide the \"type\" property anymore. Because of that JSON-RPC clients will get a notification that the item with the \"id\" xyz has changed but it could be a movie, a tvshow, an episode, a music video or whatever but there's no way anymore for the announcement receivers to know which one it really was. The \"old\" AnnounceUpdate (that was removed) provided this information.\r\n3. JSON-RPC will soon be extended to provide functionality to update meta data of database items and if one client changes something the other clients need to know about those changes as well. But if those changes don't go through the VideoInfoScanner (which would be a rather stupid implementation) the announcement won't be sent anymore.\r\n\r\nI (once again) vote for not \"abusing\" CAnnouncementManager for this kind of XBMC internal update and use a proper GUI_MSG_FOO as it is done with GUI_MSG_UPDATE_ITEM or any of the other GUI messages and revert this so that the JSON-RPC announcements work as they were intended to.","url":"https://api.github.com/repos/xbmc/xbmc/comments/814319","line":null,"commit_id":"227d928d93ff88db3004bc7369bf4a0cbd51132c"}}