{"issue":{"milestone":null,"title":"Support for things like the \"bounds=\" option for the Google geocoding service","created_at":"2011-12-30T16:36:47Z","user":{"login":"rosscooperman","id":7132,"url":"https://api.github.com/users/rosscooperman","avatar_url":"https://secure.gravatar.com/avatar/d220ebc8759a44868c189856aebe47a0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"d220ebc8759a44868c189856aebe47a0"},"updated_at":"2011-12-30T20:30:29Z","state":"open","labels":[],"id":2689849,"closed_at":null,"html_url":"https://github.com/alexreisner/geocoder/issues/155","pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"body":"Hey Alex,\r\n\r\nWhen you have a minute can you take a look at the last three commits on my fork:\r\n\r\nhttps://github.com/rosscooperman/geocoder/commits/provider_options\r\n\r\nI implemented an (optional) options parameter to Geocoder.search that will allow you to say something like:\r\n\r\n```ruby\r\nGeocoder.search(\"Some Intersection\", :bounds => [[40.0, -120.0], [39.0, -121.0]])\r\n```\r\n\r\nto bias search results in a given bounds.  I only added the functionality to pass the options through to the Google lookup object but I was planning to add viewport biasing to the other lookup providers that support it.  As implemented the feature could also be used to implement other provider options.  I wanted to run this by you before I take it any further to see if you would consider pulling something like this in.\r\n\r\nThanks!\r\n\r\n~Ross","number":155,"url":"https://api.github.com/repos/alexreisner/geocoder/issues/155","comments":6,"assignee":null},"comment":{"created_at":"2011-12-30T20:30:29Z","user":{"login":"rosscooperman","id":7132,"url":"https://api.github.com/users/rosscooperman","avatar_url":"https://secure.gravatar.com/avatar/d220ebc8759a44868c189856aebe47a0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"d220ebc8759a44868c189856aebe47a0"},"updated_at":"2011-12-30T20:30:29Z","id":3316832,"body":"Hmm, so I was going to add a deprecation warning (and note in the rdoc) to Lookup::Base#search but I went back to the unmodified source and it doesn't appear to take a second parameter (https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/lookups/base.rb#L25).  It looks to me like the first call that takes a ```reverse``` argument is the Lookup::Base#results method (overridden in each provider).  Should I add a deprecation warning there?  I was kinda assuming that nobody is calling those methods directly but it is certainly possible.","url":"https://api.github.com/repos/alexreisner/geocoder/issues/comments/3316832"},"action":"created"}