{"comment":{"created_at":"2011-10-12T22:20:20Z","body":"I hope this works. I can't really test it because osgearth trunk doesn't build for me -- probably because of my OpenSceneGraph version.\r\n\r\nThe patch modifies CMakeLists.txt and src/osgearth/CMakeLists.txt and adds a find script in CMakeModules.\r\n\r\n-D WITH_EXTERNAL_TINYXML causes the find script to run.\r\n\r\nThe find scripts has TINYXML_INCLUDE_DIR and TINYXML_LIBRARY. If both have values, TINYXML_FOUND is true.\r\n\r\nIf TINYXML_FOUND is true in src/osgearth/CMakeLists.txt, the bundled TinyXML files are not compiled. Therefore TINYXML_INCLUDE_DIR and TINYXML_LIBRARY are turned to use.\r\n\r\nhttp://www.geofrogger.net/review/osgearth-external-tinyxml.patch","updated_at":"2011-10-12T22:20:20Z","url":"https://api.github.com/repos/gwaldron/osgearth/issues/comments/2387772","id":2387772,"user":{"avatar_url":"https://secure.gravatar.com/avatar/a63373064c4a2db60b6d2baa06ccf715?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/volter","id":1042313,"login":"volter"}},"action":"created","issue":{"number":29,"created_at":"2011-09-11T12:51:17Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"Please don't bundle TinyXML.\r\n\r\nI threw together a Cmake script and patched Cmakelists.txt:\r\n\r\nhttp://www.geofrogger.net/review/osgEarth-2.0-FindTinyXML.cmake\r\nhttp://www.geofrogger.net/review/osgEarth-2.0-tinyxml.patch\r\n\r\nNote that the patch was written for version 2.0.0.","comments":2,"title":"Don't bundle TinyXML","updated_at":"2011-10-12T22:20:20Z","url":"https://api.github.com/repos/gwaldron/osgearth/issues/29","id":1617949,"assignee":null,"milestone":null,"closed_at":"2011-10-12T22:20:20Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/a63373064c4a2db60b6d2baa06ccf715?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/volter","id":1042313,"login":"volter"},"html_url":"https://github.com/gwaldron/osgearth/issues/29","labels":[],"state":"closed"},"legacy":{"issue_id":1617949,"comment_id":2387772}}