{"action":"opened","pull_request":{"created_at":"2011-12-04T16:09:39Z","state":"open","review_comments":0,"patch_url":"https://github.com/rails/rails/pull/3851.patch","updated_at":"2011-12-04T16:09:39Z","changed_files":2,"_links":{"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/3851/comments"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/3851/comments"},"html":{"href":"https://github.com/rails/rails/pull/3851"},"self":{"href":"https://api.github.com/repos/rails/rails/pulls/3851"}},"comments":0,"issue_url":"https://github.com/rails/rails/issues/3851","user":{"gravatar_id":"b1b111c4d9f3ed4e6dc0c76c42e96f19","id":8155,"url":"https://api.github.com/users/ebeigarts","avatar_url":"https://secure.gravatar.com/avatar/b1b111c4d9f3ed4e6dc0c76c42e96f19?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"ebeigarts"},"deletions":1,"merged":false,"body":"With oracle-enhanced this test started to fail (I think it was after [this commit](https://github.com/rails/rails/commit/7af719e81c46d06f50cd9b3caff38b945c5f2d84#L2R738)):\r\n\r\n```\r\n  1) Error:\r\ntest_validate_straight_inheritance_uniqueness(UniquenessValidationTest):\r\nOCIError: ORA-02289: sequence does not exist\r\n    /Users/beigaedg/.rvm/gems/ruby-1.9.2-p290@rails/gems/ruby-oci8-2.0.6/lib/oci8/oci8.rb:288:in `exec'\r\n    /Users/beigaedg/.rvm/gems/ruby-1.9.2-p290@rails/gems/ruby-oci8-2.0.6/lib/oci8/oci8.rb:116:in `exec'\r\n    /Users/beigaedg/code/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_oci_connection.rb:469:in `exec'\r\n    /Users/beigaedg/code/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_oci_connection.rb:172:in `select'\r\n    /Users/beigaedg/code/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_connection.rb:83:in `select_one'\r\n    /Users/beigaedg/code/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_connection.rb:89:in `select_value'\r\n    /Users/beigaedg/code/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:761:in `next_sequence_value'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/relation.rb:47:in `insert'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/persistence.rb:316:in `create'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/timestamp.rb:57:in `create'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/callbacks.rb:268:in `block in create'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:393:in `_run_create_callbacks'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:81:in `run_callbacks'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/callbacks.rb:268:in `create'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/persistence.rb:297:in `create_or_update'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/callbacks.rb:264:in `block in create_or_update'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:393:in `_run_save_callbacks'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:81:in `run_callbacks'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/callbacks.rb:264:in `create_or_update'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/persistence.rb:37:in `save'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/validations.rb:50:in `save'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/attribute_methods/dirty.rb:22:in `save'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/transactions.rb:241:in `block (2 levels) in save'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/transactions.rb:295:in `block in with_transaction_returning_status'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:190:in `transaction'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/transactions.rb:208:in `transaction'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/transactions.rb:293:in `with_transaction_returning_status'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/transactions.rb:241:in `block in save'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/transactions.rb:252:in `rollback_active_record_state!'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/transactions.rb:240:in `save'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/base.rb:533:in `create'\r\n    /Users/beigaedg/code/rails/activerecord/test/cases/validations/uniqueness_validation_test.rb:269:in `test_validate_straight_inheritance_uniqueness'\r\n    /Users/beigaedg/.rvm/gems/ruby-1.9.2-p290@rails/gems/mocha-0.9.12/lib/mocha/integration/mini_test/version_142_to_172.rb:27:in `run'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:415:in `_run_setup_callbacks'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:81:in `run_callbacks'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'\r\n```\r\n\r\nI also added a new test case which failed also on PostgreSQL.\r\n\r\nPostgreSQL:\r\n\r\n```\r\n  1) Error:\r\ntest_sequence_name_with_abstract_class(BasicsTest):\r\nNoMethodError: undefined method `split' for nil:NilClass\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:897:in `default_sequence_name'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/base.rb:736:in `reset_sequence_name'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/base.rb:725:in `sequence_name'\r\n    /Users/beigaedg/code/rails/activerecord/lib/active_record/base.rb:727:in `sequence_name'\r\n    ./test/cases/base_test.rb:1609:in `test_sequence_name_with_abstract_class'\r\n    /Users/beigaedg/.rvm/gems/ruby-1.9.2-p290@rails/gems/mocha-0.9.12/lib/mocha/integration/mini_test/version_142_to_172.rb:27:in `run'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:415:in `_run_setup_callbacks'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/callbacks.rb:81:in `run_callbacks'\r\n    /Users/beigaedg/code/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'\r\n```\r\n\r\nOracle:\r\n\r\n```\r\n  1) Failure:\r\ntest_sequence_name_with_abstract_class(BasicsTest) [./test/cases/base_test.rb:1611]:\r\n<\"projects_seq\"> expected but was\r\n<\"_seq\">.\r\n```\r\n\r\n","commits":1,"mergeable":null,"number":3851,"id":556340,"additions":11,"base":{"repo":{"created_at":"2008-04-11T02:19:47Z","pushed_at":"2011-12-04T12:46:59Z","updated_at":"2011-12-04T15:37:01Z","private":false,"clone_url":"https://github.com/rails/rails.git","name":"rails","watchers":11381,"svn_url":"https://svn.github.com/rails/rails","master_branch":null,"forks":2450,"language":"Ruby","owner":{"gravatar_id":"30f39a09e233e8369dddf6feb4be0308","id":4223,"url":"https://api.github.com/users/rails","avatar_url":"https://secure.gravatar.com/avatar/30f39a09e233e8369dddf6feb4be0308?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"rails"},"id":8514,"homepage":"http://rubyonrails.org","git_url":"git://github.com/rails/rails.git","description":"Ruby on Rails","html_url":"https://github.com/rails/rails","url":"https://api.github.com/repos/rails/rails","size":48768,"fork":false,"ssh_url":"git@github.com:rails/rails.git","open_issues":612},"user":{"gravatar_id":"30f39a09e233e8369dddf6feb4be0308","id":4223,"url":"https://api.github.com/users/rails","avatar_url":"https://secure.gravatar.com/avatar/30f39a09e233e8369dddf6feb4be0308?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"rails"},"sha":"91a3e92cc20b65d371dc885077ce6203cfb0c27e","ref":"master","label":"rails:master"},"merged_by":null,"title":"Fix sequence name with abstract classes.","head":{"repo":{"created_at":"2011-11-21T08:30:25Z","pushed_at":"2011-12-04T16:06:23Z","updated_at":"2011-12-04T16:06:27Z","private":false,"clone_url":"https://github.com/ebeigarts/rails.git","name":"rails","watchers":1,"svn_url":"https://svn.github.com/ebeigarts/rails","master_branch":null,"forks":0,"language":"Ruby","owner":{"gravatar_id":"b1b111c4d9f3ed4e6dc0c76c42e96f19","id":8155,"url":"https://api.github.com/users/ebeigarts","avatar_url":"https://secure.gravatar.com/avatar/b1b111c4d9f3ed4e6dc0c76c42e96f19?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"ebeigarts"},"id":2818486,"homepage":"http://rubyonrails.org","git_url":"git://github.com/ebeigarts/rails.git","description":"Ruby on Rails","html_url":"https://github.com/ebeigarts/rails","url":"https://api.github.com/repos/ebeigarts/rails","size":4552,"fork":true,"ssh_url":"git@github.com:ebeigarts/rails.git","open_issues":0},"user":{"gravatar_id":"b1b111c4d9f3ed4e6dc0c76c42e96f19","id":8155,"url":"https://api.github.com/users/ebeigarts","avatar_url":"https://secure.gravatar.com/avatar/b1b111c4d9f3ed4e6dc0c76c42e96f19?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"ebeigarts"},"sha":"4852adb6a10f7a72bee570c42f5a28e87e53270d","ref":"fix_sequence_name","label":"ebeigarts:fix_sequence_name"},"html_url":"https://github.com/rails/rails/pull/3851","closed_at":null,"url":"https://api.github.com/repos/rails/rails/pulls/3851","diff_url":"https://github.com/rails/rails/pull/3851.diff","merged_at":null},"number":3851}