{"issue":{"pull_request":{"diff_url":null,"html_url":null,"patch_url":null},"state":"closed","user":{"avatar_url":"https://secure.gravatar.com/avatar/a839a1dce92696539e7e9475604ef310?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"a839a1dce92696539e7e9475604ef310","url":"https://api.github.com/users/jmgimeno","login":"jmgimeno","id":718396},"milestone":null,"assignee":{"avatar_url":"https://secure.gravatar.com/avatar/f8e78a75eb189be1d74c39feaeb2d2d3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"f8e78a75eb189be1d74c39feaeb2d2d3","url":"https://api.github.com/users/pokoli","login":"pokoli","id":1160726},"updated_at":"2011-11-11T21:03:36Z","labels":[],"closed_at":"2011-11-11T21:03:36Z","comments":0,"url":"https://api.github.com/repos/pokoli/ButiJS/issues/1","body":"Variable player is not local to any function so gets leaked in the global scope.\r\n\r\n\tsocket.on('login', function(data, fn){\r\n\t\tplayer = Player.create();\r\n\t\tplayer.name=data.name;\r\n\t\t_player=player;\r\n\t\t_players.push(player);\r\n\t\tif(fn) fn(player);\r\n  \t});","html_url":"https://github.com/pokoli/ButiJS/issues/1","title":"variable player leaked in the global scope (src/server.js)","number":1,"id":2208404,"created_at":"2011-11-11T11:09:46Z"},"action":"closed"}