{"issue":{"state":"open","pull_request":{"diff_url":"https://github.com/technoweenie/faraday/pull/92.diff","html_url":"https://github.com/technoweenie/faraday/pull/92","patch_url":"https://github.com/technoweenie/faraday/pull/92.patch"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/e7ae77e8d649272bd557d0cad74658fb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e7ae77e8d649272bd557d0cad74658fb","url":"https://api.github.com/users/dhl","login":"dhl","id":265220},"milestone":null,"assignee":null,"labels":[],"updated_at":"2011-11-10T20:29:19Z","comments":1,"closed_at":null,"url":"https://api.github.com/repos/technoweenie/faraday/issues/92","body":"em-http supports both connection timeout (:connection_timeout) and inactivity timeout (:inactivity_timeout) options. The correct mapping from Faraday's global timeout options (:timeout, :open_timeout) to em-http should be:\r\n\r\n:timeout => :connection_timeout\r\n:open_timeout => :inactivity_timeout\r\n\r\nWhere '=>' denotes 'maps to'\r\n\r\nSee https://github.com/igrigorik/em-http-request/wiki/Redirects-and-Timeouts\r\n\r\nThis commit is made to mirror the timeout behavior of the net_http adapter.","html_url":"https://github.com/technoweenie/faraday/issues/92","title":"Correctly sets the timeout parameters for the em_synchrony adapter","number":92,"id":2201910,"created_at":"2011-11-10T19:51:12Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/e7ae77e8d649272bd557d0cad74658fb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e7ae77e8d649272bd557d0cad74658fb","url":"https://api.github.com/users/dhl","login":"dhl","id":265220},"updated_at":"2011-11-10T20:29:19Z","url":"https://api.github.com/repos/technoweenie/faraday/issues/comments/2700652","body":"Sorry about 6da3c1ebcfc4c1ac81f1201ea70a39aaeaea64c0. Should have ran the test again before committing... my bad! Fixed bugs and included a basic test case in 6da3c1ebcfc4c1ac81f1201ea70a39aaeaea64c0 to verify that connections are firing okay.","id":2700652,"created_at":"2011-11-10T20:29:19Z"}}