{"issue":{"state":"closed","pull_request":{"diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/919.diff","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/919","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/919.patch"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/8eff4f840b1605e58ce34b0c3b5eea5a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","login":"jakesmith","id":902700},"milestone":null,"labels":[],"updated_at":"2011-11-09T14:51:02Z","assignee":null,"closed_at":"2011-11-09T11:30:47Z","comments":11,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/919","body":"As a consequence, a series of addSubFile/removeSubFile in a transaction\r\nthat led ulimately to a failure of some sort (e.g. incompatible format)\r\nwould leave orphaned set properties in the subfiles (e.g. SuperOwner)\r\n\r\nSigned-off-by: Jake Smith <jake.smith@lexisnexis.com>","html_url":"https://github.com/hpcc-systems/HPCC-Platform/issues/919","title":"gh-839 - linkSubfile ignored transactions","number":919,"id":2184538,"created_at":"2011-11-09T09:40:23Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/8eff4f840b1605e58ce34b0c3b5eea5a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","login":"jakesmith","id":902700},"updated_at":"2011-11-09T14:51:02Z","url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/2681914","body":"One thing I forgot to mention, this fix, also fixed a leak if the add super operation failed.\r\nIt was passing ownership of a IDistributeFile and then if error (e.g. incompat. format) - it was leaked along with a SDS lock to the file.","id":2681914,"created_at":"2011-11-09T14:51:02Z"}}