{"comment":{"created_at":"2011-10-09T18:17:12Z","body":"Agree with scompt. I would declare the delegate\r\n\r\n    @property (nonatomic,readonly, retain) id <SHKConfigurationDelegate> delegate;\r\n\r\nDelegates should be weak referenced only. However in our specific scenario the delegate never references SHKConfiguration, so we do not need to afraid of retain cycle. The only one who knows that delegate exists is SHKConfiguration, so it should be responsible for retaining and hypothetically releasing it.\r\n\r\nSo that the terminology is not confusing, as everybody expect \"delegate\" to be weak referenced only, we could throw out delegate paradigm, and use simply inheritance:\r\nrename the  base abstract \"delegate\" class as SHKConfigurator, and use its subclasses LegacySHKConfigurator and DefaultSHKConfigurator. (or <UserSHKconfigurator). These would be retained in SHKConfiguration.","updated_at":"2011-10-09T18:17:12Z","url":"https://api.github.com/repos/ShareKit/ShareKit/issues/comments/2337681","id":2337681,"user":{"avatar_url":"https://secure.gravatar.com/avatar/b948ee8ca2e46ef7b986540c641a8418?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/VilemKurz","id":1016974,"login":"VilemKurz"}},"action":"created","issue":{"number":12,"created_at":"2011-09-08T21:36:23Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"The SHKConfiguration class should retain the delegate passed into the `initWithDelegate` method.","comments":5,"title":"SHKConfiguration should retain its delegate","updated_at":"2011-10-09T18:17:12Z","url":"https://api.github.com/repos/ShareKit/ShareKit/issues/12","id":1602673,"assignee":{"avatar_url":"https://secure.gravatar.com/avatar/730df0227780e818df8ce1e19c9a6c48?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/scompt","id":277576,"login":"scompt"},"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/730df0227780e818df8ce1e19c9a6c48?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/scompt","id":277576,"login":"scompt"},"html_url":"https://github.com/ShareKit/ShareKit/issues/12","labels":[{"name":"core","url":"https://api.github.com/repos/ShareKit/ShareKit/labels/core","color":"e10c02"}],"state":"open"},"legacy":{"issue_id":1602673,"comment_id":2337681}}