{"comment":{"created_at":"2011-10-13T00:29:40Z","body":"Yes, but I wan `disable :logging` to do a `use NullLogger`, and having `nil` mean something different from `false` might be rather confusing.","updated_at":"2011-10-13T00:29:40Z","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/2389960","id":2389960,"user":{"avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/rkh","id":30442,"login":"rkh"}},"action":"created","issue":{"number":371,"created_at":"2011-10-05T14:47:04Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"If somebody (me) wants to use Rack::CommonLogger themselves (for example, pass log file name to it), there is no way to tell Sinatra to stay out of logging business.\r\n\r\nIt used to be the case (1.2.x) that if settings.logging is set to false, Sinatra stayed wisely away from logging. Now (1.3), if it is set to false, Sinatra will use NullLogger.\r\n\r\nThis is not quite usable, as it is a variation of famous 'my way or highway'. Maybe, if 'settings.logging' is set to ':off', Sinatra should use NullLogger, and if it is 'false' or 'nil', Sinatra should simply do nothing about logging and let developer handle that.","comments":10,"title":"there is no way in Sinatra 1.3 to do custom logging","updated_at":"2011-10-13T00:29:40Z","url":"https://api.github.com/repos/sinatra/sinatra/issues/371","id":1824328,"assignee":{"avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/rkh","id":30442,"login":"rkh"},"milestone":{"number":9,"created_at":"2011-10-07T14:24:19Z","due_on":null,"title":"1.2.8","creator":{"avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/rkh","id":30442,"login":"rkh"},"url":"https://api.github.com/repos/sinatra/sinatra/milestones/9","open_issues":1,"closed_issues":0,"description":"","state":"open"},"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/9a755176a85626be390098c493730227?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/olek","id":17121,"login":"olek"},"html_url":"https://github.com/sinatra/sinatra/issues/371","labels":[{"name":"feature","url":"https://api.github.com/repos/sinatra/sinatra/labels/feature","color":"0007d6"}],"state":"open"},"legacy":{"issue_id":1824328,"comment_id":2389960}}