{"comment":{"created_at":"2011-10-16T15:25:40Z","body":"Well that's the point. If the user is missing the twig extension he wants to know why the ProfilerServiceProvider is not working. That exception is supposed to be thrown, to tell the user that he needs to add twig.\r\n\r\nIf you don't throw the exception, it will just fail silently and the user will be clueless as to why it's not working.","updated_at":"2011-10-16T15:25:40Z","url":"https://api.github.com/repos/RafalFilipek/ProfilerServiceProvider/issues/comments/2421380","id":2421380,"user":{"gravatar_id":"eb42ff31986f5ed1d97580819134d702","avatar_url":"https://secure.gravatar.com/avatar/eb42ff31986f5ed1d97580819134d702?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/igorw","id":88061,"login":"igorw"}},"action":"created","issue":{"number":2,"created_at":"2011-10-15T19:53:17Z","pull_request":{"diff_url":"https://github.com/RafalFilipek/ProfilerServiceProvider/pull/2.diff","patch_url":"https://github.com/RafalFilipek/ProfilerServiceProvider/pull/2.patch","html_url":"https://github.com/RafalFilipek/ProfilerServiceProvider/pull/2"},"body":"Hi\r\n\r\nI also fixed the way you add your twig profiler extension to the application. Currently, there's no best practice yet for adding your own twig extensions (@see discussion here: https://github.com/fabpot/Silex/issues/160). I took guidance from the KnpMenu Silex extension (@see https://github.com/knplabs/KnpMenu/blob/master/src/Knp/Menu/Silex/KnpMenuServiceProvider.php) since that seems a reasonable approach.\r\n\r\nAlso, I added a check whether the Twig provider is registered. This might help with cases when it hasn't been setup yet. In that case, the profiler provider does nothing (bad).\r\n","comments":6,"title":"Fixed overloading other twig extensions","updated_at":"2011-10-16T15:25:40Z","url":"https://api.github.com/repos/RafalFilipek/ProfilerServiceProvider/issues/2","id":1918954,"assignee":null,"milestone":null,"closed_at":null,"user":{"gravatar_id":"0bc5344c4be427ec0a0035ce01a67697","avatar_url":"https://secure.gravatar.com/avatar/0bc5344c4be427ec0a0035ce01a67697?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/peschehimself","id":63866,"login":"peschehimself"},"html_url":"https://github.com/RafalFilipek/ProfilerServiceProvider/issues/2","labels":[],"state":"open"},"legacy":{"issue_id":1918954,"comment_id":2421380}}