{"pull_request":{"state":"open","deletions":20,"merged_by":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/ce1ee06899b317fbdf19d015fdfe9ad5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ce1ee06899b317fbdf19d015fdfe9ad5","url":"https://api.github.com/users/davedoan","login":"davedoan","id":290051},"updated_at":"2011-11-07T22:31:49Z","diff_url":"https://github.com/harvesthq/time-warp/pull/2.diff","base":{"ref":"master","repo":{"name":"time-warp","pushed_at":"2011-04-15T21:27:03Z","master_branch":null,"fork":false,"updated_at":"2011-11-07T21:19:11Z","open_issues":1,"clone_url":"https://github.com/harvesthq/time-warp.git","homepage":"http://getharvest.com","svn_url":"https://svn.github.com/harvesthq/time-warp","private":false,"forks":8,"language":"Ruby","url":"https://api.github.com/repos/harvesthq/time-warp","owner":{"avatar_url":"https://secure.gravatar.com/avatar/36fe228546bb36403a5d785b01108b06?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"36fe228546bb36403a5d785b01108b06","url":"https://api.github.com/users/harvesthq","login":"harvesthq","id":43635},"html_url":"https://github.com/harvesthq/time-warp","description":"Ruby gem to warp time in tests","size":104,"id":101513,"git_url":"git://github.com/harvesthq/time-warp.git","watchers":57,"created_at":"2009-01-05T21:37:41Z","ssh_url":"git@github.com:harvesthq/time-warp.git"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/36fe228546bb36403a5d785b01108b06?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"36fe228546bb36403a5d785b01108b06","url":"https://api.github.com/users/harvesthq","login":"harvesthq","id":43635},"label":"harvesthq:master","sha":"145224ebb25aae7476adaeacd9170f90e2845898"},"commits":1,"closed_at":null,"comments":0,"merged":false,"head":{"ref":"support_date_lib_1_9_3","repo":{"name":"time-warp","pushed_at":"2011-11-07T22:21:14Z","master_branch":null,"fork":true,"updated_at":"2011-11-07T22:21:14Z","open_issues":0,"clone_url":"https://github.com/davedoan/time-warp.git","homepage":"http://getharvest.com","svn_url":"https://svn.github.com/davedoan/time-warp","private":false,"forks":0,"language":"Ruby","url":"https://api.github.com/repos/davedoan/time-warp","owner":{"avatar_url":"https://secure.gravatar.com/avatar/ce1ee06899b317fbdf19d015fdfe9ad5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ce1ee06899b317fbdf19d015fdfe9ad5","url":"https://api.github.com/users/davedoan","login":"davedoan","id":290051},"html_url":"https://github.com/davedoan/time-warp","description":"Ruby gem to warp time in tests","size":132,"id":2729373,"git_url":"git://github.com/davedoan/time-warp.git","watchers":1,"created_at":"2011-11-07T21:19:11Z","ssh_url":"git@github.com:davedoan/time-warp.git"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/ce1ee06899b317fbdf19d015fdfe9ad5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ce1ee06899b317fbdf19d015fdfe9ad5","url":"https://api.github.com/users/davedoan","login":"davedoan","id":290051},"label":"davedoan:support_date_lib_1_9_3","sha":"0ce43c4b4d9af77abcf2d11a05b496138059507a"},"url":"https://api.github.com/repos/harvesthq/time-warp/pulls/2","additions":71,"body":"Under Ruby 1.9.3, `Date.today` and `DateTime.now` are generated directly from system time instead of using `Time.now`. This caused the methods to return the actual current date/time instead of the time-warp modified ones. I extended the classes to base these methods off of `Time.now`, like they do in 1.9.2.\r\n\r\nInstead of cramming all of these extensions in `core_ext.rb`, I placed them all in separate files in a `core_ext` directory.\r\n\r\nI had also considered extending these classes to maintain offsets parallel to the `Time` class, but because `Date` doesn't have any time information, creating offsets with a precision of less than one day would be impossible. Always generating from `Time.now` is less than ideal, but I think it's okay if time-warp is only loaded when running tests.","merged_at":null,"issue_url":"https://github.com/harvesthq/time-warp/issues/2","review_comments":0,"html_url":"https://github.com/harvesthq/time-warp/pull/2","_links":{"comments":{"href":"https://api.github.com/repos/harvesthq/time-warp/issues/2/comments"},"html":{"href":"https://github.com/harvesthq/time-warp/pull/2"},"review_comments":{"href":"https://api.github.com/repos/harvesthq/time-warp/pulls/2/comments"},"self":{"href":"https://api.github.com/repos/harvesthq/time-warp/pulls/2"}},"title":"Fix issues with using date library under ruby 1.9.3","number":2,"mergeable":null,"id":471379,"changed_files":5,"patch_url":"https://github.com/harvesthq/time-warp/pull/2.patch","created_at":"2011-11-07T22:31:49Z"},"action":"opened","number":2}