{"comment":{"created_at":"2011-10-13T10:32:13Z","body":"Hey everyone,\n\nI will implement the ExperimentTableModel tonight as well as adding some other extra getter/setters method. Will push the changes tonight or sometime tomorrow morning. Cheers.\n\n\n________________________________\nFrom: ash3190 &lt;reply@reply.github.com&gt;\nTo: bcbc66822 &lt;bcbc66822@yahoo.com&gt;\nSent: Thursday, 13 October 2011 3:33 PM\nSubject: Re: [sheepmethane] Integrate ExperimentTableModel with the Experiment class (#28)\n\nhi james,\n\nwhat Bowie needs to add i think is setItime1 and setItime2 methods in the experiment.java table.. As for accouting for the new column i modified the importWizardExperimentsDescriptor to import the number of minutes the chamber was on by adding the line:\n\nexperiments[i].setTimeChamberOn(myModel.getMinutes(i));\n\nAs for now i have left the following commented.\n\n//experiments[i].setITime1(myModel.getITime1(i));\n//experiments[i].setITime2(myModel.getITime2(i));\n\n-- \nReply to this email directly or view it on GitHub:\nhttps://github.com/jamesnelson/sheepmethane/issues/28#issuecomment-2392032","updated_at":"2011-10-13T10:32:13Z","url":"https://api.github.com/repos/jamesnelson/sheepmethane/issues/comments/2393311","id":2393311,"user":{"avatar_url":"https://secure.gravatar.com/avatar/5fda23dd48bfdd158955fcd40f7fc5d8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/bcbc66822","id":975998,"login":"bcbc66822"}},"action":"created","issue":{"number":28,"created_at":"2011-10-11T17:21:21Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"The following lines in ImportWizardExperimentsDescriptor need to be uncommented and fixed. They should take the data that is available in the Experiments table from the ExperimentTableModel class (which should be fairly self explanatory), and put that data into individual experiment instances.\r\n\r\nSInce Bowie knows the Experiment class better than I do, it would probably be best if you did this. You may want to change the ExperimentTableModel class to do so, I'm not sure yet. \r\n \r\n//experiments[i].setITime1(myModel.getITime1(i));\r\n//experiments[i].setITime2(myModel.getITime2(i));\r\n//experiments[i].setChamberStandardCorrelation(myModel.getChamberStandard(i));\r\n//experiments[i].setAmbientStandardCorrelation(myModel.getAmbientStandard(i));","comments":3,"title":"Integrate ExperimentTableModel with the Experiment class","updated_at":"2011-10-13T10:32:13Z","url":"https://api.github.com/repos/jamesnelson/sheepmethane/issues/28","id":1878735,"assignee":{"avatar_url":"https://secure.gravatar.com/avatar/5fda23dd48bfdd158955fcd40f7fc5d8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/bcbc66822","id":975998,"login":"bcbc66822"},"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/4bbcd39c9fe667dedb5c47aa4bec7d5a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/jamesnelson","id":161707,"login":"jamesnelson"},"html_url":"https://github.com/jamesnelson/sheepmethane/issues/28","labels":[],"state":"open"},"legacy":{"issue_id":1878735,"comment_id":2393311}}