{"comment":{"created_at":"2011-10-18T06:54:07Z","body":"Woa, happy to hear that! :-)\n\nI might do more contributions in the near future, but not sure yet. \nI've a small contribution ready already on my github (some additional \ndoc comments), but I'll wait until I've added more docs than that.\n\nBtw, did I break that test you fixed? Oops!\n\nOn 17.10.2011 17:58, José F. Romaniello wrote:\n> I merged your changes! thank you very much for all your \n> contributions.\n> I also pushed a new version to nuget, let me know any other feedback, \n> stay\n> in touch.\n>\n> 2011/10/8 Egbert Teeselink <\n> reply@reply.github.com>\n>\n>> Hm, then I must've mailed to some wrong address. I'll look it up at \n>> work\n>> on monday.\n>>\n>> MIT looks fine. If you'd care to publish it on the github repos, \n>> I'll\n>> probably end up using Anna for a small project at work.\n>>\n>> Thanks for the little heads-up on the process. Looks like I did all \n>> that,\n>> except for the feature branch. Will do that in the future.\n>>\n>> Egbert\n>>\n>> On Sat, 08 Oct 2011 20:25:21 +0200, Jos F. Romaniello\n>> <reply@reply.github.com>\n>> wrote:\n>>\n>> > I don't remember to read any mail about the license... I guess MIT\n>> > http://www.opensource.org/licenses/mit-license.php will be okay, \n>> but if\n>> > you\n>> > need any other kind of license type just let me know. This started \n>> as an\n>> > experiment and I can adopt anything.\n>> >\n>> > About collaborating in github I am new too , but the recommended\n>> > approach is\n>> > to:\n>> >\n>> >\n>> >    - pull\n>> >    - open a branch for the new feature you will work on\n>> >    - commit, commit, work rever,t commit, etc, etc..\n>> >    - PUSH with the branch opened..\n>> >\n>> >\n>> > And then i will pull and merge your branch.\n>> >\n>> > But this time do not worried at all.\n>> >\n>> >\n>> > 2011/10/8 Egbert Teeselink <\n>> > reply@reply.github.com>\n>> >\n>> >> Hi Jos!\n>> >>\n>> >> Cool to hear that! :-) No rush, btw.\n>> >>\n>> >> That said, did you by any chance get that other email I sent you \n>> about\n>> >> Anna's license?\n>> >>\n>> >> Egbert\n>> >>\n>> >> --\n>> >> Reply to this email directly or view it on GitHub:\n>> >> https://github.com/jfromaniello/Anna/pull/1#issuecomment-2332702\n>> >>\n>>\n>> --\n>> Reply to this email directly or view it on GitHub:\n>> https://github.com/jfromaniello/Anna/pull/1#issuecomment-2333351\n>>","updated_at":"2011-10-18T06:54:07Z","url":"https://api.github.com/repos/jfromaniello/Anna/issues/comments/2438622","id":2438622,"user":{"avatar_url":"https://secure.gravatar.com/avatar/eae25ee5e8427193dd35db2267e45534?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"eae25ee5e8427193dd35db2267e45534","url":"https://api.github.com/users/eteeselink","id":703546,"login":"eteeselink"}},"action":"created","issue":{"number":1,"created_at":"2011-10-08T15:26:22Z","pull_request":{"diff_url":"https://github.com/jfromaniello/Anna/pull/1.diff","patch_url":"https://github.com/jfromaniello/Anna/pull/1.patch","html_url":"https://github.com/jfromaniello/Anna/pull/1"},"body":"Hi Jose,\r\n\r\nI really like Anna, so I spent some saturday time on hacking on it. Things I added / changed:\r\n\r\n* I added a `GetBody()` method to `Request`, which asynchronously reads the input stream into a string (in a single go, so not very suited for large uploads, but very handy for HTML form posts and RESTful APIs and the likes). I guess it can be improved a lot, but hey, it's a start.\r\n* I must admit that I didn't really like the way responses were implemented, with the implicit conversions and all: these are very difficult to discover from the IDE. You need to read examples or the source to see how to use it. So I rewrote it to simple methods on `RequestContext`.\r\n  * I added a `Send` method to the `Response` class. Advantage is that logically, I believe that this code should be local to the class. Disadvantage is that now Response has a dependency on RequestContext (which is passed through its constructor).\r\n  * I added some overloaded factory methods called `Response` and `StaticFileResponse` that create the right response object based on the parameter types. Users can thus call e.g. `context.Response(\"moo\").Send()`\r\n  * Changed some `Respond` methods so that they take literal strings and ints instead of implicitly converted `Response` objects, so that they are discoverable from the IDE.\r\n  * Removed the implicit conversions\r\n  * Result is that a user has the same options as before, but can type `context.` and a drop-down with all the different ways to create responses is shown by the IDE.\r\n* Added some doc comments here and there, plus a simple readme with an example\r\n\r\nNo idea whether you're open to this at all. Curious to see what you think!","comments":7,"title":"OMG open source contributions!","updated_at":"2011-10-18T06:54:07Z","url":"https://api.github.com/repos/jfromaniello/Anna/issues/1","id":1852705,"assignee":null,"milestone":null,"closed_at":"2011-10-17T15:33:00Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/eae25ee5e8427193dd35db2267e45534?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"eae25ee5e8427193dd35db2267e45534","url":"https://api.github.com/users/eteeselink","id":703546,"login":"eteeselink"},"html_url":"https://github.com/jfromaniello/Anna/issues/1","labels":[],"state":"closed"},"legacy":{"issue_id":1852705,"comment_id":2438622}}