{"issue":{"created_at":"2011-11-25T12:01:22Z","state":"open","updated_at":"2011-11-27T19:21:57Z","comments":5,"user":{"gravatar_id":"250d821c3104dc1ea311743ea100cc5a","id":88083,"url":"https://api.github.com/users/mikek","login":"mikek","avatar_url":"https://secure.gravatar.com/avatar/250d821c3104dc1ea311743ea100cc5a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"`set([doc_id], data, callback[, attachments=None])` has a really strange signature. It is the only method in trombi, which has first optional positional argument. Arguments parsing is manual (which can be then simplified). The real reason to change it, however, is inability to pass *callback* keyword argument. This does not allow to use [tornado.gen](http://www.tornadoweb.org/documentation/gen.html) to simplify asynchronous code.\r\nI guess it can't be handled without changing method's signature and breaking existing code. At least the first argument would become required: `set(doc_id, data, callback[, attachments=None])`.\r\nPlease, let me know if there is a clean way to get around this particular issue.","assignee":null,"number":34,"id":2348769,"labels":[],"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"title":"Change Database.set() signature","closed_at":null,"html_url":"https://github.com/inoi/trombi/issues/34","milestone":null,"url":"https://api.github.com/repos/inoi/trombi/issues/34"},"action":"created","comment":{"created_at":"2011-11-27T19:21:57Z","updated_at":"2011-11-27T19:21:57Z","user":{"gravatar_id":"7eb570f10c31357bd86b16251be8e99e","id":70927,"url":"https://api.github.com/users/akheron","login":"akheron","avatar_url":"https://secure.gravatar.com/avatar/7eb570f10c31357bd86b16251be8e99e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"The proposed error message is bad. If called with e.g. `set(a, b, c, callback=d)`, the error message is 'Database.set is missing callback argument'.","id":2889450,"url":"https://api.github.com/repos/inoi/trombi/issues/comments/2889450"}}