{"issue":{"state":"open","created_at":"2011-09-27T13:42:07Z","updated_at":"2011-11-22T23:48:45Z","user":{"gravatar_id":"de8a89bed43a77f5bc76451f101e36a3","id":799732,"url":"https://api.github.com/users/xelj","login":"xelj","avatar_url":"https://secure.gravatar.com/avatar/de8a89bed43a77f5bc76451f101e36a3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":1,"body":"Questor is not checked the mission before going to the agent. Pick-up station was lowsec, questor declined it after arriving to the agent and then again trying to get mission from storyline agent, agent says that there is no mission, and  questor stops.\r\nlog:\r\n--------------------------------------------------------------------------------------\r\n\r\n Questor: Random mission start delay of [0] seconds\r\n Questor: Storyline detected, doing storyline.\r\n Storyline: Going to do [Transaction Data Delivery] for agent [xxxxxx]\r\n TransactionDataDelivery: Switching to shuttle\r\n Traveler.StationDestination: Destination set to [xxxxxx]\r\n Traveler: Setting destination to [xxxxxx]\r\n Traveler: Warping to [Stargate (xxxxxx)]\r\n Traveler: Jumping to [xxxxxx]\r\n Traveler: Warping to [Stargate (xxxxxx)]\r\n Traveler: Jumping to [xxxxxx]\r\n Traveler.StationDestination: Warp to and dock at [xxxxxx]\r\n Traveler.StationDestination: Arrived in station\r\n AgentInteraction: Start conversation [Start Mission]\r\n AgentInteraction: Waiting for conversation\r\n AgentInteraction: Replying to agent\r\n AgentInteraction: Waiting for mission\r\n AgentInteraction: Faction fitting Default\r\n AgentInteraction: Declining low-sec mission\r\n AgentInteraction: Saying [Decline]\r\n AgentInteraction: Replying to agent\r\n\r\n--------------------------------------------------------------------------------------\r\nAnd after that questor stopped","assignee":null,"id":1752072,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[],"number":59,"title":"Transaction Data Delivery issue again","closed_at":null,"html_url":"https://github.com/Da-Teach/Questor/issues/59","milestone":null,"url":"https://api.github.com/repos/Da-Teach/Questor/issues/59"},"action":"created","comment":{"created_at":"2011-11-22T23:48:45Z","updated_at":"2011-11-22T23:48:45Z","user":{"gravatar_id":"6822228e05572460e59ee6e073f17230","id":1205530,"url":"https://api.github.com/users/ISeeDEDPpl","login":"ISeeDEDPpl","avatar_url":"https://secure.gravatar.com/avatar/6822228e05572460e59ee6e073f17230?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"This is not an issue specific to that storyline. \r\nThe problem seems to be that the same \"decline\" mechanism is being used for regular and storyline missions, but I don't think they use the same mechanism. \r\n\r\nManually clicking \"decline\" has no effect for storyline missions from what I have seen. I had to manually right click the entry in the journal and choose the option to decline/remove from journal (not sure of the exact verbage)\r\n\r\nI would imagine the most correct fix to be not to decline the mission at all, but to blacklist the agent like MaterialsForWarPreperation.cs does. \r\n\r\n                // No, black list the agent in this Questor session (note we will never decline storylines!)\r\n                return StorylineState.BlacklistAgent;\r\n\r\nLooking at storyline.cs It is unclear to me where to shoe horn it in...  AgentInteraction.cs or Storyline.cs likely...\r\n\r\nMy guess would be that this is rarely hit because questors  are mission'ing further from low sec. \r\n","id":2842807,"url":"https://api.github.com/repos/Da-Teach/Questor/issues/comments/2842807"}}