{"issue":{"created_at":"2011-12-07T16:17:35Z","state":"open","updated_at":"2011-12-07T23:41:42Z","comments":26,"user":{"gravatar_id":"2949e4409c0452a11b9fdff071b927f4","id":123766,"url":"https://api.github.com/users/maxxx","login":"maxxx","avatar_url":"https://secure.gravatar.com/avatar/2949e4409c0452a11b9fdff071b927f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"problematic block in code:\r\n\r\n```cpp\r\nbool Unit::IsImmunedToSpell(SpellInfo const* spellInfo)\r\n...\r\n    for (int i = 0; i < MAX_SPELL_EFFECTS; ++i)\r\n    {\r\n        // State/effect immunities applied by aura expect full spell immunity\r\n        // Ignore effects with mechanic, they are supposed to be checked separately\r\n        if (!spellInfo->Effects[i].Mechanic)\r\n\t\t{\r\n                       if (IsImmunedToSpellEffect(spellInfo, i))\r\n\t\t\t\treturn true;\r\n\t\t}\r\n    }\r\n...\r\n```\r\nHere if unit is immune to 1 effect - he is immune to whole spell, it's wrong. Example:\r\nhttp://www.wowhead.com/spell=62308 of ulduar demolishers VS Flame Leviathan - now Leviathan is immuned to knockback AND damage, should be only knockback effect.\r\nP.S. there was a similar issue, can't find it.\r\n\r\nrev https://github.com/TrinityCore/TrinityCore/commit/f5b3553bb3e6cf9d055cfdc7f230e3ddaeea559b\r\n","assignee":null,"id":2476390,"number":4212,"labels":[],"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"title":"problem with spells immunity system","html_url":"https://github.com/TrinityCore/TrinityCore/issues/4212","closed_at":null,"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/4212","milestone":null},"action":"created","comment":{"created_at":"2011-12-07T23:41:42Z","updated_at":"2011-12-07T23:41:42Z","user":{"gravatar_id":"7a4b36ccc8adce725330fd3857bfaf47","id":930757,"url":"https://api.github.com/users/kandera","login":"kandera","avatar_url":"https://secure.gravatar.com/avatar/7a4b36ccc8adce725330fd3857bfaf47?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"yea yours seems right sorry im really tired lol","id":3055538,"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/3055538"}}