{"issue":{"state":"closed","created_at":"2011-12-01T19:56:06Z","updated_at":"2011-12-02T11:35:54Z","comments":2,"user":{"gravatar_id":"d2c548441b9dfd8db6eff7e9f4041184","id":547637,"url":"https://api.github.com/users/digitall","avatar_url":"https://secure.gravatar.com/avatar/d2c548441b9dfd8db6eff7e9f4041184?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"digitall"},"body":"These commits add functionality to the tasm-recover tool to allow a function name mapping to be added. \r\n\r\nThis is then used to map the ASM style lower case functions of dreamgen.* to the project standard camelCase style. This makes the dreamweb code more as per project standards and significantly improves ease of reading i.e. manasleep() -> manAsleep().\r\n\r\nAlso, due to the dependencies on dreamgen.* function API, most of the other source files have also been stuck with all lower case ASM style namings, but this is now relaxed and in order to restore compilation etc., these are renamed camelCase.\r\n\r\nThough not implemented here, this also allows the function remapping to be adjusted in tasm-recover script and the generation rerun to expand various truncated namings (assumed due to character size limit of ASM labels) i.e. exobject() -> examineObject() etc. to improve readability further.\r\n\r\nP.S. Since this is quite an extensive change, I would like to merge this fairly quickly to avoid any significant merge conflicts with tramboi's work going forward, so if we can avoid arguments over the remapping which is currently 99% just to change the name to camelCase as this can be changed later to a fuller readable function name expansion, but this is better done more piecewise after the basic foundation is merged.\r\n\r\nI will leave this for tramboi to merge...","assignee":null,"id":2418973,"labels":[],"pull_request":{"patch_url":"https://github.com/scummvm/scummvm/pull/123.patch","html_url":"https://github.com/scummvm/scummvm/pull/123","diff_url":"https://github.com/scummvm/scummvm/pull/123.diff"},"number":123,"title":"Add Function Name Remapping to tasm-recover tool...","closed_at":"2011-12-01T20:35:15Z","html_url":"https://github.com/scummvm/scummvm/issues/123","url":"https://api.github.com/repos/scummvm/scummvm/issues/123","milestone":null},"action":"created","comment":{"created_at":"2011-12-02T11:35:54Z","updated_at":"2011-12-02T11:35:54Z","user":{"gravatar_id":"42a1f4b42ab4d401e5c8b969b268b128","id":307562,"url":"https://api.github.com/users/tramboi","avatar_url":"https://secure.gravatar.com/avatar/42a1f4b42ab4d401e5c8b969b268b128?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"tramboi"},"body":"Thanks for all the remapping, by the way, this was grunt work and it makes the code much more pleasant.\r\n","id":2989049,"url":"https://api.github.com/repos/scummvm/scummvm/issues/comments/2989049"}}