{"issue":{"state":"open","pull_request":{"diff_url":"https://github.com/mjpieters/setuptools_subversion/pull/2.diff","html_url":"https://github.com/mjpieters/setuptools_subversion/pull/2","patch_url":"https://github.com/mjpieters/setuptools_subversion/pull/2.patch"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/e0dae3b36598f2b55e86fe1e906497a5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e0dae3b36598f2b55e86fe1e906497a5","url":"https://api.github.com/users/mauritsvanrees","login":"mauritsvanrees","id":210587},"milestone":null,"updated_at":"2011-11-09T21:05:53Z","labels":[],"assignee":null,"closed_at":null,"comments":1,"url":"https://api.github.com/repos/mjpieters/setuptools_subversion/issues/2","body":"Hi Martijn,\r\n\r\nWith setuptools_subversion 1.4 I get an error when doing 'python2.4 setup.py sdist'::\r\n\r\n<pre>\r\n    File \"/Users/mauritsvanrees/src/git/setuptools_subversion/setuptools_subversion.py\", line 39, in listfiles\r\n      return [f for f in files.splitlines() if not f.endswith(('/', os.sep))]\r\n  TypeError: expected a character buffer object\r\n</pre>\r\n\r\nThis is because string.endswith does not accept a tuple (like python 2.5+ does).  A tuple actually seems unneeded here, as checking for endswith(os.sep) should be enough.\r\n\r\nKeeping compatibility with python 2.4 seems an uphill battle for tools like this, though this change is easy enough.  I know: it's about time I let python2.6 or 2.7 be my standard python.  I actually came across this error when I was preparing exactly that move. :-)\r\n\r\nCheers,\r\n\r\nMaurits","html_url":"https://github.com/mjpieters/setuptools_subversion/issues/2","title":"Fix python 2.4 compatibility again","number":2,"id":2173512,"created_at":"2011-11-08T11:56:00Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/09c1bb74564cba5aa5e1005e869499d4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"09c1bb74564cba5aa5e1005e869499d4","url":"https://api.github.com/users/mjpieters","login":"mjpieters","id":46775},"updated_at":"2011-11-09T21:05:53Z","url":"https://api.github.com/repos/mjpieters/setuptools_subversion/issues/comments/2687294","body":"We'll assume that svn on Windows indeed uses the '\\' separator, and just merge. :-)","id":2687294,"created_at":"2011-11-09T21:05:53Z"}}