{"issue":{"pull_request":{"diff_url":"https://github.com/mininet/mininet/pull/4.diff","html_url":"https://github.com/mininet/mininet/pull/4","patch_url":"https://github.com/mininet/mininet/pull/4.patch"},"state":"open","user":{"avatar_url":"https://secure.gravatar.com/avatar/78f1760e8d61d8e922ff98fbf84a8145?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"78f1760e8d61d8e922ff98fbf84a8145","url":"https://api.github.com/users/lantz","login":"lantz","id":744379},"milestone":null,"updated_at":"2011-10-27T22:18:32Z","labels":[],"assignee":null,"comments":3,"closed_at":null,"url":"https://api.github.com/repos/mininet/mininet/issues/4","body":"This is something I did a while back for Saurav, and which also seems to be in use by Big Switch. \r\n\r\nIt seems to pass our (very limited) tests, but was never merged into mainline, so I'm requesting a review.","html_url":"https://github.com/mininet/mininet/issues/4","title":"User OVS support","number":4,"id":2052444,"created_at":"2011-10-26T01:48:31Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/84ea60ea59605cfe1e5d180c8bb40d3a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"84ea60ea59605cfe1e5d180c8bb40d3a","url":"https://api.github.com/users/brandonheller","login":"brandonheller","id":82859},"updated_at":"2011-10-27T22:18:32Z","url":"https://api.github.com/repos/mininet/mininet/issues/comments/2550240","body":"On Thu, Oct 27, 2011 at 3:06 PM, Bob <\nreply@reply.github.com>wrote:\n\n> Hmm... but those were the actual commits I made; if you change them, then\n> it's kind of lying about what actually happened, isn't it? I guess there's a\n> trade-off between making a single patch vs. keeping the (potentially\n> interesting) actual revision history?\n>\n\nYou're sending a pull request, so the code isn't in the official repository\nyet - it's not lying in any way.  Ask yourself: is having a \"halfway\nimplemented\" commit ever going to be useful?  I don't think so.\n\nAnd yes, I fully realize that such cleanup doesn't change the end code.  But\nif you let half-done commits into the codebase, that's just lazy, and it\nleads to plenty of useless commits in the history.  When you're coding, it\nmakes sense to have smaller commits, but when you're ready to push it seems\nworth a minute to clean things.\n\n\n> On Oct 27, 2011, at 2:49 PM, Brandon Heller wrote:\n>\n> > Bob, I looked at all these, and they seem pretty reasonable, and near\n> ready to commit.  But, it would be nice if the commits could be more\n> sensibly packaged into atomic stuff.  For example, the first 4 commits plus\n> the last one would make a nice 'Add user-mode Open vSwitch\" commit.\n>  Interactive git rebase makes squashing and reordering easy - for example,\n> from this branch, you would do 'git rebase -i HEAD~8', move the last one up,\n> and set the 2nd through 5th commits to 's' for squash.  Yes, this is\n> pedantic, but the more you do this the easier it gets, to where future code\n> reviews should go by more easily.\n> >\n> > --\n> > Reply to this email directly or view it on GitHub:\n> > https://github.com/mininet/mininet/pull/4#issuecomment-2549938\n>\n> --\n> Reply to this email directly or view it on GitHub:\n> https://github.com/mininet/mininet/pull/4#issuecomment-2550104\n>","id":2550240,"created_at":"2011-10-27T22:18:32Z"}}