{"comment":{"created_at":"2011-10-17T20:02:43Z","body":"Great, that's better.  Now, the fix looks good, but in all such cases it's a good idea to add also a test that fails when the fix is not in place but passes once the fix is in.  This will ensure that the problem doesn't recur in the future.  You don't need to write up a new file, you can simply add a new test to the existing test_inputsplitter.py.\r\n\r\nWith a small test as indicated above, this will be good to go.  Thanks a lot!","updated_at":"2011-10-17T20:02:43Z","url":"https://api.github.com/repos/ipython/ipython/issues/comments/2433994","id":2433994,"user":{"gravatar_id":"95198572b00e5fbcd97fb5315215bf7a","avatar_url":"https://secure.gravatar.com/avatar/95198572b00e5fbcd97fb5315215bf7a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/fperez","id":57394,"login":"fperez"}},"action":"created","issue":{"number":877,"created_at":"2011-10-14T22:36:48Z","pull_request":{"diff_url":"https://github.com/ipython/ipython/pull/877.diff","patch_url":"https://github.com/ipython/ipython/pull/877.patch","html_url":"https://github.com/ipython/ipython/pull/877"},"body":"partial fix for issue #678\r\n\r\nThe patch handles the case of:\r\n\r\n```\r\nIn [4]: >>> a = [1,\r\n   ...: ... 2]\r\n\r\nIn [5]: a\r\nOut[5]: [1, 2]\r\n```\r\n\r\nbut not\r\n\r\n```\r\nIn [3]: >>> a = [1\r\n   ...: ... ,2]\r\n  File \"<ipython-input-3-5b39dccea2ae>\", line 2\r\n    ... ,2]\r\n     ^\r\nSyntaxError: invalid syntax\r\n```\r\n\r\nwhich happens to be valid in python.","comments":4,"title":"partial fix for issue #678","updated_at":"2011-10-17T20:02:43Z","url":"https://api.github.com/repos/ipython/ipython/issues/877","id":1914777,"assignee":null,"milestone":null,"closed_at":null,"user":{"gravatar_id":"8f1ba17d04fd58bacdca8368ec38d3b3","avatar_url":"https://secure.gravatar.com/avatar/8f1ba17d04fd58bacdca8368ec38d3b3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/djv","id":263148,"login":"djv"},"html_url":"https://github.com/ipython/ipython/issues/877","labels":[],"state":"open"},"legacy":{"issue_id":1914777,"comment_id":2433994}}