{"issue":{"created_at":"2011-11-28T18:30:09Z","state":"open","updated_at":"2011-12-12T17:07:38Z","user":{"gravatar_id":"a405b0317d210a8e142f4a45363e6942","id":621068,"url":"https://api.github.com/users/cricri","avatar_url":"https://secure.gravatar.com/avatar/a405b0317d210a8e142f4a45363e6942?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"cricri"},"comments":6,"body":"cancelAll cancels all the queries (active+queue)\r\ncancelActiveQuery cancel the running query, if any\r\n\r\nI will update the wiki for cancel, and for these two methods (if you accept the request)","assignee":null,"id":2371622,"labels":[],"pull_request":{"patch_url":"https://github.com/brianc/node-postgres/pull/75.patch","html_url":"https://github.com/brianc/node-postgres/pull/75","diff_url":"https://github.com/brianc/node-postgres/pull/75.diff"},"number":75,"title":"cancelAll, cancelActiveQuery methods","html_url":"https://github.com/brianc/node-postgres/issues/75","closed_at":null,"url":"https://api.github.com/repos/brianc/node-postgres/issues/75","milestone":null},"action":"created","comment":{"created_at":"2011-12-12T17:07:38Z","updated_at":"2011-12-12T17:07:38Z","user":{"gravatar_id":"828ea77c9537e7e0832826f11310c744","id":50081,"url":"https://api.github.com/users/brianc","avatar_url":"https://secure.gravatar.com/avatar/828ea77c9537e7e0832826f11310c744?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"brianc"},"body":"I apologize for being AWOL...for some reason github stopped giving me email notifications on issue & pull request comments.    I'll get back to you later today on this, but at first glance I prefer to keep the methods on the __Client__ limited to the bare minimum needed to get the job done.  I definitely like the ability for a __Client__ to send a cancel method, but making decisions on _how_ the message is sent should be left up to the user. i.e. reserving a 'cancel spot' in the pool, deciding on emptying out the queryQueue, etc.\r\n\r\nAnything higher level such as cancelAll and cancelActive could be implemented in _userland_.  The less surface area on __Client__ the better because it leaves it less opinionated and less open to bugs. \r\n\r\nI'm not totally familiar with the 'message flow' for canceling queries yet.  I'll read up on it, but my initial reaction is I am not a fan of _helper methods_ or shortcutty type things with node-postgres.  ","id":3108943,"url":"https://api.github.com/repos/brianc/node-postgres/issues/comments/3108943"}}