{"issue":{"milestone":null,"user":{"id":311929,"login":"kracekumar","url":"https://api.github.com/users/kracekumar","avatar_url":"https://secure.gravatar.com/avatar/c7053afe0a49a03b39ecfaa2bd389926?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"c7053afe0a49a03b39ecfaa2bd389926"},"created_at":"2011-12-06T16:15:38Z","title":"Twython now runs on python-requests","updated_at":"2011-12-18T00:32:24Z","labels":[],"state":"closed","id":2463992,"html_url":"https://github.com/ryanmcgrath/twython/issues/51","closed_at":"2011-12-18T00:32:24Z","pull_request":{"patch_url":"https://github.com/ryanmcgrath/twython/pull/51.patch","html_url":"https://github.com/ryanmcgrath/twython/pull/51","diff_url":"https://github.com/ryanmcgrath/twython/pull/51.diff"},"body":"I have implemented twython api's using requests. I have added two new file\r\n1.twythonrequests.py => twython implementation using requests, Twython class is re implemented and api names are maintained.\r\n2.tests.py =>unit tests for twythonrequests","number":51,"url":"https://api.github.com/repos/ryanmcgrath/twython/issues/51","comments":1,"assignee":null},"comment":{"user":{"id":22712,"login":"ryanmcgrath","url":"https://api.github.com/users/ryanmcgrath","avatar_url":"https://secure.gravatar.com/avatar/407b466d7290c6a7cebd0df1dde97ebd?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"407b466d7290c6a7cebd0df1dde97ebd"},"created_at":"2011-12-18T00:32:24Z","updated_at":"2011-12-18T00:32:24Z","id":3192456,"body":"Hey!\r\n\r\nFirst, I'd like to apologize for taking so long here... came down with a bad case of Mono that knocked me out for like two weeks. Far, far less than ideal.\r\n\r\nI like the idea of swapping out `httplib2` with `requests`, but I'm curious about a few things:\r\n\r\n- Why is this done in a separate file? Let's go ahead and bite the bullet and just modify the current twython.py file to be requests-based instead.\r\n- `shortenURL` is something I'd like to keep around for all people who've possibly used it in the past; it uses is.gd's API, so it's not like it's much overhead to keep around anyway.\r\n- This currently isn't a clean merge, and I wasn't able to actually run with it. Looking over it, I'm happy with the general approach, but can we get it a little more aligned with the current state of the library?\r\n- Minor note, but `line 127` of `twythonrequests.py` has an incorrect spelling for a function call. How did this pass tests? XD\r\n\r\nDefinitely happy to work with you and get this done, but would like it done right. Let me know if there's anything I can help out with.","url":"https://api.github.com/repos/ryanmcgrath/twython/issues/comments/3192456"},"action":"created"}