{"action":"closed","pull_request":{"created_at":"2011-11-21T01:09:52Z","state":"closed","review_comments":0,"patch_url":"https://github.com/pecan/pecan/pull/34.patch","updated_at":"2011-11-21T04:39:52Z","changed_files":2,"_links":{"review_comments":{"href":"https://api.github.com/repos/pecan/pecan/pulls/34/comments"},"comments":{"href":"https://api.github.com/repos/pecan/pecan/issues/34/comments"},"html":{"href":"https://github.com/pecan/pecan/pull/34"},"self":{"href":"https://api.github.com/repos/pecan/pecan/pulls/34"}},"comments":2,"user":{"gravatar_id":"bb9cdb23b5f0aab1c4ace6dfc3cb41a7","id":317847,"url":"https://api.github.com/users/alfredodeza","login":"alfredodeza","avatar_url":"https://secure.gravatar.com/avatar/bb9cdb23b5f0aab1c4ace6dfc3cb41a7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"issue_url":"https://github.com/pecan/pecan/issues/34","deletions":0,"body":"I was working with the conf module from Pecan and had the need to do `conf.get('my_option')` because this is something that a user might or might not add to my application configuration.\r\n\r\nI wanted to avoid doing something like this to circumvent the problem:\r\n\r\n    my_option = getattr(conf, 'my_option', None)\r\n\r\nSince `conf` is a dict-like module, it makes sense to be able to expose something like `conf.get`. \r\n\r\nThis pull request is tested in `tests.test_conf.py`\r\n\r\nDidn't think we should document this as `conf` is already reported as a dict-like object. But if the merge of this pull request warrants it, I can definitely add a few lines to explain it.\r\n\r\nThis pull request behaves more like a regular Python dict `get` (thanks Ryan). Somehow I missed out on the default behavior.\r\n\r\nI also added a test for the new default feature.","merged":true,"commits":3,"mergeable":null,"additions":17,"id":513045,"base":{"user":{"gravatar_id":"bd03eb8caa27253ec68de37e73c77c3a","id":654177,"url":"https://api.github.com/users/pecan","login":"pecan","avatar_url":"https://secure.gravatar.com/avatar/bd03eb8caa27253ec68de37e73c77c3a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"repo":{"created_at":"2011-03-06T17:04:08Z","pushed_at":"2011-11-21T04:39:51Z","clone_url":"https://github.com/pecan/pecan.git","private":false,"updated_at":"2011-11-21T04:39:51Z","name":"pecan","watchers":33,"master_branch":null,"svn_url":"https://svn.github.com/pecan/pecan","language":"Python","forks":11,"owner":{"gravatar_id":"bd03eb8caa27253ec68de37e73c77c3a","id":654177,"url":"https://api.github.com/users/pecan","login":"pecan","avatar_url":"https://secure.gravatar.com/avatar/bd03eb8caa27253ec68de37e73c77c3a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":1446867,"homepage":"http://www.pecanpy.org","description":"A WSGI object-dispatching web framework, designed to be lean and fast, with few dependencies.","git_url":"git://github.com/pecan/pecan.git","html_url":"https://github.com/pecan/pecan","url":"https://api.github.com/repos/pecan/pecan","size":272,"fork":false,"ssh_url":"git@github.com:pecan/pecan.git","open_issues":11},"sha":"b1063f441df1897da0530bccef2334de45cf57e3","ref":"master","label":"pecan:master"},"merged_by":{"gravatar_id":"52e23419f12efa3945163281e79a1c74","id":214912,"url":"https://api.github.com/users/ryanpetrello","login":"ryanpetrello","avatar_url":"https://secure.gravatar.com/avatar/52e23419f12efa3945163281e79a1c74?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"number":34,"head":{"user":{"gravatar_id":"bb9cdb23b5f0aab1c4ace6dfc3cb41a7","id":317847,"url":"https://api.github.com/users/alfredodeza","login":"alfredodeza","avatar_url":"https://secure.gravatar.com/avatar/bb9cdb23b5f0aab1c4ace6dfc3cb41a7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"repo":{"created_at":"2011-06-24T18:25:20Z","pushed_at":"2011-11-21T01:03:22Z","clone_url":"https://github.com/alfredodeza/pecan.git","private":false,"updated_at":"2011-11-21T01:03:22Z","name":"pecan","watchers":1,"master_branch":null,"svn_url":"https://svn.github.com/alfredodeza/pecan","language":"Python","forks":0,"owner":{"gravatar_id":"bb9cdb23b5f0aab1c4ace6dfc3cb41a7","id":317847,"url":"https://api.github.com/users/alfredodeza","login":"alfredodeza","avatar_url":"https://secure.gravatar.com/avatar/bb9cdb23b5f0aab1c4ace6dfc3cb41a7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"id":1949042,"homepage":"http://www.pecanpy.org","description":"A WSGI object-dispatching web framework, designed to be lean and fast, with few dependancies.","git_url":"git://github.com/alfredodeza/pecan.git","html_url":"https://github.com/alfredodeza/pecan","url":"https://api.github.com/repos/alfredodeza/pecan","size":120,"fork":true,"ssh_url":"git@github.com:alfredodeza/pecan.git","open_issues":0},"sha":"929ae981d5dfe41dac59f4c90eb3eae7eae066c7","ref":"config_get","label":"alfredodeza:config_get"},"title":"Config get","closed_at":"2011-11-21T04:39:52Z","html_url":"https://github.com/pecan/pecan/pull/34","url":"https://api.github.com/repos/pecan/pecan/pulls/34","diff_url":"https://github.com/pecan/pecan/pull/34.diff","merged_at":"2011-11-21T04:39:51Z"},"number":34}