{"issue":{"state":"open","pull_request":{"diff_url":"https://github.com/quicksilver/Quicksilver/pull/479.diff","html_url":"https://github.com/quicksilver/Quicksilver/pull/479","patch_url":"https://github.com/quicksilver/Quicksilver/pull/479.patch"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/5d56aaff81930773754aeae46670681a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"5d56aaff81930773754aeae46670681a","url":"https://api.github.com/users/skurfer","login":"skurfer","id":154676},"milestone":null,"updated_at":"2011-10-27T21:35:11Z","labels":[],"assignee":null,"comments":22,"closed_at":null,"url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/479","body":"This implements everything discussed in #341\r\n\r\n  * The “Enable advanced features” item has been removed from the Command preferences\r\n  * Proxy Objects are enabled by default\r\n  * “Pull selection from front application instead of Finder” is enabled by default\r\n  * All code that was conditional based on feature level has been made unconditional\r\n\r\nThat last one demands some elaboration. As a general rule, I searched the entire codebase for these strings and removed references to them.\r\n\r\n  * kItemFeatureLevel\r\n  * kFeatureLevel\r\n  * kCuttingEdgeFeatures\r\n  * betaLevel\r\n  * alphaLevel\r\n  * devLevel\r\n  * isRestricted\r\n  * fDEV\r\n  * fALPHA\r\n  * fBETA\r\n  * fSPECIAL\r\n  * meetsFeature\r\n\r\nIn some cases, this meant removing the `if` clause, making the code run all the time. In a few cases, it meant changing the condition to an `#ifdef DEBUG` instead. Please look them over.\r\n\r\nMost of this stuff is well tested at this point, as it would have been active for any user with advanced features enabled. The notable exceptions are `enableEntry` and `disableEntry` in `QSFileSystemObjectSource.m`. The (now removed) first line of these methods effectively prevented them from ever being called. Now that they’re active, they still have a limited scope. As you can see, they only affect catalog entries that have “watchTarget” or “watchPaths” set. There are a couple of presets that have this (like `~`, `/Applications/`, etc.) but that’s it. From some limited testing, the QSVoyeur stuff seems to work. Objects are immediately added and removed from the catalog as the filesystem is changed (which is pretty cool), so I’m going ahead with this pull request.\r\n\r\nOne final thing: The changes to the XIBs in 91224bcc were done with a text editor. I’m mostly lost in Interface Builder and could not find the references to alphaLevel anywhere. I haven’t experienced any problems with the change.","html_url":"https://github.com/quicksilver/Quicksilver/issues/479","number":479,"title":"Feature level","id":1610466,"created_at":"2011-09-09T19:00:40Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/055a25b1a0fab97ed35c6ec9cf690ab7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"055a25b1a0fab97ed35c6ec9cf690ab7","url":"https://api.github.com/users/pjrobertson","login":"pjrobertson","id":150431},"updated_at":"2011-10-27T21:35:11Z","url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/comments/2549765","body":"Dammit we really should have looked at this before doing all the plugins system stuff. Then we won't have needed to code all the PRE/DEV stuff into it.\r\n\r\nI've made changes to qs0/test/ so it should work with this build now.\r\n\r\nA few comments:\r\n\r\n* I still see release type stuff in the 'extras' preference pane\r\n\r\n...OK just done a search for @\"PRE\" and I see it still exists.\r\n\r\nLet me get this straight: have your changes JUST changed things to do with \"advanced features\" and have nothing to do with the 'final release' 'pre release' and 'developer release' settings?\r\nIf so - that's great! We don't need to change anything :D\r\n\r\n...OK now this is REALLY confusing me... are feature level and application update level completely different things?\r\n\r\nI've had a quick look through the code and it seems like this affects:\r\n\r\na) plugin & action loading (plugins can set the level for actions)\r\nb) Proxies\r\nc) a bit of catalog stuff you've mentioned","id":2549765,"created_at":"2011-10-27T21:35:11Z"}}