{"pull_request":{"user":{"id":203423,"login":"yabawock","url":"https://api.github.com/users/yabawock","gravatar_id":"c85dc89b5ca024dfd515bb4f3ddcac95","avatar_url":"https://secure.gravatar.com/avatar/c85dc89b5ca024dfd515bb4f3ddcac95?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"title":"Refactor the test suite for Rails 2.3 to 3.2","merged_at":"2011-12-21T16:49:20Z","created_at":"2011-12-21T08:59:09Z","review_comments":0,"updated_at":"2011-12-21T16:49:20Z","state":"closed","id":618265,"patch_url":"https://github.com/svenfuchs/routing-filter/pull/33.patch","closed_at":"2011-12-21T16:49:20Z","html_url":"https://github.com/svenfuchs/routing-filter/pull/33","deletions":243,"mergeable":null,"base":{"user":{"id":2208,"login":"svenfuchs","url":"https://api.github.com/users/svenfuchs","gravatar_id":"402602a60e500e85f2f5dc1ff3648ecb","avatar_url":"https://secure.gravatar.com/avatar/402602a60e500e85f2f5dc1ff3648ecb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"ref":"master","sha":"e367a692aebae1bceb93cfcc10f81ad2e9086757","repo":{"git_url":"git://github.com/svenfuchs/routing-filter.git","created_at":"2008-05-29T23:08:07Z","open_issues":14,"watchers":233,"fork":false,"updated_at":"2011-12-21T16:49:21Z","id":20620,"language":"Ruby","html_url":"https://github.com/svenfuchs/routing-filter","name":"routing-filter","description":"routing-filter wraps around the complex beast that the Rails routing system is, allowing for unseen flexibility and power in Rails URL recognition and generation.","master_branch":null,"url":"https://api.github.com/repos/svenfuchs/routing-filter","clone_url":"https://github.com/svenfuchs/routing-filter.git","ssh_url":"git@github.com:svenfuchs/routing-filter.git","pushed_at":"2011-12-21T16:49:21Z","forks":48,"owner":{"id":2208,"login":"svenfuchs","url":"https://api.github.com/users/svenfuchs","gravatar_id":"402602a60e500e85f2f5dc1ff3648ecb","avatar_url":"https://secure.gravatar.com/avatar/402602a60e500e85f2f5dc1ff3648ecb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"homepage":"http://www.artweb-design.de","size":208,"private":false,"svn_url":"https://svn.github.com/svenfuchs/routing-filter"},"label":"svenfuchs:master"},"issue_url":"https://github.com/svenfuchs/routing-filter/issues/33","body":"This is a (huge) bugfix for the test unit setup. The main changes included in this pull request are:\r\n\r\n* use appraisal to ease testing different rails versions, setup appraisal to test the latest rails 2.3, 3.0, 3.1 and 3.2 version\r\n* add a matcher for testing the generated routes. The return values of routes.generate with rails 2.3 and 3.0 are strings, rails 3.1+  returns an array of path and extra keys. This makes the tests usable with all rails versions\r\n* use a full blown test application to test rails 3.x - this is needed for rails 3.2 since it won't run the filters with the bare bones setup used before\r\n* include a ruby 1.9.3 compatiblity fix for testing rails 2.3\r\n* refactor rails_test.rb to use Rack::Test in a way that works on rails 2.3 to 3.2\r\n\r\nFor the rails 2.3 tests to pass issue #32 needs to be resolved first\r\n\r\nTo make the rails 3.2 tests pass i'll send a separate pull request.\r\n\r\n\r\n","commits":22,"additions":1254,"number":33,"url":"https://api.github.com/repos/svenfuchs/routing-filter/pulls/33","diff_url":"https://github.com/svenfuchs/routing-filter/pull/33.diff","merged_by":{"id":203423,"login":"yabawock","url":"https://api.github.com/users/yabawock","gravatar_id":"c85dc89b5ca024dfd515bb4f3ddcac95","avatar_url":"https://secure.gravatar.com/avatar/c85dc89b5ca024dfd515bb4f3ddcac95?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"_links":{"review_comments":{"href":"https://api.github.com/repos/svenfuchs/routing-filter/pulls/33/comments"},"html":{"href":"https://github.com/svenfuchs/routing-filter/pull/33"},"comments":{"href":"https://api.github.com/repos/svenfuchs/routing-filter/issues/33/comments"},"self":{"href":"https://api.github.com/repos/svenfuchs/routing-filter/pulls/33"}},"comments":0,"head":{"user":{"id":203423,"login":"yabawock","url":"https://api.github.com/users/yabawock","gravatar_id":"c85dc89b5ca024dfd515bb4f3ddcac95","avatar_url":"https://secure.gravatar.com/avatar/c85dc89b5ca024dfd515bb4f3ddcac95?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"ref":"appraisal","sha":"8fcb3500743cc4fd782b2677a87b38b40f438391","repo":{"git_url":"git://github.com/yabawock/routing-filter.git","created_at":"2011-12-21T00:12:10Z","open_issues":0,"watchers":2,"fork":true,"updated_at":"2011-12-21T16:06:36Z","id":3023576,"language":"Ruby","html_url":"https://github.com/yabawock/routing-filter","name":"routing-filter","description":"routing-filter wraps around the complex beast that the Rails routing system is, allowing for unseen flexibility and power in Rails URL recognition and generation.","master_branch":null,"url":"https://api.github.com/repos/yabawock/routing-filter","clone_url":"https://github.com/yabawock/routing-filter.git","ssh_url":"git@github.com:yabawock/routing-filter.git","pushed_at":"2011-12-21T10:16:50Z","forks":0,"owner":{"id":203423,"login":"yabawock","url":"https://api.github.com/users/yabawock","gravatar_id":"c85dc89b5ca024dfd515bb4f3ddcac95","avatar_url":"https://secure.gravatar.com/avatar/c85dc89b5ca024dfd515bb4f3ddcac95?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"homepage":"http://www.artweb-design.de","size":148,"private":false,"svn_url":"https://svn.github.com/yabawock/routing-filter"},"label":"yabawock:appraisal"},"changed_files":63,"merged":true},"number":33,"action":"closed"}