{"issue":{"created_at":"2011-12-07T13:28:15Z","state":"open","updated_at":"2011-12-08T19:00:03Z","comments":3,"user":{"gravatar_id":"8fce8cad45494dc806bc87a025e5bc71","id":211315,"url":"https://api.github.com/users/raskas","avatar_url":"https://secure.gravatar.com/avatar/8fce8cad45494dc806bc87a025e5bc71?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"raskas"},"body":"The iniface and outiface didn't support vlan interfaces.\r\nThose interfaces have a \".\" in there name, which wasn't listed in the regex","assignee":null,"id":2474512,"number":43,"pull_request":{"patch_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/43.patch","html_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/43","diff_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/43.diff"},"labels":[],"title":"Vlan support","html_url":"https://github.com/puppetlabs/puppetlabs-firewall/issues/43","closed_at":null,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/43","milestone":null},"action":"created","comment":{"created_at":"2011-12-08T19:00:03Z","updated_at":"2011-12-08T19:00:03Z","user":{"gravatar_id":"9accebe46504a4777d7b3c9707549dc6","id":80595,"url":"https://api.github.com/users/kbarber","avatar_url":"https://secure.gravatar.com/avatar/9accebe46504a4777d7b3c9707549dc6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"kbarber"},"body":"So yeah - this looks like good work.\r\n\r\nYou might want to consider separating your mark and your vlan work into separate topic branches and pull requests :-). The interface matching is a no brainer - but the mark stuff might take longer to review and merge.\r\n\r\nAlso are you familiar with adding spec tests? Checkout the spec/fixtures/iptables/conversion_hash.rb file for a reasonably simple pattern we use to match lines to rules and vice-versa. It avoids the heavy spec work.\r\n\r\nAlso any change to the type needs tests added here: spec/unit/puppet/type/firewall_spec.rb ... this is more pure rspec work but you can copy the patterns from other properties as a basis.\r\n\r\nCheers :-).","id":3068070,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/comments/3068070"}}