{"issue":{"created_at":"2011-11-29T19:52:51Z","state":"open","updated_at":"2011-12-01T22:05:30Z","user":{"gravatar_id":"082c34b6c1544c177cb7a66609360089","id":180987,"url":"https://api.github.com/users/nouiz","avatar_url":"https://secure.gravatar.com/avatar/082c34b6c1544c177cb7a66609360089?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"nouiz"},"comments":11,"body":"...he same as numpy.","assignee":null,"id":2391483,"labels":[],"pull_request":{"patch_url":"https://github.com/Theano/Theano/pull/242.patch","html_url":"https://github.com/Theano/Theano/pull/242","diff_url":"https://github.com/Theano/Theano/pull/242.diff"},"number":242,"title":"change the default of theano.{max,min,argmax,argmin,max_and_argmax} to t...","html_url":"https://github.com/Theano/Theano/issues/242","closed_at":null,"url":"https://api.github.com/repos/Theano/Theano/issues/242","milestone":null},"action":"created","comment":{"created_at":"2011-12-01T22:05:30Z","updated_at":"2011-12-01T22:05:30Z","user":{"gravatar_id":"28337ab166b54d4f2115cefe01fbc398","id":507137,"url":"https://api.github.com/users/delallea","avatar_url":"https://secure.gravatar.com/avatar/28337ab166b54d4f2115cefe01fbc398?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"delallea"},"body":"What about my suggestion to use it on the flattened array instead:\n\n```python\ndef max(x, axis=None):\n    if axis is None:\n        return max_and_argmax(x.flatten(), axis=0)[0]\n   # ...\n```\n\n2011/12/1 nouiz <\nreply@reply.github.com\n>\n\n> I agree that the fact that I allow list is ugly. The real fix would be to\n> create a GenericConstant Theano variable and put None in it. As I want to\n> make a release before NIPS, I don't want to do that now.\n>\n> Do you see any bug or regression? I think I fixed everything. We need to\n> have MaxAndArgmax work on all dimensions, as CarReduce don't support grad\n> for max only MaxAndArgmax do it.\n>\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/Theano/Theano/pull/242#issuecomment-2981173\n>","id":2982827,"url":"https://api.github.com/repos/Theano/Theano/issues/comments/2982827"}}