{"issue":{"created_at":"2011-10-21T08:48:39Z","state":"open","updated_at":"2011-11-24T11:05:38Z","user":{"gravatar_id":"1e6839f12e6795d7c250987e1ed08b74","id":67554,"url":"https://api.github.com/users/jeromegamez","login":"jeromegamez","avatar_url":"https://secure.gravatar.com/avatar/1e6839f12e6795d7c250987e1ed08b74?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":4,"body":"To start a better support for our IDEs, I added PHPDocs to the eZPersistentObject class (and if this passes your acceptance tests, continue with other classes inheriting from it).\r\n\r\nThere are some very small modifications to the code, too, where I made sure that a return value has always the same type, but besides there should be no critical issues rising from these changes.\r\n\r\nOriginally, I wanted to make the class abstract (because classes inheriting from eZPersistetnObject have to implement the method `fetch()`, but @lolautruche convinced me that this would be not the best idea.\r\n\r\nBest\r\n- Jérôme","assignee":null,"id":2013475,"pull_request":{"patch_url":"https://github.com/ezsystems/ezpublish/pull/138.patch","html_url":"https://github.com/ezsystems/ezpublish/pull/138","diff_url":"https://github.com/ezsystems/ezpublish/pull/138.diff"},"number":138,"labels":[],"title":"PHPDocs for eZPersistentObject","closed_at":null,"html_url":"https://github.com/ezsystems/ezpublish/issues/138","milestone":null,"url":"https://api.github.com/repos/ezsystems/ezpublish/issues/138"},"action":"created","comment":{"created_at":"2011-11-24T11:05:38Z","updated_at":"2011-11-24T11:05:38Z","user":{"gravatar_id":"1e6839f12e6795d7c250987e1ed08b74","id":67554,"url":"https://api.github.com/users/jeromegamez","login":"jeromegamez","avatar_url":"https://secure.gravatar.com/avatar/1e6839f12e6795d7c250987e1ed08b74?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"Okay, I have reverted all code changes (except the preposition of `public` in front of the `function`s), and the move of the variable `$PersistentDataDirty` from the bottom of the file to the top.\r\n\r\nDo you still see things that shouldn't be there?","id":2861330,"url":"https://api.github.com/repos/ezsystems/ezpublish/issues/comments/2861330"}}