{"issue":{"state":"closed","created_at":"2011-12-03T23:25:09Z","updated_at":"2011-12-04T17:08:42Z","comments":1,"user":{"gravatar_id":"9354eec0679e2d3b36b77ff62165f717","id":43875,"url":"https://api.github.com/users/seancorfield","login":"seancorfield","avatar_url":"https://secure.gravatar.com/avatar/9354eec0679e2d3b36b77ff62165f717?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"I've updated all references to contrib to be correct against Clojure 1.3.0 and the modular contrib libraries.\r\n\r\nI updated the build from source instructions (Maven is required for Clojure Contrib libraries).\r\n\r\nI've also corrected as many links as I could (e.g., richhickey repo, old API links) and removed some that seem to have simply gone away.\r\n\r\nI updated the web applications section to reference Noir, Ring and Framework One as well.\r\n\r\nI added a note on StructMaps that they are deprecated in favor of Records. Hopefully someone else will write up a Records section for you.\r\n\r\nI tested any code fragments I changed, against 1.3.0 and modular contribs.\r\n\r\nOnce this pull is merged in, I'll start to encourage others to fork and update the document.\r\n\r\nThank you Mark!","assignee":null,"id":2439831,"labels":[],"number":3,"pull_request":{"patch_url":"https://github.com/mvolkmann/Clojure-Article/pull/3.patch","html_url":"https://github.com/mvolkmann/Clojure-Article/pull/3","diff_url":"https://github.com/mvolkmann/Clojure-Article/pull/3.diff"},"title":"Updated old links and contrib references","closed_at":"2011-12-04T16:58:45Z","html_url":"https://github.com/mvolkmann/Clojure-Article/issues/3","url":"https://api.github.com/repos/mvolkmann/Clojure-Article/issues/3","milestone":null},"action":"created","comment":{"created_at":"2011-12-04T17:08:42Z","updated_at":"2011-12-04T17:08:42Z","user":{"gravatar_id":"8d042b437b937deb92d0c51515785a19","id":79312,"url":"https://api.github.com/users/mvolkmann","login":"mvolkmann","avatar_url":"https://secure.gravatar.com/avatar/8d042b437b937deb92d0c51515785a19?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"Thanks so much! Your changes have been merged and posted as have those from John Gabriele.\r\n\r\nI had some merge conflicts with the changes you made to the resources at the end. It seemed that you were intending to remove many of the links, but I wasn't sure. I fixed it as best I could, but didn't remove any links. Feel free to take another crack at that section and send me another pull request.\r\n\r\nOn Dec 3, 2011, at 5:25 PM, Sean Corfield wrote:\r\n\r\n> I've updated all references to contrib to be correct against Clojure 1.3.0 and the modular contrib libraries.\r\n> \r\n> I updated the build from source instructions (Maven is required for Clojure Contrib libraries).\r\n> \r\n> I've also corrected as many links as I could (e.g., richhickey repo, old API links) and removed some that seem to have simply gone away.\r\n> \r\n> I updated the web applications section to reference Noir, Ring and Framework One as well.\r\n> \r\n> I added a note on StructMaps that they are deprecated in favor of Records. Hopefully someone else will write up a Records section for you.\r\n> \r\n> I tested any code fragments I changed, against 1.3.0 and modular contribs.\r\n> \r\n> Once this pull is merged in, I'll start to encourage others to fork and update the document.\r\n> \r\n> Thank you Mark!\r\n> \r\n> You can merge this Pull Request by running:\r\n> \r\n>  git pull https://github.com/seancorfield/Clojure-Article master\r\n> \r\n> Or you can view, comment on it, or merge it online at:\r\n> \r\n>  https://github.com/mvolkmann/Clojure-Article/pull/3\r\n> \r\n> -- Commit Summary --\r\n> \r\n> * Corrected old links; Updated contrib references.\r\n> \r\n> -- File Changes --\r\n> \r\n> M article.html (248)\r\n> \r\n> -- Patch Links --\r\n> \r\n>  https://github.com/mvolkmann/Clojure-Article/pull/3.patch\r\n>  https://github.com/mvolkmann/Clojure-Article/pull/3.diff\r\n> \r\n> --- \r\n> Reply to this email directly or view it on GitHub:\r\n> https://github.com/mvolkmann/Clojure-Article/pull/3\r\n\r\n\r\n---\r\nMark Volkmann\r\nhttp://www.ociweb.com/mark","id":3007460,"url":"https://api.github.com/repos/mvolkmann/Clojure-Article/issues/comments/3007460"}}