{"comment":{"created_at":"2011-10-11T21:01:32Z","body":"Hi Nathan,\r\n\r\nIf you git pull the latest changes, anything touching an `Attribute` now has the following semantics:\r\n\r\n* vals is actually an overload. Everything internally is kept as a `Buffer`\r\n* If the attribute name ends in `;binary`, then vals will return an array of base64 encoded strings, otherwise, it's the \"old\" behavior, of being handed as utf8\r\n* If, like AD, you have things like `objectGUID` that are actually binary, but not tagged with a `';binary`, you can now access `.buffers` as opposed to `.vals` and get an array of raw node `Buffer` objects. The length and order will be the same as `.vals`.\r\n\r\nI think that should cover everything you need. Before I go publish - let me know if that covers (ideally, if you can test it that would rock :) ).\r\n\r\nm","updated_at":"2011-10-11T21:01:32Z","url":"https://api.github.com/repos/mcavage/node-ldapjs/issues/comments/2371139","id":2371139,"user":{"avatar_url":"https://secure.gravatar.com/avatar/d4303c5963bae19094178768c8aead0c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/mcavage","id":365262,"login":"mcavage"}},"action":"created","issue":{"number":21,"created_at":"2011-10-03T21:23:35Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"Currently the client and server seem to treat all attribute values as utf-8 strings.  There are some cases where the values are really binary and converting back and forth to utf-8 causes problems.  For example, I noticed that GUIDs and such get corrupted when trying to proxy for AD.\r\n\r\nI'm not sure the best way to handle that.  Maybe the client could set .buffer on the value to the original buffer.  If the server sees a .buffer, it could use that instead of the string value.","comments":4,"title":"support binary attribute values","updated_at":"2011-10-11T21:01:32Z","url":"https://api.github.com/repos/mcavage/node-ldapjs/issues/21","id":1807762,"assignee":null,"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/c0101d46c873621f3b5be8010ecfd57e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/nrogers","id":1090656,"login":"nrogers"},"html_url":"https://github.com/mcavage/node-ldapjs/issues/21","labels":[],"state":"open"},"legacy":{"issue_id":1807762,"comment_id":2371139}}