{"action":"closed","number":577,"pull_request":{"state":"closed","created_at":"2011-12-01T19:18:06Z","review_comments":0,"updated_at":"2011-12-07T11:17:02Z","changed_files":4,"_links":{"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-platform/pulls/577/comments"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-platform/issues/577/comments"},"html":{"href":"https://github.com/joomla/joomla-platform/pull/577"},"self":{"href":"https://api.github.com/repos/joomla/joomla-platform/pulls/577"}},"patch_url":"https://github.com/joomla/joomla-platform/pull/577.patch","user":{"gravatar_id":"a746e2ff69aafd175e65682cc3283fa8","id":368545,"url":"https://api.github.com/users/mbabker","login":"mbabker","avatar_url":"https://secure.gravatar.com/avatar/a746e2ff69aafd175e65682cc3283fa8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":6,"issue_url":"https://github.com/joomla/joomla-platform/issues/577","deletions":380,"merged":true,"body":"In a bit of a radical move, I've refactored JDatabaseMySQLi to extend JDatabaseMySQL.  Since these drivers build queries in a very close manner, and each other MySQLi class extends the MySQL companion, this helps to eliminate duplicate code and allows the focus to be solely on driver differences (calling mysqli_ versus mysql_ functions primarily).\r\n\r\nIn addition to this change, I've implemented a set of tests for JDatabaseMySQLi, similar in nature to JDatabaseMySQL's own tests.  In the few tests that have been created, there are no apparent major issues from refactoring the mysqli driver in this way.\r\n\r\nLastly, a bug in JDatabaseMySQL::getTableKeys was fixed in that it was incorrectly referencing `$this->db->quoteName` (db reference not needed here).","commits":9,"mergeable":null,"id":548761,"base":{"user":{"gravatar_id":"ebafeb89560f7a68353d0ccc03fe79c7","id":751633,"url":"https://api.github.com/users/joomla","login":"joomla","avatar_url":"https://secure.gravatar.com/avatar/ebafeb89560f7a68353d0ccc03fe79c7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"repo":{"created_at":"2011-04-27T02:20:52Z","pushed_at":"2011-12-07T11:17:02Z","clone_url":"https://github.com/joomla/joomla-platform.git","updated_at":"2011-12-07T11:17:02Z","private":false,"master_branch":"staging","name":"joomla-platform","watchers":263,"svn_url":"https://svn.github.com/joomla/joomla-platform","language":"PHP","forks":117,"owner":{"gravatar_id":"ebafeb89560f7a68353d0ccc03fe79c7","id":751633,"url":"https://api.github.com/users/joomla","login":"joomla","avatar_url":"https://secure.gravatar.com/avatar/ebafeb89560f7a68353d0ccc03fe79c7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":1668651,"homepage":"http://joomla.org","description":"A PHP Application Framework","git_url":"git://github.com/joomla/joomla-platform.git","html_url":"https://github.com/joomla/joomla-platform","size":59324,"open_issues":73,"fork":false,"url":"https://api.github.com/repos/joomla/joomla-platform","ssh_url":"git@github.com:joomla/joomla-platform.git"},"sha":"758c46bbbabf15e1e4b9120b6cf7f061a0a54a83","ref":"staging","label":"joomla:staging"},"additions":498,"merged_by":{"gravatar_id":"a641363e668babd6b0b13ea8f3922c7a","id":700871,"url":"https://api.github.com/users/eddieajau","login":"eddieajau","avatar_url":"https://secure.gravatar.com/avatar/a641363e668babd6b0b13ea8f3922c7a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"number":577,"head":{"user":{"gravatar_id":"a746e2ff69aafd175e65682cc3283fa8","id":368545,"url":"https://api.github.com/users/mbabker","login":"mbabker","avatar_url":"https://secure.gravatar.com/avatar/a746e2ff69aafd175e65682cc3283fa8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"repo":{"created_at":"2011-07-16T03:39:36Z","pushed_at":"2011-12-06T20:56:02Z","clone_url":"https://github.com/mbabker/joomla-platform.git","updated_at":"2011-12-06T20:56:02Z","private":false,"master_branch":null,"name":"joomla-platform","watchers":2,"svn_url":"https://svn.github.com/mbabker/joomla-platform","language":"PHP","forks":0,"owner":{"gravatar_id":"a746e2ff69aafd175e65682cc3283fa8","id":368545,"url":"https://api.github.com/users/mbabker","login":"mbabker","avatar_url":"https://secure.gravatar.com/avatar/a746e2ff69aafd175e65682cc3283fa8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"id":2056671,"homepage":"http://joomla.org","description":"A PHP Application Framework","git_url":"git://github.com/mbabker/joomla-platform.git","html_url":"https://github.com/mbabker/joomla-platform","size":188,"open_issues":0,"fork":true,"url":"https://api.github.com/repos/mbabker/joomla-platform","ssh_url":"git@github.com:mbabker/joomla-platform.git"},"sha":"d3cf9adf15d7962fb4590ff04213bdd9e03c4597","ref":"mysqli","label":"mbabker:mysqli"},"title":"Refactor JDatabaseMySQLi + Unit Tests","html_url":"https://github.com/joomla/joomla-platform/pull/577","closed_at":"2011-12-07T11:17:02Z","diff_url":"https://github.com/joomla/joomla-platform/pull/577.diff","url":"https://api.github.com/repos/joomla/joomla-platform/pulls/577","merged_at":"2011-12-07T11:17:02Z"}}