{"issue":{"title":"Patch 3","milestone":null,"user":{"id":556788,"login":"icecaster","url":"https://api.github.com/users/icecaster","avatar_url":"https://secure.gravatar.com/avatar/193e608732f0c453dc3349d32299a40f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"193e608732f0c453dc3349d32299a40f"},"created_at":"2011-09-16T03:13:25Z","labels":[],"state":"closed","updated_at":"2011-12-18T19:41:10Z","id":1659084,"html_url":"https://github.com/silverstripe/silverstripe-cms/issues/28","pull_request":{"patch_url":"https://github.com/silverstripe/silverstripe-cms/pull/28.patch","html_url":"https://github.com/silverstripe/silverstripe-cms/pull/28","diff_url":"https://github.com/silverstripe/silverstripe-cms/pull/28.diff"},"closed_at":"2011-12-18T19:41:10Z","body":"same as in https://github.com/silverstripe/silverstripe-cms/pull/26\r\n\r\nthe set default value must be in the dropdown list in order to work. \r\notherwise some browsers choose the first dropdown value - which can be a pagetype (if in front of 'all' in the alphabet) - causing the search to return nothing.","number":28,"url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/28","comments":2,"assignee":null},"comment":{"user":{"id":111025,"login":"chillu","url":"https://api.github.com/users/chillu","avatar_url":"https://secure.gravatar.com/avatar/b4f4cc99ef2108a7aa3573249800a3c1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"b4f4cc99ef2108a7aa3573249800a3c1"},"created_at":"2011-12-18T19:41:10Z","updated_at":"2011-12-18T19:41:10Z","id":3196430,"body":"Hey icecaster, sorry for the late response! Please create topic branches for any pull requests, that means it won't lump unrelated commits into the same request. See these instruction for details: https://github.com/ginatrapani/ThinkUp/wiki/Developer-Guide%3A-Get-the-Source-Code-from-GitHub-and-Keep-It-Updated - different project, but same principles apply.\r\n\r\nOn the specific commit: I'm sorry, but this has the exact opposite effect of what you're describing: By default, all pages are found. With applying this change, none are found. If you look in CMSSiteTreeFilter_Search->pagesIncluded(), it filters by the string \"All\" rather than \"Any\".","url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/comments/3196430"},"action":"created"}