{"issue":{"state":"open","created_at":"2011-11-29T10:30:29Z","updated_at":"2011-11-29T10:30:30Z","user":{"gravatar_id":"87d2e5aefadcb310f9155df28c2b3582","id":1192057,"url":"https://api.github.com/users/leofeyer","avatar_url":"https://secure.gravatar.com/avatar/87d2e5aefadcb310f9155df28c2b3582?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"leofeyer"},"comments":1,"body":"In the calendar, the template variables are related like this:\n\n* `href=\" $this->href \"`\n* `title=\" $this->title \"`\n* `<a href=\"\"> $this->link </a>`\n\nHowever, in the event list (and maybe other modules, too) it is:\n\n* `href=\" $this->link \"`\n* `title=\" $this->title \"`\n* `<a href=\"\"> $this->title </a>`\n\nThis makes it impossible to correctly implement #2853. Here is what needs to be changed:\n\n`event_list.tpl`: modify line 9\n\n```php\n<h2><a href=\"<?php echo $this->href; ?>\" title=\"<?php echo $this->title; ?> (<?php if ($this->day): echo $this->day; ?>, <?php endif; echo $this->date; if ($this->time): ?>, <?php echo $this->time; endif; ?>)\"<?php echo $this->target; ?>><?php echo $this->link; ?></a></h2>\n```\n\n@ModuleEventlist.php@: remove line 253\n\n```php\n$objTemplate->link = $event['href'];\n```\n\nRelated issues: #2853, #2965\n\n--- _Originally created on February 24th, 2011, at 12:36pm (ID 2889)_","assignee":{"gravatar_id":"87d2e5aefadcb310f9155df28c2b3582","id":1192057,"url":"https://api.github.com/users/leofeyer","avatar_url":"https://secure.gravatar.com/avatar/87d2e5aefadcb310f9155df28c2b3582?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"leofeyer"},"id":2382867,"labels":[{"name":"calendar","color":"e6e6e6","url":"https://api.github.com/repos/contao/test/labels/calendar"},{"name":"Defect","color":"bd2c00","url":"https://api.github.com/repos/contao/test/labels/Defect"}],"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"number":2889,"title":"Wrong template vars in the event list","closed_at":null,"html_url":"https://github.com/contao/test/issues/2889","url":"https://api.github.com/repos/contao/test/issues/2889","milestone":{"state":"open","created_at":"2011-11-29T05:27:05Z","due_on":null,"closed_issues":84,"creator":{"gravatar_id":"87d2e5aefadcb310f9155df28c2b3582","id":1192057,"url":"https://api.github.com/users/leofeyer","avatar_url":"https://secure.gravatar.com/avatar/87d2e5aefadcb310f9155df28c2b3582?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"leofeyer"},"number":32,"description":"Contao 2.10.0 (minor release)","title":"2.10.0","open_issues":1,"url":"https://api.github.com/repos/contao/test/milestones/32"}},"action":"created","comment":{"created_at":"2011-11-29T10:30:30Z","updated_at":"2011-11-29T10:30:30Z","user":{"gravatar_id":"87d2e5aefadcb310f9155df28c2b3582","id":1192057,"url":"https://api.github.com/users/leofeyer","avatar_url":"https://secure.gravatar.com/avatar/87d2e5aefadcb310f9155df28c2b3582?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"leofeyer"},"body":"The same applies to the newsletter list: `subject` is used for the title attribute as well as for the link.\n\n@ModuleNewsletterList.php`: change line 126 to\n\n```php\n'subject' => $objNewsletter->subject,\n'title' => specialchars($this->removeInsertTags($objNewsletter->subject)),\n```\n\n`mod_newsletter_list.tpl@: change line 12 to\n\n```php\n<li><?php echo $newsletter['datim']; ?>: <a href=\"<?php echo $newsletter['href']; ?>\" title=\"<?php echo $newsletter['title']; ?>\"><?php echo $newsletter['subject']; ?></a></li>\n```\n\n--- _Originally created on February 24th, 2011, at 12:50pm_","id":2927700,"url":"https://api.github.com/repos/contao/test/issues/comments/2927700"}}