{"action":"closed","pull_request":{"created_at":"2011-11-04T21:02:43Z","review_comments":0,"state":"closed","patch_url":"https://github.com/appcelerator/titanium_mobile/pull/630.patch","changed_files":5,"updated_at":"2011-11-19T02:21:57Z","_links":{"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/630/comments"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/630/comments"},"html":{"href":"https://github.com/appcelerator/titanium_mobile/pull/630"},"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/630"}},"user":{"gravatar_id":"71668abbd82dcf496aec4a44c29ada2d","id":169061,"url":"https://api.github.com/users/sptramer","login":"sptramer","avatar_url":"https://secure.gravatar.com/avatar/71668abbd82dcf496aec4a44c29ada2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"issue_url":"https://github.com/appcelerator/titanium_mobile/issues/630","comments":11,"deletions":4,"body":"Previously we were dumping module contents into binary builds, which is unnecessary and could be considered a possible security risk. Now assets are copied correctly, and other module content is not distributed.\r\n\r\nThere is also now support for `platform/iphone` resources to be copied in, providing a replacement for the previously (and incorrectly) recommended method of putting such resources in `modules/iphone`.\r\n\r\nPlease see both of these tickets for testing instructions.","merged":true,"mergeable":null,"commits":6,"additions":22,"id":465535,"number":630,"base":{"user":{"gravatar_id":"01d8a2b8546d6479cf4323d72cbed363","id":82188,"url":"https://api.github.com/users/appcelerator","login":"appcelerator","avatar_url":"https://secure.gravatar.com/avatar/01d8a2b8546d6479cf4323d72cbed363?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"repo":{"pushed_at":"2011-11-19T02:21:57Z","created_at":"2009-06-15T22:54:37Z","private":false,"updated_at":"2011-11-19T02:21:57Z","clone_url":"https://github.com/appcelerator/titanium_mobile.git","name":"titanium_mobile","watchers":1036,"master_branch":null,"svn_url":"https://svn.github.com/appcelerator/titanium_mobile","language":"Objective-C","forks":322,"owner":{"gravatar_id":"01d8a2b8546d6479cf4323d72cbed363","id":82188,"url":"https://api.github.com/users/appcelerator","login":"appcelerator","avatar_url":"https://secure.gravatar.com/avatar/01d8a2b8546d6479cf4323d72cbed363?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":228094,"homepage":"http://www.appcelerator.com","description":"Appcelerator Titanium Mobile","git_url":"git://github.com/appcelerator/titanium_mobile.git","html_url":"https://github.com/appcelerator/titanium_mobile","open_issues":53,"url":"https://api.github.com/repos/appcelerator/titanium_mobile","size":6860,"fork":false,"ssh_url":"git@github.com:appcelerator/titanium_mobile.git"},"sha":"8a8b0fa02c6ea8129c0f46bdb104f0989f1ec4a2","ref":"master","label":"appcelerator:master"},"merged_by":{"gravatar_id":"be5598e65954a7a5901834efca512292","id":847863,"url":"https://api.github.com/users/srahim","login":"srahim","avatar_url":"https://secure.gravatar.com/avatar/be5598e65954a7a5901834efca512292?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"head":{"user":{"gravatar_id":"71668abbd82dcf496aec4a44c29ada2d","id":169061,"url":"https://api.github.com/users/sptramer","login":"sptramer","avatar_url":"https://secure.gravatar.com/avatar/71668abbd82dcf496aec4a44c29ada2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"repo":{"pushed_at":"2011-11-19T01:18:48Z","created_at":"2011-05-27T20:34:00Z","private":false,"updated_at":"2011-11-19T01:18:48Z","clone_url":"https://github.com/sptramer/titanium_mobile.git","name":"titanium_mobile","watchers":1,"master_branch":null,"svn_url":"https://svn.github.com/sptramer/titanium_mobile","language":"Objective-C","forks":0,"owner":{"gravatar_id":"71668abbd82dcf496aec4a44c29ada2d","id":169061,"url":"https://api.github.com/users/sptramer","login":"sptramer","avatar_url":"https://secure.gravatar.com/avatar/71668abbd82dcf496aec4a44c29ada2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"id":1811752,"homepage":"http://www.appcelerator.com","description":"Appcelerator Titanium Mobile","git_url":"git://github.com/sptramer/titanium_mobile.git","html_url":"https://github.com/sptramer/titanium_mobile","open_issues":0,"url":"https://api.github.com/repos/sptramer/titanium_mobile","size":312,"fork":true,"ssh_url":"git@github.com:sptramer/titanium_mobile.git"},"sha":"501b8c78d1e0e875a272c7f177773657f5984c97","ref":"timob-5062","label":"sptramer:timob-5062"},"title":"[TIMOB-5026][TIMOB-6220] Properly manage module/platform copying","closed_at":"2011-11-19T02:21:57Z","html_url":"https://github.com/appcelerator/titanium_mobile/pull/630","url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/630","diff_url":"https://github.com/appcelerator/titanium_mobile/pull/630.diff","merged_at":"2011-11-19T02:21:57Z"},"number":630}