{"action":"closed","pull_request":{"review_comments":0,"state":"closed","created_at":"2011-12-01T01:18:08Z","patch_url":"https://github.com/mattweber/solr-for-wordpress/pull/28.patch","updated_at":"2011-12-05T19:14:55Z","changed_files":3,"_links":{"review_comments":{"href":"https://api.github.com/repos/mattweber/solr-for-wordpress/pulls/28/comments"},"comments":{"href":"https://api.github.com/repos/mattweber/solr-for-wordpress/issues/28/comments"},"html":{"href":"https://github.com/mattweber/solr-for-wordpress/pull/28"},"self":{"href":"https://api.github.com/repos/mattweber/solr-for-wordpress/pulls/28"}},"comments":2,"issue_url":"https://github.com/mattweber/solr-for-wordpress/issues/28","user":{"gravatar_id":"dac1a3c1511f0b351ea167202dd409fa","id":203929,"url":"https://api.github.com/users/palepurple","avatar_url":"https://secure.gravatar.com/avatar/dac1a3c1511f0b351ea167202dd409fa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"palepurple"},"deletions":7,"merged":true,"body":"1. Fix stray ?> in the admin options page.\r\n\r\n2. Reduce batch size and try and avoid memory limit problems when performing an import on a wordpress 3.1 blog (I'm not sure if the wp_cache_flush() is what solved it, or reducing the batch size from 1000 to 250). Regardless, the combination did work. I remain mystified as to why this server didn't accept me increasing the memory limit to 4gb (Which would have fixed the problem) and instead insisted on failing at 256mb .... nevermind.\r\n\r\nError seen :\r\n[01-Dec-2011 00:31:05] PHP Fatal error:  Allowed memory size of 268435456 bytes exhausted (tried to allocate 71 bytes) in /xxxxxx/httpdocs/wp-content/plugins/solr-for-wordpress/SolrPhpClient/Apache/Solr/Document.php on line 179\r\n\r\n\r\n\r\n3. Fix/workaround dodgy data on import -\r\n\r\nError seen:\r\n[01-Dec-2011 00:48:38] PHP Warning:  htmlspecialchars() [<a href='function.htmlspecialchars'>function.htmlspecialchars</a>]: Invalid multibyte sequence in argument in /xxxxxx/httpdocs/wp-content/plugins/solr-for-wordpress/SolrPhpClient/Apache/Solr/Service.php on line 785\r\n\r\nPassing data through utf8_encode() appears to solve the problem. It's possible this is a problem unique to this site; but this fixes it for me. Note, I'm stuck on PHP5.2.6 - newer versions of PHP/htmlspecialchars have additional options which would probably solve this, but I can't use.\r\n\r\nthanks\r\nDavid.\r\n","commits":3,"mergeable":null,"id":545788,"additions":6,"base":{"repo":{"created_at":"2010-12-13T01:44:13Z","pushed_at":"2011-12-05T19:14:55Z","updated_at":"2011-12-05T19:14:55Z","private":false,"clone_url":"https://github.com/mattweber/solr-for-wordpress.git","svn_url":"https://svn.github.com/mattweber/solr-for-wordpress","name":"solr-for-wordpress","watchers":31,"master_branch":null,"forks":14,"language":"PHP","owner":{"gravatar_id":"8ec03234adcd70bae24e9999260774e4","id":173955,"url":"https://api.github.com/users/mattweber","avatar_url":"https://secure.gravatar.com/avatar/8ec03234adcd70bae24e9999260774e4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"mattweber"},"id":1162848,"homepage":"","git_url":"git://github.com/mattweber/solr-for-wordpress.git","description":"A WordPress plugin that replaces the default WordPress search with Solr","html_url":"https://github.com/mattweber/solr-for-wordpress","url":"https://api.github.com/repos/mattweber/solr-for-wordpress","size":268,"fork":false,"open_issues":8,"ssh_url":"git@github.com:mattweber/solr-for-wordpress.git"},"user":{"gravatar_id":"8ec03234adcd70bae24e9999260774e4","id":173955,"url":"https://api.github.com/users/mattweber","avatar_url":"https://secure.gravatar.com/avatar/8ec03234adcd70bae24e9999260774e4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"mattweber"},"sha":"2da85a5b31091147c307674e8ee8a3bbf880aa42","ref":"master","label":"mattweber:master"},"merged_by":{"gravatar_id":"c44d3f9c9cde152a31c080cc0952adaa","id":488328,"url":"https://api.github.com/users/shaksi","avatar_url":"https://secure.gravatar.com/avatar/c44d3f9c9cde152a31c080cc0952adaa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"shaksi"},"number":28,"title":"import related things (memory limit, encoding issues and stray ?> in admin panel)","head":{"repo":{"created_at":"2011-11-30T13:29:30Z","pushed_at":"2011-12-01T01:12:04Z","updated_at":"2011-12-01T01:12:04Z","private":false,"clone_url":"https://github.com/palepurple/solr-for-wordpress.git","svn_url":"https://svn.github.com/palepurple/solr-for-wordpress","name":"solr-for-wordpress","watchers":1,"master_branch":null,"forks":0,"language":"PHP","owner":{"gravatar_id":"dac1a3c1511f0b351ea167202dd409fa","id":203929,"url":"https://api.github.com/users/palepurple","avatar_url":"https://secure.gravatar.com/avatar/dac1a3c1511f0b351ea167202dd409fa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"palepurple"},"id":2883299,"homepage":"","git_url":"git://github.com/palepurple/solr-for-wordpress.git","description":"A WordPress plugin that replaces the default WordPress search with Solr","html_url":"https://github.com/palepurple/solr-for-wordpress","url":"https://api.github.com/repos/palepurple/solr-for-wordpress","size":128,"fork":true,"open_issues":0,"ssh_url":"git@github.com:palepurple/solr-for-wordpress.git"},"user":{"gravatar_id":"dac1a3c1511f0b351ea167202dd409fa","id":203929,"url":"https://api.github.com/users/palepurple","avatar_url":"https://secure.gravatar.com/avatar/dac1a3c1511f0b351ea167202dd409fa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"palepurple"},"sha":"063ec7e55d57707bb794f3fb5bd4180f63bfa91a","ref":"master","label":"palepurple:master"},"closed_at":"2011-12-05T19:14:55Z","html_url":"https://github.com/mattweber/solr-for-wordpress/pull/28","url":"https://api.github.com/repos/mattweber/solr-for-wordpress/pulls/28","diff_url":"https://github.com/mattweber/solr-for-wordpress/pull/28.diff","merged_at":"2011-12-05T19:14:55Z"},"number":28}