{"issue":{"state":"closed","created_at":"2011-12-08T05:45:59Z","updated_at":"2011-12-08T11:55:36Z","comments":4,"user":{"gravatar_id":"80a1fda15bb91040818b4535a3e18bce","id":322865,"url":"https://api.github.com/users/briansahagun","avatar_url":"https://secure.gravatar.com/avatar/80a1fda15bb91040818b4535a3e18bce?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"briansahagun"},"body":"* Put /* For Image Replacement */ on top of your custom CSS to prevent the .ir styles from overriding your own declarations.\r\n  * In case you need to declare your #logo with a display:inline-block, the display:block of .ir would be overridden.\r\n* Addition of style for responsive images\r\n  * img, object, embed {max-width:100%;}\r\n  * img {height:auto;}\r\n* In cases of short content, the Body and Footer shoudl have the same background color to show continuity of color at the bottom of the page (instead of having a Footer bg color and another bg color for body).\r\n  * body, footer {background-color:red;}\r\n* Minimum height for content to push the footer down a bit (should be removed for mobile styles)\r\n  * #content {min-height:400px;}\r\n* For media queries, higher max-width should be declared first than lower max-width to avoid the higher max-width interfering with the lower max-width. This is particulary useful if you have different pixel width declaration for both media queries.\r\n  * @media only screen and (max-width:1023px) should go above @media only screen and (max-width:767px)\r\n\r\nhttp://chewyui.com/2011/12/08/improvements-on-html5-boilerplate/","assignee":null,"id":2484058,"number":882,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[],"title":"Improvements on HTML5 Boilerplate's CSS","html_url":"https://github.com/h5bp/html5-boilerplate/issues/882","closed_at":"2011-12-08T11:55:36Z","url":"https://api.github.com/repos/h5bp/html5-boilerplate/issues/882","milestone":null},"action":"created","comment":{"created_at":"2011-12-08T11:55:36Z","updated_at":"2011-12-08T11:55:36Z","user":{"gravatar_id":"992c9c162c4c62ec0e2621b4f2206533","id":239676,"url":"https://api.github.com/users/necolas","avatar_url":"https://secure.gravatar.com/avatar/992c9c162c4c62ec0e2621b4f2206533?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"necolas"},"body":"Thanks but I don't think any of these should be included by default.\r\n\r\n1. All the helper classes should probably be moved before author styles and the crucial rules `!important`'ed.\r\n\r\n2. There can be problems with `max-width:100%` on images, particularly in IE8 where they can sometimes disappear and it's not going to be obvious what is causing the disappearance. So I'd hesitate to include it by default.\r\n\r\n3. The body/footer things requires another element to have a background color to sit over the `body`'s bg color. Definitely not something we should include.\r\n\r\n4. The `min-height` thing is design specific and an arbitrary value. Shouldn't be included in h5bp\r\n\r\n5. By default, we're including `min-width()` media query placeholder.","id":3061511,"url":"https://api.github.com/repos/h5bp/html5-boilerplate/issues/comments/3061511"}}