{"comment":{"created_at":"2011-10-25T13:26:38Z","body":"commit 6ef876d is a both bugfix and enhancement. Had a request from designers to make different tint on toolbars for different sharers (blue for Facebook, green blue for Twitter). This would not be very hacky to do in old macro SHKConfig.h way. But using a configurator fits very nice.\r\n\r\nNote, that old barTintColorRed(green, blue) config items were defined in SHKConfig.h, but they were not used in the codebase at all. So I decided to get rid of them in configurator (and for compatibility support them in old macro config, though they were not used.)\r\n\r\nThere is a first config item which takes argument instead - barTintForView: and I hope this sets up basement for more dynamic UI configuration possibilities.\r\n\r\nPlease review the code, I hope you will like it.\r\n\r\n","updated_at":"2011-10-25T13:26:38Z","url":"https://api.github.com/repos/ShareKit/ShareKit/issues/comments/2517023","id":2517023,"user":{"avatar_url":"https://secure.gravatar.com/avatar/b948ee8ca2e46ef7b986540c641a8418?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"b948ee8ca2e46ef7b986540c641a8418","url":"https://api.github.com/users/VilemKurz","id":1016974,"login":"VilemKurz"}},"action":"created","issue":{"number":70,"created_at":"2011-10-25T09:44:19Z","pull_request":{"diff_url":"https://github.com/ShareKit/ShareKit/pull/70.diff","patch_url":"https://github.com/ShareKit/ShareKit/pull/70.patch","html_url":"https://github.com/ShareKit/ShareKit/pull/70"},"body":"- Refactored not to use delegation, and renamed the files and methods to avoid confusion to *configurator.\r\n- cleaned interface files (moved internal methods and variables to .m files)\r\n- checked for compatibility with old SHKConfig.h\r\n- checked codebase to be sure everywhere we use new SHKConfig() preprocessor function\r\n- added and updated comments to DefaultSHKConfigurator.m, so that new implementers have easier task configuring\r\n- tested both old and new config ways after refactoring\r\n\r\nAfter merging with master there will be need to update configuration section in wiki.\r\n\r\nI have also updated service's api keys links. I think for developers is more convenient to have them as comments directly in the configuration code. <b>I have noticed, that there is a new wiki section links. We should not maintain two link lists, so I suggest to delete wiki page, and update links in code directly.</b>\r\n\r\n<b>Also, there are many services, but only few of them have their keys in configuration </b>. Since I use only FB and TW, I do not know how other services are implemented. Where do they store their keys? If they do not need keys, ok, but if they do, they should be configured in central place - DefaultSHKConfigurator subclasses. Can anybody check that? ","comments":1,"title":"Configuration refactoring in spirit of #12","updated_at":"2011-10-25T13:26:38Z","url":"https://api.github.com/repos/ShareKit/ShareKit/issues/70","id":2043250,"assignee":null,"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/b948ee8ca2e46ef7b986540c641a8418?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"b948ee8ca2e46ef7b986540c641a8418","url":"https://api.github.com/users/VilemKurz","id":1016974,"login":"VilemKurz"},"html_url":"https://github.com/ShareKit/ShareKit/issues/70","labels":[],"state":"open"},"legacy":{"issue_id":2043250,"comment_id":2517023}}