{"ref":"refs/heads/master","commits":[{"author":{"name":"Drak","email":"75d686a353bfa2f371d9718ec34b93fbed799dbe@zikula.org"},"url":"https://api.github.com/repos/symfony/symfony/commits/0fe8ac6149da1264762bc5a96be3423585c7d54d","message":"[EventDispatcher] Removed unused argument.","sha":"0fe8ac6149da1264762bc5a96be3423585c7d54d"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"url":"https://api.github.com/repos/symfony/symfony/commits/db6fea9fd014b9272627ee8c715368b7a1918741","message":"merged branch drak/eventdispatcher_opimization (PR #2597)\n\nCommits\n-------\n\n0fe8ac6 [EventDispatcher] Removed unused argument.\n\nDiscussion\n----------\n\n[EventDispatcher] Removed unused parameter in doDispatch().\n\nBug fix: no\nFeature addition: no\nBackwards compatibility break: no\nSymfony2 tests pass: yes\nFixes the following tickets: -\n\nRemoved unused parameter.\n\n---------------------------------------------------------------------------\n\nby Seldaek at 2011/11/10 02:30:01 -0800\n\nA simple $foo($arg) is faster than call_user_func, fine, but with all the if/else logic here are you sure it is still faster?\n\n---------------------------------------------------------------------------\n\nby drak at 2011/11/10 06:44:41 -0800\n\ncall_user_func is inordinately slow, I'll make some benchmarks. The if logic here is pretty, two conditionals for array callables or one conditional for closures/functions.\n\n---------------------------------------------------------------------------\n\nby drak at 2011/11/10 12:45:27 -0800\n\nAfter doing some benchmarks, there are savings to be made in all cases except when the listener is an instantiated object when it's marginally slower, so I've reverted these changes and made this PR just to remove the unused argument in `doDispatch()`. You can see the benchmark code here: https://gist.github.com/1356129.\n\n---------------------------------------------------------------------------\n\nby drak at 2011/11/10 12:46:55 -0800\n\nThis PR is ready for consideration.","sha":"db6fea9fd014b9272627ee8c715368b7a1918741"}],"head":"db6fea9fd014b9272627ee8c715368b7a1918741","size":2,"push_id":49599008}