{"action":"opened","pull_request":{"review_comments":0,"created_at":"2011-12-08T01:08:14Z","state":"open","updated_at":"2011-12-08T01:08:14Z","changed_files":2,"_links":{"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/258/comments"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/258/comments"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/258"},"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/258"}},"patch_url":"https://github.com/puppetlabs/puppet/pull/258.patch","comments":0,"issue_url":"https://github.com/puppetlabs/puppet/issues/258","user":{"gravatar_id":"158e21e3c3705e288ee2d20bbeadc7d5","id":959879,"url":"https://api.github.com/users/lifton","avatar_url":"https://secure.gravatar.com/avatar/158e21e3c3705e288ee2d20bbeadc7d5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"lifton"},"merged":false,"body":"Previously, any error with the certificate retrieved from the master\r\nmatching the agent's private key would give the same static error\r\nmessage, which wasn't particularly helpful. This commit differentiates\r\nthree different error cases: missing certificate, missing private key,\r\nand certificate doesn't match private key. In the last case, the error\r\nmessage includes the fingerprint of the certificate in question and\r\nexplicit command line instructions on how to fix the problem.\r\n\r\nIn addition to all tests passing, I tested the error messaging and\r\nincluded instructions in a virtual machine setup running PE 2.0.0.","deletions":41,"mergeable":null,"commits":1,"id":570741,"additions":26,"base":{"repo":{"pushed_at":"2011-12-08T00:22:00Z","created_at":"2010-09-14T19:26:44Z","updated_at":"2011-12-08T00:22:00Z","private":false,"clone_url":"https://github.com/puppetlabs/puppet.git","master_branch":null,"name":"puppet","watchers":499,"svn_url":"https://svn.github.com/puppetlabs/puppet","forks":224,"language":"Ruby","owner":{"gravatar_id":"eb454c2139c156db7c8266a875519a1f","id":234268,"url":"https://api.github.com/users/puppetlabs","avatar_url":"https://secure.gravatar.com/avatar/eb454c2139c156db7c8266a875519a1f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"puppetlabs"},"id":910744,"homepage":"http://www.puppetlabs.com/puppet/introduction/","description":"Server automation framework and application","git_url":"git://github.com/puppetlabs/puppet.git","html_url":"https://github.com/puppetlabs/puppet","open_issues":64,"size":27092,"url":"https://api.github.com/repos/puppetlabs/puppet","fork":false,"ssh_url":"git@github.com:puppetlabs/puppet.git"},"user":{"gravatar_id":"eb454c2139c156db7c8266a875519a1f","id":234268,"url":"https://api.github.com/users/puppetlabs","avatar_url":"https://secure.gravatar.com/avatar/eb454c2139c156db7c8266a875519a1f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","login":"puppetlabs"},"sha":"999355facb493509e3648845286d6fefe6f598fd","ref":"2.7.x","label":"puppetlabs:2.7.x"},"number":258,"merged_by":null,"title":"Ticket/2.7.x/7110 better ssl error","head":{"repo":{"pushed_at":"2011-12-08T01:05:27Z","created_at":"2011-11-15T17:06:49Z","updated_at":"2011-12-08T01:05:27Z","private":false,"clone_url":"https://github.com/lifton/puppet.git","master_branch":null,"name":"puppet","watchers":1,"svn_url":"https://svn.github.com/lifton/puppet","forks":0,"language":"Ruby","owner":{"gravatar_id":"158e21e3c3705e288ee2d20bbeadc7d5","id":959879,"url":"https://api.github.com/users/lifton","avatar_url":"https://secure.gravatar.com/avatar/158e21e3c3705e288ee2d20bbeadc7d5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"lifton"},"id":2781748,"homepage":"http://www.puppetlabs.com/puppet/introduction/","description":"Server automation framework and application","git_url":"git://github.com/lifton/puppet.git","html_url":"https://github.com/lifton/puppet","open_issues":0,"size":168,"url":"https://api.github.com/repos/lifton/puppet","fork":true,"ssh_url":"git@github.com:lifton/puppet.git"},"user":{"gravatar_id":"158e21e3c3705e288ee2d20bbeadc7d5","id":959879,"url":"https://api.github.com/users/lifton","avatar_url":"https://secure.gravatar.com/avatar/158e21e3c3705e288ee2d20bbeadc7d5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"lifton"},"sha":"c78d17e365d21fa443ada615844dbc8e5fad425e","ref":"ticket/2.7.x/7110_better_ssl_error","label":"lifton:ticket/2.7.x/7110_better_ssl_error"},"html_url":"https://github.com/puppetlabs/puppet/pull/258","closed_at":null,"diff_url":"https://github.com/puppetlabs/puppet/pull/258.diff","url":"https://api.github.com/repos/puppetlabs/puppet/pulls/258","merged_at":null},"number":258}