{"issue":{"created_at":"2011-12-06T15:58:13Z","state":"closed","updated_at":"2011-12-06T19:11:14Z","user":{"gravatar_id":"879d886d7ff6cb659299c60d68305840","id":1178794,"url":"https://api.github.com/users/erikschoel","login":"erikschoel","avatar_url":"https://secure.gravatar.com/avatar/879d886d7ff6cb659299c60d68305840?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":1,"body":"Hey Byron,\r\n\r\nBefore anything else: Great work!!\r\n\r\nI ran into one little issue related to triggerOnBind as one of the defaultConnectOptions. The default is true, and I noticed that explicitly specifying false wasn't working.\r\n\r\nThat's because you later test whether the option is provided using - if (!options[key]) - and a value of false evaluates to false causing the default not to be overwritten.\r\n\r\nFor my purpose I just changed the default into false overriding with true if I need to, but this should be fixed more elegantly.\r\n\r\nCan you add this to the next release?\r\n\r\nThanks!! And best regards,\r\n\r\nErik","assignee":null,"id":2463790,"number":17,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[],"title":"triggerOnBind in defaultConnectOptions","html_url":"https://github.com/bruth/synapse/issues/17","closed_at":"2011-12-06T19:11:14Z","url":"https://api.github.com/repos/bruth/synapse/issues/17","milestone":null},"action":"closed"}