{"issue":{"milestone":null,"title":"Fixed not found issue when urls end with slash and rout have no slash","created_at":"2011-07-15T17:30:08Z","user":{"login":"shameerc","id":275500,"url":"https://api.github.com/users/shameerc","avatar_url":"https://secure.gravatar.com/avatar/00cdf8e7969ae438f0e84f7a8c2a5aa6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"00cdf8e7969ae438f0e84f7a8c2a5aa6"},"updated_at":"2011-12-30T00:48:02Z","state":"closed","labels":[],"id":1231575,"closed_at":"2011-12-30T00:48:02Z","html_url":"https://github.com/auraphp/Aura.Router/issues/4","pull_request":{"patch_url":"https://github.com/auraphp/Aura.Router/pull/4.patch","html_url":"https://github.com/auraphp/Aura.Router/pull/4","diff_url":"https://github.com/auraphp/Aura.Router/pull/4.diff"},"body":"Hi\r\nHi have done a small fix in Rout.php. Just changed the sensitive way of rout matching. If the url end with slash and corresponding rout have no slash (and vice versa), it will end up in 404. Here i just trimmed down the last slash of both path and regex.\r\n(NB: I am new to aura. Please let me know if done something wrong)","number":4,"url":"https://api.github.com/repos/auraphp/Aura.Router/issues/4","comments":1,"assignee":null},"comment":{"created_at":"2011-12-30T00:48:02Z","user":{"login":"pmjones","id":25754,"url":"https://api.github.com/users/pmjones","avatar_url":"https://secure.gravatar.com/avatar/c109ac4bc8af147fb90b2674f74e009c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"c109ac4bc8af147fb90b2674f74e009c"},"updated_at":"2011-12-30T00:48:02Z","id":3307400,"body":"This is a sensitive topic. Some people think that having a slash changes the meaning of the URI, so that (e.g.) \"/user/1\" and \"/user/1/\" have different meanings.  See these:\r\n\r\n- <http://www.fiftyfoureleven.com/weblog/search-engines/trailing-slashes-best-practice>\r\n- <http://www.searchenginejournal.com/linking-issues-why-a-trailing-slash-in-the-url-does-matter/13021/>\r\n\r\nOr Google for \"trailing slash in uri\".\r\n\r\nI have to agree with them here; so, I can't accept this pull request. Sorry man.","url":"https://api.github.com/repos/auraphp/Aura.Router/issues/comments/3307400"},"action":"created"}