{"issue":{"milestone":null,"user":{"id":559221,"login":"DavideD","url":"https://api.github.com/users/DavideD","avatar_url":"https://secure.gravatar.com/avatar/81bb77cf77fb3dd1347f0c5c39e20548?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"81bb77cf77fb3dd1347f0c5c39e20548"},"created_at":"2011-12-18T23:23:51Z","title":"ARQ- 502 Support arquillian.xml configuration in Maven Plugin","updated_at":"2011-12-19T11:26:01Z","labels":[],"state":"open","id":2595541,"html_url":"https://github.com/arquillian/arquillian-maven/issues/1","closed_at":null,"pull_request":{"patch_url":"https://github.com/arquillian/arquillian-maven/pull/1.patch","html_url":"https://github.com/arquillian/arquillian-maven/pull/1","diff_url":"https://github.com/arquillian/arquillian-maven/pull/1.diff"},"body":"Hi,\r\nhere's my proposal.\r\n\r\nIn the configuration I've added the property arquillianXml so that it is possible to specify the location of the file.\r\nI prefer this solution since it seems easier to change the arquillian.xml file than the tags inside the pom. I think it's also easier too maintain.\r\n\r\nThe first commit is the actual patch and the only one required.\r\nThe second and the third commit add unit tests.\r\nIn the fourth commit I took the liberty to clean (at least I hope so) the class. I think now is more readable but I committed it separately so that it can be removed easily eventually.\r\n\r\nCheers,\r\nDavide\r\n\r\n\r\n\r\n","number":1,"url":"https://api.github.com/repos/arquillian/arquillian-maven/issues/1","comments":4,"assignee":null},"comment":{"user":{"id":559221,"login":"DavideD","url":"https://api.github.com/users/DavideD","avatar_url":"https://secure.gravatar.com/avatar/81bb77cf77fb3dd1347f0c5c39e20548?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"81bb77cf77fb3dd1347f0c5c39e20548"},"created_at":"2011-12-19T11:26:01Z","updated_at":"2011-12-19T11:26:01Z","id":3202036,"body":"Correct me if I'm wrong but the system property allows to change the name of the file while looking it in the classpath isn't it?\r\nThe way I set the property now it can be anywhere on the file system.\r\nNot sure if this is a benefit but it seems the major difference to me. In this case it's probably better to change the name of the property to avoid confusion...something like arquillianXmlFilePath.","url":"https://api.github.com/repos/arquillian/arquillian-maven/issues/comments/3202036"},"action":"created"}