{"issue":{"state":"closed","created_at":"2011-11-29T05:25:32Z","updated_at":"2011-12-02T17:04:00Z","comments":2,"user":{"gravatar_id":"c56dbf5408ac15e462cbdb206d2f42ce","id":1206170,"url":"https://api.github.com/users/markkap","avatar_url":"https://secure.gravatar.com/avatar/c56dbf5408ac15e462cbdb206d2f42ce?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"markkap"},"body":"actually having the configuration of the slugs as part of the permalink page will be even nicer.....\r\n\r\nRight now my client wants that there will be an empty slug for product categories. \r\n\r\nmaybe a better idea is to have a filkter for the whole data structure passed to the various CPT related creation functions","assignee":null,"id":2377928,"number":288,"labels":[],"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"title":"filter instead of localization for the product_cat slug","closed_at":"2011-12-02T11:47:06Z","html_url":"https://github.com/woothemes/woocommerce/issues/288","url":"https://api.github.com/repos/woothemes/woocommerce/issues/288","milestone":null},"action":"created","comment":{"created_at":"2011-12-02T17:04:00Z","updated_at":"2011-12-02T17:04:00Z","user":{"gravatar_id":"c56dbf5408ac15e462cbdb206d2f42ce","id":1206170,"url":"https://api.github.com/users/markkap","avatar_url":"https://secure.gravatar.com/avatar/c56dbf5408ac15e462cbdb206d2f42ce?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"markkap"},"body":"you are right about empty, it can be done but it means to redifne all the other permalinks, and the WP API doesn't support it.\r\n\r\nMy beef with exclusivly relaying on localization, is that the localization pattern is: \r\n1. you release l10n plugin\r\n2. I translate it to hebrew and make the translation public\r\n3. some other guy use WC in hebrew.\r\n\r\nThe last guy might need to change the slug. he will look in the code for the hebrew slug which is generated by default and will not find it. after some searching or maybe contacting me, he will realize that it is in the .MO file. he will need to learn what tools to use to change .PO and generate .MO, and make the change.\r\n\r\nAnd here comes the worst part - he will not be able to upgrade WC because when installing the bundled hebrew l10n he will actually lose functionality at his site.\r\n","id":2992725,"url":"https://api.github.com/repos/woothemes/woocommerce/issues/comments/2992725"}}