{"issue":{"state":"open","pull_request":{"diff_url":"https://github.com/wvanbergen/adyen/pull/35.diff","html_url":"https://github.com/wvanbergen/adyen/pull/35","patch_url":"https://github.com/wvanbergen/adyen/pull/35.patch"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/d1c216897a0708f79144e2032040f751?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"d1c216897a0708f79144e2032040f751","url":"https://api.github.com/users/troessner","login":"troessner","id":271109},"milestone":null,"assignee":null,"updated_at":"2011-11-09T13:43:16Z","labels":[],"comments":5,"closed_at":null,"url":"https://api.github.com/repos/wvanbergen/adyen/issues/35","body":"I know there has already been a commit implementing ELV for Adyen, however there is one *big* problem with it: \r\nIt's only usable for recurring payments, not for one time payments like with credit cards.\r\nAdjusting existing logic was out of the question since this would have led to spaghetti code.\r\n\r\nThe attached pull request hopefully fixes this with minimal changing of existing logic.\r\n\r\nWhat I did:\r\n\r\na) Add a new API method\r\nb) Add a new, minimal payment service\r\nc) Add an ELV module which encapsulates elv logic\r\nd) Add a new template\r\ne) Move elv logic out of the recurring payment service in one place\r\nf) Add specs\r\n\r\nAlso, the existing validations for ELV were too strict, checking for bank_location and bank_name as well - all you need is holder name, bank_location_id and number.\r\n\r\nI tested this pull request against the Adyen API and it worked as expected.\r\n\r\nPlease let me know what you think about this.","html_url":"https://github.com/wvanbergen/adyen/issues/35","title":"Implement non-recurring ELV payment.","number":35,"id":1410428,"created_at":"2011-08-15T20:41:22Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/ed5d98f3a41d99feee05c758ae751739?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"ed5d98f3a41d99feee05c758ae751739","url":"https://api.github.com/users/wvanbergen","login":"wvanbergen","id":15870},"updated_at":"2011-11-09T13:43:16Z","url":"https://api.github.com/repos/wvanbergen/adyen/issues/comments/2681237","body":"Any progress on this? Does this pull request fix the current failing specs?","id":2681237,"created_at":"2011-11-09T13:43:16Z"}}