{"shas":[["3e11aa47eafb2493cde63687359e8066e4a2a7b5","121e2a1f9ac7c93bff05080563bf586498521b0d@fb.com","[Fix] Fix slow_tests failure\n\nSummary:\nThere are a number of slow tests failed (e.g., TestExceptions, TestArrayInit)\nbecause of duplicated symbols of s_singleton in both libtest.so and\nlibhphp_runtime.so as it was defined inside a function. I moved it out as a\nstatic class variable.\nTask ID: #\n\nBlame Rev:\n\nReviewers:\nqigao, qixin\nCC:\nhphp-diffs@lists.facebook.com\nTest Plan:\nmake fast_tests\nmake slow_tests\nRevert Plan:\n\nTags:\n\n- begin *PUBLIC* platform impact section -\nBugzilla: #\n- end platform impact -\n\nDifferential Revision: 229385","myang"],["33a0a52697b0ab7edc0f1d358bfa4f36f7475ad7","ab0409c643cbc9b8244cacadadbe1e4cec33d237@fb.com","[Fix/Perf] Variant::bindNoVariant() without FAST_REF_COUNT_FOR_VARIANT\n\nSummary:\nThis method was declared with FAST_REF_COUNT_FOR_VARIANT, but might be used\nwithout it. This diff fixes the problem by implementing the no-fast-ref-count\ncase for bindNoVariant(). It also fixes a problem for Variant::destruct()\nwithout the macro.\n\nAlso, a Variant cannot have its m_data be null without KindOfUninit or\nKindOfNull, so it is not necessary to check for null if the source Variant is of\ntype KindOfString, KindOfArray, KindOfObject, or KindOfVariant.\n\nTest Plan:\nbuild, with and without FAST_REF_COUNT_FOR_VARIANT\nfast_tests\n\nReviewed By: macvicar\nReviewers: macvicar, myang\nCC: macvicar\nRevert Plan:\nOK\n\nDifferential Revision: 229394","qixin"],["9b1daf0ca80193fc9debcdac5682638bd5d11394","43c5050ee298fdde5451b74cf4c2d495c87514a4@fb.com","Eliminate __set_state from hphp's hierarchy.\n\nSummary:\nPHP's docs call __set_state a \"magic method\", but the only\nthing magical about it is that the strings generated by var_export call\nit when eval'ed. We can tolerate this by simply generating code for\nstatic __set_state normally.\n\nNB: this diff is against the release branch, and the bug it fixes is\nholding up the push.\n\nTest Plan:\nmake tests failed 1 test: test_ext_datetime, which\nfails in an unmodifed tree as well.\n\nI need help with the test plan here; in a perfect world, this would go out\ninto production ahead of the Tuesday push. If this is impossibly\naggressive, please tell me so!\n\nReviewed By: qixin\nReviewers: iproctor, hzhao, qixin, mwilliams\nCC: qixin, hphp-diffs@lists\nTasks:\n#526164: LATEST is broken with HPHP/thrift error\n\nRevert Plan:\nOK\n\nDifferential Revision: 229451","kma"],["4dd8e2b8b69057e7820a626f69a5f5087454cbe9","43c5050ee298fdde5451b74cf4c2d495c87514a4@fb.com","Hash pointers.\n\nSummary:\nUsing pointers' bitwise values as their hash is really\nunacceptable. The low-order bits are almost always clear, leading\nto heavy collision behavior on power-of-two-sized hash tables.\n\nThe only runtime use of note right now appears to be serialization code\nfor arrays, which probably is not too critical. Still, it made Jason\nand me nervous to see this in the code base.\n\nTest Plan:\n1605/1605 on the make tests. Reviewers: what else?\n\nReviewed By: je\nReviewers: jsobel, hzhao, qixin, je, mwilliams\nCommenters: mwilliams, qixin\nCC: kma, qixin, je, mwilliams, hphp-diffs@lists\nRevert Plan:\nOK\n\nDifferential Revision: 227094","kma"],["d94383e79ec27446414c862a619fc323fdfb0766","4baaee8a3e1d52ead025808fe14e6a867853d49e@fb.com","[Fix] Fix compilation failure due to incorrect type inference\n\nSummary:\nLorenzo Castelli reported an compilation failure due to the following code\n\n    <?php\n    function test($p) {\n      $b = 1;\n      do {\n        $a = sqrt($p);\n        $b = $p < 1 ? $a + $b : $a - $b;\n        $a = $p * 1;\n      } while (false);\n    }\n\nThis fixes that issue, and does some cleanup of type casting for binary and\nunary operators. But digging into this has reminded me how fragile this code is.\nThis is just a stop gap until it can be properly overhauled.\n\nTest Plan:\nfast_tests, slow_tests, flib/unit tests. Inspected generated code, and compared\ndiffs. www-dev shrank by 100k.\n\nReviewed By: macvicar\nReviewers: macvicar\nCC: macvicar\nRevert Plan:\nOK\n\nDifferential Revision: 229240","mwilliams"]],"repo":"facebook/hiphop-php","actor":"scottmac","ref":"refs/heads/master","size":5,"head":"d94383e79ec27446414c862a619fc323fdfb0766","actor_gravatar":"3c5a0318513620a5d04916e7deee6737","push_id":27779564}