{"comment":{"created_at":"2011-10-26T23:14:06Z","body":"Let's get discussion going on this again.  Looking through the top 100 pdf report I put together I'm seeing quite a few with cmyk jpegs.  We've also had a few issues filed by users now.\r\n\r\n@notmasteryet Once we turn on workers and have all the compatibility checks can we get this into pdf.js?  I'd be happy to work on it more if you don't have time.","updated_at":"2011-10-26T23:14:06Z","url":"https://api.github.com/repos/andreasgal/pdf.js/issues/comments/2537835","id":2537835,"user":{"avatar_url":"https://secure.gravatar.com/avatar/d33a62b635bb5d4f87235b86d853cb8a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"d33a62b635bb5d4f87235b86d853cb8a","url":"https://api.github.com/users/brendandahl","id":942640,"login":"brendandahl"}},"action":"created","issue":{"number":316,"created_at":"2011-08-09T13:25:51Z","pull_request":{"diff_url":"https://github.com/andreasgal/pdf.js/pull/316.diff","patch_url":"https://github.com/andreasgal/pdf.js/pull/316.patch","html_url":"https://github.com/andreasgal/pdf.js/pull/316"},"body":"So @notmasteryet implemented a DCTDecode library in javascript. For most images, it makes sense to use the built in jpeg decoder, but the browser does not support CMYK images well, so currently its being used for those.\r\n\r\nThe image for CMYK images still isnt correct (there still needs to be a color transform done) but its pretty close.\r\n\r\nAlso, this refactoring shows some of the downfalls of DOM images, in particular that if the image isn't loaded then nothing is displayed. We need some way to figure out when the image is loaded. ","comments":18,"title":"using jpeg implementation in javascript","updated_at":"2011-10-26T23:14:06Z","url":"https://api.github.com/repos/andreasgal/pdf.js/issues/316","id":1372264,"assignee":null,"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/b0d83f776a1c6e0e50b0478d5057ffb9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"b0d83f776a1c6e0e50b0478d5057ffb9","url":"https://api.github.com/users/sbarman","id":141888,"login":"sbarman"},"html_url":"https://github.com/andreasgal/pdf.js/issues/316","labels":[],"state":"open"},"legacy":{"issue_id":1372264,"comment_id":2537835}}