{"issue":{"state":"open","created_at":"2011-11-29T15:46:38Z","updated_at":"2011-11-29T15:46:41Z","user":{"gravatar_id":"e80c46e273aeef40f4fee102a03522cf","id":676671,"url":"https://api.github.com/users/computino","login":"computino","avatar_url":"https://secure.gravatar.com/avatar/e80c46e273aeef40f4fee102a03522cf?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":3,"body":"In upcoming events when using \"cal_noSpan\" it is always the startDate used as a reference / array key. For multiday-events, the event will not be displayed as soon as the start date is over. Currently I have something like that: the IAA Nutzfahrzeuge is opened from 25.09. till 02.10. From 26.09. the event was no longer displayed, although in my opinion (and more important: the customers) the date is still \"upcoming\".\n\nI changed very little code to change it to a more suitable logic:\n\n```\n  Events->addEvent line 272ff\n  if ($this->cal_noSpan)\n  {\n    $intDate = $intEnd?$intEnd:$intStart;\n    $intKey = date('Ymd', $intEnd?$intEnd:$intStart);\n  }\n  $this->arrEvents[$intKey][$intDate][] = $arrEvent;\n```\n\nIt works like a charm with the short and long version of upcoming events.\n\n--- _Originally created on October 1st, 2008, at 03:19pm (ID 153)_","assignee":{"gravatar_id":"87d2e5aefadcb310f9155df28c2b3582","id":1192057,"url":"https://api.github.com/users/leofeyer","login":"leofeyer","avatar_url":"https://secure.gravatar.com/avatar/87d2e5aefadcb310f9155df28c2b3582?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"number":153,"id":2385931,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"labels":[{"name":"calendar","color":"e6e6e6","url":"https://api.github.com/repos/contao/import/labels/calendar"},{"name":"Defect","color":"bd2c00","url":"https://api.github.com/repos/contao/import/labels/Defect"}],"title":"upcoming events - small change in logic for displaying events?","closed_at":null,"html_url":"https://github.com/contao/import/issues/153","url":"https://api.github.com/repos/contao/import/issues/153","milestone":{"state":"open","created_at":"2011-11-29T15:29:34Z","closed_issues":0,"due_on":null,"creator":{"gravatar_id":"87d2e5aefadcb310f9155df28c2b3582","id":1192057,"url":"https://api.github.com/users/leofeyer","login":"leofeyer","avatar_url":"https://secure.gravatar.com/avatar/87d2e5aefadcb310f9155df28c2b3582?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"number":11,"title":"2.7.1","description":"TYPOlight 2.7.1 (maintenance release)","url":"https://api.github.com/repos/contao/import/milestones/11","open_issues":1}},"action":"created","comment":{"created_at":"2011-11-29T15:46:40Z","updated_at":"2011-11-29T15:46:40Z","user":{"gravatar_id":"e80c46e273aeef40f4fee102a03522cf","id":676671,"url":"https://api.github.com/users/computino","login":"computino","avatar_url":"https://secure.gravatar.com/avatar/e80c46e273aeef40f4fee102a03522cf?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"It really depends on the view you want - in your example you could offer the possibility to join the user meeting later, or you just want to let people how long it will go on.\n\ncal_noSpan creates an ugly view, lacking overview with multiple long events. In my current live website there were 2 long events at the same time (IAA 25.09.2008 - 02.10.2008 and INTERGEO 30.09.2008 - 02.10.2008), so having cal_noSpan there would have been 11 events in the list, mixed daily. The visitor would have no overview at all which events starts and ends when.\n\nFor letting the user choose, 5 lines of code and a radio would be enough. \n\nuse ( ) start date ( ) end date (as the radio in mod event upcoming) and the lines I had above changed to:\n\n```\n  Events->addEvent line 272ff\n  if ($this->cal_noSpan && $this->useEndDate == true)\n  {\n    $intDate = $intEnd?$intEnd:$intStart;\n    $intKey = date('Ymd', $intEnd?$intEnd:$intStart);\n  }\n  $this->arrEvents[$intKey][$intDate][] = $arrEvent;\n```\n\nPossible solution?\n\n--- _Originally created on October 5th, 2008, at 11:05am_","id":2932028,"url":"https://api.github.com/repos/contao/import/issues/comments/2932028"}}