{"shas":[["fa417e57a68b7aa026ec5fd8c0471b6c60ca109f","b8c8dd8f747f1a510525ee56a3584fdc28e4c351@llnl.gov","Call udevadm trigger more safely\n\nSome udev hooks are not designed to be idempotent, so calling udevadm\ntrigger outside of the distribution's initialization scripts can have\nunexpected (and potentially dangerous) side effects.  For example, the\nsystem time may change or devices may appear multiple times.  See Ubuntu\nlaunchpad bug 320200 and this mailing list post for more details:\n\nhttps://lists.ubuntu.com/archives/ubuntu-devel/2009-January/027260.html\n\nTo avoid these problems we call udevadm trigger with --action=change\n--subsystem-match=block.  The first argument tells udev just to refresh\ndevices, and make sure everything's as it should be.  The second\nargument limits the scope to block devices, so devices belonging to\nother subsystems cannot be affected.\n\nThis doesn't fix the problem on older udev implementations that don't\nprovide udevadm but instead have udevtrigger as a standalone program.\nIn this case the above options aren't available so there's no way to\ncall call udevtrigger safely.  But we can live with that since this\nissue only exists in optional test and helper scripts, and most\nzfs-on-linux users are running newer systems anyways.","Ned Bass"],["d433c206515e567c52ce09589033405a0ae3716e","32d50ad1e384dcb9a5bf7e40fa470df5dabaf348@llnl.gov","Fix `make distclean` for `./configure --with-config=user\n\n    Making distclean in module\n    make[1]: Entering directory `/zfs/module'\n    make -C  SUBDIRS=`pwd`  clean\n    make: Entering an unknown directory\n    make: *** SUBDIRS=/zfs/module: No such file or directory.  Stop.\n\nWhen using --with-config=user the 'distclean' target would fail\nbecause it assumes the kernel configuration infrastrure is set up.\nThis is not the case, nor does it need to be, because the\n'--with-config=user' option will prune the entire ./module subtree\nfrom SUBDIRS.  This prevents most build rules from operating in the\n./module directory.\n\nHowever, the 'dist*' rules will still traverse this directory\nbecause it is listed in DIST_SUBDIRS.  This is correct because we\nneed to ensure the dist rules package the directory contents\nregardless of the configuration for the 'dist' rule.  The correct\nway to handle this is to only invoke the kernel build system as\npart of the 'clean' rule when CONFIG_KERNEL_TRUE is set.\n\nInitial fix provided by Darik Horn <dajhorn@vanadac.com>.\nThis commit is a slightly refined form of the original.","Brian Behlendorf"]],"repo":"dajhorn/pkg-zfs","actor":"dajhorn","ref":"refs/heads/upstream","size":2,"head":"d433c206515e567c52ce09589033405a0ae3716e","actor_gravatar":"ba25dd7bae959c5e7fedceaf946c7d05","push_id":28354195}