{"pull_request":{"merged_at":null,"user":{"login":"rmaiwald","id":999910,"url":"https://api.github.com/users/rmaiwald","avatar_url":"https://secure.gravatar.com/avatar/fb0e22aaf09eb02fb4bd9babfdaf904b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"fb0e22aaf09eb02fb4bd9babfdaf904b"},"title":"Typo in permission check","created_at":"2011-11-24T20:15:49Z","updated_at":"2011-12-19T15:37:31Z","review_comments":0,"state":"closed","id":527338,"patch_url":"https://github.com/zikula-modules/Scribite/pull/30.patch","html_url":"https://github.com/zikula-modules/Scribite/pull/30","closed_at":"2011-12-19T15:37:31Z","deletions":21,"mergeable":false,"issue_url":"https://github.com/zikula-modules/Scribite/issues/30","base":{"user":{"login":"zikula-modules","id":339454,"url":"https://api.github.com/users/zikula-modules","avatar_url":"https://secure.gravatar.com/avatar/e843dc3a2ebec92ac584e2cab6579289?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"e843dc3a2ebec92ac584e2cab6579289"},"ref":"master","sha":"2b09ea83ec4f657cc5c99262a840fc1c41a3166f","repo":{"git_url":"git://github.com/zikula-modules/Scribite.git","open_issues":11,"created_at":"2010-07-30T06:47:08Z","watchers":31,"updated_at":"2011-12-19T08:37:49Z","fork":false,"id":806926,"language":"JavaScript","html_url":"https://github.com/zikula-modules/Scribite","master_branch":null,"name":"Scribite","description":"Integrate WYSIWYG editors for Zikula and its modules. ","url":"https://api.github.com/repos/zikula-modules/Scribite","ssh_url":"git@github.com:zikula-modules/Scribite.git","clone_url":"https://github.com/zikula-modules/Scribite.git","forks":5,"pushed_at":"2011-12-19T08:37:49Z","owner":{"login":"zikula-modules","id":339454,"url":"https://api.github.com/users/zikula-modules","avatar_url":"https://secure.gravatar.com/avatar/e843dc3a2ebec92ac584e2cab6579289?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"e843dc3a2ebec92ac584e2cab6579289"},"homepage":"","svn_url":"https://svn.github.com/zikula-modules/Scribite","size":252,"private":false},"label":"zikula-modules:master"},"body":"Variable substitution in PHP will only work inside double quotes but not inside single quotes. In pnuser.php, functions scribite_user_run and scribite_user_loader the instance parameter for checkPermission must be double quoted:\r\n\r\n... SecurityUtil::checkPermission('scribite::', '$module::', ...\r\n\r\nchaged to\r\n\r\n... SecurityUtil::checkPermission('scribite::', \"$module::\", ...\r\n","additions":27,"number":30,"commits":2,"url":"https://api.github.com/repos/zikula-modules/Scribite/pulls/30","merged_by":null,"diff_url":"https://github.com/zikula-modules/Scribite/pull/30.diff","_links":{"review_comments":{"href":"https://api.github.com/repos/zikula-modules/Scribite/pulls/30/comments"},"html":{"href":"https://github.com/zikula-modules/Scribite/pull/30"},"self":{"href":"https://api.github.com/repos/zikula-modules/Scribite/pulls/30"},"comments":{"href":"https://api.github.com/repos/zikula-modules/Scribite/issues/30/comments"}},"comments":0,"head":{"user":{"login":"rmaiwald","id":999910,"url":"https://api.github.com/users/rmaiwald","avatar_url":"https://secure.gravatar.com/avatar/fb0e22aaf09eb02fb4bd9babfdaf904b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"fb0e22aaf09eb02fb4bd9babfdaf904b"},"ref":"patch-1","sha":"c922205dcb10415a3b2278804483a5b0d693102a","repo":{"git_url":"git://github.com/rmaiwald/Scribite.git","open_issues":0,"created_at":"2011-11-24T20:10:29Z","watchers":1,"updated_at":"2011-11-24T20:12:45Z","fork":true,"id":2845734,"language":"JavaScript","html_url":"https://github.com/rmaiwald/Scribite","master_branch":null,"name":"Scribite","description":"Integrate WYSIWYG editors for Zikula and its modules. ","url":"https://api.github.com/repos/rmaiwald/Scribite","ssh_url":"git@github.com:rmaiwald/Scribite.git","clone_url":"https://github.com/rmaiwald/Scribite.git","forks":0,"pushed_at":"2011-11-24T20:12:25Z","owner":{"login":"rmaiwald","id":999910,"url":"https://api.github.com/users/rmaiwald","avatar_url":"https://secure.gravatar.com/avatar/fb0e22aaf09eb02fb4bd9babfdaf904b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"fb0e22aaf09eb02fb4bd9babfdaf904b"},"homepage":"http://code.zikula.org/scribite/","svn_url":"https://svn.github.com/rmaiwald/Scribite","size":96,"private":false},"label":"rmaiwald:patch-1"},"changed_files":3,"merged":false},"number":30,"action":"closed"}