{"comment":{"created_at":"2011-10-07T21:02:18Z","body":"Ok, it's done. it was trivial enough that I don't think it needed another review. I've merged it into master.\r\nAbout the generating of diff, if you could do it, it would be better since I'm not sure if you have a script to autogen it out of the git log or you use some other way of generating it.\r\nBy the way, why isn't ps3toolchain just doing a git clone from this repo directly ?","updated_at":"2011-10-07T21:02:18Z","url":"https://api.github.com/repos/ps3dev/newlib-1.19.0-PS3/issues/comments/2328227","id":2328227,"user":{"avatar_url":"https://secure.gravatar.com/avatar/93be0d1ccc59145ea00f7c630a2066d6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/kakaroto","id":27990,"login":"kakaroto"}},"action":"created","issue":{"number":3,"created_at":"2011-09-26T07:05:38Z","pull_request":{"diff_url":null,"patch_url":null,"html_url":null},"body":"The cos/sin functions code is very stupid. I've tracked down a bug in the EFL code (used for an animation) to newlib's implementation of cos/sin, where it will return the input parameter if it's above a limit.\r\nHere is the code used : http://pastie.org/2587298\r\nIt's in newlib/libm/mathfp/s_sine.c\r\nBasically the limit is 210828714.0, and for any 'x' value above that, it will return 'x' (technically, if you're outside the domain, it should return NaN, not x).\r\nThat YMAX value is so small that if you try to run an animation using the timeval.tv_sec (from gettimeofday) then the cos or sin will always return the same value and your animation will be completely screwed.\r\nThere is no reason to have a limit and this should be fixed. I'm sure many others have had the same issue (besides, the code is stupid enough to make sure the 'y' is always positive then it checks if it's negative...)","comments":20,"title":"sine and cosine functions are being stupid","updated_at":"2011-10-07T21:02:18Z","url":"https://api.github.com/repos/ps3dev/newlib-1.19.0-PS3/issues/3","id":1737240,"assignee":null,"milestone":null,"closed_at":"2011-10-07T21:02:18Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/93be0d1ccc59145ea00f7c630a2066d6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/kakaroto","id":27990,"login":"kakaroto"},"html_url":"https://github.com/ps3dev/newlib-1.19.0-PS3/issues/3","labels":[],"state":"closed"},"legacy":{"issue_id":1737240,"comment_id":2328227}}