{"number":46,"pull_request":{"number":46,"issue_url":"https://github.com/scrapy/scrapy/issues/46","head":{"repo":{"master_branch":null,"name":"scrapy","created_at":"2011-10-12T20:03:28Z","size":116,"clone_url":"https://github.com/mattd/scrapy.git","private":false,"updated_at":"2011-10-12T20:12:11Z","watchers":1,"ssh_url":"git@github.com:mattd/scrapy.git","url":"https://api.github.com/repos/mattd/scrapy","git_url":"git://github.com/mattd/scrapy.git","language":"Python","fork":true,"svn_url":"https://svn.github.com/mattd/scrapy","id":2564971,"pushed_at":"2011-10-12T20:11:58Z","open_issues":0,"homepage":"http://scrapy.org","description":"Scrapy, a fast high-level screen scraping and web crawling framework for Python.","forks":0,"html_url":"https://github.com/mattd/scrapy","owner":{"avatar_url":"https://secure.gravatar.com/avatar/577dd287eff3b15edd240c55ec089577?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"577dd287eff3b15edd240c55ec089577","url":"https://api.github.com/users/mattd","id":119057,"login":"mattd"}},"label":"mattd:master","sha":"8a5a01bf3fd28a1a1cdb1e5083ae08724e0e4707","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/577dd287eff3b15edd240c55ec089577?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"577dd287eff3b15edd240c55ec089577","url":"https://api.github.com/users/mattd","id":119057,"login":"mattd"}},"merged_by":null,"created_at":"2011-10-12T20:20:32Z","changed_files":1,"merged":false,"body":"My attempts to use the PickleItemExporter were resulting in invalid pickle files. It took me awhile to figure out that the cause of the problem was the the Item keys were being exhausted after the first run of export_item. The result was that the first pickled item included both keys and values where subsequent Items had only values. This broke the pickle and made it unloadable.\r\n\r\nUnfortunately, I'm not *totally* sure where the bug was coming from. The call to item.iterkeys() in _get_serialized_fields seems to be what's blowing up, so it's almost certainly a problem with the use of generators. The code that was here is what I would have written, so I'm a bit baffled.\r\n\r\nThis commit, however, does fix the problem.","comments":1,"title":"Fix big in PickleItemExporter that created invalid pickle dumps.","additions":4,"diff_url":"https://github.com/scrapy/scrapy/pull/46.diff","updated_at":"2011-10-25T04:39:28Z","url":"https://api.github.com/repos/scrapy/scrapy/pulls/46","id":398152,"patch_url":"https://github.com/scrapy/scrapy/pull/46.patch","mergeable":false,"merged_at":null,"commits":1,"closed_at":"2011-10-25T04:39:28Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/577dd287eff3b15edd240c55ec089577?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"577dd287eff3b15edd240c55ec089577","url":"https://api.github.com/users/mattd","id":119057,"login":"mattd"},"deletions":2,"html_url":"https://github.com/scrapy/scrapy/pull/46","base":{"repo":{"master_branch":null,"name":"scrapy","created_at":"2010-02-22T02:01:14Z","size":552,"clone_url":"https://github.com/scrapy/scrapy.git","private":false,"updated_at":"2011-10-25T04:37:10Z","watchers":293,"ssh_url":"git@github.com:scrapy/scrapy.git","url":"https://api.github.com/repos/scrapy/scrapy","git_url":"git://github.com/scrapy/scrapy.git","language":"Python","fork":false,"svn_url":"https://svn.github.com/scrapy/scrapy","id":529502,"pushed_at":"2011-10-25T04:37:00Z","open_issues":36,"homepage":"http://scrapy.org","description":"Scrapy, a fast high-level screen scraping and web crawling framework for Python.","forks":44,"html_url":"https://github.com/scrapy/scrapy","owner":{"avatar_url":"https://secure.gravatar.com/avatar/4b1f68760dddf81c5cf5da23b592ffe2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"4b1f68760dddf81c5cf5da23b592ffe2","url":"https://api.github.com/users/scrapy","id":733635,"login":"scrapy"}},"label":"scrapy:master","sha":"43b79afc9cdee1cb9eeba9c6bd56666db91f3011","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/4b1f68760dddf81c5cf5da23b592ffe2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"4b1f68760dddf81c5cf5da23b592ffe2","url":"https://api.github.com/users/scrapy","id":733635,"login":"scrapy"}},"state":"closed"},"action":"closed"}