{"shas":[["ffae7b19e69fb7d0e44340cb8739c35ab3a7a41b","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Slightly loosen the mention regexp to allow for \"Go ask @tomo.\"\n\nSummary: Currently, we incorrectly flag these under the \"@lists.com\" rule.\nTest Plan:\nhttps://secure.phabricator.com/file/view/PHID-FILE-887c2bc66eb9d47d02f4/\nReviewed By: tomo\nReviewers: tomo\nCC: aran, epriestley, tomo\nDifferential Revision: 708","epriestley"],["8df62d535279ba72f4cfa28c15655b95181946ba","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Allow users to associate SSH Public Keys with their accounts\n\nSummary:\nWith the sshd-vcs thing I hacked together, this will enable Phabricator to host\nrepositories without requiring users to have SSH accounts.\n\nI also fixed \"subporjects\" and added an explicit ENGINE to it.\n\nTest Plan: Created, edited and deleted public keys. Attempted to add the same\npublic key twice. Attempted to add invalid and unnamed public keys.\nReviewed By: aran\nReviewers: jungejason, tuomaspelkonen, aran, cadamo, codeblock\nCC: aran, epriestley\nDifferential Revision: 711","epriestley"],["2a894438ae33288e638d7a675f86913eac774782","a809f56716ec985d30f4c18bbebd4ac4629a8988@gmail.com","Add a 'description' field to Phriction\n\nSummary:\nAdd a new column to PhrictionContent called 'comment' or 'description' or\nsomething\n        Add an optional field to the Phriction document editing interface that\nallows you to add a comment\n\nTest Plan:\nRun the sql patch to modify phriction_content table\n           Create a new wiki page in Phriction\n           Type in words in description field and save the page\n           Visit this page and click \"Edit Page\" button\n           The content in the desciption field is saved\n\nReviewed By: epriestley\nReviewers: epriestley, hsb, codeblock\nCommenters: codeblock\nCC: aran, codeblock, hwang, epriestley\nDifferential Revision: 709","Hua Wang"],["2de071ce3ac2cbcafd3547b5053e391033b155b5","febfe31bdb2d862e181c7fb49f402480a5a7b3f1@yahoo.com","Merge pull request #42 from hwang36/master\n\nT341 Add a 'description' field to Phriction for annotating edits","Jun Ge"],["6e08a9215ddd798e847b0e5cd6208a074b5c6f35","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Move \"Preferences\" to \"Settings\"\n\nSummary:\nIt makes more sense to just make this a settings panel rather than a standalone\napp, particularly since setting panels are relatively well separated now.\n\nAlso default-disabled the SSH Keys interface since it won't currently be useful\nfor most installs.\n\nTest Plan: Edited preferences.\nReviewed By: jungejason\nReviewers: tuomaspelkonen, jungejason, aran\nCC: aran, jungejason\nDifferential Revision: 716","epriestley"],["da8beefa6c0b646c2a0fc98247a1ec0b5a9693dd","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Use AphrontFormLayoutView, not AphrontFormView, for GitHub 'Repository'\ninterface\n\nSummary:\nSee T58. When I originally wrote this interface you couldn't make a form that\nlooked like a form but wasn't really a form, so I made it a real form. That\nmeant you could hit \"return\" in the text input and submit the form, which didn't\ndo anything but is vaguely silly.\n\nAfter D422 there's a layout-only form element, so switch to that.\n\nTest Plan: Loaded the tab, hit return in the textarea, it didn't do a form\nsubmit.\nReviewed By: jungejason\nReviewers: jungejason, tuomaspelkonen, aran\nCC: aran, jungejason, epriestley\nDifferential Revision: 719","epriestley"],["26bca418289d204947c0c8df8bedb4b784d24cdf","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Improve setup process to detect 'open_basedir', 'date.timezone' and 'safe_mode'\nproblems\n\nSummary: Detect more PHP misconfigurations in setup.\nTest Plan: Broke my configuration, ran setup, it seemed to detect all the\nproblems and issue meaningful error messages.\nReviewed By: jungejason\nReviewers: hunterbridges, 10098, jungejason, tuomaspelkonen, aran\nCC: aran, jungejason\nDifferential Revision: 717","epriestley"],["eacd0f537007318f389ec2356c3c61d4bddd05b2","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Allow Maniphest task status to be changed on the \"Edit Task\" interface\n\nSummary: We omit a 'status' dropdown when creating a new task since it's silly\nto create a non-open task and would just clutter the interface, but there's no\nreason not to allow status to be edited on the \"Edit\" interface.\nTest Plan: Created a new task (no status dropdown). Edited a task, including\nchanging the task status.\nReviewed By: jungejason\nReviewers: toulouse, jungejason, tuomaspelkonen, aran\nCC: aran, jungejason\nDifferential Revision: 720","epriestley"],["8d26399cfdf44a696942c2b50eca4d5ebefccd04","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Remove unused EXPECTED_SCHEMA_VERSION constant\n\nSummary: This didn't end up getting used but I neglected to delete it.\nTest Plan: git grep\nReviewed By: jungejason\nReviewers: tuomaspelkonen, jungejason, aran\nCC: aran, jungejason\nDifferential Revision: 721","epriestley"],["0de2e03cc245723fd64f410f5fe22ee65f05f568","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Unify profile and avatar images, move profile editing into settings\n\nSummary: See T266. Combine these interfaces into one and move it to settings.\n\nTest Plan: Edited my profile and account.\n\nReviewers: codeblock, tcook, jungejason, tuomaspelkonen, aran\n\nCC:\n\nDifferential Revision: 722","epriestley"],["29e3a7dae35ed51ebaa596e8643134fc264667e2","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Slightly simplify SearchAttach controller\n\nSummary:\nI want clean this up enough that I can land D595 without making a complete mess,\nhere's a small simplification.\n\nMove object load logic into PhabricatorObjectHandleData.\n\nTest Plan: Attached tasks and revisions, merged tasks.\nReviewed By: aran\nReviewers: tuomaspelkonen, jungejason, aran\nCC: aran\nDifferential Revision: 724","epriestley"],["e00fae8436b59e60714727e27c1f91e785f854cb","1b6aa49f46e3e4d0fc1a60434e24b29758de9002@fb.com","Files can be set not to use 'ignore-all' by default.\n\nSummary:\nPython people don't seem to like the 'ignore-all' as default. Provide a way\nto configure which file types should not use 'ignore-all'.\n\nTest Plan:\nTested that it worked with bunch of Python of files and non-python\nfiles. Cache was disabled during the test.\n\nReviewed By: jungejason\nReviewers: epriestley, jungejason\nCommenters: epriestley\nCC: aran, jungejason, epriestley\nDifferential Revision: 713","tuomaspelkonen"],["aeae33b7d61fc11d1eff38f0fa96391f440dbcf1","08aa3197596775b3d1f1d3c62382dc7531e0571b@gmail.com","Key Value Store for ManiphestTask\n\nTest Plan: Look at a task detail. Some dummy attributes are automatically added in ManiphestTaskDetailController.\nReviewed By: epriestley\n\nDifferential Revision: 730","hunterbridges"],["9d94ea9fdf56c4f1c109945d995bb284c9e47922","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Restore user edit controller, remove profile edit controller\n\nSummary:\nI took the wrong route out of the URI map in\nrP0de2e03cc245723fd64f410f5fe22ee65f05f568.\n\nThe removed route was user account editing/creation.\n\nThe intended route was profile editing (now in Settings).\n\nTest Plan:\n  - Clicked \"Create New Account\", got account create interface instead of 404.\n  - Went to /profile/edit/, got 404 instead of class-not-found exception.\n\nReviewed By: moskov\nReviewers: moskov, jungejason, tuomaspelkonen, aran\nCC: aran, moskov\nDifferential Revision: 731","epriestley"],["4dc6552af943a6964ccec87a0ed188438840ad68","038b8a8e4869ae81b3b83c709d69d13f2885effc@fb.com","Restore \"author\" link to diffusion\n\nSummary: create the page by getting data from the search result.\nTest Plan:\nload page with url /author/, /author/valid_username, and\n/uathor/invalid_username, and verified that it works as expected.\n\nReviewed By: epriestley\nReviewers: epriestley, tuomaspelkonen\nCommenters: tuomaspelkonen\nCC: hwang, aran, tuomaspelkonen, epriestley, jungejason\nDifferential Revision: 723","Jason Ge"],["ede78b2ccc70246a1ef7681ede7ad51ca395f41f","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Improve Diffusion behavior for SVN file moves\n\nSummary:\nWe just weren't handling these at all reasonably, must have dropped the logic\nwhen they got ported.\n\nThis still isn't perfect: we have some display glitches around file names, so\nthe 'away' part renders as \"This file was moved to .\". I'll see if I can follow\nup and fix that, but this resolves the more immediate issue of the interface\njust not working at all.\n\nTest Plan: Moved and copied files in my test repository, verified they rendered\nsomewhat correctly.\nReviewed By: jungejason\nReviewers: tuomaspelkonen, jungejason, aran\nCC: aran, jungejason, epriestley\nDifferential Revision: 699","epriestley"],["218856e8b8073390c1740acb905c6d71bed58630","08aa3197596775b3d1f1d3c62382dc7531e0571b@gmail.com","Modified create workflow to support rapid templated task creation, made Task Edit repopulate user input array fields on error\n\nReviewers: epriestley\nTest Plan: Create a new task in Maniphest, then click \"Create Another Task Like This\"\n\nDifferential Revision: 734","hunterbridges"],["4efd36ccf552f6f64194c7ece88ee9c2c947b940","da89c66a11fa4819bd4b616a212a002358bfaaf8@javelinjs.com","Merge pull request #44 from hunterbridges/workflow-create\n\nModified create workflow to support rapid templated task creation, made T","Evan Priestley"],["879431fb504122a23af82354437d534371366a86","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Improve GC performance for Herald Transcripts\n\nSummary: This has to table scan a ginormous table right now, give it a fighting\nchance with a more usable key.\nTest Plan:\n  - Launched GC daemon, no errors.\n  - Used test console to create a new transcript.\n  - Viewed some old transcripts.\n  - Ran EXPLAIN on the SELECT and verified it was utilizing the garbageCollected\nkey.\n\nReviewed By: jungejason\nReviewers: jungejason, tuomaspelkonen, aran\nCC: aran, epriestley, jungejason\nDifferential Revision: 735","epriestley"],["ab0f09d115f3fee7d3dcdea8370781b07eb3c403","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Style tweaks for Conduit API console\n\nSummary:\n  - Use pretty JSON formatter for human-readable Conduit output\n  - Fix some whitespace issues with format/layout.\n\nTest Plan:\n  - Looked at conduit console.\n  - Looked at human-readable output of several calls.\n\nReviewed By: codeblock\nReviewers: codeblock, jungejason, tuomaspelkonen, aran\nCC: aran, codeblock\nDifferential Revision: 740","epriestley"]],"ref":"refs/heads/master","size":46,"head":"e10b5b0abd8d27acd82348a458bbbaaebd0a51f3","push_id":38482581}