{"ref":"refs/heads/master","commits":[{"author":{"name":"Drak","email":"75d686a353bfa2f371d9718ec34b93fbed799dbe@zikula.org"},"sha":"0fe8ac6149da1264762bc5a96be3423585c7d54d","message":"[EventDispatcher] Removed unused argument.","url":"https://api.github.com/repos/Burgov/symfony/commits/0fe8ac6149da1264762bc5a96be3423585c7d54d"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"632a99fd7c8250903579527c45e128f23de97906","message":"merged branch stealth35/fix_2599 (PR #2601)\n\nCommits\n-------\n\na245e15 [DomCrawler] trim URI in getURI\n\nDiscussion\n----------\n\n[DomCrawler] trim URI in getURI\n\nBug fix: yes\nFeature addition: no\nBackwards compatibility break: no\nSymfony2 tests pass: yes\nFixes the following tickets: #2599","url":"https://api.github.com/repos/Burgov/symfony/commits/632a99fd7c8250903579527c45e128f23de97906"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"45b218e7c4cb6f1d8280c6cd09b262395f8f24a4","message":"[Translation] added detection for circular references when adding a fallback catalogue","url":"https://api.github.com/repos/Burgov/symfony/commits/45b218e7c4cb6f1d8280c6cd09b262395f8f24a4"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"db6fea9fd014b9272627ee8c715368b7a1918741","message":"merged branch drak/eventdispatcher_opimization (PR #2597)\n\nCommits\n-------\n\n0fe8ac6 [EventDispatcher] Removed unused argument.\n\nDiscussion\n----------\n\n[EventDispatcher] Removed unused parameter in doDispatch().\n\nBug fix: no\nFeature addition: no\nBackwards compatibility break: no\nSymfony2 tests pass: yes\nFixes the following tickets: -\n\nRemoved unused parameter.\n\n---------------------------------------------------------------------------\n\nby Seldaek at 2011/11/10 02:30:01 -0800\n\nA simple $foo($arg) is faster than call_user_func, fine, but with all the if/else logic here are you sure it is still faster?\n\n---------------------------------------------------------------------------\n\nby drak at 2011/11/10 06:44:41 -0800\n\ncall_user_func is inordinately slow, I'll make some benchmarks. The if logic here is pretty, two conditionals for array callables or one conditional for closures/functions.\n\n---------------------------------------------------------------------------\n\nby drak at 2011/11/10 12:45:27 -0800\n\nAfter doing some benchmarks, there are savings to be made in all cases except when the listener is an instantiated object when it's marginally slower, so I've reverted these changes and made this PR just to remove the unused argument in `doDispatch()`. You can see the benchmark code here: https://gist.github.com/1356129.\n\n---------------------------------------------------------------------------\n\nby drak at 2011/11/10 12:46:55 -0800\n\nThis PR is ready for consideration.","url":"https://api.github.com/repos/Burgov/symfony/commits/db6fea9fd014b9272627ee8c715368b7a1918741"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"6b0e7c8c410bdc646e29b7af24d6664e5dd1d3ac","message":"[Translation] removed unneeded methods","url":"https://api.github.com/repos/Burgov/symfony/commits/6b0e7c8c410bdc646e29b7af24d6664e5dd1d3ac"},{"author":{"name":"ondrowan","email":"246283e426a574fea9fde11856cb62c37ac9eaa3@gmail.com"},"sha":"8351a112861cd1cc71fbe35d69455c504d2f6acf","message":"Added check for array fields to be integers in reverseTransform method. This prevents checkdate from getting strings as arguments and throwing incorrect ErrorException when submitting form with malformed (string) data in, for example, Date field. #2609","url":"https://api.github.com/repos/Burgov/symfony/commits/8351a112861cd1cc71fbe35d69455c504d2f6acf"},{"author":{"name":"ondrowan","email":"246283e426a574fea9fde11856cb62c37ac9eaa3@gmail.com"},"sha":"2582fcb1e1a29dbd95fe4258e093926af5a14d1d","message":"Added tests for string fix in DateTimeToArrayTransformer (8351a112861cd1cc71fbe35d69455c504d2f6acf).","url":"https://api.github.com/repos/Burgov/symfony/commits/2582fcb1e1a29dbd95fe4258e093926af5a14d1d"},{"author":{"name":"Jordan Alliot","email":"e3bc2b2f0dfb113c43eda4775d6ca6d790280615@gmail.com"},"sha":"e83e00a7b881e6d1eccdd8c3213ca78c7add2d37","message":"Fixed rendering of FileType (value is not a valid attribute for input[type=file])","url":"https://api.github.com/repos/Burgov/symfony/commits/e83e00a7b881e6d1eccdd8c3213ca78c7add2d37"},{"author":{"name":"Igor Wiedler","email":"78b6854e22ab09d4ae3dac29b92052963103b33e@wiedler.ch"},"sha":"ed1a6c2e453025ceff40193a1ac53aeb1f72647a","message":"[TwigBundle] Do not clean output buffering below initial level\n\nThis resulted in issues with PHPUnit 3.6, which will buffer all output and clean them in the end. Since\nwe cleaned their buffer, the subsequent clean would raise a warning. This is documented in issue 390 of\nthe PHPUnit tracker.\n\nCloses #2531.","url":"https://api.github.com/repos/Burgov/symfony/commits/ed1a6c2e453025ceff40193a1ac53aeb1f72647a"},{"author":{"name":"Igor Wiedler","email":"78b6854e22ab09d4ae3dac29b92052963103b33e@wiedler.ch"},"sha":"29e12affb064882d5599f16a8e13f8975148520c","message":"[TwigBundle] Extract output buffer cleaning to method","url":"https://api.github.com/repos/Burgov/symfony/commits/29e12affb064882d5599f16a8e13f8975148520c"},{"author":{"name":"Costin Bereveanu","email":"806e1630c170e704524b6b4a6104c1dcbfb9fe66@gmail.com"},"sha":"7cba0a07b6e34ca4721e7be12d610a5dc3f3a5d4","message":"Also identify FirePHP by the X-FirePHP-Version header","url":"https://api.github.com/repos/Burgov/symfony/commits/7cba0a07b6e34ca4721e7be12d610a5dc3f3a5d4"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"6140869baacf19f3b0a8c895426d9b231d87ae19","message":"Revert \"merged branch drak/eventdispatcher_opimization (PR #2597)\"\n\nThis reverts commit db6fea9fd014b9272627ee8c715368b7a1918741, reversing\nchanges made to 47b09f791b832761621348d6a526a303a5428522.","url":"https://api.github.com/repos/Burgov/symfony/commits/6140869baacf19f3b0a8c895426d9b231d87ae19"},{"author":{"name":"Joseph Rouff","email":"61a8e8e25c210b14444f4b48bf123c31a370886d@gmail.com"},"sha":"fb0379d3b7d42a9fa1ba88f6821e05fef19d0b12","message":"Fix some CheckStyle violations on Components.\n\nOn casts, Control signature etc.","url":"https://api.github.com/repos/Burgov/symfony/commits/fb0379d3b7d42a9fa1ba88f6821e05fef19d0b12"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"1a2b3cffd81da7be3581e340873595815e604c80","message":"merged branch schniper/patch-2 (PR #2622)\n\nCommits\n-------\n\n7cba0a0 Also identify FirePHP by the X-FirePHP-Version header\n\nDiscussion\n----------\n\nAlso identify FirePHP by the X-FirePHP-Version header","url":"https://api.github.com/repos/Burgov/symfony/commits/1a2b3cffd81da7be3581e340873595815e604c80"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"78f5ae28151a1399af832475f2e2cf42069826f8","message":"merged branch rouffj/cs (PR #2624)\n\nCommits\n-------\n\nfb0379d Fix some CheckStyle violations on Components.\n\nDiscussion\n----------\n\nFix some CheckStyle violations on Components.\n\nOn casts, Control signature etc.\n\nThis Pull request follow the #2618 (https://github.com/symfony/symfony/pull/2618) where @stof had some trouble to merge it.","url":"https://api.github.com/repos/Burgov/symfony/commits/78f5ae28151a1399af832475f2e2cf42069826f8"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"7475a3924c900d7eb46bee66ea316fab8dc007ed","message":"merged branch ondrowan/2.0 (PR #2614)\n\nCommits\n-------\n\n2582fcb Added tests for string fix in DateTimeToArrayTransformer (8351a112861cd1cc71fbe35d69455c504d2f6acf).\n8351a11 Added check for array fields to be integers in reverseTransform method. This prevents checkdate from getting strings as arguments and throwing incorrect ErrorException when submitting form with malformed (string) data in, for example, Date field. #2609\n\nDiscussion\n----------\n\nFix for #2609\n\nSecond take for fix for #2609, hope it's ok now. Tests are failing without my fix and passing with it.","url":"https://api.github.com/repos/Burgov/symfony/commits/7475a3924c900d7eb46bee66ea316fab8dc007ed"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"3922fb839ae573a6431590a012576f129767bc6c","message":"[Form] simplified previous merge","url":"https://api.github.com/repos/Burgov/symfony/commits/3922fb839ae573a6431590a012576f129767bc6c"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"0427b126c15a0a27cd7033375e30371ae6a4e516","message":"[Form] fixed previous merge","url":"https://api.github.com/repos/Burgov/symfony/commits/0427b126c15a0a27cd7033375e30371ae6a4e516"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"7f32043f1944e4e363bfb02903d4c0342a5bfdd9","message":"merged branch jalliot/file_widget (PR #2608)\n\nCommits\n-------\n\ne83e00a Fixed rendering of FileType (value is not a valid attribute for input[type=file])\n\nDiscussion\n----------\n\nFixed rendering of FileType\n\nBug fix: yes\nFeature addition: no\nBackwards compatibility break: no\nSymfony2 tests pass: yes\nFixes the following tickets: -\n\nAccording to the W3C validator, `value` is not a valid attribute for `input[type=file]`.\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/11/10 23:01:24 -0800\n\nInstead of creating yet another block, what about modifying the `field_widget` to not render the `value` attribute if the value is empty? Also, the PHP template must be fixed too.\n\n---------------------------------------------------------------------------\n\nby jalliot at 2011/11/11 02:02:52 -0800\n\n@fabpot Changed ;)","url":"https://api.github.com/repos/Burgov/symfony/commits/7f32043f1944e4e363bfb02903d4c0342a5bfdd9"},{"author":{"name":"Fabien Potencier","email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com"},"sha":"1940bec31b05c89015e712141120660ef9b26daf","message":"merged branch igorw/phpunit-ob-level (PR #2617)\n\nCommits\n-------\n\n29e12af [TwigBundle] Extract output buffer cleaning to method\ned1a6c2 [TwigBundle] Do not clean output buffering below initial level\n\nDiscussion\n----------\n\n[TwigBundle] Do not clean output buffering below initial level\n\nThis resulted in issues with PHPUnit 3.6, which will buffer all output and clean them in the end. Since\nwe cleaned their buffer, the subsequent clean would raise a warning. This is documented in [issue 390](https://github.com/sebastianbergmann/phpunit/issues/390) of\nthe PHPUnit tracker.\n\nCloses #2531.\n\nThis also affects FOSRestBundle's ExceptionController /cc @lsmith.\n\n---------------------------------------------------------------------------\n\nby fabpot at 2011/11/11 07:33:24 -0800\n\nI have a similar fix locally but I have not merged it yet as it looks a bit dirty (but I've not a better idea yet). Anyway, your PR is better than mine as you've added some unit tests already.","url":"https://api.github.com/repos/Burgov/symfony/commits/1940bec31b05c89015e712141120660ef9b26daf"}],"head":"2363748ba2c9e8769b03824dae578412a8a7c7f4","push_id":52766882,"size":150}