{"shas":[["091e891d0c61f7d3afef8b5b0cf9739473b6ea54","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","No need to call Process() in OnDeinitWindow as ProcessRenderLoop(true) does this","Jonathan Marshall"],["1fe79717ff10782266e8e2b8b483a0522c14a6ea","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","move update of frame time to immediately following flip, and pass in whether or not a flip occurred","Jonathan Marshall"],["1f97c3e9dc4e6ea991c8de9210c1a5bec468dc18","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","Add CTimeSmoother class for smoothing timestamps","Jonathan Marshall"],["d7c14268d663b067cc2f51102bdb72e48170658e","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","Enable the timesmoother for frame times","Jonathan Marshall"],["87b682734e78ae67d714c49ddeb9f0182a51fd81","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","make CApplication::FrameMove conditional to cleanup ProcessRenderLoop","Jonathan Marshall"],["927d5d4aa6fc33a26e1f8ff2e0bede3c4a2f6848","507f80ec5d5445eddde1af056cad3f549476ca60@gmail.com","Rebase of Unique ID field in profiles.xml for pull request.\n\nFull history below:\n\nSixth revision of implementation of Unique ID field in profiles.xml\n\n- This should be the final revision of the profiles.xml portion\n\n- Cleanup of unnecessarily added and changed whitespace\n\n- Changed nextIdProfile data integrity and migration routing from while() loop to max() test\n\n- Added one additional nextIdProfile++ to cover off aligning id's when a new profiles.xml is created because it is missing\n\n- Integration tested with deleting and adding profiles across restarts, as well as migration from old versions of profiles.xml and having no profiles.xml present.\n\nFifth revision of implementation of Unique ID field in profiles.xml\n\nRenamed CSettings::GetNextIdProfile() to CSettings::GetNextProfileID() for readability\n\nRemoved unneeded CSettings::IncrementNextIdProfile() and changed usage to m_nextIdProfile++\n\nAdded GetCurrentProfileId() for clean use in database selects, inserts, etc...\n\nFourth revision of implementation of Unique ID field in profiles.xml\n\n-Fixed data type on GetNextIdProfile()\n\n-AddProfile back to const input parameter\n\n-Changed CProfile::Load to take the nextIdProfile from Settings in when loading a profile to use if nothing is loaded.\n\n-Removed CProfie::setId() entirely\n\n-Combined data integrity implementation and incrementing mechanics on nextIdProfile to use only one method IncrementNextIdProfile()\n\n-Made small change to CProfile constructor usage in GUIDialogProfileSettings.cpp to pass in the nextIdProfile when creating new profiles.\n\nThird revision of implementation of Unique ID field in profiles.xml\n\n-Removed unneeded m_maxProfileId tracking variable and related methods.\n-Simplified handling migration from previous versions of profiles.xml and providing default values.\n-Tightened up CProfile::setId() to only allow setting in the m_id was a previously unset value (indicated by -1) and changed method to a bool to allow detection if setId() was successful or not.\n\nCode Changes:\n-Moved master profile detection from Profile.cpp to Settings.cpp\n-Changed profileId data types from unsigned int to signed int\n-Fixed unnecessary pass-by-reference in CProfile constructor\n\nCleanup:\n-ensured all tabs were converted to appropriate spaces\n\nTested with:\n-Adding profiles\n-Deleting profiles\n-Re-adding profiles after ones are deleted\n-Migrating an XML from a previous version that did not have ID's.\n\nRE: Background work for bug 11747\n\nImplementation of Unique Profile ID field in profile.xml\n\nThis is background work to get various Profile based Library statuses isolated by the active profile, starting with the Videos watched status.\n\nre bug 11747\n\nIncludes methods required to migrate existing configurations as well as setup data with ID's on a fresh installation.\n\nThe end result is we will have a unique ID that will not be re-used if new profiles are created. This should eventually be pulled out if and when the Profiles are moved to the database and the getId() method reworked to the DB calls.\n\n-- This is a combined commit of 4 previous and 1 new re-based for code review.\n\nFourth revision of implementation of Unique ID field in profiles.xml\n\n-Fixed data type on GetNextIdProfile()\n\n-AddProfile back to const input parameter\n\n-Changed CProfile::Load to take the nextIdProfile from Settings in when loading a profile to use if nothing is loaded.\n\n-Removed CProfie::setId() entirely\n\n-Combined data integrity implementation and incrementing mechanics on nextIdProfile to use only one method IncrementNextIdProfile()\n\n-Made small change to CProfile constructor usage in GUIDialogProfileSettings.cpp to pass in the nextIdProfile when creating new profiles.\n\nThird revision of implementation of Unique ID field in profiles.xml\n\n-Removed unneeded m_maxProfileId tracking variable and related methods.\n-Simplified handling migration from previous versions of profiles.xml and providing default values.\n-Tightened up CProfile::setId() to only allow setting in the m_id was a previously unset value (indicated by -1) and changed method to a bool to allow detection if setId() was successful or not.\n\nCode Changes:\n-Moved master profile detection from Profile.cpp to Settings.cpp\n-Changed profileId data types from unsigned int to signed int\n-Fixed unnecessary pass-by-reference in CProfile constructor\n\nCleanup:\n-ensured all tabs were converted to appropriate spaces\n\nTested with:\n-Adding profiles\n-Deleting profiles\n-Re-adding profiles after ones are deleted\n-Migrating an XML from a previous version that did not have ID's.\n\nRE: Background work for bug 11747\n\nFirst implementation of Unique ID field in profiles.xml\n\nIncludes methods required to migrate existing configurations.\n\nre bug 11750","Dak0ta"],["b43620d55f7cdea7b12710d524b4f45a4237ce68","4a8a58b73f4dac1394daf2ae6bd769d58f26ce4c@xbmc.org","Remove useless comment/code","CrystalP"],["01c6596541cafde150cc1a67e6fe167aa930e7ce","4a8a58b73f4dac1394daf2ae6bd769d58f26ce4c@xbmc.org","Removed useless code. The shader objects are not reused so there is no previous state to clean up.","CrystalP"],["9a8927040acedcdde2b2cf5d3be37b99e30dc3b5","4a8a58b73f4dac1394daf2ae6bd769d58f26ce4c@xbmc.org","Use a proper virtual destructor instead of a custom mechanism.\nIt did the same with more code and more room for errors down the line.","CrystalP"],["d2ed7547d52d9f53d4b463fc56a013d25391bebc","4a8a58b73f4dac1394daf2ae6bd769d58f26ce4c@xbmc.org","Replace Release() with standard object destuction.\n\nThe shader objects are not ref counted or reused so having a Release() method was misleading and useless. Regular delete operator/going out of scope are just fine to release resources.","CrystalP"],["1920f489e6ba2f1de270d6e9b1e937389499b53d","507f80ec5d5445eddde1af056cad3f549476ca60@gmail.com","Updated AddProfile() to cover off uses of m_vecProfiles.push_back(profile)\n\n-In response to cleanup comments I've moved some of the code that was repeated around validating and incrementing m_nextIdProfile into AddProfile() and replaced any specific code and calls to m_vecProfiles.push_back(profile) in Settings.cpp to AddProfile()\n\n-Re-did integration testing to ensure changes did not cause any side effects. (New profiles.xml, migration from old, adding/deleting profiles)","Dak0ta"],["b9e483e9980c553d7972486583f9c82dfd12b5fb","7c6e7fc748410c5437595b2f239785c5a42a9367@gmail.com","Merge pull request #306 from Dak0ta/master\n\nAdd Unique Identifier to Profiles in profiles.xml","jmarshallnz"],["bbf9ea510b8d2eea8be958d0bbe7917a98710113","37131632f0b0e3ae3c71c6e469aebd548212b919@xboxmediacenter.com","Merge pull request #310 from CrystalP/refactor-winshaders\n\nRefactor the Windows Shaders destruction","CrystalP"],["29bfb97ebd1706804ec43ddd4b72957434e2690f","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","Merge branch 'log_frame_times'\n\n* log_frame_times:\n  make CApplication::FrameMove conditional to cleanup ProcessRenderLoop\n  Enable the timesmoother for frame times\n  Add CTimeSmoother class for smoothing timestamps\n  move update of frame time to immediately following flip, and pass in whether or not a flip occurred\n  No need to call Process() in OnDeinitWindow as ProcessRenderLoop(true) does this\n\nConflicts:\n\txbmc/Application.cpp","Jonathan Marshall"],["a736c616fa71ebf51668f078d76f14ebe3ea7a04","d3c2066500e724dbb5469f360ea471abe5472d6a@void.org","fixed: (Part of) ticket #11783 - Video filenames are always cleaned when stacking is enabled","arnova"],["c6b108fab97a0b090d969ed123641d8309038443","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","fix infinite loop in CTimeSmoother::GetConvergent","Jonathan Marshall"],["49cceb1203c41dff663e290ffad0604559892174","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","if we say we're not messing with labels, we better restore the correct one","Jonathan Marshall"],["0002f0fba26a56eb18ac9aa3c3c5ce2ffd287be5","d7ebb597520c9a1d41b531f7085c438e5da0184a@never.you.mind","clean the xcode project of dupe'd files","Jonathan Marshall"],["c64e27c470408ade3f841d6028c4b231e37a7270","02eca53414771f613663be8f734feef58909dcd5@gmail.com","Changed: [Confluence] addon.xml resolution stuff to use the new standard instead of the old way","Jezz_X"],["4f0a8cce4143f3bc3533d660a465f4d24c9622f9","d3c2066500e724dbb5469f360ea471abe5472d6a@void.org","fixed: Cosmetics","arnova"]],"ref":"refs/heads/master","size":25,"head":"1273189e72dc3caec9ed94676ccd75c8a6219828","push_id":38098642}