{"comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/39d7a21e90f28c037e8446fbf536c62f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"39d7a21e90f28c037e8446fbf536c62f","url":"https://api.github.com/users/zackr","login":"zackr","id":727590},"position":15,"updated_at":"2011-11-17T16:57:33Z","commit_id":"c0e24af608bc7e2c259a398544e590ecb06b6655","url":"https://api.github.com/repos/apitrace/apitrace/comments/728036","line":594,"body":"On Thursday, November 17, 2011 10:58:32 AM José Fonseca wrote:\r\n> Zack,\r\n> \r\n> Internal format is an attribute of the image, but unlike unit/target/level\r\n> it doesn not idenfity it, ie., it's not possible to have two images with\r\n> the same unit/target/level and different image.\r\n\r\nSorry, I'm not sure what you mean. Yes, it's possible and it happens all the \r\ntime. Over a lifespan of an application there can be and usually are hundreds \r\nof images bound to the same unit/target/level.\r\n\r\n> This will make, e.g., comparing state dumps between textures of different\r\n> internal formats impossible.\r\n\r\nBut that is correct, isn't it?\r\nGL_TEXTURE0, GL_TEXTURE_2D, GL_R32_F, 0 level, 1025 x 493\r\nis not the same as\r\nGL_TEXTURE0, GL_TEXTURE_2D, GL_RGBA8, 0 level, 1025 x 493\r\nand without the format they will incorrectly compare as the same. \r\n\r\n> I'd prefer that this sort of meta data was passed separately of the image\r\n> label. The label should just uniquely identify the texture.\r\n\r\nAs mentioned the issue is that the label doesn't uniquely identify the image. \r\nWe don't pass at all the only thing that uniquely identifies the image - the \r\nobject name. Over large traces it's really very irritating to always see \r\nGL_TEXTURE0, GL_TEXTURE_2D bound but with no quick way of knowing what exactly \r\nit is.\r\nPersonally I think the label should be the object name, whether it's the same \r\nas the trace or not doesn't matter, it's still an unique identifier and all \r\nthe rest of the data should be passed as metadata. As long as the gui can get \r\nthe format it doesn't matter to me hough. It's simply that we can't visualize \r\nthe float surfaces very well so unless we list the format lots of images in \r\nthe gui seems to just be garbage.\r\n\r\nz","html_url":"https://github.com/apitrace/apitrace/commit/c0e24af608#commitcomment-728036","id":728036,"path":"glstate.cpp","created_at":"2011-11-17T16:57:33Z"}}