{"issue":{"pull_request":{"diff_url":"https://github.com/libgit2/libgit2/pull/456.diff","html_url":"https://github.com/libgit2/libgit2/pull/456","patch_url":"https://github.com/libgit2/libgit2/pull/456.patch"},"state":"closed","user":{"avatar_url":"https://secure.gravatar.com/avatar/194f9871684ffc7052bb8d702448af0a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"194f9871684ffc7052bb8d702448af0a","url":"https://api.github.com/users/brodie","login":"brodie","id":42407},"milestone":null,"labels":[],"assignee":null,"updated_at":"2011-10-29T02:32:32Z","closed_at":"2011-10-29T02:04:23Z","comments":11,"url":"https://api.github.com/repos/libgit2/libgit2/issues/456","body":"These two commits fix certain files being created with 0600 permissions instead of 0444 permissions, and it fixes directories being created with 0755 permissions instead of 0777 permissions.\r\n\r\nSee the individual commits for more information. I've made them against master with the idea that they can be rolled into a 0.15.1 stable release.","html_url":"https://github.com/libgit2/libgit2/issues/456","title":"Create objects, indexes, and directories with the right file permissions","number":456,"id":1896323,"created_at":"2011-10-13T00:50:10Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/1c611ca5a1b5aaf2da4ce23f2887de2d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"1c611ca5a1b5aaf2da4ce23f2887de2d","url":"https://api.github.com/users/carlosmn","login":"carlosmn","id":335443},"updated_at":"2011-10-29T02:32:32Z","url":"https://api.github.com/repos/libgit2/libgit2/issues/comments/2563159","body":"This breaks horribly on Windows:\r\n\r\n```\r\nSuite \"refs\": ..........................FFFFFF..FF\r\n  Failed (8 failures):\r\n  1) \"can force-rename a packed reference with the name of an existing loose and packed reference\" [test rename5 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:655]\r\n\tMethod failed: git_reference_lookup(&looked_up_ref, repo, packed_test_head_name)\r\n\tError: Failed to lookup reference. Reference doesn't exist\r\n  2) \"can force-rename a loose reference with the name of an existing loose reference\" [test rename6 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:670]\r\n\tMethod failed: open_temp_repo(&repo, REPOSITORY_FOLDER)\r\n  3) \"can not overwrite name of existing reference\" [test rename7 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:699]\r\n\tMethod failed: open_temp_repo(&repo, REPOSITORY_FOLDER)\r\n  4) \"can be renamed to a new name prefixed with the old name\" [test rename8 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:729]\r\n\tMethod failed: open_temp_repo(&repo, REPOSITORY_FOLDER)\r\n  5) \"can move a reference to a upper reference hierarchy\" [test rename9 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:758]\r\n\tMethod failed: open_temp_repo(&repo, REPOSITORY_FOLDER)\r\n  6) \"deleting a ref which is both packed and loose should remove both tracks in the filesystem\" [test delete0 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:787]\r\n\tMethod failed: open_temp_repo(&repo, REPOSITORY_FOLDER)\r\n  7) \"write a reflog for a given reference and ensure it can be read back\" [test reflog0 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:1059]\r\n\tMethod failed: open_temp_repo(&repo, REPOSITORY_FOLDER)\r\n  8) \"avoid writing an obviously wrong reflog\" [test reflog1 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t10-refs.c:1112]\r\n\tMethod failed: open_temp_repo(&repo, REPOSITORY_FOLDER)\r\nSuite \"repository\": ..FFFFFF...F\r\n  Failed (7 failures):\r\n  1) \"initialize a standard repo\" [test init0 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t12-repo.c:160]\r\n\tMethod failed: ensure_repository_init(TEMP_REPO_FOLDER, STANDARD_REPOSITORY, path_index, path_repository, TEMP_REPO_FOLDER)\r\n  2) \"initialize a bare repo\" [test init1 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t12-repo.c:169]\r\n\tMethod failed: ensure_repository_init(TEMP_REPO_FOLDER, BARE_REPOSITORY, NULL, path_repository, NULL)\r\n  3) \"Initialize and open a bare repo with a relative path escaping out of the current working directory\" [test init2 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t12-repo.c:196]\r\n\tMethod failed: git_futils_rmdir_r(TEMP_REPO_FOLDER, 1)\r\n\tError: Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to lookup reference. Reference doesn't exist\r\n  4) \"Open a bare repository that has just been initialized by git\" [test open0 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t12-repo.c:204]\r\n\tMethod failed: copydir_recurs(EMPTY_BARE_REPOSITORY_FOLDER, TEMP_REPO_FOLDER)\r\n  5) \"Open a standard repository that has just been initialized by git\" [test open1 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t12-repo.c:226]\r\n\tMethod failed: git_futils_rmdir_r(TEMP_REPO_FOLDER, 1)\r\n\tError: Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- \r\n  6) \"Open a bare repository with a relative path escaping out of the current working directory\" [test open2 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t12-repo.c:254]\r\n\tMethod failed: git_futils_rmdir_r(TEMP_REPO_FOLDER, 1)\r\n\tError: Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- \r\n  7) \"test discover\" [test discover0 @ C:\\jenkins\\workspace\\libgit2-win32-msvc\\tests\\t12-repo.c:443]\r\n\tMethod failed: git_futils_rmdir_r(TEMP_REPO_FOLDER, 1)\r\n\tError: Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Failed to remove directory `testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx` \r\n\t- Not a git repository (or any of the parent directories): testrepo.git/discover.git/sub_repo/sub/subsub/subsubsub","id":2563159,"created_at":"2011-10-29T02:32:32Z"}}