{"number":28,"pull_request":{"number":28,"issue_url":"https://github.com/martynsmith/node-irc/issues/28","head":{"repo":{"master_branch":null,"name":"node-irc","created_at":"2011-09-25T07:01:06Z","size":124,"clone_url":"https://github.com/fent/node-irc.git","private":false,"updated_at":"2011-10-10T03:16:13Z","watchers":1,"ssh_url":"git@github.com:fent/node-irc.git","url":"https://api.github.com/repos/fent/node-irc","git_url":"git://github.com/fent/node-irc.git","language":"JavaScript","fork":true,"svn_url":"https://svn.github.com/fent/node-irc","id":2453610,"pushed_at":"2011-10-10T03:16:12Z","open_issues":0,"homepage":"","description":"NodeJS IRC client library","forks":0,"html_url":"https://github.com/fent/node-irc","owner":{"gravatar_id":"3471337d7de26218e5fced27d186f020","avatar_url":"https://secure.gravatar.com/avatar/3471337d7de26218e5fced27d186f020?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/fent","id":933490,"login":"fent"}},"label":"fent:master","sha":"5b4082455d618c3b28c8b2334180102f42092666","ref":"master","user":{"gravatar_id":"3471337d7de26218e5fced27d186f020","avatar_url":"https://secure.gravatar.com/avatar/3471337d7de26218e5fced27d186f020?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/fent","id":933490,"login":"fent"}},"merged_by":null,"created_at":"2011-09-25T11:45:16Z","changed_files":2,"merged":false,"body":"Some people might find this useful if they want to use callbacks instead of emitters.\r\n\r\n### connect(retryCount, callback)\r\n### disconnect(mesage, callback)\r\n\r\nBoth arguments are still optional and if the first argument is a function, it will be treated as the callback.\r\n\r\nOh, and I also cleaned up a bit of the code in `join` and `part`.","comments":4,"title":"Added optional callbacks to connect and disconnect","additions":33,"diff_url":"https://github.com/martynsmith/node-irc/pull/28.diff","updated_at":"2011-10-27T05:35:42Z","_links":{"html":{"_href":"https://github.com/martynsmith/node-irc/pull/28"},"self":{"_href":"https://api.github.com/repos/martynsmith/node-irc/pulls/28"},"comments":{"_href":"https://api.github.com/repos/martynsmith/node-irc/issues/28/comments"},"review_comments":{"_href":"https://api.github.com/repos/martynsmith/node-irc/pulls/28/comments"}},"url":"https://api.github.com/repos/martynsmith/node-irc/pulls/28","id":353766,"patch_url":"https://github.com/martynsmith/node-irc/pull/28.patch","mergeable":false,"merged_at":null,"commits":5,"closed_at":"2011-10-27T05:35:42Z","user":{"gravatar_id":"3471337d7de26218e5fced27d186f020","avatar_url":"https://secure.gravatar.com/avatar/3471337d7de26218e5fced27d186f020?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/fent","id":933490,"login":"fent"},"deletions":11,"html_url":"https://github.com/martynsmith/node-irc/pull/28","review_comments":0,"base":{"repo":{"master_branch":null,"name":"node-irc","created_at":"2010-05-14T11:04:07Z","size":408,"clone_url":"https://github.com/martynsmith/node-irc.git","private":false,"updated_at":"2011-10-27T05:25:52Z","watchers":134,"ssh_url":"git@github.com:martynsmith/node-irc.git","url":"https://api.github.com/repos/martynsmith/node-irc","git_url":"git://github.com/martynsmith/node-irc.git","language":"JavaScript","fork":false,"svn_url":"https://svn.github.com/martynsmith/node-irc","id":666274,"pushed_at":"2011-10-27T05:25:52Z","open_issues":9,"homepage":"","description":"NodeJS IRC client library","forks":41,"html_url":"https://github.com/martynsmith/node-irc","owner":{"gravatar_id":"04b02c3f659fab92c0972f5ec52329f7","avatar_url":"https://secure.gravatar.com/avatar/04b02c3f659fab92c0972f5ec52329f7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/martynsmith","id":276501,"login":"martynsmith"}},"label":"martynsmith:master","sha":"5ad251ccbb67ae191b2ca427d23f8ac76de270e4","ref":"master","user":{"gravatar_id":"04b02c3f659fab92c0972f5ec52329f7","avatar_url":"https://secure.gravatar.com/avatar/04b02c3f659fab92c0972f5ec52329f7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/martynsmith","id":276501,"login":"martynsmith"}},"state":"closed"},"action":"closed"}