{"pull_request":{"state":"closed","user":{"avatar_url":"https://secure.gravatar.com/avatar/e69881c9d7afd5f0861baf803fad7538?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e69881c9d7afd5f0861baf803fad7538","url":"https://api.github.com/users/dpaneda","login":"dpaneda","id":715979},"deletions":15,"merged_by":{"avatar_url":"https://secure.gravatar.com/avatar/9782c7af1412a338925a56fbc0e17937?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"9782c7af1412a338925a56fbc0e17937","url":"https://api.github.com/users/jamwt","login":"jamwt","id":61509},"updated_at":"2011-11-02T22:09:06Z","commits":1,"base":{"ref":"master","repo":{"name":"stud","fork":false,"pushed_at":"2011-11-02T22:09:06Z","master_branch":null,"homepage":"","clone_url":"https://github.com/bumptech/stud.git","updated_at":"2011-11-02T22:09:06Z","open_issues":15,"forks":44,"private":false,"svn_url":"https://svn.github.com/bumptech/stud","language":"C","url":"https://api.github.com/repos/bumptech/stud","owner":{"avatar_url":"https://secure.gravatar.com/avatar/37b0ffea56947c2223bfdf46972e92a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"37b0ffea56947c2223bfdf46972e92a6","url":"https://api.github.com/users/bumptech","login":"bumptech","id":423539},"html_url":"https://github.com/bumptech/stud","description":"The Scalable TLS Unwrapping Daemon","size":428,"id":1877150,"watchers":261,"git_url":"git://github.com/bumptech/stud.git","created_at":"2011-06-10T17:48:30Z","ssh_url":"git@github.com:bumptech/stud.git"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/37b0ffea56947c2223bfdf46972e92a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"37b0ffea56947c2223bfdf46972e92a6","url":"https://api.github.com/users/bumptech","login":"bumptech","id":423539},"label":"bumptech:master","sha":"8012fe3731d6d013e1e060a0cf1e47903529bb56"},"diff_url":"https://github.com/bumptech/stud/pull/43.diff","closed_at":"2011-11-02T22:09:06Z","comments":0,"url":"https://api.github.com/repos/bumptech/stud/pulls/43","additions":40,"merged":true,"head":{"ref":"master","repo":{"name":"stud","fork":true,"pushed_at":"2011-10-20T11:27:10Z","master_branch":null,"homepage":"","clone_url":"https://github.com/dpaneda/stud.git","updated_at":"2011-10-20T11:27:11Z","open_issues":0,"forks":0,"private":false,"svn_url":"https://svn.github.com/dpaneda/stud","language":"C","url":"https://api.github.com/repos/dpaneda/stud","owner":{"avatar_url":"https://secure.gravatar.com/avatar/e69881c9d7afd5f0861baf803fad7538?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e69881c9d7afd5f0861baf803fad7538","url":"https://api.github.com/users/dpaneda","login":"dpaneda","id":715979},"html_url":"https://github.com/dpaneda/stud","description":"The Scalable TLS Unwrapping Daemon","size":172,"id":2612593,"watchers":1,"git_url":"git://github.com/dpaneda/stud.git","created_at":"2011-10-20T11:24:52Z","ssh_url":"git@github.com:dpaneda/stud.git"},"user":{"avatar_url":"https://secure.gravatar.com/avatar/e69881c9d7afd5f0861baf803fad7538?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"e69881c9d7afd5f0861baf803fad7538","url":"https://api.github.com/users/dpaneda","login":"dpaneda","id":715979},"label":"dpaneda:master","sha":"240a0627660cdf2fdb6add839a18c734b195c1e3"},"body":"The connection with the cliend does not use SO_KEEPALIVE. \r\n\r\nThe problem with that is that sometimes client connection can terminate in a total silently way. For example, a client can send a RST packet which get lost on the network and stud will never close the conn. When a lot of connections are being done through stud, this leads to an increasing number of open connections and memory used both in kernel and stud.\r\n\r\nWith this patch, we set the keepalive option on this socket to avoid the problem. The default for the Keepalive is 3600 seconds, but it can be changed with a new option (-k).","merged_at":"2011-11-02T22:09:06Z","review_comments":0,"html_url":"https://github.com/bumptech/stud/pull/43","_links":{"comments":{"href":"https://api.github.com/repos/bumptech/stud/issues/43/comments"},"html":{"href":"https://github.com/bumptech/stud/pull/43"},"review_comments":{"href":"https://api.github.com/repos/bumptech/stud/pulls/43/comments"},"self":{"href":"https://api.github.com/repos/bumptech/stud/pulls/43"}},"issue_url":"https://github.com/bumptech/stud/issues/43","number":43,"title":"Patch to set SO_KEEPALIVE on client socket","mergeable":null,"id":418183,"patch_url":"https://github.com/bumptech/stud/pull/43.patch","changed_files":1,"created_at":"2011-10-20T11:35:25Z"},"action":"closed","number":43}