{"issue":{"milestone":null,"title":"Add 'quiet' option to suppress screen output during %prun calls, edited dochelp","created_at":"2011-12-26T21:54:13Z","user":{"login":"andrewgiessel","id":1160997,"url":"https://api.github.com/users/andrewgiessel","avatar_url":"https://secure.gravatar.com/avatar/77da0aa9071dade4538ca6fe73a50c52?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"77da0aa9071dade4538ca6fe73a50c52"},"labels":[],"updated_at":"2011-12-30T01:14:18Z","state":"open","id":2660103,"closed_at":null,"html_url":"https://github.com/ipython/ipython/issues/1210","pull_request":{"patch_url":"https://github.com/ipython/ipython/pull/1210.patch","html_url":"https://github.com/ipython/ipython/pull/1210","diff_url":"https://github.com/ipython/ipython/pull/1210.diff"},"body":"Edited magic.py to add an extra option to magic_prun().  Specifically, added -q to suppress output to the screen via the pager.  This eases use of %prun to do profiling of multiple functions inside of another script.\r\n\r\n","number":1210,"url":"https://api.github.com/repos/ipython/ipython/issues/1210","comments":4,"assignee":null},"comment":{"created_at":"2011-12-30T01:14:18Z","user":{"login":"andrewgiessel","id":1160997,"url":"https://api.github.com/users/andrewgiessel","avatar_url":"https://secure.gravatar.com/avatar/77da0aa9071dade4538ca6fe73a50c52?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"77da0aa9071dade4538ca6fe73a50c52"},"updated_at":"2011-12-30T01:14:18Z","id":3307668,"body":"these are both excellent suggestions, thanks!\n\nbest,\n\nag\n\nOn Wed, Dec 28, 2011 at 13:24, Thomas <\nreply@reply.github.com\n> wrote:\n\n> Can I suggest you just do the new feature on its own, and if you want to\n> do substantial clean-ups, do them as a separate PR? It's fine to do a\n> couple of small cleanups in the same function, but beyond that it's hard to\n> see what's really changed.\n>\n> Also, please test `if key in dict` rather than `if key in dict.keys()`.\n> The former is perfectly standard Python, and also faster (looking up a key\n> in a dict is O(1), whereas dict.keys() produces a list, and searching that\n> is O(N)).\n>\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/ipython/ipython/pull/1210#issuecomment-3293555\n>\n\n\n\n-- \nAndrew Giessel, PhD\n\nDepartment of Neurobiology, Harvard Medical School\n220 Longwood Ave Boston, MA 02115\nph: 617.432.7971 email: andrew_giessel@hms.harvard.edu","url":"https://api.github.com/repos/ipython/ipython/issues/comments/3307668"},"action":"created"}