{"shas":[["31ec0119225a0556cf53f2c16d1f30337f9e1eaa","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Move some VCS-specific logic into VCS APIs\n\nSummary:\nWe have some git-specific logic on main pathways which should be in the API\nclass, move it around so \"arc lint\" with an engine works under Mercurial. This\nresovles the error @makinde reported:\n\n> PHP Catchable fatal error:  Argument 1 passed to\nArcanistBaseWorkflow::parseGitRelativeCommit() must be an instance of\nArcanistGitAPI, instance of ArcanistMercurialAPI given, called in\n/home/makinde/.arc_install/arcanist/src/workflow/lint/ArcanistLintWorkflow.php\non line 131 and defined in\n/home/makinde/.arc_install/arcanist/src/workflow/base/ArcanistBaseWorkflow.php\non line 830\n\nTest Plan: Ran \"arc diff\" in git and hg working copies, plus \"arc lint\" with a\nconfigured \"lint_engine\".\n\nReviewers: Makinde, aran, jungejason, nh, tuomaspelkonen\n\nReviewed By: Makinde\n\nCC: aran, Makinde\n\nDifferential Revision: 935","epriestley"]],"ref":"refs/heads/master","size":1,"head":"31ec0119225a0556cf53f2c16d1f30337f9e1eaa","push_id":42836352}