{"action":"closed","pull_request":{"state":"closed","review_comments":10,"created_at":"2011-12-05T14:21:42Z","updated_at":"2011-12-06T13:35:08Z","changed_files":6,"_links":{"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/698/comments"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/698/comments"},"html":{"href":"https://github.com/infinispan/infinispan/pull/698"},"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/698"}},"patch_url":"https://github.com/infinispan/infinispan/pull/698.patch","issue_url":"https://github.com/infinispan/infinispan/issues/698","user":{"gravatar_id":"f8752dd8747f09944cae7bee579ab8fb","id":504907,"url":"https://api.github.com/users/danberindei","login":"danberindei","avatar_url":"https://secure.gravatar.com/avatar/f8752dd8747f09944cae7bee579ab8fb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":2,"merged":false,"body":"Update: Don't integrate yet, I need to modify the pull req to support the old rehash/stateRetrieval config element as well as the new stateTransfer element.\r\nUpdate 2: I removed the ISPN-1475 commit from this pull request so that we can get it into CR1.\r\n\r\nhttps://issues.jboss.org/browse/ISPN-284\r\nhttps://issues.jboss.org/browse/ISPN-1475\r\n\r\nPlease have a look at the new state transfer configuration, I'm not sure if it's the \"right\" way to do it. (Maybe we can find better names for fetchInMemoryState/fetchPersistentState.)\r\n\r\nI implemented state splitting, each transferred state chunk will have a fixed number of cache entries. I considered serializing the state explicitly so I could configure the chunk size in bytes but I ultimately rejected it because sending partial entries in a state transfer command would be too complicated.\r\n\r\nI consolidated state transfer options to a stateTransfer configuration element (out of hash and stateRetrieval).\r\nI added a new chunkSize setting for chunked state transfer (ISPN-284).","deletions":43,"mergeable":true,"commits":1,"id":558391,"number":698,"merged_by":null,"base":{"user":{"gravatar_id":"0fb77c892345331382006ea0b2c8a020","id":458093,"url":"https://api.github.com/users/infinispan","login":"infinispan","avatar_url":"https://secure.gravatar.com/avatar/0fb77c892345331382006ea0b2c8a020?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"repo":{"pushed_at":"2011-12-06T13:34:38Z","created_at":"2010-11-04T12:33:19Z","updated_at":"2011-12-06T13:34:38Z","private":false,"clone_url":"https://github.com/infinispan/infinispan.git","name":"infinispan","watchers":123,"master_branch":null,"svn_url":"https://svn.github.com/infinispan/infinispan","language":"Java","forks":64,"owner":{"gravatar_id":"0fb77c892345331382006ea0b2c8a020","id":458093,"url":"https://api.github.com/users/infinispan","login":"infinispan","avatar_url":"https://secure.gravatar.com/avatar/0fb77c892345331382006ea0b2c8a020?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"id":1050944,"homepage":"http://www.infinispan.org","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","git_url":"git://github.com/infinispan/infinispan.git","html_url":"https://github.com/infinispan/infinispan","size":16704,"open_issues":1,"fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","ssh_url":"git@github.com:infinispan/infinispan.git"},"sha":"e0d1022b5700a2fc4766abc00b2981497665d38e","ref":"master","label":"infinispan:master"},"additions":209,"head":{"user":{"gravatar_id":"f8752dd8747f09944cae7bee579ab8fb","id":504907,"url":"https://api.github.com/users/danberindei","login":"danberindei","avatar_url":"https://secure.gravatar.com/avatar/f8752dd8747f09944cae7bee579ab8fb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"repo":{"pushed_at":"2011-12-06T12:57:55Z","created_at":"2010-12-01T12:42:11Z","updated_at":"2011-12-06T12:57:55Z","private":false,"clone_url":"https://github.com/danberindei/infinispan.git","name":"infinispan","watchers":1,"master_branch":null,"svn_url":"https://svn.github.com/danberindei/infinispan","language":"Java","forks":0,"owner":{"gravatar_id":"f8752dd8747f09944cae7bee579ab8fb","id":504907,"url":"https://api.github.com/users/danberindei","login":"danberindei","avatar_url":"https://secure.gravatar.com/avatar/f8752dd8747f09944cae7bee579ab8fb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"id":1128600,"homepage":"http://www.infinispan.org","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","git_url":"git://github.com/danberindei/infinispan.git","html_url":"https://github.com/danberindei/infinispan","size":172,"open_issues":0,"fork":true,"url":"https://api.github.com/repos/danberindei/infinispan","ssh_url":"git@github.com:danberindei/infinispan.git"},"sha":"11b78d5de01fdd69909106d41f219195a3180647","ref":"t_284_m","label":"danberindei:t_284_m"},"title":"ISPN-284 - Chunked rehashing and state transfer && ISPN-1475 - Clean up state transfer and rehashing configuration options","html_url":"https://github.com/infinispan/infinispan/pull/698","closed_at":"2011-12-06T13:35:08Z","diff_url":"https://github.com/infinispan/infinispan/pull/698.diff","url":"https://api.github.com/repos/infinispan/infinispan/pulls/698","merged_at":null},"number":698}