{"number":243,"pull_request":{"number":243,"issue_url":"https://github.com/nipy/nipype/issues/243","head":{"repo":{"master_branch":null,"name":"nipype","created_at":"2010-07-31T03:58:48Z","size":260,"clone_url":"https://github.com/satra/nipype.git","private":false,"updated_at":"2011-10-12T13:10:34Z","watchers":6,"ssh_url":"git@github.com:satra/nipype.git","url":"https://api.github.com/repos/satra/nipype","git_url":"git://github.com/satra/nipype.git","language":"Python","fork":true,"svn_url":"https://svn.github.com/satra/nipype","id":808813,"pushed_at":"2011-10-12T13:10:34Z","open_issues":0,"homepage":"http://nipy.org/nipype/","description":"Workflows and interfaces for neuroimaging packages","forks":1,"html_url":"https://github.com/satra/nipype","owner":{"avatar_url":"https://secure.gravatar.com/avatar/d3afc58453bc273dc015254e1d9581b3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/satra","id":184063,"login":"satra"}},"label":"satra:fix/node_cleanup","sha":"9222552868a0d377a74490dcf43e25f69f98243e","ref":"fix/node_cleanup","user":{"avatar_url":"https://secure.gravatar.com/avatar/d3afc58453bc273dc015254e1d9581b3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/satra","id":184063,"login":"satra"}},"merged_by":{"avatar_url":"https://secure.gravatar.com/avatar/5987ea33df23c6eee468867c347e04aa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/chrisfilo","id":238759,"login":"chrisfilo"},"created_at":"2011-10-03T16:00:50Z","changed_files":8,"merged":true,"body":"the first commit is the real change. the second is a code cleanup.\r\n\r\nfrom email exchange: \r\n\r\n> But I am talking about the apply_to_files inputs. I don't see why I would\r\n> like to keep them around.\r\n\r\nbut if you are applying to files, then the input files should be deleted, because the outputs get a different name (i believe). so i found the issue but you can get it to work even before that is merged see B below.\r\n\r\nA. while the node is running:\r\n\r\n(devpype)[satra@unwarped coregtest]$ ls\r\n_0xa9b9db8ce2c33c51de2fc16abb701d55_unfinished.json\trf5.mat\r\n_inputs.pklz\t\t\t\t\t\trf5.nii\r\n_node.pklz\t\t\t\t\t\trmeanf3.nii\r\n_report\t\t\t\t\t\t\trrf3.mat\r\nmeanf3.nii\t\t\t\t\t\trrf3.nii\r\npyscript_coregister.m\t\t\t\t\trrf5.mat\r\nrf3.mat\t\t\t\t\t\t\trrf5.nii\r\nrf3.nii\t\t\t\t\t\t\tstruct.nii\r\n\r\nB. with node.needed_outputs = ['coregistered_files']\r\nafter the node finished running:\r\n(devpype)[satra@unwarped temp]$ ls coregtest/\r\n_0x6923264e07d7198c986f2d2f5eca0ee5.json\tpyscript_coregister.m\r\n_inputs.pklz\t\t\t\t\tresult_coregtest.pklz\r\n_node.pklz\t\t\t\t\trrf3.nii\r\n_report\t\t\t\t\t\trrf5.nii\r\n\r\nC. with this pull request (keeps all outputs plus nipype specific things - we can clean this some more):\r\n\r\n(devpype)[satra@unwarped temp]$ ls coregtest/\r\n_0xa9b9db8ce2c33c51de2fc16abb701d55.json\tresult_coregtest.pklz\r\n_inputs.pklz\t\t\t\t\trmeanf3.nii\r\n_node.pklz\t\t\t\t\trrf3.nii\r\n_report\t\t\t\t\t\trrf5.nii\r\npyscript_coregister.m\r\n \r\n> Besides, anything that is not in the outputs should be deleted, as it is\r\n> using disk space and is not accessible to my Python code.\r\n\r\nwe can augment this pull request to clean more if necessary.\r\n","comments":3,"title":"Fix/node cleanup","additions":704,"diff_url":"https://github.com/nipy/nipype/pull/243.diff","updated_at":"2011-10-13T13:00:05Z","url":"https://api.github.com/repos/nipy/nipype/pulls/243","id":372798,"patch_url":"https://github.com/nipy/nipype/pull/243.patch","mergeable":null,"merged_at":"2011-10-13T13:00:05Z","commits":11,"closed_at":"2011-10-13T13:00:05Z","user":{"avatar_url":"https://secure.gravatar.com/avatar/d3afc58453bc273dc015254e1d9581b3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/satra","id":184063,"login":"satra"},"deletions":99,"html_url":"https://github.com/nipy/nipype/pull/243","base":{"repo":{"master_branch":null,"name":"nipype","created_at":"2010-07-22T17:06:49Z","size":1156,"clone_url":"https://github.com/nipy/nipype.git","private":false,"updated_at":"2011-10-13T13:00:05Z","watchers":42,"ssh_url":"git@github.com:nipy/nipype.git","url":"https://api.github.com/repos/nipy/nipype","git_url":"git://github.com/nipy/nipype.git","language":"Python","fork":false,"svn_url":"https://svn.github.com/nipy/nipype","id":791477,"pushed_at":"2011-10-13T13:00:05Z","open_issues":43,"homepage":"http://www.mit.edu/~satra/nipype-nightly/","description":"Workflows and interfaces for neuroimaging packages","forks":25,"html_url":"https://github.com/nipy/nipype","owner":{"avatar_url":"https://secure.gravatar.com/avatar/0fb4618f739b0e9b1d35a7560963a205?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/nipy","id":233707,"login":"nipy"}},"label":"nipy:master","sha":"43be9ec56d0e26e34072ad3173a973540b9fb2da","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/0fb4618f739b0e9b1d35a7560963a205?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/nipy","id":233707,"login":"nipy"}},"state":"closed"},"action":"closed"}