{"issue":{"created_at":"2011-11-28T14:01:28Z","state":"open","updated_at":"2011-11-28T17:32:13Z","user":{"gravatar_id":"f25c2b6770fff75ccef73d49bf25525a","id":112119,"url":"https://api.github.com/users/johnelse","avatar_url":"https://secure.gravatar.com/avatar/f25c2b6770fff75ccef73d49bf25525a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"johnelse"},"comments":2,"body":"Pool join and rolling pool upgrade checks now depend on PLATFORM_VERSION where previously they depended on PRODUCT_VERSION.\r\n\r\nPool join checks now also use the existence of the PRODUCT_BRAND key to distinguish between XCP and XenServer.","assignee":null,"id":2367509,"labels":[],"pull_request":{"patch_url":"https://github.com/xen-org/xen-api/pull/406.patch","html_url":"https://github.com/xen-org/xen-api/pull/406","diff_url":"https://github.com/xen-org/xen-api/pull/406.diff"},"number":406,"title":"EA-1012: Swizzle pool join and rolling pool upgrade","closed_at":null,"html_url":"https://github.com/xen-org/xen-api/issues/406","url":"https://api.github.com/repos/xen-org/xen-api/issues/406","milestone":null},"action":"created","comment":{"created_at":"2011-11-28T17:32:13Z","updated_at":"2011-11-28T17:32:13Z","user":{"gravatar_id":"2aef3d70406baad1bbf88618c4e16a4b","id":198586,"url":"https://api.github.com/users/djs55","avatar_url":"https://secure.gravatar.com/avatar/2aef3d70406baad1bbf88618c4e16a4b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","login":"djs55"},"body":"@johnelse: could you ask someone to review these patches for you? The pool join code is a slightly dangerous area, it would be good to have someone else confirm they think it's ok (apart from me that is)","id":2903011,"url":"https://api.github.com/repos/xen-org/xen-api/issues/comments/2903011"}}