{"issue":{"user":{"id":23423,"login":"trans","url":"https://api.github.com/users/trans","avatar_url":"https://secure.gravatar.com/avatar/45196398e9685000d195ec626d477f0e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"45196398e9685000d195ec626d477f0e"},"milestone":null,"title":"Encourage custom formatters to use a proper namespace.","created_at":"2011-12-14T13:59:25Z","labels":[],"state":"closed","updated_at":"2011-12-22T19:45:01Z","id":2551693,"pull_request":{"patch_url":"https://github.com/rspec/rspec-core/pull/541.patch","html_url":"https://github.com/rspec/rspec-core/pull/541","diff_url":"https://github.com/rspec/rspec-core/pull/541.diff"},"html_url":"https://github.com/rspec/rspec-core/issues/541","closed_at":"2011-12-17T09:43:43Z","number":541,"body":"The code could use more work, such as corresponding require code, but this addition marks the main idea of it.","url":"https://api.github.com/repos/rspec/rspec-core/issues/541","comments":9,"assignee":null},"comment":{"user":{"id":49391,"login":"myronmarston","url":"https://api.github.com/users/myronmarston","avatar_url":"https://secure.gravatar.com/avatar/42d4590355a1404230fbc9aff4dd377b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"42d4590355a1404230fbc9aff4dd377b"},"created_at":"2011-12-22T19:45:01Z","updated_at":"2011-12-22T19:45:01Z","id":3253861,"body":"> Also, current code uses eval to get constant from -f option, which is a security hole, so to speak. It really should use a more explicit const_get approach. Also, it could pick up the wrong constant inadvertently and possibly do some strange things.\r\n\r\nAgreed about that.   I'd prefer not to see `eval` here, too.\r\n\r\n> since it would not be proper to use tapy.rb and tapj.rb in the top of the lib/ space\r\n\r\nIt's good to be very careful about what you put in the folder that goes on the load path...but if you want both of these to be easily require'able and reference'able using `require \"tapy\"` and `--format TapY` or `require \"tapj\"` and `--format TapJ`...then I don't see the problem with putting them directly in lib so people can use them directly.\r\n\r\nThe main point is that it's important to be very, very selective about what goes directly in `lib`, and you should _never_ put a file there that conflicts with a known other ruby library file (i.e. `set.rb` from the stdlib).","url":"https://api.github.com/repos/rspec/rspec-core/issues/comments/3253861"},"action":"created"}