{"comment":{"created_at":"2011-10-16T14:29:59Z","body":"Oh, and `M_sun` is solar mass (at least that's what the comment above it says). \r\n\r\n`year` looks to me to be the tropical year in seconds (is that right, Thomas?)  I think `year` probable does not belong in constants though, as it would lead to a fair amount of confusion because of precisely these ambiguities - the time module (not in yet but being worked on) can take care of that stuff.","updated_at":"2011-10-16T14:29:59Z","url":"https://api.github.com/repos/astropy/astropy/issues/comments/2421156","id":2421156,"user":{"gravatar_id":"b2a66b4a75397bcd42fdd7bb399ee553","avatar_url":"https://secure.gravatar.com/avatar/b2a66b4a75397bcd42fdd7bb399ee553?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/eteq","id":346587,"login":"eteq"}},"action":"created","issue":{"number":21,"created_at":"2011-10-15T16:57:28Z","pull_request":{"diff_url":"https://github.com/astropy/astropy/pull/21.diff","patch_url":"https://github.com/astropy/astropy/pull/21.patch","html_url":"https://github.com/astropy/astropy/pull/21"},"body":"**Note:** this module is not ready for merging. I am opening this pull request so that we can review the current code and iterate on it first (with the ultimate goal of merging).\r\n\r\nA few notes:\r\n\r\n* I decided to always use ``_`` for subscripts and to use lowercase and uppercase as is usually conventional - but we can also switch to all lowercase if you think that would be best\r\n\r\n* I decided to spell out sun, jup, and earth to avoid a possible conflict between electron mass and earth mass (let me know if you have a better idea!).\r\n\r\n* The S.I. constants re-use the values from the cgs module so that we only need to change constants in one place.\r\n\r\n* There are no tests yet, as I'm not sure what tests would consist of in the case of constants. Maybe we can check for example that a certain dimensionless combination of constants in cgs is equal to that in S.I. (which would test the c.g.s to S.I conversion).\r\n\r\n* I need to double check the constants values, and we'll need several other people to vet them, since this is obviously very important to get right.\r\n\r\n* I need to add a documentation page","comments":7,"title":"Constants","updated_at":"2011-10-16T14:29:59Z","url":"https://api.github.com/repos/astropy/astropy/issues/21","id":1918135,"assignee":null,"milestone":null,"closed_at":null,"user":{"gravatar_id":"f586e2a9879fe0a55fd1e3ea529c664f","avatar_url":"https://secure.gravatar.com/avatar/f586e2a9879fe0a55fd1e3ea529c664f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/astrofrog","id":314716,"login":"astrofrog"},"html_url":"https://github.com/astropy/astropy/issues/21","labels":[],"state":"open"},"legacy":{"issue_id":1918135,"comment_id":2421156}}