{"number":38,"pull_request":{"number":38,"issue_url":"https://github.com/marcel/aws-s3/issues/38","head":{"repo":{"master_branch":null,"name":"aws-s3","created_at":"2011-10-11T21:42:38Z","size":116,"clone_url":"https://github.com/jjb/aws-s3.git","private":false,"updated_at":"2011-10-11T21:43:05Z","watchers":1,"ssh_url":"git@github.com:jjb/aws-s3.git","url":"https://api.github.com/repos/jjb/aws-s3","git_url":"git://github.com/jjb/aws-s3.git","language":"Ruby","fork":true,"svn_url":"https://svn.github.com/jjb/aws-s3","id":2558510,"pushed_at":"2011-10-11T21:43:02Z","open_issues":0,"homepage":"http://amazon.rubyforge.org","description":"AWS-S3 is a Ruby implementation of Amazon's S3 REST API","forks":0,"html_url":"https://github.com/jjb/aws-s3","owner":{"avatar_url":"https://secure.gravatar.com/avatar/75fb60cc633a994debfe8b3a19eb91cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/jjb","id":6097,"login":"jjb"}},"label":"jjb:prepare_path-escaping","sha":"be1f3110849af9d1576b8e13ab97e3071e1e4188","ref":"prepare_path-escaping","user":{"avatar_url":"https://secure.gravatar.com/avatar/75fb60cc633a994debfe8b3a19eb91cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/jjb","id":6097,"login":"jjb"}},"merged_by":null,"created_at":"2011-10-11T21:46:30Z","changed_files":1,"merged":false,"body":"Currently, if a file on s3 has a URI reserved character in its name, it's possible for it to make its way into the URL.\r\n\r\nSome browsers make a correct guess about dealing with this, and others don't. Depending on one's definition of correct. The point is, they will make different guesses, resulting in the timeout signature being incorrect in some cases.\r\n\r\nIn this patch are 2 failing tests. I couldn't find an obvious way to make them pass, so I'm submitting this first for your comment. If you agree that they should pass, I can try to find a solution.\r\n\r\n(the solution will probably involve splitting the path along **/**, `CGI.escaping`ing each part, then rejoining on **/**)","comments":0,"title":"Prepare path escaping","additions":27,"diff_url":"https://github.com/marcel/aws-s3/pull/38.diff","updated_at":"2011-10-11T21:46:30Z","url":"https://api.github.com/repos/marcel/aws-s3/pulls/38","id":394984,"patch_url":"https://github.com/marcel/aws-s3/pull/38.patch","mergeable":null,"merged_at":null,"commits":2,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/75fb60cc633a994debfe8b3a19eb91cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/jjb","id":6097,"login":"jjb"},"deletions":1,"html_url":"https://github.com/marcel/aws-s3/pull/38","base":{"repo":{"master_branch":null,"name":"aws-s3","created_at":"2008-06-06T07:42:02Z","size":264,"clone_url":"https://github.com/marcel/aws-s3.git","private":false,"updated_at":"2011-10-11T21:42:38Z","watchers":510,"ssh_url":"git@github.com:marcel/aws-s3.git","url":"https://api.github.com/repos/marcel/aws-s3","git_url":"git://github.com/marcel/aws-s3.git","language":"Ruby","fork":false,"svn_url":"https://svn.github.com/marcel/aws-s3","id":22826,"pushed_at":"2011-07-15T15:59:25Z","open_issues":36,"homepage":"http://amazon.rubyforge.org","description":"AWS-S3 is a Ruby implementation of Amazon's S3 REST API","forks":186,"html_url":"https://github.com/marcel/aws-s3","owner":{"avatar_url":"https://secure.gravatar.com/avatar/aefec48f6f83b6ead722c625c8edf78b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/marcel","id":245,"login":"marcel"}},"label":"marcel:master","sha":"5cd500f6dbc6cf5e9ca122f5802907818ed796b9","ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/aefec48f6f83b6ead722c625c8edf78b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/marcel","id":245,"login":"marcel"}},"state":"open"},"action":"opened"}