{"issue":{"created_at":"2011-12-02T23:42:52Z","state":"open","updated_at":"2011-12-03T00:36:00Z","comments":1,"user":{"gravatar_id":"82eb424af081d92cf7b06e4864e1927b","id":265838,"url":"https://api.github.com/users/tingham","login":"tingham","avatar_url":"https://secure.gravatar.com/avatar/82eb424af081d92cf7b06e4864e1927b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"While implementing I noticed a show-stopper when attempting to write a value that included two single quotes. Debugging revealed that apparently only one of the quotes was being properly escaped.\r\n\r\nI've implemented a fix that seems to work for me:\r\n\r\nhttps://github.com/tingham/node-orm/commit/46110a7eb0cec74bede5b27a6917d28d7bbf5aab\r\n\r\nI'd love to get some feedback on it - no idea if I'm being narrow-minded in my work around.\r\n\r\nThanks,\r\n\r\nThomas","assignee":null,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"id":2434483,"number":14,"labels":[],"title":"Quoted Value Santization Issue (mySQL)","html_url":"https://github.com/dresende/node-orm/issues/14","closed_at":null,"url":"https://api.github.com/repos/dresende/node-orm/issues/14","milestone":null},"action":"created","comment":{"created_at":"2011-12-03T00:36:00Z","updated_at":"2011-12-03T00:36:00Z","user":{"gravatar_id":"8953325768912c213e3805695ad8d6a9","id":157494,"url":"https://api.github.com/users/dresende","login":"dresende","avatar_url":"https://secure.gravatar.com/avatar/8953325768912c213e3805695ad8d6a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"That's an interesting way of escaping quotes. I have to better check mysql (and postgresql) to see if they have a native way of doing it. The problem with my initial replace is that it should replace globally and not just the first occurrence, I'm not sure your implementation is efficient (fast on hundreds of objects), but I'll check and let you know ;)","id":2997945,"url":"https://api.github.com/repos/dresende/node-orm/issues/comments/2997945"}}