{"issue":{"created_at":"2011-11-18T14:54:02Z","state":"open","updated_at":"2011-11-18T15:01:52Z","user":{"gravatar_id":"04b418ee23dae0e13762e8e39a5305fd","id":10998,"url":"https://api.github.com/users/rubiojr","login":"rubiojr","avatar_url":"https://secure.gravatar.com/avatar/04b418ee23dae0e13762e8e39a5305fd?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"comments":1,"body":"Hiya!\r\n\r\nI'm trying to connect to an ESX 4 (using the libvirt fog provider) that needs user/pass but it raises an exception if the little patch below is not applied:\r\n\r\n/home/rubiojr/.rvm/gems/ruby-1.9.3-p0/gems/fog-1.1.1/lib/fog/core/service.rb:193:in `validate_options': Unrecognized arguments: libvirt_username, libvirt_password (ArgumentError)\r\n\tfrom /home/rubiojr/.rvm/gems/ruby-1.9.3-p0/gems/fog-1.1.1/lib/fog/core/service.rb:58:in `new'\r\n\tfrom /home/rubiojr/.rvm/gems/ruby-1.9.3-p0/gems/fog-1.1.1/lib/fog/compute.rb:31:in `new'\r\n\tfrom fog_libvirt_esx_info.rb:37:in `<main>'\r\n\r\nNot sure if it's the right thing to do so I'm not submitting a pull request.\r\n\r\n--- libvirt/compute.rb.orig\t2011-11-18 15:45:44.157356945 +0100\r\n+++ libvirt/compute.rb\t2011-11-18 15:45:59.619547859 +0100\r\n@@ -8,6 +8,7 @@\r\n     class Libvirt < Fog::Service\r\n \r\n       requires :libvirt_uri\r\n+      recognizes :libvirt_username, :libvirt_password\r\n \r\n       model_path 'fog/libvirt/models/compute'\r\n       model       :server\r\n","assignee":null,"id":2280804,"pull_request":{"patch_url":null,"html_url":null,"diff_url":null},"number":616,"labels":[],"title":"libvirt provider missing libvirt_username and libvirt_password as \"recognized\" parameters?","closed_at":null,"html_url":"https://github.com/fog/fog/issues/616","milestone":null,"url":"https://api.github.com/repos/fog/fog/issues/616"},"action":"created","comment":{"created_at":"2011-11-18T15:01:52Z","updated_at":"2011-11-18T15:01:52Z","user":{"gravatar_id":"2a05e5e24cfce84b942634aea441b818","id":70908,"url":"https://api.github.com/users/jedi4ever","login":"jedi4ever","avatar_url":"https://secure.gravatar.com/avatar/2a05e5e24cfce84b942634aea441b818?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"body":"Ha, I guess was done differently in the past, maybe I provided it via the .fog file instead of via the call of the function. I think you're spot on with the patch. Send in a pull request, should be good.","id":2790031,"url":"https://api.github.com/repos/fog/fog/issues/comments/2790031"}}