{"pull_request":{"title":"Fix with_api and logging to file","merged_at":"2011-12-16T06:31:20Z","user":{"id":30812,"login":"sleeper","url":"https://api.github.com/users/sleeper","gravatar_id":"4605de69c4c3af3f48b8e829206cd4c2","avatar_url":"https://secure.gravatar.com/avatar/4605de69c4c3af3f48b8e829206cd4c2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"created_at":"2011-12-15T22:26:39Z","state":"closed","review_comments":0,"updated_at":"2011-12-16T06:31:20Z","id":600522,"patch_url":"https://github.com/postrank-labs/goliath/pull/118.patch","html_url":"https://github.com/postrank-labs/goliath/pull/118","closed_at":"2011-12-16T06:31:20Z","deletions":1,"mergeable":null,"issue_url":"https://github.com/postrank-labs/goliath/issues/118","base":{"user":{"id":550975,"login":"postrank-labs","url":"https://api.github.com/users/postrank-labs","gravatar_id":"3b679600ef91737ed500bc8d052355c4","avatar_url":"https://secure.gravatar.com/avatar/3b679600ef91737ed500bc8d052355c4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"ref":"master","sha":"4bd552b451a416e6e2f94097b6090278b8c15400","repo":{"open_issues":4,"created_at":"2011-01-06T21:25:45Z","watchers":869,"git_url":"git://github.com/postrank-labs/goliath.git","fork":false,"updated_at":"2011-12-16T06:31:20Z","id":1227666,"language":"Ruby","html_url":"https://github.com/postrank-labs/goliath","name":"goliath","description":"Goliath is a non-blocking Ruby web server framework","master_branch":null,"url":"https://api.github.com/repos/postrank-labs/goliath","forks":78,"clone_url":"https://github.com/postrank-labs/goliath.git","pushed_at":"2011-12-16T06:31:20Z","ssh_url":"git@github.com:postrank-labs/goliath.git","owner":{"id":550975,"login":"postrank-labs","url":"https://api.github.com/users/postrank-labs","gravatar_id":"3b679600ef91737ed500bc8d052355c4","avatar_url":"https://secure.gravatar.com/avatar/3b679600ef91737ed500bc8d052355c4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png"},"homepage":"http://goliath.io","size":520,"svn_url":"https://svn.github.com/postrank-labs/goliath","private":false},"label":"postrank-labs:master"},"body":"Current implementation of `:log_file` option in `with_api` is broken:\r\n\r\n* it tries to instantiate a `Logger` object (instead of `Log4R::Logger`)\r\n* it does not respect the `Log4r` API\r\n\r\nThis patch intends to fix this and add a `:log_stdout` as well as `:verbose` option.\r\n\r\nNote that some code could be factorized between `runner.rb` and `test_helper.rb` (mainly the setup of logger).\r\n\r\nI've also added specs to validate the logging options in `with_api` are working.\r\n","commits":4,"number":118,"additions":55,"url":"https://api.github.com/repos/postrank-labs/goliath/pulls/118","merged_by":{"id":10652,"login":"igrigorik","url":"https://api.github.com/users/igrigorik","gravatar_id":"a17f0025641b4be419a6cd3845e55dd2","avatar_url":"https://secure.gravatar.com/avatar/a17f0025641b4be419a6cd3845e55dd2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"diff_url":"https://github.com/postrank-labs/goliath/pull/118.diff","_links":{"review_comments":{"href":"https://api.github.com/repos/postrank-labs/goliath/pulls/118/comments"},"html":{"href":"https://github.com/postrank-labs/goliath/pull/118"},"self":{"href":"https://api.github.com/repos/postrank-labs/goliath/pulls/118"},"comments":{"href":"https://api.github.com/repos/postrank-labs/goliath/issues/118/comments"}},"comments":0,"head":{"user":{"id":30812,"login":"sleeper","url":"https://api.github.com/users/sleeper","gravatar_id":"4605de69c4c3af3f48b8e829206cd4c2","avatar_url":"https://secure.gravatar.com/avatar/4605de69c4c3af3f48b8e829206cd4c2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"ref":"fix_with_api","sha":"65e71bccef80fba3df76a3aa3e00b412b985928b","repo":{"open_issues":0,"created_at":"2011-11-22T08:48:19Z","watchers":1,"git_url":"git://github.com/sleeper/goliath.git","fork":true,"updated_at":"2011-12-15T22:20:21Z","id":2826439,"language":"Ruby","html_url":"https://github.com/sleeper/goliath","name":"goliath","description":"Goliath is a non-blocking Ruby web server framework","master_branch":null,"url":"https://api.github.com/repos/sleeper/goliath","forks":0,"clone_url":"https://github.com/sleeper/goliath.git","pushed_at":"2011-12-15T22:20:21Z","ssh_url":"git@github.com:sleeper/goliath.git","owner":{"id":30812,"login":"sleeper","url":"https://api.github.com/users/sleeper","gravatar_id":"4605de69c4c3af3f48b8e829206cd4c2","avatar_url":"https://secure.gravatar.com/avatar/4605de69c4c3af3f48b8e829206cd4c2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png"},"homepage":"http://goliath.io","size":124,"svn_url":"https://svn.github.com/sleeper/goliath","private":false},"label":"sleeper:fix_with_api"},"changed_files":2,"merged":true},"number":118,"action":"closed"}