{"pull_request":{"state":"open","deletions":1,"merged_by":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/950f430609c6de3f023db78dff9b23f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"950f430609c6de3f023db78dff9b23f4","url":"https://api.github.com/users/jdespatis","login":"jdespatis","id":919566},"updated_at":"2011-11-15T19:57:19Z","closed_at":null,"base":{"ref":"master","user":{"avatar_url":"https://secure.gravatar.com/avatar/dbbdb060113a80091749fe80be36cff7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","login":"ezsystems","id":295311},"repo":{"name":"ezpublish","fork":false,"master_branch":null,"pushed_at":"2011-11-15T13:10:08Z","open_issues":60,"clone_url":"https://github.com/ezsystems/ezpublish.git","updated_at":"2011-11-15T13:10:08Z","homepage":"http://ez.no/ezpublish","svn_url":"https://svn.github.com/ezsystems/ezpublish","private":false,"language":"PHP","forks":119,"url":"https://api.github.com/repos/ezsystems/ezpublish","owner":{"avatar_url":"https://secure.gravatar.com/avatar/dbbdb060113a80091749fe80be36cff7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","gravatar_id":"dbbdb060113a80091749fe80be36cff7","url":"https://api.github.com/users/ezsystems","login":"ezsystems","id":295311},"html_url":"https://github.com/ezsystems/ezpublish","description":"eZ Publish","size":171437,"id":715911,"git_url":"git://github.com/ezsystems/ezpublish.git","watchers":189,"created_at":"2010-06-11T15:47:13Z","ssh_url":"git@github.com:ezsystems/ezpublish.git"},"label":"ezsystems:master","sha":"babd7fafb32ffadcb1fbcf7c701a4df701ae9205"},"comments":0,"diff_url":"https://github.com/ezsystems/ezpublish/pull/204.diff","commits":1,"head":{"ref":"too-many-args11","user":{"avatar_url":"https://secure.gravatar.com/avatar/950f430609c6de3f023db78dff9b23f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"950f430609c6de3f023db78dff9b23f4","url":"https://api.github.com/users/jdespatis","login":"jdespatis","id":919566},"repo":{"name":"ezpublish","fork":true,"master_branch":null,"pushed_at":"2011-11-15T19:52:02Z","open_issues":0,"clone_url":"https://github.com/jdespatis/ezpublish.git","updated_at":"2011-11-15T19:52:02Z","homepage":"http://ez.no/ezpublish","svn_url":"https://svn.github.com/jdespatis/ezpublish","private":false,"language":"PHP","forks":0,"url":"https://api.github.com/repos/jdespatis/ezpublish","owner":{"avatar_url":"https://secure.gravatar.com/avatar/950f430609c6de3f023db78dff9b23f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"950f430609c6de3f023db78dff9b23f4","url":"https://api.github.com/users/jdespatis","login":"jdespatis","id":919566},"html_url":"https://github.com/jdespatis/ezpublish","description":"eZ Publish","size":380,"id":2568762,"git_url":"git://github.com/jdespatis/ezpublish.git","watchers":1,"created_at":"2011-10-13T11:05:28Z","ssh_url":"git@github.com:jdespatis/ezpublish.git"},"label":"jdespatis:too-many-args11","sha":"6a5c543068344e56e979cbefaff89869c7e4a43c"},"additions":1,"url":"https://api.github.com/repos/ezsystems/ezpublish/pulls/204","merged":false,"body":"Watchout for this commit!! I've done an assumption that may be wrong...\r\n\r\nFirst iniMatch is a function that exists only in the file ezfilepackagehandler.php\r\n\r\nIn order to solve this problem, 2 options:\r\n\r\n1/ as iniMatch supports currently 4 args, then just delete 5th arg whenever this function is called...\r\n\r\n2/ or add a 5th arg to iniMatch() method, that is done in that commit (look at fileExists() method in that class)\r\n    Because this function is performing a $triedFiles[] = $filePath; but if a 5th arg is not present, then all those affected values to $triedFiles would be lost. So I guess 2/ is the correct solution and the commit is correct, but please check intensively...","merged_at":null,"html_url":"https://github.com/ezsystems/ezpublish/pull/204","issue_url":"https://github.com/ezsystems/ezpublish/issues/204","_links":{"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish/issues/204/comments"},"html":{"href":"https://github.com/ezsystems/ezpublish/pull/204"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish/pulls/204/comments"},"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish/pulls/204"}},"review_comments":0,"title":"iniMatch only supports 4 args, but 2 calls uses 5 args","number":204,"mergeable":null,"id":497233,"changed_files":1,"patch_url":"https://github.com/ezsystems/ezpublish/pull/204.patch","created_at":"2011-11-15T19:57:19Z"},"action":"opened","number":204}