{"issue":{"pull_request":{"diff_url":"https://github.com/matplotlib/matplotlib/pull/572.diff","html_url":"https://github.com/matplotlib/matplotlib/pull/572","patch_url":"https://github.com/matplotlib/matplotlib/pull/572.patch"},"state":"open","user":{"avatar_url":"https://secure.gravatar.com/avatar/6c2496a73573bf0c9ac85f71db561475?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"6c2496a73573bf0c9ac85f71db561475","url":"https://api.github.com/users/cgohlke","login":"cgohlke","id":483428},"milestone":null,"labels":[],"updated_at":"2011-11-09T19:18:31Z","assignee":null,"comments":3,"closed_at":null,"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/572","body":"","html_url":"https://github.com/matplotlib/matplotlib/issues/572","number":572,"title":"Fix: use urllib instead of urllib2 on Python 3","id":2189258,"created_at":"2011-11-09T18:18:44Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/7e9e53dbe9781722d56e308c32387078?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"7e9e53dbe9781722d56e308c32387078","url":"https://api.github.com/users/efiring","login":"efiring","id":85125},"updated_at":"2011-11-09T19:18:31Z","url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/2685790","body":"On 11/09/2011 08:58 AM, cgohlke wrote:\n> 2to3 is not perfect and misses some use of urllib2, for example in `getattr(urllib2, 'quote', None)`, which this patch fixes. Alternatively one could try to write custom 2to3 fixes.\n>\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/matplotlib/matplotlib/pull/572#issuecomment-2685497\n\nOK; but at the very least, some explanation needs to go into the code as \na comment.  Before your patch, I think the code was internally \nconsistent, in the sense that when I scan it, it looks like everything \nthat is used is explicitly imported.  After your patch, this is not the \ncase; the code may work fine after 2to3 modifies it, but it looks \nwrong--it appears to be referencing names that have never been imported \nunder python 3.  It needs to look right, as well as work right.\n\nThis is all based on quick scanning, so maybe I am missing something \nobvious.","id":2685790,"created_at":"2011-11-09T19:18:31Z"}}