{"issue":{"state":"open","pull_request":{"diff_url":null,"html_url":null,"patch_url":null},"user":{"avatar_url":"https://secure.gravatar.com/avatar/246c159d5e8583a47de3f3e228580b62?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"246c159d5e8583a47de3f3e228580b62","url":"https://api.github.com/users/atong-tcs","login":"atong-tcs","id":1017595},"milestone":{"state":"open","open_issues":12,"url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones/1","due_on":"2011-11-30T08:00:00Z","creator":{"avatar_url":"https://secure.gravatar.com/avatar/71d0ca8310884ecff6f81a23768b73e3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"71d0ca8310884ecff6f81a23768b73e3","url":"https://api.github.com/users/awakecoding","login":"awakecoding","id":295841},"title":"1.0","description":"First release in the FreeRDP 1.x series","number":1,"closed_issues":182,"created_at":"2011-09-08T22:41:34Z"},"assignee":null,"updated_at":"2011-11-08T05:22:23Z","labels":[{"name":"feature","color":"d7e102","url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels/feature"}],"closed_at":null,"comments":3,"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/192","body":"#125 described that there are remaining issues in nscodec, but did not reference what they actually were in the issue or the code.\r\n\r\nHere are some of my findings.\r\n\r\nWith chroma-subsampled bitmaps, the chrome decompressed lengths do not match the example in ms-rdpnsc 4. (though I am not sure if the supersampling code handles this correctly).\r\n\r\nThe rle decompression can cause a segv (nsc_rle_decode->memset). I'll post the full trace separately and try to grab the offending buffer.\r\n\r\nThe colors are not correct. My suspicion is this may be related to the alpha channel/drawing mode/what it's being transparent on top of.\r\n\r\nFor the time being, I recommend documenting the '--nsc' command line as experimental\r\n","html_url":"https://github.com/FreeRDP/FreeRDP/issues/192","title":"nscodec issues","number":192,"id":2090952,"created_at":"2011-10-30T15:35:54Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/6463e6094d534d416a29fedc9448d1d5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"6463e6094d534d416a29fedc9448d1d5","url":"https://api.github.com/users/jiten19","login":"jiten19","id":1000599},"updated_at":"2011-11-08T05:22:23Z","url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/2664003","body":"Hi atong,\r\nIf you can confirm it is indeed a bug in rle_decode can you post a gdb trace of it like the arguments passed to nsc_rle_decode() and for which  plane buffer (i =  0,1,2 ) in for loop in nsc_rle_decompress_data() ?\r\nProbably a problem with origsize .\r\nI have never encountered such bug with rle_decode() and kinda hard to reproduce without more info.\r\n\r\nAnd the colors are not correct and i have no idea about that that was the main issue in #125","id":2664003,"created_at":"2011-11-08T05:22:23Z"}}