{"issue":{"state":"open","pull_request":{"diff_url":null,"html_url":null,"patch_url":null},"user":{"avatar_url":"https://secure.gravatar.com/avatar/6cbe04be3caf1c81b73a72f9e6b692ff?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"6cbe04be3caf1c81b73a72f9e6b692ff","url":"https://api.github.com/users/schmurfy","login":"schmurfy","id":2983},"milestone":null,"labels":[],"assignee":null,"updated_at":"2011-10-31T16:31:04Z","closed_at":null,"comments":5,"url":"https://api.github.com/repos/chuckremes/ffi-rzmq/issues/45","body":"Hi,\r\nWhy did you change the signature of the call in latest version instead of raising an error ?\r\nIf you wanted to make your api looks like C I think you succeeded but that's not really the ruby way...\r\n\r\nThe current code:\r\n\r\n```ruby\r\narray = []\r\nrc = socket.getsockopt(ZMQ::HWM, array)\r\nhwm = array.first if ZMQ::Util.resultcode_ok?(rc)\r\n```\r\n\r\nAnd what it could be:\r\n\r\n```ruby\r\nbegin\r\n  hwm = socket.getsockopt(ZMQ::HWM)\r\nrescue ZMQ::OperationFailed => err\r\n  # do something\r\nend\r\n```\r\n\r\nSince looking at the first really makes me sick I can even provide the pull request, but would you accept it ?\r\n","html_url":"https://github.com/chuckremes/ffi-rzmq/issues/45","title":"new getsockopt signature","number":45,"id":2096048,"created_at":"2011-10-31T11:42:05Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/6cbe04be3caf1c81b73a72f9e6b692ff?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"6cbe04be3caf1c81b73a72f9e6b692ff","url":"https://api.github.com/users/schmurfy","login":"schmurfy","id":2983},"updated_at":"2011-10-31T16:31:04Z","url":"https://api.github.com/repos/chuckremes/ffi-rzmq/issues/comments/2579286","body":"Just to clarify my first message, what bothers me is not that you changed the api since your incremented the minor version everything is fine but that you chose to match the C code (passing a buffer to fill it).\r\n\r\nI started a wrapper module but my goal is not to fully bring back the old api but more to have a \"developer friendly\" ruby api, is it fine with you if I provide such a module ? ","id":2579286,"created_at":"2011-10-31T16:31:04Z"}}