{"comment":{"created_at":"2011-10-18T14:12:20Z","body":"Cool but project specific. This isn't a good fit for liquid core. \r\n\r\n-- Tobi\r\nCEO Shopify\r\n\r\nWritten with thumbs. \r\n\r\nOn Oct 17, 2011, at 12:51 PM, Holger Just<reply@reply.github.com> wrote:\r\n\r\n> This pull request make the bundled include tag more modular to allow other implementations with complex more template concepts to hook into it.\r\n> \r\n> My specific use-case here is the introduction of Liquid into ChiliProject (a Redmine fork). We want to use the liquid include to include wiki pages. The templates here are ActiveRecord models. As an additional challenge, the templates are also required to be parsed with Textile. Our basic rendering pipeline goes like \r\n> \r\n>    Text ~> Liquid parser ~> Textile parser ~> HTML\r\n> \r\n> During the inclusion phase, we need to make sure that the context is updated with the correct, well, context. E.g. we need to render each page with the correct project drop in the context, as we allow cross-project includes and need to properly resolve the targets of sub-includes.\r\n> \r\n> See the full example at https://github.com/meineerde/chiliproject/blob/issues/unstable/604-liquid/lib/chili_project/liquid/tags/include.rb\r\n> \r\n> You can merge this Pull Request by running:\r\n> \r\n>  git pull https://github.com/meineerde/liquid pull/more-extensible-include\r\n> \r\n> Or you can view, comment on it, or merge it online at:\r\n> \r\n>  https://github.com/Shopify/liquid/pull/78\r\n> \r\n> -- Commit Summary --\r\n> \r\n> * Normalize whitespace\r\n> * Move template reading into the new context tack to allow the filesystem to update the new context\r\n> * Pull rendering steps into their own methods.\r\n> \r\n> -- File Changes --\r\n> \r\n> M lib/liquid/tags/include.rb (60)\r\n> \r\n> -- Patch Links --\r\n> \r\n>  https://github.com/Shopify/liquid/pull/78.patch\r\n>  https://github.com/Shopify/liquid/pull/78.diff\r\n> \r\n> -- \r\n> Reply to this email directly or view it on GitHub:\r\n> https://github.com/Shopify/liquid/pull/78","updated_at":"2011-10-18T14:12:20Z","url":"https://api.github.com/repos/Shopify/liquid/issues/comments/2442138","id":2442138,"user":{"avatar_url":"https://secure.gravatar.com/avatar/43bc2bd2f4f5eea925e61a3eb61362b4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"43bc2bd2f4f5eea925e61a3eb61362b4","url":"https://api.github.com/users/tobi","id":347,"login":"tobi"}},"action":"created","issue":{"number":78,"created_at":"2011-10-17T19:51:22Z","pull_request":{"diff_url":"https://github.com/Shopify/liquid/pull/78.diff","patch_url":"https://github.com/Shopify/liquid/pull/78.patch","html_url":"https://github.com/Shopify/liquid/pull/78"},"body":"This pull request make the bundled include tag more modular to allow other implementations with complex more template concepts to hook into it.\r\n\r\nMy specific use-case here is the introduction of Liquid into ChiliProject (a Redmine fork). We want to use the liquid include to include wiki pages. The templates here are ActiveRecord models. As an additional challenge, the templates are also required to be parsed with Textile. Our basic rendering pipeline goes like \r\n\r\n    Text ~> Liquid parser ~> Textile parser ~> HTML\r\n\r\nDuring the inclusion phase, we need to make sure that the context is updated with the correct, well, context. E.g. we need to render each page with the correct project drop in the context, as we allow cross-project includes and need to properly resolve the targets of sub-includes.\r\n\r\nSee the full example at https://github.com/meineerde/chiliproject/blob/issues/unstable/604-liquid/lib/chili_project/liquid/tags/include.rb","comments":1,"title":"More extensible include","updated_at":"2011-10-18T14:12:20Z","url":"https://api.github.com/repos/Shopify/liquid/issues/78","id":1932648,"assignee":null,"milestone":null,"closed_at":null,"user":{"avatar_url":"https://secure.gravatar.com/avatar/2ab37d9d26c2c1947bef767725a118b6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"2ab37d9d26c2c1947bef767725a118b6","url":"https://api.github.com/users/meineerde","id":95506,"login":"meineerde"},"html_url":"https://github.com/Shopify/liquid/issues/78","labels":[],"state":"open"},"legacy":{"issue_id":1932648,"comment_id":2442138}}