{"issue":{"pull_request":{"diff_url":null,"html_url":null,"patch_url":null},"state":"open","user":{"avatar_url":"https://secure.gravatar.com/avatar/50a9a17a9e831f8183130624396c0ea2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"50a9a17a9e831f8183130624396c0ea2","url":"https://api.github.com/users/Viewer","login":"Viewer","id":80979},"milestone":null,"assignee":{"avatar_url":"https://secure.gravatar.com/avatar/5d56aaff81930773754aeae46670681a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"5d56aaff81930773754aeae46670681a","url":"https://api.github.com/users/skurfer","login":"skurfer","id":154676},"labels":[],"updated_at":"2011-11-04T13:32:41Z","comments":9,"closed_at":null,"url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/515","body":"(QS B61, Snow Leopard 10.6.8)\r\n\r\nUsing the \"Add Trigger\" action after pressing control + enter during a Quicksilver invocation opens the third pane in text mode.\r\n\r\nRegardless of whether the third pane is left empty or contains text when then enter key is pressed, nothing appears to change Quicksilver's Triggers list.","html_url":"https://github.com/quicksilver/Quicksilver/issues/515","number":515,"title":"\"Add Trigger\" has no Effect","id":2040132,"created_at":"2011-10-25T00:02:14Z"},"action":"created","comment":{"user":{"avatar_url":"https://secure.gravatar.com/avatar/693fdf95aa76f4dfadaade6097d5c750?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","gravatar_id":"693fdf95aa76f4dfadaade6097d5c750","url":"https://api.github.com/users/tiennou","login":"tiennou","id":81099},"updated_at":"2011-11-04T13:32:41Z","url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/comments/2630696","body":"I know the indirectObject part of this is my \"fault\" : I wanted to be able to specify a Trigger type before showing the Trigger pref pane. But I found it klunky because I don't think that's a nice enough way of doing it. You can freely drop the indirect stuff (unless you want to actually implement it, but I'm not sure that's the way to go...) if that's cleans your mind, but here are some \"implementation thoughts\" on creating QS through its main interface.\r\n\r\nThe best way to handle this IMHO is to add an action for every trigger type (new actions in trigger plugins that means), which would take an encapsulated command as its direct object and a trigger-specific thing for its indirect object. Example: \r\nDirect object : \"pizza\" > Display In Large Type\r\nAction : \"Create hotkey trigger\"\r\nIndirect Object : text placeholder for the shortcut.\r\n\r\nBut then you would have to change the text entry stuff to handle modifiers (or try to provide reasonable defaults, but we're messing with globally-defined system hotkeys...). A way to alleviate that would be to drop the indirect object and bring up the Trigger pref pane with the newly created trigger selected.\r\n\r\nThen implement \"Create mouse trigger\" and have its indirect object resolve to things like Top Border, Top-Left Corner, ...\r\n\r\nMy 2 cents ;-)","id":2630696,"created_at":"2011-11-04T13:32:41Z"}}